Death Knight class id cleanup.

This commit is contained in:
MobiusDevelopment 2021-10-15 21:05:38 +00:00
parent 1e3c3dd1e7
commit 5599581cea
12 changed files with 95 additions and 40 deletions

View File

@ -585,4 +585,18 @@
<id>34</id> <!-- bladedancer -->
<id>107</id> <!-- spectral_dancer -->
</category>
<category name="DEATH_KNIGHT_ALL_CLASS">
<id>196</id> <!-- Death Pilgrim - Human -->
<id>197</id> <!-- Death Blade - Human -->
<id>198</id> <!-- Death Messenger - Human -->
<id>199</id> <!-- Death Knight - Human -->
<id>200</id> <!-- Death Pilgrim - Elf -->
<id>201</id> <!-- Death Blade - Elf -->
<id>202</id> <!-- Death Messenger - Elf -->
<id>203</id> <!-- Death Knight - Elf -->
<id>204</id> <!-- Death Pilgrim - Dark Elf -->
<id>205</id> <!-- Death Blade - Dark Elf -->
<id>206</id> <!-- Death Messenger - Dark Elf -->
<id>207</id> <!-- Death Knight - Dark Elf -->
</category>
</list>

View File

@ -414,7 +414,7 @@ public class AdminEditChar implements IAdminCommandHandler
player.getAppearance().setFemale();
}
// Death Knight checks.
if ((classidval > 195) && (classidval < 208))
if (player.isDeathKnight())
{
player.getAppearance().setMale();
}

View File

@ -148,8 +148,14 @@ public class Q00255_Tutorial extends Quest
@Override
public String onAdvEvent(String event, Npc npc, PlayerInstance player)
{
// Null check.
if (player == null)
{
return null;
}
// Death Knights.
if ((player == null) || (player.getClassId().getId() > 195))
if (player.isDeathKnight())
{
return null;
}

View File

@ -103,17 +103,17 @@
<class classId="134" name="Trickster" parentClassId="130" />
<!-- Death Knight - Human -->
<class classId="196" name="Death Pilgrim" />
<class classId="205" name="Death Blade" parentClassId="196" />
<class classId="202" name="Death Messenger" parentClassId="205" />
<class classId="199" name="Death Knight" parentClassId="202" />
<class classId="197" name="Death Blade" parentClassId="196" />
<class classId="198" name="Death Messenger" parentClassId="197" />
<class classId="199" name="Death Knight" parentClassId="198" />
<!-- Death Knight - Elf -->
<class classId="200" name="Death Pilgrim" />
<class classId="197" name="Death Blade" parentClassId="200" />
<class classId="206" name="Death Messenger" parentClassId="197" />
<class classId="203" name="Death Knight" parentClassId="206" />
<class classId="201" name="Death Blade" parentClassId="200" />
<class classId="202" name="Death Messenger" parentClassId="201" />
<class classId="203" name="Death Knight" parentClassId="202" />
<!-- Death Knight - Dark Elf -->
<class classId="204" name="Death Pilgrim" />
<class classId="201" name="Death Blade" parentClassId="204" />
<class classId="198" name="Death Messenger" parentClassId="201" />
<class classId="207" name="Death Knight" parentClassId="198" />
<class classId="205" name="Death Blade" parentClassId="204" />
<class classId="206" name="Death Messenger" parentClassId="205" />
<class classId="207" name="Death Knight" parentClassId="206" />
</list>

View File

@ -54,7 +54,8 @@ public enum CategoryType
SUB_GROUP_ORC,
SUB_GROUP_WARE,
SUB_GROUP_BLACK,
SUB_GROUP_DE;
SUB_GROUP_DE,
DEATH_KNIGHT_ALL_CLASS;
/**
* Finds category by it's name

View File

@ -6694,7 +6694,7 @@ public class PlayerInstance extends Playable
{
player._activeClass = activeClassId;
}
if ((activeClassId > 195) && (activeClassId < 208))
if (CategoryData.getInstance().isInCategory(CategoryType.DEATH_KNIGHT_ALL_CLASS, activeClassId))
{
player._isDeathKnight = true;
}
@ -14233,7 +14233,7 @@ public class PlayerInstance extends Playable
addStatusUpdateValue(StatusUpdateType.LEVEL);
addStatusUpdateValue(StatusUpdateType.MAX_CP);
addStatusUpdateValue(StatusUpdateType.CUR_CP);
if (isPlayer() && (getActingPlayer().getClassId().getId() > 195))
if (isDeathKnight())
{
addStatusUpdateValue(StatusUpdateType.CUR_DP);
}

View File

@ -66,16 +66,16 @@
<id>194</id> <!-- Soul Breaker -->
<id>195</id> <!-- Soul Hound -->
<id>196</id> <!-- Death Pilgrim - Human -->
<id>205</id> <!-- Death Blade - Human -->
<id>202</id> <!-- Death Messenger - Human -->
<id>197</id> <!-- Death Blade - Human -->
<id>198</id> <!-- Death Messenger - Human -->
<id>199</id> <!-- Death Knight - Human -->
<id>200</id> <!-- Death Pilgrim - Elf -->
<id>197</id> <!-- Death Blade - Elf -->
<id>206</id> <!-- Death Messenger - Elf -->
<id>201</id> <!-- Death Blade - Elf -->
<id>202</id> <!-- Death Messenger - Elf -->
<id>203</id> <!-- Death Knight - Elf -->
<id>204</id> <!-- Death Pilgrim - Dark Elf -->
<id>201</id> <!-- Death Blade - Dark Elf -->
<id>198</id> <!-- Death Messenger - Dark Elf -->
<id>205</id> <!-- Death Blade - Dark Elf -->
<id>206</id> <!-- Death Messenger - Dark Elf -->
<id>207</id> <!-- Death Knight - Dark Elf -->
<id>208</id> <!-- Sylph Gunner -->
<id>209</id> <!-- Sharpshooter -->
@ -206,16 +206,16 @@
<id>194</id> <!-- Soul Breaker -->
<id>195</id> <!-- Soul Hound -->
<id>196</id> <!-- Death Pilgrim - Human -->
<id>205</id> <!-- Death Blade - Human -->
<id>202</id> <!-- Death Messenger - Human -->
<id>197</id> <!-- Death Blade - Human -->
<id>198</id> <!-- Death Messenger - Human -->
<id>199</id> <!-- Death Knight - Human -->
<id>200</id> <!-- Death Pilgrim - Elf -->
<id>197</id> <!-- Death Blade - Elf -->
<id>206</id> <!-- Death Messenger - Elf -->
<id>201</id> <!-- Death Blade - Elf -->
<id>202</id> <!-- Death Messenger - Elf -->
<id>203</id> <!-- Death Knight - Elf -->
<id>204</id> <!-- Death Pilgrim - Dark Elf -->
<id>201</id> <!-- Death Blade - Dark Elf -->
<id>198</id> <!-- Death Messenger - Dark Elf -->
<id>205</id> <!-- Death Blade - Dark Elf -->
<id>206</id> <!-- Death Messenger - Dark Elf -->
<id>207</id> <!-- Death Knight - Dark Elf -->
<id>208</id> <!-- Sylph Gunner -->
<id>209</id> <!-- Sharpshooter -->
@ -597,4 +597,24 @@
<id>34</id> <!-- bladedancer -->
<id>107</id> <!-- spectral_dancer -->
</category>
<category name="DEATH_KNIGHT_ALL_CLASS">
<id>196</id> <!-- Death Pilgrim - Human -->
<id>197</id> <!-- Death Blade - Human -->
<id>198</id> <!-- Death Messenger - Human -->
<id>199</id> <!-- Death Knight - Human -->
<id>200</id> <!-- Death Pilgrim - Elf -->
<id>201</id> <!-- Death Blade - Elf -->
<id>202</id> <!-- Death Messenger - Elf -->
<id>203</id> <!-- Death Knight - Elf -->
<id>204</id> <!-- Death Pilgrim - Dark Elf -->
<id>205</id> <!-- Death Blade - Dark Elf -->
<id>206</id> <!-- Death Messenger - Dark Elf -->
<id>207</id> <!-- Death Knight - Dark Elf -->
</category>
<category name="SYLPH_ALL_CLASS">
<id>208</id> <!-- Sylph Gunner -->
<id>209</id> <!-- Sharpshooter -->
<id>210</id> <!-- Wind Sniper -->
<id>211</id> <!-- Storm Blaster -->
</category>
</list>

View File

@ -410,7 +410,7 @@ public class AdminEditChar implements IAdminCommandHandler
}
}
// Death Knight checks.
if ((classidval > 195) && (classidval < 208))
if (player.isDeathKnight())
{
player.getAppearance().setMale();
}

View File

@ -148,8 +148,20 @@ public class Q00255_Tutorial extends Quest
@Override
public String onAdvEvent(String event, Npc npc, PlayerInstance player)
{
// Null check.
if (player == null)
{
return null;
}
// Death Knights.
if ((player == null) || (player.getClassId().getId() > 195))
if (player.isDeathKnight())
{
return null;
}
// Sylph.
if (player.getRace() == Race.SYLPH)
{
return null;
}

View File

@ -103,19 +103,19 @@
<class classId="134" name="Trickster" parentClassId="130" />
<!-- Death Knight - Human -->
<class classId="196" name="Death Pilgrim" />
<class classId="205" name="Death Blade" parentClassId="196" />
<class classId="202" name="Death Messenger" parentClassId="205" />
<class classId="199" name="Death Knight" parentClassId="202" />
<class classId="197" name="Death Blade" parentClassId="196" />
<class classId="198" name="Death Messenger" parentClassId="197" />
<class classId="199" name="Death Knight" parentClassId="198" />
<!-- Death Knight - Elf -->
<class classId="200" name="Death Pilgrim" />
<class classId="197" name="Death Blade" parentClassId="200" />
<class classId="206" name="Death Messenger" parentClassId="197" />
<class classId="203" name="Death Knight" parentClassId="206" />
<class classId="201" name="Death Blade" parentClassId="200" />
<class classId="202" name="Death Messenger" parentClassId="201" />
<class classId="203" name="Death Knight" parentClassId="202" />
<!-- Death Knight - Dark Elf -->
<class classId="204" name="Death Pilgrim" />
<class classId="201" name="Death Blade" parentClassId="204" />
<class classId="198" name="Death Messenger" parentClassId="201" />
<class classId="207" name="Death Knight" parentClassId="198" />
<class classId="205" name="Death Blade" parentClassId="204" />
<class classId="206" name="Death Messenger" parentClassId="205" />
<class classId="207" name="Death Knight" parentClassId="206" />
<!-- Sylph -->
<class classId="208" name="Sylph Gunner" />
<class classId="209" name="Sharpshooter" parentClassId="208" />

View File

@ -54,7 +54,9 @@ public enum CategoryType
SUB_GROUP_ORC,
SUB_GROUP_WARE,
SUB_GROUP_BLACK,
SUB_GROUP_DE;
SUB_GROUP_DE,
DEATH_KNIGHT_ALL_CLASS,
SYLPH_ALL_CLASS;
/**
* Finds category by it's name

View File

@ -6739,7 +6739,7 @@ public class PlayerInstance extends Playable
{
player._activeClass = activeClassId;
}
if ((activeClassId > 195) && (activeClassId < 208))
if (CategoryData.getInstance().isInCategory(CategoryType.DEATH_KNIGHT_ALL_CLASS, activeClassId))
{
player._isDeathKnight = true;
}
@ -14310,7 +14310,7 @@ public class PlayerInstance extends Playable
addStatusUpdateValue(StatusUpdateType.LEVEL);
addStatusUpdateValue(StatusUpdateType.MAX_CP);
addStatusUpdateValue(StatusUpdateType.CUR_CP);
if (isPlayer() && (getActingPlayer().getClassId().getId() > 195))
if (isDeathKnight())
{
addStatusUpdateValue(StatusUpdateType.CUR_DP);
}