TriggerSkillByMagicType should not be triggered by common skills.

This commit is contained in:
MobiusDevelopment 2022-06-22 10:18:05 +00:00
parent 4ab1e589db
commit d3330617bd
13 changed files with 156 additions and 13 deletions

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{

View File

@ -33,6 +33,7 @@ import org.l2jmobius.gameserver.model.events.listeners.ConsumerEventListener;
import org.l2jmobius.gameserver.model.holders.SkillHolder;
import org.l2jmobius.gameserver.model.item.instance.Item;
import org.l2jmobius.gameserver.model.skill.BuffInfo;
import org.l2jmobius.gameserver.model.skill.CommonSkill;
import org.l2jmobius.gameserver.model.skill.Skill;
import org.l2jmobius.gameserver.model.skill.SkillCaster;
import org.l2jmobius.gameserver.model.skill.targets.TargetType;
@ -90,7 +91,8 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
if (!CommonUtil.contains(_magicTypes, event.getSkill().getMagicType()))
final Skill eventSkill = event.getSkill();
if (!CommonUtil.contains(_magicTypes, eventSkill.getMagicType()))
{
return;
}
@ -114,6 +116,15 @@ public class TriggerSkillByMagicType extends AbstractEffect
return;
}
// Ignore common skills.
for (CommonSkill skill : CommonSkill.values())
{
if (skill.getId() == eventSkill.getId())
{
return;
}
}
final Skill triggerSkill;
if (_skillLevelScaleTo <= 0)
{