Door distance check should not be necessary.

This commit is contained in:
MobiusDev 2018-09-03 00:01:17 +00:00
parent 118ca0d877
commit 7e2dafb4ff
8 changed files with 32 additions and 72 deletions

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -921,7 +921,6 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
if (TerritoryWarManager.getInstance().isTWInProgress()) if (TerritoryWarManager.getInstance().isTWInProgress())
@ -935,7 +934,6 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -956,13 +954,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// Mobius: Do not move when attack is launched. // Mobius: Do not move when attack is launched.

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks

View File

@ -934,14 +934,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide())) else if ((target.getActingPlayer() != null) && (getActingPlayer().getSiegeState() > 0) && isInsideZone(ZoneId.SIEGE) && (target.getActingPlayer().getSiegeState() == getActingPlayer().getSiegeState()) && (target.getActingPlayer() != this) && (target.getActingPlayer().getSiegeSide() == getActingPlayer().getSiegeSide()))
{ {
sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE); sendPacket(SystemMessageId.FORCE_ATTACK_IS_IMPOSSIBLE_AGAINST_A_TEMPORARY_ALLIED_MEMBER_DURING_A_SIEGE);
sendPacket(ActionFailed.STATIC_PACKET); sendPacket(ActionFailed.STATIC_PACKET);
return; return;
} }
// Checking if target has moved to peace zone // Checking if target has moved to peace zone
else if (target.isInsidePeaceZone(getActingPlayer())) else if (target.isInsidePeaceZone(getActingPlayer()))
{ {
@ -962,13 +960,10 @@ public abstract class L2Character extends L2Object implements ISkillsHolder, IDe
// GeoData Los Check here (or dz > 1000) // GeoData Los Check here (or dz > 1000)
if (!GeoEngine.getInstance().canSeeTarget(this, target)) if (!GeoEngine.getInstance().canSeeTarget(this, target))
{ {
if (!target.isDoor() || (target.calculateDistance(this, false, false) > 200)) // fix for big door targeting sendPacket(SystemMessageId.CANNOT_SEE_TARGET);
{ getAI().setIntention(AI_INTENTION_ACTIVE);
sendPacket(SystemMessageId.CANNOT_SEE_TARGET); sendPacket(ActionFailed.STATIC_PACKET);
getAI().setIntention(AI_INTENTION_ACTIVE); return;
sendPacket(ActionFailed.STATIC_PACKET);
return;
}
} }
// BOW and CROSSBOW checks // BOW and CROSSBOW checks