lineage2/L2Bot2.0
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: switch strings to string references

Browse Source
This commit is contained in:
k0t9i 2023-01-23 23:58:45 +04:00
parent 9592833ddf
commit e127d94902
9 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
L2BotCore/Domain/Entities/Drop.h
View File

@ -52,8 +52,8 @@ namespace L2Bot::Domain::Entities
const ValueObjects::Transform transform,
const uint32_t itemId,
const uint32_t amount,
const std::string name,
const std::string iconName
const std::string& name,
const std::string& iconName
) :
WorldObject(id, transform),
m_ItemId(itemId),

4
L2BotCore/Domain/Serializers/Node.h
View File

@ -14,11 +14,11 @@ namespace L2Bot::Domain::Serializers
const bool isContainer = false;
Node() = delete;
Node(const std::string name, const std::string value) :
Node(const std::string& name, const std::string& value) :
name(name), value(value)
{
}
Node(const std::string name, const std::vector<Node> children, const bool isArray = false) :
Node(const std::string& name, const std::vector<Node> children, const bool isArray = false) :
name(name), children(children), isArray(isArray), isContainer(true)
{
}

2
L2BotCore/Domain/Serializers/SerializableStateContainer.h
View File

@ -42,7 +42,7 @@ namespace L2Bot::Domain::Serializers
return result;
}
SerializableStateContainer(const std::vector<std::shared_ptr<DTO::EntityState>> objects, const std::string containerName) :
SerializableStateContainer(const std::vector<std::shared_ptr<DTO::EntityState>> objects, const std::string& containerName) :
m_Objects(objects), m_ContainerName(containerName)
{

2
L2BotCore/Domain/Transports/TransportInterface.h
View File

@ -8,7 +8,7 @@ namespace L2Bot::Domain::Transports
public:
virtual const bool Connect() = 0;
virtual const bool IsConnected() const = 0;
virtual const void Send(std::string data) = 0;
virtual const void Send(const std::string& data) = 0;
virtual const std::string Receive() = 0;
};
}

6
L2BotCore/Domain/ValueObjects/BaseItem.h
View File

@ -97,9 +97,9 @@ namespace L2Bot::Domain::ValueObjects
const bool isEquipped,
const uint16_t enchantLevel,
const int32_t mana,
const std::string name,
const std::string iconName,
const std::string description,
const std::string& name,
const std::string& iconName,
const std::string& description,
const uint16_t weight
) :
m_ItemId(itemId),

4
L2BotCore/Domain/ValueObjects/FullName.h
View File

@ -30,8 +30,8 @@ namespace L2Bot::Domain::ValueObjects
}
FullName(
const std::string nickname,
const std::string title
const std::string& nickname,
const std::string& title
) :
m_Nickname(nickname),
m_Title(title)

2
L2BotDll/Events/EventDispatcher.h
View File

@ -31,7 +31,7 @@ public:
}
}
void Subscribe(std::string eventName, Delegate handler)
void Subscribe(const std::string& eventName, const Delegate handler)
{
m_Handlers[eventName].push_back(handler);
}

2
L2BotDll/Transports/DebugViewTransport.h
View File

@ -18,7 +18,7 @@ public:
return true;
}
const void Send(std::string data) override
const void Send(const std::string& data) override
{
OutputDebugStringA(data.c_str());
}

2
L2BotDll/Transports/NamedPipeTransport.h
View File

@ -37,7 +37,7 @@ public:
return true;
}
const void Send(std::string data) override
const void Send(const std::string& data) override
{
if (!m_Pipe.IsConnected())
{