Reuse of cumulative chance for CreateItemRandom.

This commit is contained in:
MobiusDev
2018-09-01 18:22:50 +00:00
parent 47ad159563
commit fe5fa51654
7 changed files with 28 additions and 7 deletions

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;

View File

@@ -64,9 +64,12 @@ public class CreateItemRandom extends AbstractEffect
return; return;
} }
double cumulativeChance = 0;
final int random = Rnd.get(100);
for (ItemChanceHolder holder : item.getItem().getCreateItems()) for (ItemChanceHolder holder : item.getItem().getCreateItems())
{ {
if (holder.getChance() < Rnd.get(100)) cumulativeChance += holder.getChance();
if (random < cumulativeChance)
{ {
player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true); player.addItem("CreateItems", holder.getId(), holder.getCount(), player, true);
return; return;