QuestState isNowAvailable method should not return null values as true.

This commit is contained in:
MobiusDev
2018-07-07 12:23:10 +00:00
parent cffea875fd
commit fd58e1bfa7
9 changed files with 9 additions and 17 deletions

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -61,7 +61,7 @@ public final class BlackMarketeerOfMammon extends AbstractNpcAI
if (player.getLevel() >= MIN_LEVEL) if (player.getLevel() >= MIN_LEVEL)
{ {
final QuestState qs = getQuestState(player, true); final QuestState qs = getQuestState(player, true);
if (!qs.isNowAvailable()) if ((qs.get("restartTime") != null) && !qs.isNowAvailable())
{ {
htmltext = "31092-03.html"; htmltext = "31092-03.html";
} }

View File

@@ -35,7 +35,6 @@ import com.l2jmobius.gameserver.network.serverpackets.TutorialCloseHtml;
import com.l2jmobius.gameserver.network.serverpackets.TutorialEnableClientEvent; import com.l2jmobius.gameserver.network.serverpackets.TutorialEnableClientEvent;
import com.l2jmobius.gameserver.network.serverpackets.TutorialShowHtml; import com.l2jmobius.gameserver.network.serverpackets.TutorialShowHtml;
import com.l2jmobius.gameserver.network.serverpackets.TutorialShowQuestionMark; import com.l2jmobius.gameserver.network.serverpackets.TutorialShowQuestionMark;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -749,7 +748,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
/** /**

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)

View File

@@ -30,7 +30,6 @@ import com.l2jmobius.gameserver.model.events.EventDispatcher;
import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete; import com.l2jmobius.gameserver.model.events.impl.character.player.OnPlayerQuestComplete;
import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark; import com.l2jmobius.gameserver.network.serverpackets.ExShowQuestMark;
import com.l2jmobius.gameserver.network.serverpackets.QuestList; import com.l2jmobius.gameserver.network.serverpackets.QuestList;
import com.l2jmobius.gameserver.util.Util;
/** /**
* Quest state class. * Quest state class.
@@ -823,7 +822,7 @@ public final class QuestState
public boolean isNowAvailable() public boolean isNowAvailable()
{ {
final String val = get("restartTime"); final String val = get("restartTime");
return (val == null) || !Util.isDigit(val) || (Long.parseLong(val) <= System.currentTimeMillis()); return (val != null) && (Long.parseLong(val) <= System.currentTimeMillis());
} }
public void setSimulated(boolean simulated) public void setSimulated(boolean simulated)