lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent SkillHolder tapping into SkillData for each getSkill call.

Browse Source
This commit is contained in:
MobiusDevelopment
2019-11-03 18:25:56 +00:00
parent cf5297282a
commit eec2b16df0
17 changed files with 217 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
L2J_Mobius_Classic_Interlude/java/org/l2jmobius/gameserver/model/holders/SkillHolder.java
View File

@ -28,12 +28,14 @@ public class SkillHolder
private final int _skillId;
private final int _skillLevel;
private final int _skillSubLevel;
private Skill _skill;
public SkillHolder(int skillId, int skillLevel)
{
_skillId = skillId;
_skillLevel = skillLevel;
_skillSubLevel = 0;
_skill = null;
}
public SkillHolder(int skillId, int skillLevel, int skillSubLevel)
@ -41,6 +43,7 @@ public class SkillHolder
_skillId = skillId;
_skillLevel = skillLevel;
_skillSubLevel = skillSubLevel;
_skill = null;
}
public SkillHolder(Skill skill)
@ -48,6 +51,7 @@ public class SkillHolder
_skillId = skill.getId();
_skillLevel = skill.getLevel();
_skillSubLevel = skill.getSubLevel();
_skill = skill;
}
public int getSkillId()
@ -67,7 +71,11 @@ public class SkillHolder
public Skill getSkill()
{
return SkillData.getInstance().getSkill(_skillId, Math.max(_skillLevel, 1), _skillSubLevel);
if (_skill == null)
{
_skill = SkillData.getInstance().getSkill(_skillId, Math.max(_skillLevel, 1), _skillSubLevel);
}
return _skill;
}
@Override