Cleanup of unnecessary void method and class modifiers.

This commit is contained in:
MobiusDevelopment
2022-12-13 22:13:36 +00:00
parent 7e3dd71d77
commit e6085edc4c
2172 changed files with 3581 additions and 3581 deletions

View File

@@ -435,7 +435,7 @@ public class Gallias extends AbstractNpcAI
return "DualSkill-" + level;
}
private final void takeSkills(Player player, String type)
private void takeSkills(Player player, String type)
{
final PlayerVariables vars = player.getVariables();
final String list = vars.getString(type, "");
@@ -453,7 +453,7 @@ public class Gallias extends AbstractNpcAI
}
}
private final void giveSkills(Player player, String type)
private void giveSkills(Player player, String type)
{
final String list = player.getVariables().getString(type, "");
if (!list.isEmpty())

View File

@@ -25,7 +25,7 @@ import ai.AbstractNpcAI;
* Soul Summon Stone AI.
* @author NviX
*/
public final class SoulSummonStone extends AbstractNpcAI
public class SoulSummonStone extends AbstractNpcAI
{
// NPCs
private static final int SOUL_SUMMON_STONE = 34434;

View File

@@ -26,7 +26,7 @@ import ai.AbstractNpcAI;
* Valleria AI.
* @author CostyKiller
*/
public final class Valleria extends AbstractNpcAI
public class Valleria extends AbstractNpcAI
{
// NPC
private static final int VALLERIA = 34435;

View File

@@ -73,7 +73,7 @@ public class HarnakUndergroundRuinsZone extends AbstractNpcAI
return super.onAdvEvent(event, npc, player);
}
private static final class zoneInfo
private static class zoneInfo
{
private int currentPoints = 0;
private int currentMonitorizedDamage = 0;
@@ -121,7 +121,7 @@ public class HarnakUndergroundRuinsZone extends AbstractNpcAI
}
}
private static final class changeZoneStage implements Runnable
private static class changeZoneStage implements Runnable
{
private final ZoneType _zone;

View File

@@ -453,7 +453,7 @@ public class Trandon extends AbstractNpcAI
return "DualSkill-" + level;
}
private final void takeSkills(Player player, String type)
private void takeSkills(Player player, String type)
{
final PlayerVariables vars = player.getVariables();
final String list = vars.getString(type, "");
@@ -471,7 +471,7 @@ public class Trandon extends AbstractNpcAI
}
}
private final void giveSkills(Player player, String type)
private void giveSkills(Player player, String type)
{
final String list = player.getVariables().getString(type, "");
if (!list.isEmpty())

View File

@@ -98,12 +98,12 @@ public class AnakimBoss extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -93,12 +93,12 @@ public class AnakimElitePriest extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -457,7 +457,7 @@ public class Antharas extends AbstractInstance
return super.onSpellFinished(npc, player, skill);
}
private final void refreshAiParams(Player attacker, int damage)
private void refreshAiParams(Player attacker, int damage)
{
final Instance world = attacker.getInstanceWorld();
if (world == null)

View File

@@ -614,12 +614,12 @@ public class Baium extends AbstractNpcAI
return super.unload(removeFromList);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -95,12 +95,12 @@ public class Cyrax extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class TempleEliteWizard extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class ChoirOfDarkness extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -94,12 +94,12 @@ public class Etina extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class GreatTempleDarkJudge extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class GreatTempleSoulGuide extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class JudgeOfHeresy extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -93,12 +93,12 @@ public class Kain extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class LiberatorOfLust extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class SeekerOfDespair extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class SoulDestroyer extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class TempleArchon extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class TempleDarkWizard extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class TempleFlameMaster extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class TempleHighPriest extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class EliteWizard extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -107,12 +107,12 @@ public class FafurionBoss extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -92,12 +92,12 @@ public class Helios1 extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -92,12 +92,12 @@ public class Helios2 extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -93,12 +93,12 @@ public class Helios3 extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -91,12 +91,12 @@ public class RoyalArchmageMinion extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -98,12 +98,12 @@ public class LilithBoss extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -94,12 +94,12 @@ public class LilithEliteShaman extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -42,7 +42,7 @@ import ai.AbstractNpcAI;
* OK - All Raid Bosses who use Limit Barrier are listed below:
*/
@Disabled // Behaviour does not go well with low population servers.
public final class LimitBarrier extends AbstractNpcAI
public class LimitBarrier extends AbstractNpcAI
{
// NPCs
private static final int[] RAID_BOSSES =

View File

@@ -447,12 +447,12 @@ public class Ramona extends AbstractNpcAI
return super.onAttack(npc, attacker, damage, isSummon);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage)
private void refreshAiParams(Creature attacker, Npc npc, int damage)
{
refreshAiParams(attacker, npc, damage, damage);
}
private final void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
private void refreshAiParams(Creature attacker, Npc npc, int damage, int aggro)
{
final int newAggroVal = damage + getRandom(3000);
final int aggroVal = aggro + 1000;

View File

@@ -178,7 +178,7 @@ public class CastleChamberlain extends AbstractNpcAI
return "chamberlain-21.html";
}
private final void funcReplace(Castle castle, NpcHtmlMessage html, int func, String str)
private void funcReplace(Castle castle, NpcHtmlMessage html, int func, String str)
{
final CastleFunction function = castle.getCastleFunction(func);
if (function == null)

View File

@@ -31,7 +31,7 @@ import ai.AbstractNpcAI;
* @URL https://dev.l2central.info/main/articles/355.html
* @author CostyKiller, NasSeKa
*/
public final class GreedyTreasureChests extends AbstractNpcAI
public class GreedyTreasureChests extends AbstractNpcAI
{
// NPCs
private static final int CHEST_LV110 = 8710;

View File

@@ -1589,7 +1589,7 @@ public class AdminEditChar implements IAdminCommandHandler
activeChar.sendPacket(adminReply);
}
private final class IpPack
private class IpPack
{
String ip;
int[][] tracert;

View File

@@ -77,7 +77,7 @@ public class AdminHtml implements IAdminCommandHandler
* @param activeChar activeChar where html is shown
* @param path relative path from directory data/html/admin/ to html
*/
static void showAdminHtml(Player activeChar, String path)
public static void showAdminHtml(Player activeChar, String path)
{
showHtml(activeChar, "data/html/admin/" + path, false);
}

View File

@@ -110,7 +110,7 @@ public abstract class AbstractInstance extends AbstractNpcAI
* @param npc NPC which allows to enter into instance
* @param templateId template ID of instance where player wants to enter
*/
protected final void enterInstance(Player player, Npc npc, int templateId)
protected void enterInstance(Player player, Npc npc, int templateId)
{
Instance instance = getPlayerInstance(player);
if (instance != null) // Player has already any instance active

View File

@@ -568,7 +568,7 @@ public class Kamaloka extends AbstractInstance
* Spawn all NPCs in kamaloka
* @param world instanceWorld
*/
private final void spawnKama(Instance world)
private void spawnKama(Instance world)
{
int[] npcs;
int[][] spawns;

View File

@@ -42,7 +42,7 @@ import ai.AbstractNpcAI;
public abstract class AirShipController extends AbstractNpcAI
{
private final class DecayTask implements Runnable
private class DecayTask implements Runnable
{
public DecayTask()
{
@@ -58,7 +58,7 @@ public abstract class AirShipController extends AbstractNpcAI
}
}
private final class DepartTask implements Runnable
private class DepartTask implements Runnable
{
public DepartTask()
{

View File

@@ -119,7 +119,7 @@ public class AirShipGludioGracia extends AbstractNpcAI implements Runnable
_ship.runEngine(60000);
}
private final void broadcastInGludio(NpcStringId npcString)
private void broadcastInGludio(NpcStringId npcString)
{
if (!_foundAtcGludio)
{
@@ -132,7 +132,7 @@ public class AirShipGludioGracia extends AbstractNpcAI implements Runnable
}
}
private final void broadcastInGracia(NpcStringId npcStringId)
private void broadcastInGracia(NpcStringId npcStringId)
{
if (!_foundAtcGracia)
{