From d3b51827fd575197d22a2b89308b86e6772dfcac Mon Sep 17 00:00:00 2001
From: MobiusDevelopment <8391001+MobiusDevelopment@users.noreply.github.com>
Date: Fri, 15 Jul 2022 09:42:50 +0000
Subject: [PATCH] Hero list size should be written only once. Contributed by
 nasseka.

---
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 .../serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java   | 5 +++--
 10 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/L2J_Mobius_07.0_PreludeOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_07.0_PreludeOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 8cc3ba0278..010d7a5372 100644
--- a/L2J_Mobius_07.0_PreludeOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_07.0_PreludeOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -102,9 +102,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_08.2_Homunculus/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_08.2_Homunculus/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_08.2_Homunculus/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_08.2_Homunculus/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_09.2_ReturnOfTheQueenAnt/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_09.2_ReturnOfTheQueenAnt/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_09.2_ReturnOfTheQueenAnt/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_09.2_ReturnOfTheQueenAnt/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_10.1_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_10.1_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_10.1_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_10.1_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_10.2_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_10.2_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_10.2_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_10.2_MasterClass/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_Classic_3.0_TheKamael/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_Classic_3.0_TheKamael/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 8cc3ba0278..010d7a5372 100644
--- a/L2J_Mobius_Classic_3.0_TheKamael/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_Classic_3.0_TheKamael/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -102,9 +102,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_Essence_4.2_DwellingOfSpirits/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_Essence_4.2_DwellingOfSpirits/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_Essence_4.2_DwellingOfSpirits/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_Essence_4.2_DwellingOfSpirits/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_Essence_5.2_FrostLord/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_Essence_5.2_FrostLord/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_Essence_5.2_FrostLord/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_Essence_5.2_FrostLord/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_Essence_6.1_BattleChronicle/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_Essence_6.1_BattleChronicle/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_Essence_6.1_BattleChronicle/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_Essence_6.1_BattleChronicle/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{
diff --git a/L2J_Mobius_Essence_6.2_Vanguard/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java b/L2J_Mobius_Essence_6.2_Vanguard/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
index 5c835c1dea..e4df174e89 100644
--- a/L2J_Mobius_Essence_6.2_Vanguard/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
+++ b/L2J_Mobius_Essence_6.2_Vanguard/java/org/l2jmobius/gameserver/network/serverpackets/ranking/ExOlympiadHeroAndLegendInfo.java
@@ -55,7 +55,7 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 				try (ResultSet rset = statement.executeQuery())
 				{
 					int i = 1;
-					final boolean writedCount = false;
+					boolean wroteCount = false;
 					while (rset.next())
 					{
 						if (i == 1)
@@ -93,9 +93,10 @@ public class ExOlympiadHeroAndLegendInfo implements IClientOutgoingPacket
 						}
 						else
 						{
-							if (!writedCount)
+							if (!wroteCount)
 							{
 								packet.writeD(Hero.getInstance().getHeroes().size() - 1);
+								wroteCount = true;
 							}
 							if (Hero.getInstance().getHeroes().size() > 1)
 							{