Fixed probable getAllyCrestId NPE.

Contributed by Sahar.
This commit is contained in:
MobiusDevelopment 2019-10-28 20:39:29 +00:00
parent f7fe3534c3
commit bf4e116a19
18 changed files with 35 additions and 173 deletions

View File

@ -4242,20 +4242,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4248,20 +4248,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4250,20 +4250,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4245,20 +4245,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4223,20 +4223,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4223,20 +4223,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4224,20 +4224,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4139,20 +4139,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -5588,34 +5588,16 @@ public class PlayerInstance extends Playable
}
/**
* Return the Alliance Identifier of the PlayerInstance.<BR>
* <BR>
* @return the ally id
* @return the Alliance Identifier of the PlayerInstance.
*/
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
/**
* Gets the ally crest id.
* @return the ally crest id
*/
public int getAllyCrestId()
{
if ((getClanId() == 0) || (getClan() == null))
{
return 0;
}
if (getClan().getAllyId() == 0)
{
return 0;
}
return getClan().getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4315,7 +4315,7 @@ public class PlayerInstance extends Playable
public int getAllyCrestId()
{
return (_clanId == 0) || (_clan.getAllyId() == 0) ? 0 : _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4202,7 +4202,7 @@ public class PlayerInstance extends Playable
public int getAllyCrestId()
{
return (_clanId == 0) || (_clan.getAllyId() == 0) ? 0 : _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4217,20 +4217,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4218,20 +4218,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4201,20 +4201,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4212,20 +4212,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4212,20 +4212,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4110,20 +4110,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**

View File

@ -4218,20 +4218,12 @@ public class PlayerInstance extends Playable
@Override
public int getAllyId()
{
if (_clan == null)
{
return 0;
}
return _clan.getAllyId();
return _clan == null ? 0 : _clan.getAllyId();
}
public int getAllyCrestId()
{
if ((_clanId == 0) || (_clan == null) || (_clan.getAllyId() == 0))
{
return 0;
}
return _clan.getAllyCrestId();
return getAllyId() == 0 ? 0 : _clan.getAllyCrestId();
}
/**