Proper modifier order and removal if implied by their context.

This commit is contained in:
MobiusDev
2018-06-19 02:02:54 +00:00
parent 61b336acb9
commit a5b69096dd
163 changed files with 325 additions and 325 deletions

View File

@@ -177,7 +177,7 @@ public final class Elpies extends Event
return super.onSpawn(npc);
}
private static enum EventLocation
private enum EventLocation
{
ADEN("Aden", 146558, 148341, 26622, 28560, -2200),
DION("Dion", 18564, 19200, 144377, 145782, -3081),

View File

@@ -191,7 +191,7 @@ public final class Rnd
/**
* @author Forsaiken
*/
public static enum RandomType
public enum RandomType
{
/**
* For best random quality.

View File

@@ -151,7 +151,7 @@ public final class BlockComplexDynamic extends BlockComplex implements IBlockDyn
}
@Override
final synchronized public void addGeoObject(IGeoObject object)
public final synchronized void addGeoObject(IGeoObject object)
{
// add geo object, update block geodata when added
if (_objects.add(object))
@@ -161,7 +161,7 @@ public final class BlockComplexDynamic extends BlockComplex implements IBlockDyn
}
@Override
final synchronized public void removeGeoObject(IGeoObject object)
public final synchronized void removeGeoObject(IGeoObject object)
{
// remove geo object, update block geodata when removed
if (_objects.remove(object))

View File

@@ -196,7 +196,7 @@ public final class BlockMultilayerDynamic extends BlockMultilayer implements IBl
}
@Override
final synchronized public void addGeoObject(IGeoObject object)
public final synchronized void addGeoObject(IGeoObject object)
{
// add geo object, update block geodata when added
if (_objects.add(object))
@@ -206,7 +206,7 @@ public final class BlockMultilayerDynamic extends BlockMultilayer implements IBl
}
@Override
final synchronized public void removeGeoObject(IGeoObject object)
public final synchronized void removeGeoObject(IGeoObject object)
{
// remove geo object, update block geodata when removed
if (_objects.remove(object))

View File

@@ -55,7 +55,7 @@ public class DBSpawnManager
protected final Map<Integer, StatsSet> _storedInfo = new ConcurrentHashMap<>();
protected final Map<Integer, ScheduledFuture<?>> _schedules = new ConcurrentHashMap<>();
public static enum DBStatusType
public enum DBStatusType
{
ALIVE,
DEAD,

View File

@@ -21,9 +21,9 @@ package com.l2jmobius.gameserver.instancemanager;
*/
public class PlayerCountManager
{
private volatile static int connectedCount = 0;
private volatile static int maxConnectedCount = 0;
private volatile static int offlineTradeCount = 0;
private static volatile int connectedCount = 0;
private static volatile int maxConnectedCount = 0;
private static volatile int offlineTradeCount = 0;
protected PlayerCountManager()
{

View File

@@ -829,12 +829,12 @@ public final class L2PcInstance extends L2Playable
}
// Training Camp
private final static String TRAINING_CAMP_VAR = "TRAINING_CAMP";
private final static String TRAINING_CAMP_DURATION = "TRAINING_CAMP_DURATION";
private static final String TRAINING_CAMP_VAR = "TRAINING_CAMP";
private static final String TRAINING_CAMP_DURATION = "TRAINING_CAMP_DURATION";
// Attendance Reward system
private final static String ATTENDANCE_DATE_VAR = "ATTENDANCE_DATE";
private final static String ATTENDANCE_INDEX_VAR = "ATTENDANCE_INDEX";
private static final String ATTENDANCE_DATE_VAR = "ATTENDANCE_DATE";
private static final String ATTENDANCE_INDEX_VAR = "ATTENDANCE_INDEX";
// Save responder name for log it
private String _lastPetitionGmName = null;

View File

@@ -62,7 +62,7 @@ public class HpCondition implements ICubicCondition
return getClass().getSimpleName() + " chance: " + _hpPer;
}
public static enum HpConditionType
public enum HpConditionType
{
GREATER,
LESSER;

View File

@@ -26,11 +26,11 @@ import com.l2jmobius.gameserver.model.StatsSet;
*/
public class LuckyGameDataHolder
{
final private int _index;
final private int _turningPoints;
final private List<ItemChanceHolder> _commonRewards = new ArrayList<>();
final private List<ItemPointHolder> _uniqueRewards = new ArrayList<>();
final private List<ItemChanceHolder> _modifyRewards = new ArrayList<>();
private final int _index;
private final int _turningPoints;
private final List<ItemChanceHolder> _commonRewards = new ArrayList<>();
private final List<ItemPointHolder> _uniqueRewards = new ArrayList<>();
private final List<ItemChanceHolder> _modifyRewards = new ArrayList<>();
private int _minModifyRewardGame;
private int _maxModifyRewardGame;

View File

@@ -36,7 +36,7 @@ public class ExOneDayReceiveRewardList implements IClientOutgoingPacket
{
final L2PcInstance _player;
private final Collection<DailyMissionDataHolder> _rewards;
private final static Function<String, Long> _remainTime = pattern -> (new Predictor(pattern).nextMatchingTime() - System.currentTimeMillis()) / 1000L;
private static final Function<String, Long> _remainTime = pattern -> (new Predictor(pattern).nextMatchingTime() - System.currentTimeMillis()) / 1000L;
private final long _dayRemainTime;
private final long _weekRemainTime;

View File

@@ -61,22 +61,22 @@ public class Gui
{
JTextArea txtrConsole;
final static String[] shutdownOptions =
static final String[] shutdownOptions =
{
"Shutdown",
"Cancel"
};
final static String[] restartOptions =
static final String[] restartOptions =
{
"Restart",
"Cancel"
};
final static String[] abortOptions =
static final String[] abortOptions =
{
"Abort",
"Cancel"
};
final static String[] confirmOptions =
static final String[] confirmOptions =
{
"Confirm",
"Cancel"

View File

@@ -39,7 +39,7 @@ import com.l2jmobius.gameserver.util.Locator;
*/
public class SystemPanel extends JPanel
{
final static long startTime = System.currentTimeMillis();
static final long startTime = System.currentTimeMillis();
public SystemPanel()
{

View File

@@ -39,7 +39,7 @@ import com.l2jmobius.Config;
public class frmAbout
{
private JFrame frmAbout;
final static String URL = "www.l2jmobius.com";
static final String URL = "www.l2jmobius.com";
URI uri;
public frmAbout()

View File

@@ -695,8 +695,8 @@ public final class Util
{
final StringBuilder sb = new StringBuilder();
try (InputStream in = new FileInputStream(file);
final InputStreamReader reader = new InputStreamReader(in, cs);
final BufferedReader buffer = new BufferedReader(reader))
InputStreamReader reader = new InputStreamReader(in, cs);
BufferedReader buffer = new BufferedReader(reader))
{
String line;
while ((line = buffer.readLine()) != null)

View File

@@ -511,7 +511,7 @@ public class SchedulingPattern
/**
* Definition for a value parser.
*/
private static interface ValueParser
private interface ValueParser
{
/**
* Attempts to parse a value.

View File

@@ -61,12 +61,12 @@ public class Gui
JCheckBoxMenuItem chckbxmntmDisabled;
JCheckBoxMenuItem chckbxmntmGmOnly;
final static String[] shutdownOptions =
static final String[] shutdownOptions =
{
"Shutdown",
"Cancel"
};
final static String[] restartOptions =
static final String[] restartOptions =
{
"Restart",
"Cancel"

View File

@@ -37,7 +37,7 @@ import javax.swing.WindowConstants;
public class frmAbout
{
private JFrame frmAbout;
final static String URL = "www.l2jmobius.com";
static final String URL = "www.l2jmobius.com";
URI uri;
public frmAbout()