lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor alchemy code improvements.

Browse Source
This commit is contained in:
MobiusDev
2015-11-17 13:46:59 +00:00
parent 7c665e0276
commit 9a8e3df86d
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
trunk/java/com/l2jserver/gameserver/network/clientpackets/alchemy/RequestAlchemyConversion.java
View File

@ -81,12 +81,9 @@ public class RequestAlchemyConversion extends L2GameClientPacket
return; return;
} }
final double chance = 80; // 80% ?
for (int i = 0; i < _skillUseCount; i++) for (int i = 0; i < _skillUseCount; i++)
{ {
boolean ok = Rnd.get(1, 100) < chance; if (Rnd.get(1, 100) < 90) // 90% ?
if (ok)
{ {
_resultItemCount += alchemySkill.getTransmutedItem().getCount(); _resultItemCount += alchemySkill.getTransmutedItem().getCount();
} }
@ -94,7 +91,6 @@ public class RequestAlchemyConversion extends L2GameClientPacket
{ {
_resultFailCount++; _resultFailCount++;
} }
alchemySkill.getIngridientItems().forEach(holder -> activeChar.getInventory().destroyItemByItemId("Alchemy", holder.getId(), holder.getCount(), activeChar, null)); alchemySkill.getIngridientItems().forEach(holder -> activeChar.getInventory().destroyItemByItemId("Alchemy", holder.getId(), holder.getCount(), activeChar, null));
} }
@ -107,7 +103,7 @@ public class RequestAlchemyConversion extends L2GameClientPacket
for (ItemHolder item : alchemySkill.getIngridientItems()) for (ItemHolder item : alchemySkill.getIngridientItems())
{ {
activeChar.getInventory().destroyItemByItemId("Alchemy", item.getId(), _resultFailCount, activeChar, null); activeChar.getInventory().destroyItemByItemId("Alchemy", item.getId(), _resultFailCount, activeChar, null);
break; // FIXME: Take only 1st ingridient. break; // FIXME: Takes only 1st ingredient (client has specific item and quantity).
} }
activeChar.sendPacket(SystemMessageId.FAILURE_TO_TRANSMUTE_WILL_DESTROY_SOME_INGREDIENTS); activeChar.sendPacket(SystemMessageId.FAILURE_TO_TRANSMUTE_WILL_DESTROY_SOME_INGREDIENTS);
} }

2
trunk/java/com/l2jserver/gameserver/network/serverpackets/alchemy/ExAlchemySkillList.java
View File

@ -34,7 +34,7 @@ public class ExAlchemySkillList extends L2GameServerPacket
private final static int ALCHEMY_CUBE_SKILL = 17943; private final static int ALCHEMY_CUBE_SKILL = 17943;
private final List<Skill> _skills = new ArrayList<>(); private final List<Skill> _skills = new ArrayList<>();
public ExAlchemySkillList(final L2PcInstance player) public ExAlchemySkillList(L2PcInstance player)
{ {
for (Skill skill : player.getAllSkills()) for (Skill skill : player.getAllSkills())
{ {

4
trunk/java/com/l2jserver/gameserver/network/serverpackets/alchemy/ExTryMixCube.java
View File

@ -27,14 +27,14 @@ public class ExTryMixCube extends L2GameServerPacket
private final int _itemId; private final int _itemId;
private final long _itemCount; private final long _itemCount;
public ExTryMixCube(final int result) public ExTryMixCube(int result)
{ {
_result = result; _result = result;
_itemId = 0; _itemId = 0;
_itemCount = 0; _itemCount = 0;
} }
public ExTryMixCube(final int itemId, final long itemCount) public ExTryMixCube(int itemId, long itemCount)
{ {
_result = 0; _result = 0;
_itemId = itemId; _itemId = itemId;