lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code improvements.

Browse Source 
Contributed by Mathael.
This commit is contained in:
MobiusDev
2016-03-28 10:39:18 +00:00
parent fdafe7447e
commit 901d2a858b
10 changed files with 92 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
trunk/dist/game/data/scripts/ai/atelia_fortess/AteliaStatus/AteliaStatus.java vendored
View File

@@ -409,28 +409,15 @@ final class AteliaStatus extends AbstractNpcAI
} }
break; break;
} }
// Quest Timer to Stages
case "TimeEnd":
{
if (npc != null)
{
npc.deleteMe();
}
break;
}
// Stronghold's // Stronghold's
case "SH_1": case "SH_1":
{ {
if (npc == null) if (npc == null)
{ {
final L2Npc barton = addSpawn(BARTON, BARTON_LOC); addSpawn(BARTON, BARTON_LOC, false, DESPAWN);
final L2Npc glenki = addSpawn(GLENKI, GLENKI_LOC); addSpawn(GLENKI, GLENKI_LOC, false, DESPAWN);
final L2Npc flagone = addSpawn(FLAG, FLAG_1_LOC); addSpawn(FLAG, FLAG_1_LOC, false, DESPAWN);
final L2Npc flagtwo = addSpawn(FLAG, FLAG_2_LOC); addSpawn(FLAG, FLAG_2_LOC, false, DESPAWN);
startQuestTimer("TimeEnd", DESPAWN, barton, null);
startQuestTimer("TimeEnd", DESPAWN, glenki, null);
startQuestTimer("TimeEnd", DESPAWN, flagone, null);
startQuestTimer("TimeEnd", DESPAWN, flagtwo, null);
} }
break; break;
} }
@@ -438,14 +425,10 @@ final class AteliaStatus extends AbstractNpcAI
{ {
if (npc == null) if (npc == null)
{ {
final L2Npc hayuk = addSpawn(HAYUK, HAYUK_LOC); addSpawn(HAYUK, HAYUK_LOC, false, DESPAWN);
final L2Npc hurak = addSpawn(HURAK, HURAK_LOC); addSpawn(HURAK, HURAK_LOC, false, DESPAWN);
final L2Npc flagthree = addSpawn(FLAG, FLAG_3_LOC); addSpawn(FLAG, FLAG_3_LOC, false, DESPAWN);
final L2Npc flagfour = addSpawn(FLAG, FLAG_4_LOC); addSpawn(FLAG, FLAG_4_LOC, false, DESPAWN);
startQuestTimer("TimeEnd", DESPAWN, hayuk, null);
startQuestTimer("TimeEnd", DESPAWN, hurak, null);
startQuestTimer("TimeEnd", DESPAWN, flagthree, null);
startQuestTimer("TimeEnd", DESPAWN, flagfour, null);
} }
break; break;
} }
@@ -453,18 +436,12 @@ final class AteliaStatus extends AbstractNpcAI
{ {
if (npc == null) if (npc == null)
{ {
final L2Npc elise = addSpawn(ELISE, ELISE_LOC); addSpawn(ELISE, ELISE_LOC, false, DESPAWN);
final L2Npc laffian = addSpawn(LAFFIAN, LAFFIAN_LOC); addSpawn(LAFFIAN, LAFFIAN_LOC, false, DESPAWN);
final L2Npc julia = addSpawn(JULIA, JULIA_LOC); addSpawn(JULIA, JULIA_LOC, false, DESPAWN);
final L2Npc mion = addSpawn(MION, MION_LOC); addSpawn(MION, MION_LOC, false, DESPAWN);
final L2Npc flagfive = addSpawn(FLAG, FLAG_5_LOC); addSpawn(FLAG, FLAG_5_LOC, false, DESPAWN);
final L2Npc flagsix = addSpawn(FLAG, FLAG_6_LOC); addSpawn(FLAG, FLAG_6_LOC, false, DESPAWN);
startQuestTimer("TimeEnd", DESPAWN, elise, null);
startQuestTimer("TimeEnd", DESPAWN, laffian, null);
startQuestTimer("TimeEnd", DESPAWN, julia, null);
startQuestTimer("TimeEnd", DESPAWN, mion, null);
startQuestTimer("TimeEnd", DESPAWN, flagfive, null);
startQuestTimer("TimeEnd", DESPAWN, flagsix, null);
} }
break; break;
} }
@@ -472,18 +449,12 @@ final class AteliaStatus extends AbstractNpcAI
{ {
if (npc == null) if (npc == null)
{ {
final L2Npc eliyah = addSpawn(ELIYAH, ELIYAH_LOC); addSpawn(ELIYAH, ELIYAH_LOC, false, DESPAWN);
final L2Npc sherry = addSpawn(SHERRY, SHERRY_LOC); addSpawn(SHERRY, SHERRY_LOC, false, DESPAWN);
final L2Npc saylem = addSpawn(SAYLEM, SAYLEM_LOC); addSpawn(SAYLEM, SAYLEM_LOC, false, DESPAWN);
final L2Npc nika = addSpawn(NIKA, NIKA_LOC); addSpawn(NIKA, NIKA_LOC, false, DESPAWN);
final L2Npc flagseven = addSpawn(FLAG, FLAG_7_LOC); addSpawn(FLAG, FLAG_7_LOC, false, DESPAWN);
final L2Npc flageight = addSpawn(FLAG, FLAG_8_LOC); addSpawn(FLAG, FLAG_8_LOC, false, DESPAWN);
startQuestTimer("TimeEnd", DESPAWN, eliyah, null);
startQuestTimer("TimeEnd", DESPAWN, sherry, null);
startQuestTimer("TimeEnd", DESPAWN, saylem, null);
startQuestTimer("TimeEnd", DESPAWN, nika, null);
startQuestTimer("TimeEnd", DESPAWN, flagseven, null);
startQuestTimer("TimeEnd", DESPAWN, flageight, null);
} }
break; break;
} }
@@ -586,14 +557,6 @@ final class AteliaStatus extends AbstractNpcAI
} }
break; break;
} }
case "DEVIANNE_CLEAR":
{
if (npc != null)
{
npc.deleteMe();
}
break;
}
case "SPY_CLEAR": case "SPY_CLEAR":
{ {
for (L2Npc spawn : FortessSpawns) for (L2Npc spawn : FortessSpawns)
@@ -701,8 +664,7 @@ final class AteliaStatus extends AbstractNpcAI
} }
else if (npc.getId() == BURNSTEIN) else if (npc.getId() == BURNSTEIN)
{ {
final L2Npc devianne = addSpawn(DEVIANNE, DEVIANNE_LOC); addSpawn(DEVIANNE, DEVIANNE_LOC, false, DDESPAWN);
startQuestTimer("DEVIANNE_CLEAR", DDESPAWN, devianne, null);
startQuestTimer("SPY_CLEAR", 100, npc, null); startQuestTimer("SPY_CLEAR", 100, npc, null);
startQuestTimer("SB_3", 100, npc, killer); startQuestTimer("SB_3", 100, npc, killer);
} }

18
trunk/dist/game/data/scripts/ai/atelia_fortess/Devianne.java vendored
View File

@@ -35,7 +35,7 @@ final class Devianne extends AbstractNpcAI
// Location // Location
private static final Location DEVIANNE_LOC = new Location(-50063, 49439, -1760, 40362); private static final Location DEVIANNE_LOC = new Location(-50063, 49439, -1760, 40362);
// Other // Other
private static final int DESPAWN = 3600000; // Time 1 Hour private static final int DESPAWN_DELAY = 3600000; // Time 1 Hour
private Devianne() private Devianne()
{ {
@@ -44,24 +44,10 @@ final class Devianne extends AbstractNpcAI
addSpawnId(DEVIANNE); addSpawnId(DEVIANNE);
} }
@Override
public String onAdvEvent(String event, L2Npc npc, L2PcInstance player)
{
if (event.equals("devianne_despawn"))
{
if (npc != null)
{
npc.deleteMe();
}
}
return event;
}
@Override @Override
public String onKill(L2Npc npc, L2PcInstance killer, boolean isSummon) public String onKill(L2Npc npc, L2PcInstance killer, boolean isSummon)
{ {
final L2Npc devianne = addSpawn(DEVIANNE, DEVIANNE_LOC); addSpawn(DEVIANNE, DEVIANNE_LOC, false, DESPAWN_DELAY);
startQuestTimer("devianne_despawn", DESPAWN, devianne, null);
return super.onKill(npc, killer, isSummon); return super.onKill(npc, killer, isSummon);
} }

5
trunk/dist/game/data/scripts/ai/npc/AltarOfSouls/AltarOfSouls.java vendored
View File

@@ -52,11 +52,6 @@ final class AltarOfSouls extends AbstractNpcAI
@Override @Override
public String onAdvEvent(String event, L2Npc npc, L2PcInstance player) public String onAdvEvent(String event, L2Npc npc, L2PcInstance player)
{ {
if (npc.getId() != ALTAR_OF_SOULS)
{
return null;
}
switch (event) switch (event)
{ {
case "request_boss_88": case "request_boss_88":

9
trunk/dist/game/data/scripts/ai/npc/Hardin/Hardin.java vendored
View File

@@ -46,10 +46,7 @@ final class Hardin extends AbstractNpcAI
public String onFirstTalk(L2Npc npc, L2PcInstance player) public String onFirstTalk(L2Npc npc, L2PcInstance player)
{ {
String htmltext = null; String htmltext = null;
switch (npc.getId())
{
case HARDIN:
{
if ((player.getRace() != Race.ERTHEIA) && (player.getLevel() < MIN_LEVEL)) if ((player.getRace() != Race.ERTHEIA) && (player.getLevel() < MIN_LEVEL))
{ {
htmltext = "33870-01.html"; htmltext = "33870-01.html";
@@ -62,9 +59,7 @@ final class Hardin extends AbstractNpcAI
{ {
htmltext = "33870-03.html"; htmltext = "33870-03.html";
} }
break;
}
}
return htmltext; return htmltext;
} }

3
trunk/dist/game/data/scripts/quests/Q10338_SeizeYourDestiny/Q10338_SeizeYourDestiny.java vendored
View File

@@ -207,15 +207,12 @@ public class Q10338_SeizeYourDestiny extends Quest
@Override @Override
public String onKill(L2Npc npc, L2PcInstance player, boolean isSummon) public String onKill(L2Npc npc, L2PcInstance player, boolean isSummon)
{
if (npc.getId() == HARNAKS_WRAITH)
{ {
final QuestState qs = getQuestState(player, false); final QuestState qs = getQuestState(player, false);
if ((qs != null) && qs.isCond(2)) if ((qs != null) && qs.isCond(2))
{ {
qs.setCond(3, true); qs.setCond(3, true);
} }
}
return super.onKill(npc, player, isSummon); return super.onKill(npc, player, isSummon);
} }
} }

8
trunk/dist/game/data/scripts/quests/Q10382_DayOfLiberation/Q10382_DayOfLiberation.java vendored
View File

@@ -84,10 +84,6 @@ public class Q10382_DayOfLiberation extends Quest
final QuestState qs = getQuestState(player, true); final QuestState qs = getQuestState(player, true);
String htmltext = getNoQuestMsg(player); String htmltext = getNoQuestMsg(player);
switch (npc.getId())
{
case SIZRAK:
{
if (qs.isCreated()) if (qs.isCreated())
{ {
htmltext = "sofa_sizraku_q10382_01.htm"; htmltext = "sofa_sizraku_q10382_01.htm";
@@ -107,9 +103,7 @@ public class Q10382_DayOfLiberation extends Quest
{ {
htmltext = "sofa_sizraku_q10382_06.html"; htmltext = "sofa_sizraku_q10382_06.html";
} }
break;
}
}
return htmltext; return htmltext;
} }

5
trunk/dist/game/data/scripts/quests/Q10734_DoOrDie/Q10734_DoOrDie.java vendored
View File

@@ -283,8 +283,7 @@ public class Q10734_DoOrDie extends Quest
{ {
return super.onKill(npc, killer, isSummon); return super.onKill(npc, killer, isSummon);
} }
if (npc.getId() == TRAINING_DUMMY)
{
if (qs.isCond(1)) if (qs.isCond(1))
{ {
if (killer.isMageClass()) if (killer.isMageClass())
@@ -307,7 +306,7 @@ public class Q10734_DoOrDie extends Quest
qs.setCond(8, true); qs.setCond(8, true);
} }
} }
}
return super.onKill(npc, killer, isSummon); return super.onKill(npc, killer, isSummon);
} }
} }

8
trunk/dist/game/data/scripts/quests/Q10756_AnInterdimensionalDraft/Q10756_AnInterdimensionalDraft.java vendored
View File

@@ -101,10 +101,6 @@ public class Q10756_AnInterdimensionalDraft extends Quest
htmltext = getAlreadyCompletedMsg(player); htmltext = getAlreadyCompletedMsg(player);
} }
switch (npc.getId())
{
case PIO:
{
if (qs.isCreated()) if (qs.isCreated())
{ {
htmltext = "33963-01.htm"; htmltext = "33963-01.htm";
@@ -132,9 +128,7 @@ public class Q10756_AnInterdimensionalDraft extends Quest
} }
} }
} }
break;
}
}
return htmltext; return htmltext;
} }

6
trunk/dist/game/data/scripts/quests/Q10760_LettersFromTheQueen_OrcBarracs/Q10760_LettersFromTheQueen_OrcBarracs.java vendored
View File

@@ -145,11 +145,7 @@ public class Q10760_LettersFromTheQueen_OrcBarracs extends Quest implements IByp
} }
case PIOTUR: case PIOTUR:
{ {
if (player.getRace() != Race.ERTHEIA) if (qs.isCreated())
{
htmltext = getNoQuestMsg(player);
}
else if (qs.isCreated())
{ {
htmltext = getNoQuestMsg(player); htmltext = getNoQuestMsg(player);
} }

6
trunk/java/com/l2jmobius/gameserver/model/L2Spawn.java
View File

@@ -87,7 +87,7 @@ public class L2Spawn implements IPositionable, IIdentifiable, INamable
private String _areaName; private String _areaName;
private int _globalMapId; private int _globalMapId;
private String _title = ""; private final String _title = "";
/** The task launching the function doSpawn() */ /** The task launching the function doSpawn() */
class SpawnTask implements Runnable class SpawnTask implements Runnable
@@ -694,10 +694,6 @@ public class L2Spawn implements IPositionable, IIdentifiable, INamable
mob.setTitle(_title); mob.setTitle(_title);
} }
// Reset summoner // Reset summoner
mob.setSummoner(null); mob.setSummoner(null);
// Reset summoned list // Reset summoned list