Prevent various auto-boxing operations by using primitive getters.
This commit is contained in:
@@ -333,7 +333,7 @@ public class AwakeningMaster extends AbstractNpcAI
|
||||
{
|
||||
if (player.isInCategory(ent.getKey()))
|
||||
{
|
||||
giveItems(player, ent.getValue(), 1);
|
||||
giveItems(player, ent.getValue().intValue(), 1);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@@ -351,7 +351,7 @@ public class AdventureGuildsman extends AbstractNpcAI
|
||||
{
|
||||
if (player.isInCategory(entry.getKey()))
|
||||
{
|
||||
multisellId = entry.getValue();
|
||||
multisellId = entry.getValue().intValue();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -369,7 +369,7 @@ public class AdventureGuildsman extends AbstractNpcAI
|
||||
{
|
||||
if (player.isInCategory(entry.getKey()))
|
||||
{
|
||||
multisellId = entry.getValue();
|
||||
multisellId = entry.getValue().intValue();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -387,7 +387,7 @@ public class AdventureGuildsman extends AbstractNpcAI
|
||||
{
|
||||
if (player.isInCategory(entry.getKey()))
|
||||
{
|
||||
multisellId = entry.getValue();
|
||||
multisellId = entry.getValue().intValue();
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -406,7 +406,7 @@ public class AdventureGuildsman extends AbstractNpcAI
|
||||
{
|
||||
if (player.isInCategory(entry.getKey()))
|
||||
{
|
||||
multisellId = entry.getValue();
|
||||
multisellId = entry.getValue().intValue();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@@ -215,7 +215,7 @@ public class OlyManager extends AbstractNpcAI implements IBypassHandler
|
||||
{
|
||||
if (player.isInCategory(entry.getKey()))
|
||||
{
|
||||
multisellId = entry.getValue();
|
||||
multisellId = entry.getValue().intValue();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
@@ -100,7 +100,7 @@ public class AirBind extends AbstractEffect
|
||||
{
|
||||
if ((nearbyPlayer.getRace() != Race.ERTHEIA) && (nearbyPlayer.getTarget() == effected) && nearbyPlayer.isInCategory(CategoryType.SIXTH_CLASS_GROUP) && !nearbyPlayer.isAlterSkillActive())
|
||||
{
|
||||
final int chainSkill = AIRBIND_SKILLS.get(nearbyPlayer.getClassId());
|
||||
final int chainSkill = AIRBIND_SKILLS.get(nearbyPlayer.getClassId()).intValue();
|
||||
if (nearbyPlayer.getSkillRemainingReuseTime(chainSkill) == -1)
|
||||
{
|
||||
nearbyPlayer.sendPacket(new ExAlterSkillRequest(nearbyPlayer, chainSkill, chainSkill, 5));
|
||||
|
@@ -54,7 +54,7 @@ public class AttackTrait extends AbstractEffect
|
||||
{
|
||||
for (Entry<TraitType, Float> trait : _attackTraits.entrySet())
|
||||
{
|
||||
effected.getStat().mergeAttackTrait(trait.getKey(), trait.getValue());
|
||||
effected.getStat().mergeAttackTrait(trait.getKey(), trait.getValue().floatValue());
|
||||
}
|
||||
}
|
||||
|
||||
@@ -63,7 +63,7 @@ public class AttackTrait extends AbstractEffect
|
||||
{
|
||||
for (Entry<TraitType, Float> trait : _attackTraits.entrySet())
|
||||
{
|
||||
effected.getStat().removeAttackTrait(trait.getKey(), trait.getValue());
|
||||
effected.getStat().removeAttackTrait(trait.getKey(), trait.getValue().floatValue());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@@ -54,9 +54,9 @@ public class DefenceTrait extends AbstractEffect
|
||||
{
|
||||
for (Entry<TraitType, Float> trait : _defenceTraits.entrySet())
|
||||
{
|
||||
if (trait.getValue() < 1.0f)
|
||||
if (trait.getValue().floatValue() < 1.0f)
|
||||
{
|
||||
effected.getStat().mergeDefenceTrait(trait.getKey(), trait.getValue());
|
||||
effected.getStat().mergeDefenceTrait(trait.getKey(), trait.getValue().floatValue());
|
||||
}
|
||||
else
|
||||
{
|
||||
@@ -70,9 +70,9 @@ public class DefenceTrait extends AbstractEffect
|
||||
{
|
||||
for (Entry<TraitType, Float> trait : _defenceTraits.entrySet())
|
||||
{
|
||||
if (trait.getValue() < 1.0f)
|
||||
if (trait.getValue().floatValue() < 1.0f)
|
||||
{
|
||||
effected.getStat().removeDefenceTrait(trait.getKey(), trait.getValue());
|
||||
effected.getStat().removeDefenceTrait(trait.getKey(), trait.getValue().floatValue());
|
||||
}
|
||||
else
|
||||
{
|
||||
|
@@ -80,7 +80,7 @@ public class DispelBySlot extends AbstractEffect
|
||||
{
|
||||
// Dispel transformations (buff and by GM)
|
||||
final Short transformToDispel = _dispelAbnormals.get(AbnormalType.TRANSFORM);
|
||||
if ((transformToDispel != null) && ((transformToDispel == effected.getTransformationId()) || (transformToDispel < 0)))
|
||||
if ((transformToDispel != null) && ((transformToDispel.intValue() == effected.getTransformationId()) || (transformToDispel.intValue() < 0)))
|
||||
{
|
||||
effected.stopTransformation(true);
|
||||
}
|
||||
@@ -94,7 +94,7 @@ public class DispelBySlot extends AbstractEffect
|
||||
}
|
||||
|
||||
final Short abnormalLevel = _dispelAbnormals.get(info.getSkill().getAbnormalType());
|
||||
return (abnormalLevel != null) && ((abnormalLevel < 0) || (abnormalLevel >= info.getSkill().getAbnormalLvl()));
|
||||
return (abnormalLevel != null) && ((abnormalLevel.shortValue() < 0) || (abnormalLevel.shortValue() >= info.getSkill().getAbnormalLvl()));
|
||||
}, true, true);
|
||||
}
|
||||
}
|
||||
|
@@ -179,7 +179,7 @@ public class KnockBack extends AbstractEffect
|
||||
{
|
||||
if ((nearbyPlayer.getRace() != Race.ERTHEIA) && (nearbyPlayer.getTarget() == effected) && nearbyPlayer.isInCategory(CategoryType.SIXTH_CLASS_GROUP) && !nearbyPlayer.isAlterSkillActive())
|
||||
{
|
||||
final int chainSkill = KNOCKBACK_SKILLS.get(nearbyPlayer.getClassId());
|
||||
final int chainSkill = KNOCKBACK_SKILLS.get(nearbyPlayer.getClassId()).intValue();
|
||||
if (nearbyPlayer.getSkillRemainingReuseTime(chainSkill) == -1)
|
||||
{
|
||||
nearbyPlayer.sendPacket(new ExAlterSkillRequest(nearbyPlayer, chainSkill, chainSkill, 3));
|
||||
|
@@ -141,7 +141,7 @@ public class PhysicalAttackWeaponBonus extends AbstractEffect
|
||||
|
||||
// Skill specific mods.
|
||||
final double weaponMod = effector.getAttackType().isRanged() ? 70 : 77;
|
||||
final double weaponBonus = _weaponBonus.getOrDefault(effector.getAttackType(), 1.0);
|
||||
final double weaponBonus = _weaponBonus.containsKey(effector.getAttackType()) ? _weaponBonus.get(effector.getAttackType()).doubleValue() : 1d;
|
||||
final double power = _power + effector.getStat().getValue(Stat.SKILL_POWER_ADD, 0);
|
||||
final double rangedBonus = effector.getAttackType().isRanged() ? attack + power : 0;
|
||||
final double critMod = critical ? Formulas.calcCritDamage(effector, effected, skill) : 1;
|
||||
|
@@ -117,7 +117,7 @@ public class RestorationRandom extends AbstractEffect
|
||||
newItem.setEnchantLevel(Rnd.get(createdItem.getMinEnchant(), createdItem.getMaxEnchant()));
|
||||
}
|
||||
|
||||
if (extractedItems.get(newItem) != null)
|
||||
if (extractedItems.containsKey(newItem))
|
||||
{
|
||||
extractedItems.put(newItem, extractedItems.get(newItem) + itemCount);
|
||||
}
|
||||
@@ -143,7 +143,7 @@ public class RestorationRandom extends AbstractEffect
|
||||
playerIU.addModifiedItem(itemInstance);
|
||||
}
|
||||
}
|
||||
sendMessage(player, entry.getKey(), entry.getValue());
|
||||
sendMessage(player, entry.getKey(), entry.getValue().longValue());
|
||||
}
|
||||
player.sendPacket(playerIU);
|
||||
}
|
||||
@@ -155,7 +155,7 @@ public class RestorationRandom extends AbstractEffect
|
||||
return EffectType.EXTRACT_ITEM;
|
||||
}
|
||||
|
||||
private void sendMessage(PlayerInstance player, ItemInstance item, Long count)
|
||||
private void sendMessage(PlayerInstance player, ItemInstance item, long count)
|
||||
{
|
||||
final SystemMessage sm;
|
||||
if (count > 1)
|
||||
|
@@ -61,7 +61,7 @@ public class ServitorShare extends AbstractEffect
|
||||
{
|
||||
for (Entry<Stat, Float> stats : _sharedStats.entrySet())
|
||||
{
|
||||
effected.getStat().mergeAdd(stats.getKey(), owner.getStat().getValue(stats.getKey()) * stats.getValue());
|
||||
effected.getStat().mergeAdd(stats.getKey(), owner.getStat().getValue(stats.getKey()) * stats.getValue().floatValue());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@@ -63,7 +63,7 @@ public class Transformation extends AbstractEffect
|
||||
{
|
||||
if (!_id.isEmpty())
|
||||
{
|
||||
effected.transform(_id.get(Rnd.get(_id.size())), true);
|
||||
effected.transform(_id.get(Rnd.get(_id.size())).intValue(), true);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -200,7 +200,7 @@ public class ExtractableItems implements IItemHandler
|
||||
|
||||
for (Entry<ItemInstance, Long> entry : extractedItems.entrySet())
|
||||
{
|
||||
sendMessage(player, entry.getKey(), entry.getValue());
|
||||
sendMessage(player, entry.getKey(), entry.getValue().longValue());
|
||||
}
|
||||
|
||||
return true;
|
||||
@@ -208,7 +208,7 @@ public class ExtractableItems implements IItemHandler
|
||||
|
||||
private void addItem(Map<ItemInstance, Long> extractedItems, ItemInstance newItem)
|
||||
{
|
||||
if (extractedItems.get(newItem) != null)
|
||||
if (extractedItems.containsKey(newItem))
|
||||
{
|
||||
extractedItems.put(newItem, extractedItems.get(newItem) + 1);
|
||||
}
|
||||
@@ -218,7 +218,7 @@ public class ExtractableItems implements IItemHandler
|
||||
}
|
||||
}
|
||||
|
||||
private void sendMessage(PlayerInstance player, ItemInstance item, Long count)
|
||||
private void sendMessage(PlayerInstance player, ItemInstance item, long count)
|
||||
{
|
||||
final SystemMessage sm;
|
||||
if (count > 1)
|
||||
|
@@ -260,10 +260,13 @@ public class EvilIncubator extends AbstractInstance
|
||||
if (st.isCond(9))
|
||||
{
|
||||
st.setCond(10, true);
|
||||
final int classItemId = CLASS_ITEMS.getOrDefault(player.getClassId(), -1);
|
||||
if ((classItemId != -1) && !hasQuestItems(player, classItemId))
|
||||
if (CLASS_ITEMS.containsKey(player.getClassId()))
|
||||
{
|
||||
giveItems(player, classItemId, 1);
|
||||
final int classItemId = CLASS_ITEMS.get(player.getClassId()).intValue();
|
||||
if (!hasQuestItems(player, classItemId))
|
||||
{
|
||||
giveItems(player, classItemId, 1);
|
||||
}
|
||||
}
|
||||
npc.broadcastSay(ChatType.NPC_GENERAL, NpcStringId.THE_CRY_OF_DESTINY_PENDANT_WILL_BE_HELPFUL_TO_YOU_PLEASE_EQUIP_IT_AND_BRING_OUT_THE_POWER_OF_THE_PENDANT_TO_PREPARE_FOR_THE_NEXT_FIGHT);
|
||||
htmltext = "33170-06.html";
|
||||
@@ -494,7 +497,7 @@ public class EvilIncubator extends AbstractInstance
|
||||
world.setParameter("WORLD_WAVE", waveId);
|
||||
showOnScreenMsg(world, NpcStringId.I_DEATH_WOUND_CHAMPION_OF_SHILEN_SHALL_END_YOUR_WORLD, ExShowScreenMessage.TOP_CENTER, 5000, true);
|
||||
getTimers().addTimer("SPAWN_WAVE", 20000, e -> manageWaveSpawn(world));
|
||||
final Npc boss = addSpawn(CLASS_BOSS.get(world.getFirstPlayer().getClassId()), BOSS_LOC, false, 0, false, world.getId());
|
||||
final Npc boss = addSpawn(CLASS_BOSS.get(world.getFirstPlayer().getClassId()).intValue(), BOSS_LOC, false, 0, false, world.getId());
|
||||
world.broadcastPacket(new Earthquake(boss, 50, 10));
|
||||
break;
|
||||
}
|
||||
|
@@ -464,12 +464,12 @@ public class Kamaloka extends AbstractInstance
|
||||
for (Entry<Integer, Long> entry : instanceTimes.entrySet())
|
||||
{
|
||||
// find instance with same name (kamaloka or labyrinth)
|
||||
if (!instanceName.equals(InstanceManager.getInstance().getInstanceName(entry.getKey())))
|
||||
if (!instanceName.equals(InstanceManager.getInstance().getInstanceName(entry.getKey().intValue())))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
// if found instance still can't be reentered - exit
|
||||
if (System.currentTimeMillis() < entry.getValue())
|
||||
if (System.currentTimeMillis() < entry.getValue().longValue())
|
||||
{
|
||||
final SystemMessage sm = new SystemMessage(SystemMessageId.C1_MAY_NOT_RE_ENTER_YET);
|
||||
sm.addPcName(partyMember);
|
||||
|
@@ -173,7 +173,7 @@ public class KartiaHelperElise extends AbstractNpcAI
|
||||
for (Entry<WorldObject, Integer> entry : sortedHpMap.entrySet())
|
||||
{
|
||||
final WorldObject friend = entry.getKey();
|
||||
final int percent = entry.getValue();
|
||||
final int percent = entry.getValue().intValue();
|
||||
if ((friend != null) && (percent < 80) && (percent > 1))
|
||||
{
|
||||
peopleToHeal.add(friend);
|
||||
|
@@ -87,7 +87,7 @@ public abstract class ThirdClassTransferQuest extends Quest
|
||||
addTalkId(VANGUARDS);
|
||||
for (Entry<Race, Integer> tag : RACE_TAGS.entrySet())
|
||||
{
|
||||
registerQuestItems(tag.getValue());
|
||||
registerQuestItems(tag.getValue().intValue());
|
||||
}
|
||||
//@formatter:off
|
||||
registerQuestItems(
|
||||
@@ -159,7 +159,7 @@ public abstract class ThirdClassTransferQuest extends Quest
|
||||
{
|
||||
qs.setCond(4, true);
|
||||
qs.unset("vanguard");
|
||||
takeItems(player, RACE_TAGS.get(player.getRace()), -1);
|
||||
takeItems(player, RACE_TAGS.get(player.getRace()).intValue(), -1);
|
||||
htmltext = event;
|
||||
}
|
||||
break;
|
||||
@@ -181,9 +181,9 @@ public abstract class ThirdClassTransferQuest extends Quest
|
||||
final int vanguard = qs.getInt("vanguard");
|
||||
if ((vanguard & bit) != bit)
|
||||
{
|
||||
giveItems(player, RACE_TAGS.get(player.getRace()), 1);
|
||||
giveItems(player, RACE_TAGS.get(player.getRace()).intValue(), 1);
|
||||
qs.set("vanguard", vanguard | bit);
|
||||
if (getQuestItemsCount(player, RACE_TAGS.get(player.getRace())) == 4)
|
||||
if (getQuestItemsCount(player, RACE_TAGS.get(player.getRace()).intValue()) == 4)
|
||||
{
|
||||
qs.setCond(3, true);
|
||||
htmltext = "vanguard-04.html";
|
||||
|
Reference in New Issue
Block a user