lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed RequestExPledgeCrestLarge out of bounds index for byte array.

Browse Source
This commit is contained in:
MobiusDevelopment 2020-02-17 09:16:48 +00:00
parent eddbb43a56
commit 74e32bf28d
2 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
L2J_Mobius_7.0_PreludeOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestExPledgeCrestLarge.java
View File

@ -47,18 +47,14 @@ public class RequestExPledgeCrestLarge implements IClientIncomingPacket
{ {
for (int i = 0; i <= 4; i++) for (int i = 0; i <= 4; i++)
{ {
if (i < 4) final int size = Math.max(Math.min(14336, data.length - (14336 * i)), 0);
if (size == 0)
{ {
final byte[] fullChunk = new byte[14336]; continue;
System.arraycopy(data, (14336 * i), fullChunk, 0, 14336);
client.sendPacket(new ExPledgeEmblem(_crestId, fullChunk, _clanId, i));
}
else
{
final byte[] lastChunk = new byte[8320];
System.arraycopy(data, (14336 * i), lastChunk, 0, 8320);
client.sendPacket(new ExPledgeEmblem(_crestId, lastChunk, _clanId, i));
} }
final byte[] chunk = new byte[size];
System.arraycopy(data, (14336 * i), chunk, 0, size);
client.sendPacket(new ExPledgeEmblem(_crestId, chunk, _clanId, i));
} }
} }
} }

16
L2J_Mobius_Classic_3.0_TheKamael/java/org/l2jmobius/gameserver/network/clientpackets/RequestExPledgeCrestLarge.java
View File

@ -47,18 +47,14 @@ public class RequestExPledgeCrestLarge implements IClientIncomingPacket
{ {
for (int i = 0; i <= 4; i++) for (int i = 0; i <= 4; i++)
{ {
if (i < 4) final int size = Math.max(Math.min(14336, data.length - (14336 * i)), 0);
if (size == 0)
{ {
final byte[] fullChunk = new byte[14336]; continue;
System.arraycopy(data, (14336 * i), fullChunk, 0, 14336);
client.sendPacket(new ExPledgeEmblem(_crestId, fullChunk, _clanId, i));
}
else
{
final byte[] lastChunk = new byte[8320];
System.arraycopy(data, (14336 * i), lastChunk, 0, 8320);
client.sendPacket(new ExPledgeEmblem(_crestId, lastChunk, _clanId, i));
} }
final byte[] chunk = new byte[size];
System.arraycopy(data, (14336 * i), chunk, 0, size);
client.sendPacket(new ExPledgeEmblem(_crestId, chunk, _clanId, i));
} }
} }
} }