Check for queued skill before next action.

L2J_Mobius_1.0_Ertheia/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_2.5_Underground/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_3.0_Helios/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_4.0_GrandCrusade/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_5.0_Salvation/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_5.5_EtinasFate/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_Classic_2.0_Saviors/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_Classic_2.1_Zaken/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_Classic_2.2_Antharas/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)

L2J_Mobius_Classic_2.3_SevenSigns/java/com/l2jmobius/gameserver/model/skills/SkillCaster.java

@@ -740,8 +740,23 @@ public class SkillCaster implements Runnable
 			caster.sendPacket(ActionFailed.get(_castingType)); // send an "action failed" packet to the caster
 		}
 		
-		// Attack target after skill use
+		// If there is a queued skill, launch it and wipe the queue.
-		// TODO: This shouldnt be here. If skill condition fail, you still go autoattack. This doesn't happen if skill is in cooldown though.
+		if (caster.isPlayer())
+		{
+			final L2PcInstance currPlayer = caster.getActingPlayer();
+			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
+			if (queuedSkill != null)
+			{
+				ThreadPool.execute(() ->
+				{
+					currPlayer.setQueuedSkill(null, null, false, false);
+					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
+				});
+				return;
+			}
+		}
+		
+		// Attack target after skill use.
 		if ((_skill.getNextAction() != NextActionType.NONE) && (caster.getAI().getNextIntention() == null))
 		{
 			if ((_skill.getNextAction() == NextActionType.ATTACK) && (target != null) && (target != caster) && target.isAutoAttackable(caster))
@@ -761,26 +776,6 @@ public class SkillCaster implements Runnable
 		{
 			caster.getAI().notifyEvent(CtrlEvent.EVT_FINISH_CASTING);
 		}
-		
-		// Notify the AI of the L2Character with EVT_FINISH_CASTING
-		
-		// If there is a queued skill, launch it and wipe the queue.
-		if (caster.isPlayer())
-		{
-			final L2PcInstance currPlayer = caster.getActingPlayer();
-			final SkillUseHolder queuedSkill = currPlayer.getQueuedSkill();
-			
-			if (queuedSkill != null)
-			{
-				ThreadPool.execute(() ->
-				{
-					currPlayer.setQueuedSkill(null, null, false, false);
-					currPlayer.useMagic(queuedSkill.getSkill(), queuedSkill.getItem(), queuedSkill.isCtrlPressed(), queuedSkill.isShiftPressed());
-				});
-				
-				return;
-			}
-		}
 	}
 	
 	private void calcSkillTiming(L2Character creature, Skill skill)