Removal of Creature effect and skill getter conversions to arrays.

This commit is contained in:
MobiusDevelopment
2021-04-21 22:06:59 +00:00
parent 7fe7f49ab3
commit 6d16bebe1a
45 changed files with 425 additions and 886 deletions

View File

@@ -385,15 +385,11 @@ public class Baium extends Quest
if (attacker.getMountType() == 1)
{
int sk4258 = 0;
final Effect[] effects = attacker.getAllEffects();
if ((effects != null) && (effects.length != 0))
for (Effect e : attacker.getAllEffects())
{
for (Effect e : effects)
if (e.getSkill().getId() == 4258)
{
if (e.getSkill().getId() == 4258)
{
sk4258 = 1;
}
sk4258 = 1;
}
}
if (sk4258 == 0)

View File

@@ -158,17 +158,13 @@ public class Valakas extends Quest
{
int level = 0;
int sk4691 = 0;
final Effect[] effects = npc.getAllEffects();
if ((effects != null) && (effects.length != 0))
for (Effect e : npc.getAllEffects())
{
for (Effect e : effects)
if (e.getSkill().getId() == 4629)
{
if (e.getSkill().getId() == 4629)
{
sk4691 = 1;
level = e.getSkill().getLevel();
break;
}
sk4691 = 1;
level = e.getSkill().getLevel();
break;
}
}
@@ -376,15 +372,11 @@ public class Valakas extends Quest
if (attacker.getMountType() == 1)
{
int sk4258 = 0;
final Effect[] effects = attacker.getAllEffects();
if ((effects != null) && (effects.length != 0))
for (Effect e : attacker.getAllEffects())
{
for (Effect e : effects)
if (e.getSkill().getId() == 4258)
{
if (e.getSkill().getId() == 4258)
{
sk4258 = 1;
}
sk4258 = 1;
}
}
if (sk4258 == 0)

View File

@@ -212,19 +212,15 @@ public class Zaken extends Quest
}
int sk4223 = 0;
int sk4227 = 0;
final Effect[] effects = npc.getAllEffects();
if ((effects != null) && (effects.length != 0))
for (Effect e : npc.getAllEffects())
{
for (Effect e : effects)
if (e.getSkill().getId() == 4227)
{
if (e.getSkill().getId() == 4227)
{
sk4227 = 1;
}
if (e.getSkill().getId() == 4223)
{
sk4223 = 1;
}
sk4227 = 1;
}
if (e.getSkill().getId() == 4223)
{
sk4223 = 1;
}
}
if (getTimeHour() < 5)
@@ -754,15 +750,11 @@ public class Zaken extends Quest
if (attacker.getMountType() == 1)
{
int sk4258 = 0;
final Effect[] effects = attacker.getAllEffects();
if ((effects != null) && (effects.length != 0))
for (Effect e : attacker.getAllEffects())
{
for (Effect e : effects)
if (e.getSkill().getId() == 4258)
{
if (e.getSkill().getId() == 4258)
{
sk4258 = 1;
}
sk4258 = 1;
}
}
if (sk4258 == 0)