diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/Server.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/Server.java index bd8b9abec3..df010968c7 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/Server.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/Server.java @@ -52,11 +52,11 @@ public class Server } // Start game server. - GameServer gameServer = new GameServer(); + final GameServer gameServer = new GameServer(); gameServer.start(); // Start login server. - LoginServer loginServer = new LoginServer(); + final LoginServer loginServer = new LoginServer(); loginServer.start(); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/AdminCommands.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/AdminCommands.java index 17031831eb..7a16575bca 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/AdminCommands.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/AdminCommands.java @@ -74,15 +74,15 @@ public class AdminCommands extends Thread StringTokenizer st; NpcInstance target; String id; - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (command.equals("admin_show")) { showMainPage(client); } else if (command.startsWith("admin_kill")) { - int objectId = Integer.parseInt(command.substring(11)); - WorldObject temp = World.getInstance().findObject(objectId); + final int objectId = Integer.parseInt(command.substring(11)); + final WorldObject temp = World.getInstance().findObject(objectId); if (temp instanceof NpcInstance) { target = (NpcInstance) temp; @@ -91,8 +91,8 @@ public class AdminCommands extends Thread } else if (command.startsWith("admin_delete")) { - int objectId = Integer.parseInt(command.substring(13)); - WorldObject temp = World.getInstance().findObject(objectId); + final int objectId = Integer.parseInt(command.substring(13)); + final WorldObject temp = World.getInstance().findObject(objectId); if (temp instanceof NpcInstance) { target = (NpcInstance) temp; @@ -122,7 +122,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(23); + final String val = command.substring(23); Announcements.getInstance().addAnnouncement(val); Announcements.getInstance().listAnnouncements(activeChar); } @@ -133,7 +133,7 @@ public class AdminCommands extends Thread } else if (command.startsWith("admin_del_announcement")) { - int val = Integer.parseInt(command.substring(23)); + final int val = Integer.parseInt(command.substring(23)); Announcements.getInstance().delAnnouncement(val); Announcements.getInstance().listAnnouncements(activeChar); } @@ -163,12 +163,12 @@ public class AdminCommands extends Thread } else if (command.startsWith("admin_skill_index")) { - String val = command.substring(18); + final String val = command.substring(18); showHelpPage(client, "skills/" + val + ".htm"); } else if (command.startsWith("admin_spawn_index")) { - String val = command.substring(18); + final String val = command.substring(18); showHelpPage(client, "spawns/" + val + ".htm"); } else if (command.equals("admin_character_disconnect")) @@ -207,7 +207,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(14); + final String val = command.substring(14); teleportTo(client, val); } catch (StringIndexOutOfBoundsException e) @@ -220,7 +220,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(11); + final String val = command.substring(11); showHelpPage(client, val); } catch (StringIndexOutOfBoundsException e) @@ -231,7 +231,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(21); + final String val = command.substring(21); showCharacterList(client, val); } catch (StringIndexOutOfBoundsException e) @@ -242,8 +242,8 @@ public class AdminCommands extends Thread { try { - String val = command.substring(22); - int page = Integer.parseInt(val); + final String val = command.substring(22); + final int page = Integer.parseInt(val); listCharacters(client, page); } catch (StringIndexOutOfBoundsException e) @@ -254,7 +254,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(21); + final String val = command.substring(21); findCharacter(client, val); } catch (StringIndexOutOfBoundsException e) @@ -267,7 +267,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(16); + final String val = command.substring(16); adminAddExpSp(client, val); } catch (StringIndexOutOfBoundsException e) @@ -280,7 +280,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(15); + final String val = command.substring(15); adminAddSkill(client, val); } catch (StringIndexOutOfBoundsException e) @@ -293,8 +293,8 @@ public class AdminCommands extends Thread { try { - String id2 = command.substring(19); - int idval = Integer.parseInt(id2); + final String id2 = command.substring(19); + final int idval = Integer.parseInt(id2); adminRemoveSkill(client, idval); } catch (StringIndexOutOfBoundsException e) @@ -307,7 +307,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(24); + final String val = command.substring(24); adminModifyCharacter(client, val); } catch (StringIndexOutOfBoundsException e) @@ -320,7 +320,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(25); + final String val = command.substring(25); teleportCharacter(client, val); } catch (StringIndexOutOfBoundsException e) @@ -333,7 +333,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(20); + final String val = command.substring(20); spawnMenu(client, val); } catch (StringIndexOutOfBoundsException e) @@ -344,7 +344,7 @@ public class AdminCommands extends Thread { try { - String val = command.substring(20); + final String val = command.substring(20); st = new StringTokenizer(val); if (st.countTokens() != 2) { @@ -353,7 +353,7 @@ public class AdminCommands extends Thread return; } id = st.nextToken(); - String targetName = st.nextToken(); + final String targetName = st.nextToken(); spawnMonster(client, id, targetName); } catch (StringIndexOutOfBoundsException e) @@ -364,7 +364,7 @@ public class AdminCommands extends Thread { try { - int val = Integer.parseInt(command.substring(22)); + final int val = Integer.parseInt(command.substring(22)); serverShutdown(client, val); } catch (StringIndexOutOfBoundsException e) @@ -385,20 +385,20 @@ public class AdminCommands extends Thread { try { - String val = command.substring(17); + final String val = command.substring(17); st = new StringTokenizer(val); if (st.countTokens() == 2) { id = st.nextToken(); - int idval = Integer.parseInt(id); - String num = st.nextToken(); - int numval = Integer.parseInt(num); + final int idval = Integer.parseInt(id); + final String num = st.nextToken(); + final int numval = Integer.parseInt(num); createItem(client, idval, numval); } else if (st.countTokens() == 1) { id = st.nextToken(); - int idval = Integer.parseInt(id); + final int idval = Integer.parseInt(id); createItem(client, idval, 1); } else @@ -415,7 +415,7 @@ public class AdminCommands extends Thread private void handleBuyRequest(ClientThread client, String command) { - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); int val = -1; try { @@ -425,10 +425,10 @@ public class AdminCommands extends Thread { _log.warning("admin buylist failed:" + command); } - TradeList list = TradeController.getInstance().getBuyList(val); + final TradeList list = TradeController.getInstance().getBuyList(val); if (list != null) { - BuyList bl = new BuyList(list, player.getAdena()); + final BuyList bl = new BuyList(list, player.getAdena()); player.sendPacket(bl); } else @@ -440,9 +440,9 @@ public class AdminCommands extends Thread public void showMainPage(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Server Status"); + final PlayerInstance activeChar = client.getActiveChar(); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Server Status"); replyMSG.append(""); replyMSG.append(""); replyMSG.append(""); @@ -468,15 +468,15 @@ public class AdminCommands extends Thread private void teleportTo(ClientThread client, String coords) { - PlayerInstance activeChar = client.getActiveChar(); - StringTokenizer st = new StringTokenizer(coords); - String x1 = st.nextToken(); - int x = Integer.parseInt(x1); - String y1 = st.nextToken(); - int y = Integer.parseInt(y1); - String z1 = st.nextToken(); - int z = Integer.parseInt(z1); - TeleportToLocation tele = new TeleportToLocation(activeChar, x, y, z); + final PlayerInstance activeChar = client.getActiveChar(); + final StringTokenizer st = new StringTokenizer(coords); + final String x1 = st.nextToken(); + final int x = Integer.parseInt(x1); + final String y1 = st.nextToken(); + final int y = Integer.parseInt(y1); + final String z1 = st.nextToken(); + final int z = Integer.parseInt(z1); + final TeleportToLocation tele = new TeleportToLocation(activeChar, x, y, z); activeChar.sendPacket(tele); activeChar.setX(x); activeChar.setY(y); @@ -487,17 +487,17 @@ public class AdminCommands extends Thread private void createItem(ClientThread client, int id, int num) { - PlayerInstance activeChar = client.getActiveChar(); - ItemInstance createditem = ItemTable.getInstance().createItem(id); + final PlayerInstance activeChar = client.getActiveChar(); + final ItemInstance createditem = ItemTable.getInstance().createItem(id); for (int i = 0; i < num; ++i) { activeChar.getInventory().addItem(createditem); } - ItemList il = new ItemList(activeChar, true); + final ItemList il = new ItemList(activeChar, true); activeChar.sendPacket(il); activeChar.sendMessage("You have spawned " + num + " item(s) number " + id + " in your inventory."); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Item Creation Complete(I Hope)"); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Item Creation Complete(I Hope)"); replyMSG.append(""); replyMSG.append("
"); replyMSG.append(""); @@ -507,12 +507,12 @@ public class AdminCommands extends Thread private void listCharacters(ClientThread client, int page) { - PlayerInstance activeChar = client.getActiveChar(); - Collection allWorldPlayers = World.getInstance().getAllPlayers(); - PlayerInstance[] players = allWorldPlayers.toArray(new PlayerInstance[allWorldPlayers.size()]); - int MaxCharactersPerPage = 20; + final PlayerInstance activeChar = client.getActiveChar(); + final Collection allWorldPlayers = World.getInstance().getAllPlayers(); + final PlayerInstance[] players = allWorldPlayers.toArray(new PlayerInstance[allWorldPlayers.size()]); + final int MaxCharactersPerPage = 20; int MaxPages = players.length / MaxCharactersPerPage; - int modulus = players.length % MaxCharactersPerPage; + final int modulus = players.length % MaxCharactersPerPage; if (modulus != 0) { ++MaxPages; @@ -521,10 +521,10 @@ public class AdminCommands extends Thread { page = MaxPages; } - int CharactersStart = MaxCharactersPerPage * page; - int CharactersEnd = players.length - CharactersStart; - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Characters List"); + final int CharactersStart = MaxCharactersPerPage * page; + final int CharactersEnd = players.length - CharactersStart; + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Characters List"); replyMSG.append(""); for (int x = 0; x < MaxPages; ++x) { @@ -550,10 +550,10 @@ public class AdminCommands extends Thread private void showCharacterList(ClientThread client, String CharName) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(CharName); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Character Information"); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(CharName); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Character Information"); replyMSG.append(""); replyMSG.append("
"); replyMSG.append("
" + player.getName() + "

"); @@ -611,10 +611,10 @@ public class AdminCommands extends Thread private void addExpSp(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Add Exp-Sp to " + player.getName() + ""); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Add Exp-Sp to " + player.getName() + ""); replyMSG.append(""); replyMSG.append("
"); replyMSG.append("

Lv: " + player.getLevel() + " " + CharTemplateTable.getInstance().getTemplate(player.getClassId()).getClassName() + "

"); @@ -635,19 +635,19 @@ public class AdminCommands extends Thread private void adminAddExpSp(ClientThread client, String ExpSp) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - StringTokenizer st = new StringTokenizer(ExpSp); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final StringTokenizer st = new StringTokenizer(ExpSp); if (st.countTokens() != 2) { addExpSp(client); } else { - String exp = st.nextToken(); - String sp = st.nextToken(); - int expval = Integer.parseInt(exp); - int spval = Integer.parseInt(sp); + final String exp = st.nextToken(); + final String sp = st.nextToken(); + final int expval = Integer.parseInt(exp); + final int spval = Integer.parseInt(sp); player.sendMessage("Admin is adding you " + expval + " xp and " + spval + " sp."); player.addExpAndSp(expval, spval); activeChar.sendMessage("Added " + expval + " xp and " + spval + " sp to " + player.getName() + "."); @@ -657,33 +657,33 @@ public class AdminCommands extends Thread private void adminModifyCharacter(ClientThread client, String modifications) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - StringTokenizer st = new StringTokenizer(modifications); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final StringTokenizer st = new StringTokenizer(modifications); if (st.countTokens() != 9) { editCharacter(client); } else { - String hp = st.nextToken(); - String hpmax = st.nextToken(); - String mp = st.nextToken(); - String mpmax = st.nextToken(); - String load = st.nextToken(); - String karma = st.nextToken(); - String pvpflag = st.nextToken(); - String pvpkills = st.nextToken(); - String classid = st.nextToken(); - int hpval = Integer.parseInt(hp); - int hpmaxval = Integer.parseInt(hpmax); - int mpval = Integer.parseInt(mp); - int mpmaxval = Integer.parseInt(mpmax); - int loadval = Integer.parseInt(load); - int karmaval = Integer.parseInt(karma); - int pvpflagval = Integer.parseInt(pvpflag); - int pvpkillsval = Integer.parseInt(pvpkills); - int classidval = Integer.parseInt(classid); + final String hp = st.nextToken(); + final String hpmax = st.nextToken(); + final String mp = st.nextToken(); + final String mpmax = st.nextToken(); + final String load = st.nextToken(); + final String karma = st.nextToken(); + final String pvpflag = st.nextToken(); + final String pvpkills = st.nextToken(); + final String classid = st.nextToken(); + final int hpval = Integer.parseInt(hp); + final int hpmaxval = Integer.parseInt(hpmax); + final int mpval = Integer.parseInt(mp); + final int mpmaxval = Integer.parseInt(mpmax); + final int loadval = Integer.parseInt(load); + final int karmaval = Integer.parseInt(karma); + final int pvpflagval = Integer.parseInt(pvpflag); + final int pvpkillsval = Integer.parseInt(pvpkills); + final int classidval = Integer.parseInt(classid); player.sendMessage("Admin has changed your stats. Hp: " + hpval + " HpMax: " + hpmaxval + " Mp: " + mpval + " MpMax: " + mpmaxval + " MaxLoad: " + loadval + " Karma: " + karmaval + " Pvp: " + pvpflagval + " / " + pvpkillsval + " ClassId: " + classidval); player.setCurrentHp(hpval); player.setCurrentMp(mpval); @@ -693,7 +693,7 @@ public class AdminCommands extends Thread player.setKarma(karmaval); player.setPvpKills(pvpkillsval); player.setClassId(classidval); - StatusUpdate su = new StatusUpdate(player.getObjectId()); + final StatusUpdate su = new StatusUpdate(player.getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, hpval); su.addAttribute(StatusUpdate.MAX_HP, hpmaxval); su.addAttribute(StatusUpdate.CUR_MP, mpval); @@ -709,10 +709,10 @@ public class AdminCommands extends Thread private void editCharacter(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Editing character " + player.getName() + ""); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Editing character " + player.getName() + ""); replyMSG.append(""); replyMSG.append("

Caution ! Dont forget that modifying players stats can ruin the game...

"); replyMSG.append("Note: you must type all values to confirm modifications.

"); @@ -759,8 +759,8 @@ public class AdminCommands extends Thread private void disconnectCharacter(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); if (player.getName().equals(activeChar.getName())) { activeChar.sendMessage("You cannot logout your character."); @@ -768,7 +768,7 @@ public class AdminCommands extends Thread else { activeChar.sendMessage("Character " + player.getName() + " disconnected from server."); - LeaveWorld ql = new LeaveWorld(); + final LeaveWorld ql = new LeaveWorld(); player.sendPacket(ql); try { @@ -784,10 +784,10 @@ public class AdminCommands extends Thread private void findCharacter(ClientThread client, String CharacterToFind) { - PlayerInstance activeChar = client.getActiveChar(); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final PlayerInstance activeChar = client.getActiveChar(); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); int CharactersFound = 0; - StringBuffer replyMSG = new StringBuffer("Character Search"); + final StringBuffer replyMSG = new StringBuffer("Character Search"); replyMSG.append(""); replyMSG.append("
"); replyMSG.append("
Players Online: " + World.getInstance().getAllPlayers().size() + "
"); @@ -830,10 +830,10 @@ public class AdminCommands extends Thread private void showTeleportCharWindow(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Teleport Character"); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Teleport Character"); replyMSG.append(""); replyMSG.append("The character you will teleport is " + player.getName() + "."); replyMSG.append("
"); @@ -853,23 +853,23 @@ public class AdminCommands extends Thread private void teleportCharacter(ClientThread client, String Cords) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); if (player.getName().equals(activeChar.getName())) { player.sendMessage("You cannot teleport your character."); } else { - StringTokenizer st = new StringTokenizer(Cords); - String x1 = st.nextToken(); - int x = Integer.parseInt(x1); - String y1 = st.nextToken(); - int y = Integer.parseInt(y1); - String z1 = st.nextToken(); - int z = Integer.parseInt(z1); + final StringTokenizer st = new StringTokenizer(Cords); + final String x1 = st.nextToken(); + final int x = Integer.parseInt(x1); + final String y1 = st.nextToken(); + final int y = Integer.parseInt(y1); + final String z1 = st.nextToken(); + final int z = Integer.parseInt(z1); player.sendMessage("Admin is teleporting you."); - TeleportToLocation tele = new TeleportToLocation(player, x, y, z); + final TeleportToLocation tele = new TeleportToLocation(player, x, y, z); player.sendPacket(tele); player.setX(x); player.setY(y); @@ -881,18 +881,18 @@ public class AdminCommands extends Thread private void teleportToCharacter(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); if (player.getName().equals(activeChar.getName())) { activeChar.sendMessage("You cannot self teleport."); } else { - int x = player.getX(); - int y = player.getY(); - int z = player.getZ(); - TeleportToLocation tele = new TeleportToLocation(activeChar, x, y, z); + final int x = player.getX(); + final int y = player.getY(); + final int z = player.getZ(); + final TeleportToLocation tele = new TeleportToLocation(activeChar, x, y, z); activeChar.sendPacket(tele); activeChar.setX(x); activeChar.setY(y); @@ -904,9 +904,9 @@ public class AdminCommands extends Thread private void spawnMenu(ClientThread client, String monsterId) { - PlayerInstance activeChar = client.getActiveChar(); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Custom Spawn Menu"); + final PlayerInstance activeChar = client.getActiveChar(); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Custom Spawn Menu"); replyMSG.append("
Enter target player's name below.
You may leave the field blank for self-spawn.

"); replyMSG.append("


"); replyMSG.append("

"); @@ -917,17 +917,17 @@ public class AdminCommands extends Thread private void spawnMonster(ClientThread client, String monsterId, String CharName) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance targetPlayer = World.getInstance().getPlayer(CharName); - int monsterTemplate = Integer.parseInt(monsterId); - Npc template1 = NpcTable.getInstance().getTemplate(monsterTemplate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance targetPlayer = World.getInstance().getPlayer(CharName); + final int monsterTemplate = Integer.parseInt(monsterId); + final Npc template1 = NpcTable.getInstance().getTemplate(monsterTemplate); if (template1 == null) { return; } try { - Spawn spawn = new Spawn(template1); + final Spawn spawn = new Spawn(template1); spawn.setLocx(targetPlayer.getX()); spawn.setLocy(targetPlayer.getY()); spawn.setLocz(targetPlayer.getZ()); @@ -951,7 +951,7 @@ public class AdminCommands extends Thread { for (PlayerInstance player : World.getInstance().getAllPlayers()) { - LeaveWorld ql = new LeaveWorld(); + final LeaveWorld ql = new LeaveWorld(); player.sendPacket(ql); try { @@ -970,7 +970,7 @@ public class AdminCommands extends Thread { secondsShut = seconds; clientShut = client; - AdminCommands ShutDownThread = new AdminCommands(); + final AdminCommands ShutDownThread = new AdminCommands(); ShutDownThread.start(); } @@ -979,9 +979,9 @@ public class AdminCommands extends Thread { if ((secondsShut == 0) && (clientShut != null)) { - PlayerInstance activeChar = clientShut.getActiveChar(); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Shutdown Server"); + final PlayerInstance activeChar = clientShut.getActiveChar(); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Shutdown Server"); replyMSG.append("
"); replyMSG.append("Enter in seconds the time till the server

shutdowns bellow:"); replyMSG.append(""); @@ -1034,7 +1034,7 @@ public class AdminCommands extends Thread } } } - int delay = 1000; + final int delay = 1000; Thread.sleep(delay); } if (disconnectAllCharacters() == 1) @@ -1058,13 +1058,13 @@ public class AdminCommands extends Thread FileInputStream fis = null; try { - File file = new File("data/html/admin/" + filename); + final File file = new File("data/html/admin/" + filename); fis = new FileInputStream(file); - byte[] raw = new byte[fis.available()]; + final byte[] raw = new byte[fis.available()]; fis.read(raw); - String content = new String(raw, "UTF-8"); - PlayerInstance activeChar = client.getActiveChar(); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final String content = new String(raw, "UTF-8"); + final PlayerInstance activeChar = client.getActiveChar(); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); adminReply.setHtml(content); activeChar.sendPacket(adminReply); @@ -1106,7 +1106,7 @@ public class AdminCommands extends Thread public void broadcastToAll(String message) { - CreatureSay cs = new CreatureSay(0, 9, "[Announcement]", message); + final CreatureSay cs = new CreatureSay(0, 9, "[Announcement]", message); for (PlayerInstance player : World.getInstance().getAllPlayers()) { player.sendPacket(cs); @@ -1115,10 +1115,10 @@ public class AdminCommands extends Thread private void removeSkillsPage(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Remove skills of " + player.getName() + ""); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Remove skills of " + player.getName() + ""); replyMSG.append(""); replyMSG.append("
"); replyMSG.append("

Lv: " + player.getLevel() + " " + CharTemplateTable.getInstance().getTemplate(player.getClassId()).getClassName() + "

"); @@ -1146,10 +1146,10 @@ public class AdminCommands extends Thread private void showSkillsPage(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Modify skills of " + player.getName() + ""); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Modify skills of " + player.getName() + ""); replyMSG.append(""); replyMSG.append("
"); replyMSG.append("

Lv: " + player.getLevel() + " " + CharTemplateTable.getInstance().getTemplate(player.getClassId()).getClassName() + "

"); @@ -1169,15 +1169,15 @@ public class AdminCommands extends Thread private void adminGetSkills(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); if (player.getName().equals(activeChar.getName())) { player.sendMessage("There is no point in doing it on your character..."); } else { - Collection skills = player.getAllSkills(); + final Collection skills = player.getAllSkills(); adminSkills = activeChar.getAllSkills(); for (Skill skill : adminSkills) { @@ -1194,15 +1194,15 @@ public class AdminCommands extends Thread private void adminResetSkills(ClientThread client) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); if (adminSkills == null) { activeChar.sendMessage("You must first get the skills of someone to do this."); } else { - Collection skills = player.getAllSkills(); + final Collection skills = player.getAllSkills(); for (Skill skill : skills) { player.removeSkill(skill); @@ -1228,20 +1228,20 @@ public class AdminCommands extends Thread private void adminAddSkill(ClientThread client, String val) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - StringTokenizer st = new StringTokenizer(val); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final StringTokenizer st = new StringTokenizer(val); if (st.countTokens() != 2) { showSkillsPage(client); } else { - String id = st.nextToken(); - String level = st.nextToken(); - int idval = Integer.parseInt(id); - int levelval = Integer.parseInt(level); - Skill skill = SkillTable.getInstance().getInfo(idval, levelval); + final String id = st.nextToken(); + final String level = st.nextToken(); + final int idval = Integer.parseInt(id); + final int levelval = Integer.parseInt(level); + final Skill skill = SkillTable.getInstance().getInfo(idval, levelval); if (skill != null) { player.sendMessage("Admin gave you the skill " + skill.getName() + "."); @@ -1258,9 +1258,9 @@ public class AdminCommands extends Thread private void adminRemoveSkill(ClientThread client, int idval) { - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); - Skill skill = SkillTable.getInstance().getInfo(idval, player.getSkillLevel(idval)); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance player = World.getInstance().getPlayer(_characterToManipulate); + final Skill skill = SkillTable.getInstance().getInfo(idval, player.getSkillLevel(idval)); if (skill != null) { player.sendMessage("Admin removed the skill " + skill.getName() + "."); @@ -1276,15 +1276,15 @@ public class AdminCommands extends Thread public void showSkill(ClientThread client, String val) { - PlayerInstance activeChar = client.getActiveChar(); - int skillid = Integer.parseInt(val); - Skill skill = SkillTable.getInstance().getInfo(skillid, 1); + final PlayerInstance activeChar = client.getActiveChar(); + final int skillid = Integer.parseInt(val); + final Skill skill = SkillTable.getInstance().getInfo(skillid, 1); if (skill != null) { if (skill.getTargetType() == 0) { activeChar.setTarget(activeChar); - MagicSkillUser msk = new MagicSkillUser(activeChar, skillid, 1, skill.getHitTime(), skill.getReuseDelay()); + final MagicSkillUser msk = new MagicSkillUser(activeChar, skillid, 1, skill.getHitTime(), skill.getReuseDelay()); activeChar.sendPacket(msk); activeChar.broadcastPacket(msk); // ActionFailed af = new ActionFailed(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/Announcements.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/Announcements.java index 8d6f4a76f0..842130a9ce 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/Announcements.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/Announcements.java @@ -56,7 +56,7 @@ public class Announcements public void loadAnnouncements() { _announcements.clear(); - File file = new File("data/announcements.txt"); + final File file = new File("data/announcements.txt"); if (file.exists()) { readFromDisk(file); @@ -71,15 +71,15 @@ public class Announcements { for (int i = 0; i < _announcements.size(); ++i) { - CreatureSay cs = new CreatureSay(0, 10, activeChar.getName(), _announcements.get(i).toString()); + final CreatureSay cs = new CreatureSay(0, 10, activeChar.getName(), _announcements.get(i).toString()); activeChar.sendPacket(cs); } } public void listAnnouncements(PlayerInstance activeChar) { - NpcHtmlMessage adminReply = new NpcHtmlMessage(5); - StringBuffer replyMSG = new StringBuffer("Announcements:"); + final NpcHtmlMessage adminReply = new NpcHtmlMessage(5); + final StringBuffer replyMSG = new StringBuffer("Announcements:"); replyMSG.append(""); for (int i = 0; i < _announcements.size(); ++i) { @@ -117,15 +117,15 @@ public class Announcements String line = null; try { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); while ((line = lnr.readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, "\n\r"); + final StringTokenizer st = new StringTokenizer(line, "\n\r"); if (!st.hasMoreTokens()) { continue; } - String announcement = st.nextToken(); + final String announcement = st.nextToken(); _announcements.add(announcement); ++i; } @@ -146,7 +146,7 @@ public class Announcements { try { - FileWriter save = new FileWriter(new File("data/announcements.txt")); + final FileWriter save = new FileWriter(new File("data/announcements.txt")); for (int i = 0; i < _announcements.size(); ++i) { save.write(_announcements.get(i).toString()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameServer.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameServer.java index fdc3952eda..7acdae51d6 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameServer.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameServer.java @@ -87,7 +87,7 @@ public class GameServer extends Thread public static void main(String[] args) throws Exception { - GameServer server = new GameServer(); + final GameServer server = new GameServer(); _log.config("GameServer Listening on port 7777"); server.start(); } @@ -102,7 +102,7 @@ public class GameServer extends Thread do { // _log.info("Waiting for client connection..."); - Socket connection = _serverSocket.accept(); + final Socket connection = _serverSocket.accept(); new ClientThread(connection); } while (true); @@ -126,7 +126,7 @@ public class GameServer extends Thread if (!Config.SERVER_HOST_NAME.equals("*")) { - InetAddress adr = InetAddress.getByName(Config.SERVER_HOST_NAME); + final InetAddress adr = InetAddress.getByName(Config.SERVER_HOST_NAME); Config._ip = adr.getHostAddress(); _serverSocket = new ServerSocket(Config.SERVER_PORT, 50, adr); _log.config("GameServer listening on IP:" + Config._ip + " Port " + Config.SERVER_PORT); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameTimeController.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameTimeController.java index 60c06b172a..a195b599fd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameTimeController.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/GameTimeController.java @@ -45,7 +45,7 @@ public class GameTimeController extends Thread public int getGameTime() { - long time = (System.currentTimeMillis() - _gameStartTime) / 10000L; + final long time = (System.currentTimeMillis() - _gameStartTime) / 10000L; return (int) time; } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/IdFactory.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/IdFactory.java index a73727f92f..6322c40dd4 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/IdFactory.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/IdFactory.java @@ -40,9 +40,9 @@ public class IdFactory { try { - FileInputStream fis = new FileInputStream("data/idstate.dat"); - BufferedInputStream bis = new BufferedInputStream(fis); - ObjectInputStream oos = new ObjectInputStream(bis); + final FileInputStream fis = new FileInputStream("data/idstate.dat"); + final BufferedInputStream bis = new BufferedInputStream(fis); + final ObjectInputStream oos = new ObjectInputStream(bis); _curOID = (Integer) oos.readObject(); _oldOIDs = (Stack) oos.readObject(); oos.close(); @@ -81,9 +81,9 @@ public class IdFactory { try { - FileOutputStream fos = new FileOutputStream("data/idstate.dat"); - BufferedOutputStream bos = new BufferedOutputStream(fos); - ObjectOutputStream oos = new ObjectOutputStream(bos); + final FileOutputStream fos = new FileOutputStream("data/idstate.dat"); + final BufferedOutputStream bos = new BufferedOutputStream(fos); + final ObjectOutputStream oos = new ObjectOutputStream(bos); oos.writeObject(_curOID); oos.writeObject(_oldOIDs); oos.close(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharNameTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharNameTable.java index 0e6d20ae9d..c89d554a94 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharNameTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharNameTable.java @@ -38,16 +38,16 @@ public class CharNameTable private CharNameTable() { - File _accountsFolder = new File("data/accounts"); + final File _accountsFolder = new File("data/accounts"); _accountsFolder.mkdirs(); _charNames = new ArrayList<>(); - File[] accounts = _accountsFolder.listFiles(); + final File[] accounts = _accountsFolder.listFiles(); for (File account : accounts) { try { - File _charFolder = new File("data/accounts/" + account.getName()); - File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); + final File _charFolder = new File("data/accounts/" + account.getName()); + final File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); for (File c : chars) { _charNames.add(c.getName().replaceAll("_char.csv", "").toLowerCase()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharStatsTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharStatsTable.java index fd26eddd3c..7350b7c136 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharStatsTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharStatsTable.java @@ -47,10 +47,10 @@ public class CharStatsTable { try { - File modifierData = new File("data/char_stats.csv"); + final File modifierData = new File("data/char_stats.csv"); if (modifierData.isFile() && modifierData.exists()) { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(modifierData))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(modifierData))); String line = null; while ((line = lnr.readLine()) != null) { @@ -58,8 +58,8 @@ public class CharStatsTable { continue; } - StringTokenizer st = new StringTokenizer(line, ";"); - StatModifiers modifier = new StatModifiers(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final StatModifiers modifier = new StatModifiers(); modifier.setClassid(Integer.parseInt(st.nextToken())); modifier.setModstr(Integer.parseInt(st.nextToken())); modifier.setModcon(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharTemplateTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharTemplateTable.java index 3e25db455d..712838f17f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharTemplateTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/CharTemplateTable.java @@ -48,10 +48,10 @@ public class CharTemplateTable { try { - File charTemplateData = new File("data/char_templates.csv"); + final File charTemplateData = new File("data/char_templates.csv"); if (charTemplateData.isFile() && charTemplateData.exists()) { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(charTemplateData))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(charTemplateData))); String line = null; while ((line = lnr.readLine()) != null) { @@ -59,8 +59,8 @@ public class CharTemplateTable { continue; } - CharTemplate ct = new CharTemplate(); - StringTokenizer st = new StringTokenizer(line, ";"); + final CharTemplate ct = new CharTemplate(); + final StringTokenizer st = new StringTokenizer(line, ";"); ct.setClassId(Integer.parseInt(st.nextToken())); ct.setClassName(st.nextToken()); ct.setRaceId(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ClanTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ClanTable.java index 224fe15c0b..8134fd325f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ClanTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ClanTable.java @@ -51,12 +51,12 @@ public class ClanTable { try { - File clanFolder = new File("data/clans"); + final File clanFolder = new File("data/clans"); clanFolder.mkdirs(); - File[] clans = clanFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith(".csv")); + final File[] clans = clanFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith(".csv")); for (File clan2 : clans) { - Clan clan = restoreClan(clan2); + final Clan clan = restoreClan(clan2); _clans.put(clan.getClanId(), clan); } _log.config("Restored " + _clans.size() + " clans."); @@ -72,7 +72,7 @@ public class ClanTable Clan clan = null; try { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); lnr.readLine(); clan = parseClanData(lnr.readLine()); lnr.readLine(); @@ -80,7 +80,7 @@ public class ClanTable boolean first = true; while ((line = lnr.readLine()) != null) { - ClanMember member = parseMembers(line); + final ClanMember member = parseMembers(line); if (first) { clan.setLeader(member); @@ -100,8 +100,8 @@ public class ClanTable private Clan parseClanData(String line) { - Clan clan = new Clan(); - StringTokenizer st = new StringTokenizer(line, ";"); + final Clan clan = new Clan(); + final StringTokenizer st = new StringTokenizer(line, ";"); clan.setClanId(Integer.parseInt(st.nextToken())); clan.setName(st.nextToken()); clan.setLevel(Integer.parseInt(st.nextToken())); @@ -114,11 +114,11 @@ public class ClanTable private ClanMember parseMembers(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - String name = st.nextToken(); - int level = Integer.parseInt(st.nextToken()); - int classId = Integer.parseInt(st.nextToken()); - int objectId = Integer.parseInt(st.nextToken()); + final StringTokenizer st = new StringTokenizer(line, ";"); + final String name = st.nextToken(); + final int level = Integer.parseInt(st.nextToken()); + final int classId = Integer.parseInt(st.nextToken()); + final int objectId = Integer.parseInt(st.nextToken()); return new ClanMember(name, level, classId, objectId); } @@ -137,7 +137,7 @@ public class ClanTable } return null; } - Clan clan = new Clan(); + final Clan clan = new Clan(); clan.setClanId(IdFactory.getInstance().getNextId()); clan.setName(clanName); clan.setLevel(0); @@ -145,7 +145,7 @@ public class ClanTable clan.setHasHideout(0); clan.setAllyId(0); clan.setAllyName(" "); - ClanMember leader = new ClanMember(player.getName(), player.getLevel(), player.getClassId(), player.getObjectId()); + final ClanMember leader = new ClanMember(player.getName(), player.getLevel(), player.getClassId(), player.getObjectId()); clan.setLeader(leader); _clans.put(clan.getClanId(), clan); clan.store(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ExperienceTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ExperienceTable.java index 23bef3d834..f2e5537621 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ExperienceTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ExperienceTable.java @@ -36,10 +36,10 @@ public class ExperienceTable { try { - File expData = new File("data/exp.csv"); + final File expData = new File("data/exp.csv"); if (expData.isFile() && expData.exists()) { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(expData))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(expData))); String line = null; while ((line = lnr.readLine()) != null) { @@ -47,9 +47,9 @@ public class ExperienceTable { continue; } - StringTokenizer expLine = new StringTokenizer(line, ";"); - String level = expLine.nextToken().trim(); - String exp = expLine.nextToken().trim(); + final StringTokenizer expLine = new StringTokenizer(line, ";"); + final String level = expLine.nextToken().trim(); + final String exp = expLine.nextToken().trim(); _exp.put(Integer.parseInt(level), Integer.parseInt(exp)); } lnr.close(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ItemTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ItemTable.java index eb06524994..554a280d6e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ItemTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/ItemTable.java @@ -140,7 +140,7 @@ public class ItemTable { File weaponFile; File armorFile; - File etcItemFile = new File("data/etcitem.csv"); + final File etcItemFile = new File("data/etcitem.csv"); if (!etcItemFile.isFile() && !etcItemFile.canRead()) { _initialized = false; @@ -175,7 +175,7 @@ public class ItemTable { for (int key : items.keySet()) { - EtcItem item = (EtcItem) items.get(key); + final EtcItem item = (EtcItem) items.get(key); if ((item.getWeight() == 0) && (item.getEtcItemType() != 7) && !item.getName().startsWith("world_map") && !item.getName().startsWith("crystal_")) { item.setType2(3); @@ -205,7 +205,7 @@ public class ItemTable private HashMap parseFile(File dataFile, int type) { - HashMap result = new HashMap<>(); + final HashMap result = new HashMap<>(); LineNumberReader lnr = null; Item temp = null; try @@ -257,14 +257,14 @@ public class ItemTable private EtcItem parseEtcLine(String line) { - EtcItem result = new EtcItem(); + final EtcItem result = new EtcItem(); try { - StringTokenizer st = new StringTokenizer(line, ";"); + final StringTokenizer st = new StringTokenizer(line, ";"); result.setItemId(Integer.parseInt(st.nextToken())); result.setName(st.nextToken()); result.setCrystallizable(Boolean.valueOf(st.nextToken())); - String itemType = st.nextToken(); + final String itemType = st.nextToken(); result.setType1(4); if (itemType.equals("none")) { @@ -312,7 +312,7 @@ public class ItemTable _log.warning("Unknown etcitem type:" + itemType); } result.setWeight(Integer.parseInt(st.nextToken())); - String consume = st.nextToken(); + final String consume = st.nextToken(); if (consume.equals("asset")) { result.setStackable(true); @@ -323,9 +323,9 @@ public class ItemTable { result.setStackable(true); } - Integer material = _materials.get(st.nextToken()); + final Integer material = _materials.get(st.nextToken()); result.setMaterialType(material); - Integer crystal = _crystalTypes.get(st.nextToken()); + final Integer crystal = _crystalTypes.get(st.nextToken()); result.setCrystalType(crystal); result.setDurability(Integer.parseInt(st.nextToken())); } @@ -339,18 +339,18 @@ public class ItemTable private Armor parseArmorLine(String line) { - Armor result = new Armor(); + final Armor result = new Armor(); try { - StringTokenizer st = new StringTokenizer(line, ";"); + final StringTokenizer st = new StringTokenizer(line, ";"); result.setItemId(Integer.parseInt(st.nextToken())); result.setName(st.nextToken()); - Integer bodyPart = _slots.get(st.nextToken()); + final Integer bodyPart = _slots.get(st.nextToken()); result.setBodyPart(bodyPart); result.setCrystallizable(Boolean.valueOf(st.nextToken())); - Integer armor = _armorTypes.get(st.nextToken()); + final Integer armor = _armorTypes.get(st.nextToken()); result.setArmorType(armor); - int slot = result.getBodyPart(); + final int slot = result.getBodyPart(); if ((slot == 8) || ((slot & 4) != 0) || ((slot & 0x20) != 0)) { result.setType1(0); @@ -362,9 +362,9 @@ public class ItemTable result.setType2(1); } result.setWeight(Integer.parseInt(st.nextToken())); - Integer material = _materials.get(st.nextToken()); + final Integer material = _materials.get(st.nextToken()); result.setMaterialType(material); - Integer crystal = _crystalTypes.get(st.nextToken()); + final Integer crystal = _crystalTypes.get(st.nextToken()); result.setCrystalType(crystal); result.setAvoidModifier(Integer.parseInt(st.nextToken())); result.setDurability(Integer.parseInt(st.nextToken())); @@ -382,27 +382,27 @@ public class ItemTable private Weapon parseWeaponLine(String line) { - Weapon result = new Weapon(); + final Weapon result = new Weapon(); try { - StringTokenizer st = new StringTokenizer(line, ";"); + final StringTokenizer st = new StringTokenizer(line, ";"); result.setItemId(Integer.parseInt(st.nextToken())); result.setName(st.nextToken()); result.setType1(0); result.setType2(0); - Integer bodyPart = _slots.get(st.nextToken()); + final Integer bodyPart = _slots.get(st.nextToken()); result.setBodyPart(bodyPart); result.setCrystallizable(Boolean.valueOf(st.nextToken())); result.setWeight(Integer.parseInt(st.nextToken())); result.setSoulShotCount(Integer.parseInt(st.nextToken())); result.setSpiritShotCount(Integer.parseInt(st.nextToken())); - Integer material = _materials.get(st.nextToken()); + final Integer material = _materials.get(st.nextToken()); result.setMaterialType(material); - Integer crystal = _crystalTypes.get(st.nextToken()); + final Integer crystal = _crystalTypes.get(st.nextToken()); result.setCrystalType(crystal); result.setPDamage(Integer.parseInt(st.nextToken())); result.setRandomDamage(Integer.parseInt(st.nextToken())); - Integer weapon = _weaponTypes.get(st.nextToken()); + final Integer weapon = _weaponTypes.get(st.nextToken()); result.setWeaponType(weapon); if (weapon == 1) { @@ -496,7 +496,7 @@ public class ItemTable public ItemInstance createItem(int itemId) { - ItemInstance temp = new ItemInstance(); + final ItemInstance temp = new ItemInstance(); temp.setObjectId(IdFactory.getInstance().getNextId()); temp.setItem(getTemplate(itemId)); World.getInstance().storeObject(temp); @@ -505,7 +505,7 @@ public class ItemTable public ItemInstance createDummyItem(int itemId) { - ItemInstance temp = new ItemInstance(); + final ItemInstance temp = new ItemInstance(); temp.setObjectId(0); Item item = null; try diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/LevelUpData.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/LevelUpData.java index bab8cff9ec..3f7ab446a5 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/LevelUpData.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/LevelUpData.java @@ -49,8 +49,8 @@ public class LevelUpData { try { - File spawnDataFile = new File("data/lvlupgain.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(spawnDataFile))); + final File spawnDataFile = new File("data/lvlupgain.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(spawnDataFile))); String line = null; while ((line = lnr.readLine()) != null) { @@ -58,8 +58,8 @@ public class LevelUpData { continue; } - StringTokenizer st = new StringTokenizer(line, ";"); - LvlupData lvlupData = new LvlupData(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final LvlupData lvlupData = new LvlupData(); lvlupData.setClassid(Integer.parseInt(st.nextToken())); lvlupData.setDefaulthp(Double.parseDouble(st.nextToken())); lvlupData.setDefaulthpadd(Double.parseDouble(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/MapRegionTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/MapRegionTable.java index 83718ef032..5f1ea3e56a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/MapRegionTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/MapRegionTable.java @@ -46,8 +46,8 @@ public class MapRegionTable int count = 0; try { - File regionDataFile = new File("data/mapregion.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(regionDataFile))); + final File regionDataFile = new File("data/mapregion.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(regionDataFile))); String line = null; while ((line = lnr.readLine()) != null) { @@ -55,7 +55,7 @@ public class MapRegionTable { continue; } - StringTokenizer st = new StringTokenizer(line, ";"); + final StringTokenizer st = new StringTokenizer(line, ";"); for (int j = 0; j < 10; ++j) { MapRegionTable._regions[j][count] = Integer.parseInt(st.nextToken()); @@ -152,14 +152,14 @@ public class MapRegionTable public int getMapRegion(int posX, int posY) { - int tileX = (posX >> 15) + 4; - int tileY = (posY >> 15) + 10; + final int tileX = (posX >> 15) + 4; + final int tileY = (posY >> 15) + 10; return _regions[tileX][tileY]; } public int[] getClosestTownCords(PlayerInstance player) { - int closest = getMapRegion(player.getX(), player.getY()); + final int closest = getMapRegion(player.getX(), player.getY()); int[] closestCords; if (player.getKarma() > 0) { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/NpcTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/NpcTable.java index 10efd0daa3..dd422fd5d0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/NpcTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/NpcTable.java @@ -62,8 +62,8 @@ public class NpcTable { try { - File npcData = new File("data/npc.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(npcData))); + final File npcData = new File("data/npc.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(npcData))); String line = null; while ((line = lnr.readLine()) != null) { @@ -71,7 +71,7 @@ public class NpcTable { continue; } - Npc npc = parseList(line); + final Npc npc = parseList(line); _npcs.put(npc.getNpcId(), npc); } lnr.close(); @@ -91,8 +91,8 @@ public class NpcTable private Npc parseList(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - Npc npc = new Npc(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final Npc npc = new Npc(); int id = Integer.parseInt(st.nextToken()); if (id > 1000000) { @@ -110,8 +110,8 @@ public class NpcTable { try { - File npcData2 = new File("data/npc2.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(npcData2))); + final File npcData2 = new File("data/npc2.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(npcData2))); String line = null; while ((line = lnr.readLine()) != null) { @@ -142,9 +142,9 @@ public class NpcTable private void parseAdditionalDataLine(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - int id = Integer.parseInt(st.nextToken()); - Npc npcDat = _npcs.get(id); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int id = Integer.parseInt(st.nextToken()); + final Npc npcDat = _npcs.get(id); if (npcDat == null) { _log.warning("Missing npc template id:" + id); @@ -177,8 +177,8 @@ public class NpcTable { try { - File dropData = new File("data/droplist.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(dropData))); + final File dropData = new File("data/droplist.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(dropData))); String line = null; int n = 0; while ((line = lnr.readLine()) != null) @@ -212,15 +212,15 @@ public class NpcTable private void parseDropLine(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - int mobId = Integer.parseInt(st.nextToken()); - Npc npc = _npcs.get(mobId); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int mobId = Integer.parseInt(st.nextToken()); + final Npc npc = _npcs.get(mobId); if (npc == null) { _log.warning("Could not add drop data for npcid:" + mobId); return; } - DropData dropDat = new DropData(); + final DropData dropDat = new DropData(); dropDat.setItemId(Integer.parseInt(st.nextToken())); dropDat.setMinDrop(Integer.parseInt(st.nextToken())); dropDat.setMaxDrop(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/PriceListTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/PriceListTable.java index eff76afe3e..4b2a588195 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/PriceListTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/PriceListTable.java @@ -49,22 +49,22 @@ public class PriceListTable { try { - File file = new File("data/pricelist.csv"); + final File file = new File("data/pricelist.csv"); if (file.isFile() && file.exists()) { int i = 0; String line = null; - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(file))); while ((line = lnr.readLine()) != null) { if (line.startsWith("#")) { continue; } - StringTokenizer st = new StringTokenizer(line, ";"); - int itemId = Integer.parseInt(st.nextToken().toString()); - int price = Integer.parseInt(st.nextToken().toString()); - Item temp = ItemTable.getInstance().getTemplate(itemId); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int itemId = Integer.parseInt(st.nextToken().toString()); + final int price = Integer.parseInt(st.nextToken().toString()); + final Item temp = ItemTable.getInstance().getTemplate(itemId); temp.setItemId(itemId); temp.setReferencePrice(price); ++i; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTable.java index 5bc13b9957..14d7fc9f6f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTable.java @@ -60,7 +60,7 @@ public class SkillTable { continue; } - Skill skill = parseList(line); + final Skill skill = parseList(line); _skills.put((skill.getId() * 100) + skill.getLevel(), skill); } skillData = new File("data/skills2.csv"); @@ -96,17 +96,17 @@ public class SkillTable private void parseList2(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - int id = Integer.parseInt(st.nextToken()); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int id = Integer.parseInt(st.nextToken()); st.nextToken(); - int level = Integer.parseInt(st.nextToken()); - int key = (id * 100) + level; - Skill skill = _skills.get(key); + final int level = Integer.parseInt(st.nextToken()); + final int key = (id * 100) + level; + final Skill skill = _skills.get(key); if (skill == null) { return; } - String target = st.nextToken(); + final String target = st.nextToken(); if (target.equalsIgnoreCase("self")) { skill.setTargetType(Skill.TARGET_SELF); @@ -132,12 +132,12 @@ public class SkillTable private Skill parseList(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - Skill skill = new Skill(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final Skill skill = new Skill(); skill.setId(Integer.parseInt(st.nextToken())); skill.setName(st.nextToken()); skill.setLevel(Integer.parseInt(st.nextToken())); - String opType = st.nextToken(); + final String opType = st.nextToken(); if (opType.equalsIgnoreCase("once")) { skill.setOperateType(Skill.OP_ONCE); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTreeTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTreeTable.java index 13a39a3ff2..2ed38f5faa 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTreeTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SkillTreeTable.java @@ -175,11 +175,11 @@ public class SkillTreeTable String line = null; try { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(skillData))); - List list = new ArrayList<>(); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(skillData))); + final List list = new ArrayList<>(); if (parentClassId != -1) { - List parentList = _skillTrees.get(parentClassId); + final List parentList = _skillTrees.get(parentClassId); list.addAll(parentList); } while ((line = lnr.readLine()) != null) @@ -188,7 +188,7 @@ public class SkillTreeTable { continue; } - SkillLearn skill = parseList(line); + final SkillLearn skill = parseList(line); list.add(skill); } _skillTrees.put(classId, list); @@ -207,8 +207,8 @@ public class SkillTreeTable private SkillLearn parseList(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - SkillLearn skill = new SkillLearn(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final SkillLearn skill = new SkillLearn(); skill.setId(Integer.parseInt(st.nextToken())); skill.setName(st.nextToken()); skill.setLevel(Integer.parseInt(st.nextToken())); @@ -219,8 +219,8 @@ public class SkillTreeTable public Collection getAvailableSkills(PlayerInstance cha) { - List result = new ArrayList<>(); - List skills = _skillTrees.get(cha.getClassId()); + final List result = new ArrayList<>(); + final List skills = _skillTrees.get(cha.getClassId()); if (skills == null) { _log.warning("Skilltree for class " + cha.getClassId() + " is not defined !"); @@ -228,10 +228,10 @@ public class SkillTreeTable } // TODO: Remove toArray. - Skill[] oldSkills = cha.getAllSkills().toArray(new Skill[cha.getAllSkills().size()]); + final Skill[] oldSkills = cha.getAllSkills().toArray(new Skill[cha.getAllSkills().size()]); for (int i = 0; i < skills.size(); ++i) { - SkillLearn temp = skills.get(i); + final SkillLearn temp = skills.get(i); if (temp.getMinLevel() > cha.getLevel()) { continue; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SpawnTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SpawnTable.java index 32a655e53c..49a452ea38 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SpawnTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/SpawnTable.java @@ -50,8 +50,8 @@ public class SpawnTable { try { - File spawnDataFile = new File("data/spawnlist.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(spawnDataFile))); + final File spawnDataFile = new File("data/spawnlist.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(spawnDataFile))); String line = null; while ((line = lnr.readLine()) != null) { @@ -61,7 +61,7 @@ public class SpawnTable { continue; } - Spawn spawn = parseList(line); + final Spawn spawn = parseList(line); _spawntable.put(spawn.getId(), spawn); if (spawn.getId() <= _highestId) { @@ -89,18 +89,18 @@ public class SpawnTable private Spawn parseList(String line) throws SecurityException, ClassNotFoundException { - StringTokenizer st = new StringTokenizer(line, ";"); - int spawnId = Integer.parseInt(st.nextToken()); - String location = st.nextToken(); - int count = Integer.parseInt(st.nextToken()); - int npcId = Integer.parseInt(st.nextToken()); - Npc template1 = NpcTable.getInstance().getTemplate(npcId); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int spawnId = Integer.parseInt(st.nextToken()); + final String location = st.nextToken(); + final int count = Integer.parseInt(st.nextToken()); + final int npcId = Integer.parseInt(st.nextToken()); + final Npc template1 = NpcTable.getInstance().getTemplate(npcId); if (template1 == null) { _log.warning("Monster data for id:" + npcId + " missing in npc.csv"); return null; } - Spawn spawnDat = new Spawn(template1); + final Spawn spawnDat = new Spawn(template1); spawnDat.setId(spawnId); spawnDat.setLocation(location); // ? spawnDat.setAmount(count); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TeleportLocationTable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TeleportLocationTable.java index 33cfa03610..68d371cebd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TeleportLocationTable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TeleportLocationTable.java @@ -47,10 +47,10 @@ public class TeleportLocationTable { try { - File teleData = new File("data/teleport.csv"); + final File teleData = new File("data/teleport.csv"); if (teleData.isFile() && teleData.exists()) { - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(teleData))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(teleData))); String line = null; while ((line = lnr.readLine()) != null) { @@ -58,8 +58,8 @@ public class TeleportLocationTable { continue; } - StringTokenizer st = new StringTokenizer(line, ";"); - TeleportLocation teleport = new TeleportLocation(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final TeleportLocation teleport = new TeleportLocation(); teleport.setTeleId(Integer.parseInt(st.nextToken())); teleport.setLocX(Integer.parseInt(st.nextToken())); teleport.setLocY(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TradeController.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TradeController.java index c2390d80e7..1a29a3516d 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TradeController.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/data/TradeController.java @@ -50,8 +50,8 @@ public class TradeController String line = null; try { - File buylistData = new File("data/buylists.csv"); - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(buylistData))); + final File buylistData = new File("data/buylists.csv"); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(buylistData))); while ((line = lnr.readLine()) != null) { if (line.trim().isEmpty() || line.startsWith("#")) @@ -75,14 +75,14 @@ public class TradeController private void parseList(String line) { - StringTokenizer st = new StringTokenizer(line, ";"); - int listId = Integer.parseInt(st.nextToken()); - TradeList buy1 = new TradeList(listId); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int listId = Integer.parseInt(st.nextToken()); + final TradeList buy1 = new TradeList(listId); while (st.hasMoreTokens()) { - int itemId = Integer.parseInt(st.nextToken()); - int price = Integer.parseInt(st.nextToken()); - ItemInstance item = ItemTable.getInstance().createDummyItem(itemId); + final int itemId = Integer.parseInt(st.nextToken()); + final int price = Integer.parseInt(st.nextToken()); + final ItemInstance item = ItemTable.getInstance().createDummyItem(itemId); item.setPrice(price); buy1.addItem(item); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/ItemHandler.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/ItemHandler.java index 78022da2e8..7009435a36 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/ItemHandler.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/ItemHandler.java @@ -40,7 +40,7 @@ public class ItemHandler public void registerItemHandler(IItemHandler handler) { - int[] ids = handler.getItemIds(); + final int[] ids = handler.getItemIds(); for (int id : ids) { _datatable.put(id, handler); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/SkillHandler.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/SkillHandler.java index 96a326fd77..b28da25f88 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/SkillHandler.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/SkillHandler.java @@ -40,7 +40,7 @@ public class SkillHandler public void registerSkillHandler(ISkillHandler handler) { - int[] ids = handler.getSkillIds(); + final int[] ids = handler.getSkillIds(); for (int id : ids) { _datatable.put(id, handler); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/PetSummon.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/PetSummon.java index 85cc48389c..dfc969f758 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/PetSummon.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/PetSummon.java @@ -77,8 +77,8 @@ public class PetSummon implements IItemHandler return 0; } } - Npc petTemplate = NpcTable.getInstance().getTemplate(npcId); - PetInstance newpet = new PetInstance(petTemplate); + final Npc petTemplate = NpcTable.getInstance().getTemplate(npcId); + final PetInstance newpet = new PetInstance(petTemplate); newpet.setTitle(activeChar.getName()); newpet.setControlItemId(item.getObjectId()); newpet.setObjectId(IdFactory.getInstance().getNextId()); @@ -102,10 +102,10 @@ public class PetSummon implements IItemHandler newpet.setRunning(true); World.getInstance().storeObject(newpet); World.getInstance().addVisibleObject(newpet); - MagicSkillUser msk = new MagicSkillUser(activeChar, 2046, 1, 1000, 600000); + final MagicSkillUser msk = new MagicSkillUser(activeChar, 2046, 1, 1000, 600000); activeChar.sendPacket(msk); - PetInfo ownerni = new PetInfo(newpet); - NpcInfo ni = new NpcInfo(newpet); + final PetInfo ownerni = new PetInfo(newpet); + final NpcInfo ni = new NpcInfo(newpet); activeChar.broadcastPacket(ni); activeChar.sendPacket(ownerni); activeChar.sendPacket(new PetItemList(newpet)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/Potions.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/Potions.java index 38de8ee06e..90a217953e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/Potions.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/Potions.java @@ -43,13 +43,13 @@ public class Potions implements IItemHandler @Override public int useItem(PlayerInstance activeChar, ItemInstance item) { - Potion Potion = new Potion(); - int itemId = item.getItemId(); + final Potion Potion = new Potion(); + final int itemId = item.getItemId(); if ((itemId == 65) || (itemId == 725) || (itemId == 727) || (itemId == 1060) || (itemId == 1061) || (itemId == 1539) || (itemId == 1540) || (itemId == 1073)) { - WorldObject OldTarget = activeChar.getTarget(); + final WorldObject OldTarget = activeChar.getTarget(); activeChar.setTarget(activeChar); - MagicSkillUser MSU = new MagicSkillUser(activeChar, 2038, 1, 0, 0); + final MagicSkillUser MSU = new MagicSkillUser(activeChar, 2038, 1, 0, 0); activeChar.sendPacket(MSU); activeChar.broadcastPacket(MSU); activeChar.setTarget(OldTarget); @@ -57,9 +57,9 @@ public class Potions implements IItemHandler } else if ((itemId == 726) || (itemId == 728)) { - WorldObject OldTarget = activeChar.getTarget(); + final WorldObject OldTarget = activeChar.getTarget(); activeChar.setTarget(activeChar); - MagicSkillUser MSU = new MagicSkillUser(activeChar, 2038, 1, 0, 0); + final MagicSkillUser MSU = new MagicSkillUser(activeChar, 2038, 1, 0, 0); activeChar.sendPacket(MSU); activeChar.broadcastPacket(MSU); activeChar.setTarget(OldTarget); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/ScrollOfEscape.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/ScrollOfEscape.java index 9d79980eb4..85269ddb62 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/ScrollOfEscape.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/ScrollOfEscape.java @@ -40,13 +40,13 @@ public class ScrollOfEscape implements IItemHandler @Override public int useItem(PlayerInstance activeChar, ItemInstance item) { - int[] townCords = MapRegionTable.getInstance().getClosestTownCords(activeChar); + final int[] townCords = MapRegionTable.getInstance().getClosestTownCords(activeChar); activeChar.setTarget(activeChar); - Skill skill = SkillTable.getInstance().getInfo(1050, 1); - MagicSkillUser msk = new MagicSkillUser(activeChar, 1050, 1, 20000, 0); + final Skill skill = SkillTable.getInstance().getInfo(1050, 1); + final MagicSkillUser msk = new MagicSkillUser(activeChar, 1050, 1, 20000, 0); activeChar.sendPacket(msk); activeChar.broadcastPacket(msk); - SetupGauge sg = new SetupGauge(0, skill.getSkillTime()); + final SetupGauge sg = new SetupGauge(0, skill.getSkillTime()); activeChar.sendPacket(sg); if (skill.getSkillTime() > 200) { @@ -59,14 +59,14 @@ public class ScrollOfEscape implements IItemHandler // empty catch block } } - StopMove sm = new StopMove(activeChar); + final StopMove sm = new StopMove(activeChar); activeChar.sendPacket(sm); activeChar.broadcastPacket(sm); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); activeChar.sendPacket(af); World.getInstance().removeVisibleObject(activeChar); activeChar.removeAllKnownObjects(); - TeleportToLocation teleport = new TeleportToLocation(activeChar, townCords[0], townCords[1], townCords[2]); + final TeleportToLocation teleport = new TeleportToLocation(activeChar, townCords[0], townCords[1], townCords[2]); activeChar.sendPacket(teleport); activeChar.broadcastPacket(teleport); activeChar.setX(townCords[0]); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/SoulShots.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/SoulShots.java index d6a8f65db8..e64ef18e7e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/SoulShots.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/itemhandlers/SoulShots.java @@ -44,16 +44,16 @@ public class SoulShots implements IItemHandler { return 0; } - int SoulshotId = item.getItemId(); - Weapon weapon = activeChar.getActiveWeapon(); + final int SoulshotId = item.getItemId(); + final Weapon weapon = activeChar.getActiveWeapon(); if (weapon == null) { activeChar.sendPacket(new SystemMessage(SystemMessage.CANNOT_USE_SOULSHOTS)); return 0; } - int grade = weapon.getCrystalType(); - int soulShotConsumption = weapon.getSoulShotCount(); - int count = item.getCount(); + final int grade = weapon.getCrystalType(); + final int soulShotConsumption = weapon.getSoulShotCount(); + final int count = item.getCount(); if (soulShotConsumption == 0) { activeChar.sendPacket(new SystemMessage(SystemMessage.CANNOT_USE_SOULSHOTS)); @@ -71,9 +71,9 @@ public class SoulShots implements IItemHandler } activeChar.setActiveSoulshotGrade(grade); activeChar.sendPacket(new SystemMessage(SystemMessage.ENABLED_SOULSHOT)); - WorldObject OldTarget = activeChar.getTarget(); + final WorldObject OldTarget = activeChar.getTarget(); activeChar.setTarget(activeChar); - MagicSkillUser MSU = new MagicSkillUser(activeChar, 2039, 1, 0, 0); + final MagicSkillUser MSU = new MagicSkillUser(activeChar, 2039, 1, 0, 0); activeChar.sendPacket(MSU); activeChar.broadcastPacket(MSU); activeChar.setTarget(OldTarget); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/DamageSkill.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/DamageSkill.java index 66c9355c8c..07c4fac5ca 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/DamageSkill.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/DamageSkill.java @@ -55,14 +55,14 @@ public class DamageSkill implements ISkillHandler if (target instanceof Creature) { - Creature creature = (Creature) target; + final Creature creature = (Creature) target; int mdef = creature.getMagicalDefense(); if (mdef == 0) { mdef = 350; } - int dmg = (int) ((91 * skill.getPower() * Math.sqrt(activeChar.getMagicalAttack())) / mdef); - SystemMessage sm = new SystemMessage(SystemMessage.YOU_DID_S1_DMG); + final int dmg = (int) ((91 * skill.getPower() * Math.sqrt(activeChar.getMagicalAttack())) / mdef); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_DID_S1_DMG); sm.addNumber(dmg); activeChar.sendPacket(sm); if (creature.getCurrentHp() > creature.getMaxHp()) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/HealSkill.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/HealSkill.java index 59c46f77e2..efdbc06f62 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/HealSkill.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/handler/skillhandlers/HealSkill.java @@ -56,7 +56,7 @@ public class HealSkill implements ISkillHandler if (skill.getTargetType() == Skill.TARGET_PET) { - PetInstance pet = activeChar.getPet(); + final PetInstance pet = activeChar.getPet(); double hp = pet.getCurrentHp(); pet.setCurrentHp(hp += skill.getPower()); } @@ -66,7 +66,7 @@ public class HealSkill implements ISkillHandler { double hp = player.getCurrentHp(); player.setCurrentHp(hp += skill.getPower()); - StatusUpdate su = new StatusUpdate(player.getObjectId()); + final StatusUpdate su = new StatusUpdate(player.getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, (int) hp); player.sendPacket(su); player.sendPacket(new SystemMessage(SystemMessage.REJUVENATING_HP)); @@ -76,7 +76,7 @@ public class HealSkill implements ISkillHandler { double hp = activeChar.getCurrentHp(); activeChar.setCurrentHp(hp += skill.getPower()); - StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); + final StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, (int) hp); activeChar.sendPacket(su); activeChar.sendPacket(new SystemMessage(SystemMessage.REJUVENATING_HP)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/managers/CommunityBoardManager.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/managers/CommunityBoardManager.java index a8aaf87378..ff09519c82 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/managers/CommunityBoardManager.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/managers/CommunityBoardManager.java @@ -49,19 +49,19 @@ public class CommunityBoardManager public void handleCommands(ClientThread client, String command) { - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (command.startsWith("bbs_")) { - StringBuffer htmlCode = new StringBuffer("

L2J Community Board
"); + final StringBuffer htmlCode = new StringBuffer("
L2J Community Board
"); if (command.equals("bbs_default")) { - Collection players = World.getInstance().getAllPlayers(); + final Collection players = World.getInstance().getAllPlayers(); htmlCode.append(""); - int t = GameTimeController.getInstance().getGameTime(); - int h = t / 60; - int m = t % 60; - SimpleDateFormat format = new SimpleDateFormat("h:mm a"); - Calendar cal = Calendar.getInstance(); + final int t = GameTimeController.getInstance().getGameTime(); + final int h = t / 60; + final int m = t % 60; + final SimpleDateFormat format = new SimpleDateFormat("h:mm a"); + final Calendar cal = Calendar.getInstance(); cal.set(11, h); cal.set(12, m); htmlCode.append(""); @@ -106,7 +106,7 @@ public class CommunityBoardManager } else if (command.equals("bbs_clan")) { - Clan clan = activeChar.getClan(); + final Clan clan = activeChar.getClan(); htmlCode.append("
Game Time: " + format.format(cal.getTime()) + "
" + clan.getName() + " (Level " + clan.getLevel() + "):
"); String title = ""; if (!clan.getClanMember(clan.getLeaderName()).getTitle().equals("")) @@ -142,8 +142,8 @@ public class CommunityBoardManager } else if (command.startsWith("bbs_player_info")) { - String name = command.substring(16); - PlayerInstance player = World.getInstance().getPlayer(name); + final String name = command.substring(16); + final PlayerInstance player = World.getInstance().getPlayer(name); String sex = "Male"; if (player.getSex() == 1) { @@ -162,10 +162,10 @@ public class CommunityBoardManager htmlCode.append(""); htmlCode.append(""); htmlCode.append(""); - int uptime = (int) player.getUptime() / 1000; - int h = uptime / 3600; - int m = (uptime - (h * 3600)) / 60; - int s = uptime - (h * 3600) - (m * 60); + final int uptime = (int) player.getUptime() / 1000; + final int h = uptime / 3600; + final int m = (uptime - (h * 3600)) / 60; + final int s = uptime - (h * 3600) - (m * 60); htmlCode.append(""); htmlCode.append(""); if (player.getClan() != null) @@ -179,12 +179,12 @@ public class CommunityBoardManager { try { - String val = command.substring(14); - StringTokenizer st = new StringTokenizer(val); - String name = st.nextToken(); - String message = val.substring(name.length() + 1); - PlayerInstance reciever = World.getInstance().getPlayer(name); - CreatureSay cs = new CreatureSay(activeChar.getObjectId(), 2, activeChar.getName(), message); + final String val = command.substring(14); + final StringTokenizer st = new StringTokenizer(val); + final String name = st.nextToken(); + final String message = val.substring(name.length() + 1); + final PlayerInstance reciever = World.getInstance().getPlayer(name); + final CreatureSay cs = new CreatureSay(activeChar.getObjectId(), 2, activeChar.getName(), message); reciever.sendPacket(cs); activeChar.sendPacket(cs); htmlCode.append("Message Sent
Experience: " + player.getExp() + "/" + nextLevelExp + "
Experience needed for level up: " + nextLevelExpNeeded + "

Uptime: " + h + "h " + m + "m " + s + "s

"); - ShowBoard sb = new ShowBoard(activeChar, htmlCode.toString()); + final ShowBoard sb = new ShowBoard(activeChar, htmlCode.toString()); activeChar.sendPacket(sb); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Clan.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Clan.java index eed5f3d67c..dc45fa1001 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Clan.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Clan.java @@ -85,7 +85,7 @@ public class Clan public void addClanMember(PlayerInstance player) { - ClanMember member = new ClanMember(player); + final ClanMember member = new ClanMember(player); this.addClanMember(member); } @@ -106,7 +106,7 @@ public class Clan public Collection getOnlineMembers(String exclude) { - List result = new ArrayList<>(); + final List result = new ArrayList<>(); for (ClanMember member : _members.values()) { if (!member.isOnline() || member.getName().equals(exclude)) @@ -185,7 +185,7 @@ public class Clan public void store() { - File clanFile = new File("data/clans/" + getName() + ".csv"); + final File clanFile = new File("data/clans/" + getName() + ".csv"); FileWriter out = null; try { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Inventory.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Inventory.java index 1ed68e0cf4..98b78df8cd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Inventory.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Inventory.java @@ -91,7 +91,7 @@ public class Inventory { for (int i = 0; i < _items.size(); ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); if (temp.getItemId() != itemId) { continue; @@ -133,7 +133,7 @@ public class Inventory public Collection unEquipItemInBodySlot(int slot) { - List unequipedItems = new ArrayList<>(); + final List unequipedItems = new ArrayList<>(); int pdollSlot = -1; switch (slot) { @@ -221,7 +221,7 @@ public class Inventory public Collection unEquipItemOnPaperdoll(int pdollSlot) { - List unequipedItems = new ArrayList<>(); + final List unequipedItems = new ArrayList<>(); if (pdollSlot == 14) { unEquipSlot(unequipedItems, 8); @@ -233,15 +233,15 @@ public class Inventory public List equipItem(ItemInstance item) { - ArrayList changedItems = new ArrayList<>(); - int targetSlot = item.getItem().getBodyPart(); + final ArrayList changedItems = new ArrayList<>(); + final int targetSlot = item.getItem().getBodyPart(); switch (targetSlot) { case 16384: { ItemInstance arrow; unEquipSlot(changedItems, 8); - ItemInstance old1 = unEquipSlot(14); + final ItemInstance old1 = unEquipSlot(14); if (old1 != null) { changedItems.add(old1); @@ -265,7 +265,7 @@ public class Inventory } case 256: { - ItemInstance old1 = unEquipSlot(14); + final ItemInstance old1 = unEquipSlot(14); if (old1 != null) { unEquipSlot(changedItems, 7); @@ -341,7 +341,7 @@ public class Inventory } case 2048: { - ItemInstance chest = getPaperdollItem(10); + final ItemInstance chest = getPaperdollItem(10); if ((chest != null) && (chest.getItem().getBodyPart() == 32768)) { unEquipSlot(changedItems, 10); @@ -392,7 +392,7 @@ public class Inventory private ItemInstance unEquipSlot(int slot) { - ItemInstance item = _paperdoll[slot]; + final ItemInstance item = _paperdoll[slot]; if (item != null) { item.setEquipSlot(-1); @@ -408,7 +408,7 @@ public class Inventory { return false; } - ItemInstance item = _paperdoll[slot]; + final ItemInstance item = _paperdoll[slot]; if (item != null) { item.setEquipSlot(-1); @@ -423,7 +423,7 @@ public class Inventory { for (int i = 0; i < _items.size(); ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); if (temp.getObjectId() != objectId) { continue; @@ -483,7 +483,7 @@ public class Inventory public ItemInstance destroyItem(int objectId, int count) { - ItemInstance item = getItem(objectId); + final ItemInstance item = getItem(objectId); if (item.getCount() == count) { _items.remove(item); @@ -501,7 +501,7 @@ public class Inventory public ItemInstance destroyItemByItemId(int itemId, int count) { - ItemInstance item = findItemByItemId(itemId); + final ItemInstance item = findItemByItemId(itemId); if (item.getCount() == count) { _items.remove(item); @@ -519,7 +519,7 @@ public class Inventory public ItemInstance dropItem(int objectId, int count) { - ItemInstance oldItem = getItem(objectId); + final ItemInstance oldItem = getItem(objectId); return this.dropItem(oldItem, count); } @@ -537,7 +537,7 @@ public class Inventory if (oldItem.getItemId() == 57) { reduceAdena(count); - ItemInstance adena = ItemTable.getInstance().createItem(oldItem.getItemId()); + final ItemInstance adena = ItemTable.getInstance().createItem(oldItem.getItemId()); adena.setCount(count); return adena; } @@ -550,7 +550,7 @@ public class Inventory } oldItem.setCount(oldItem.getCount() - count); oldItem.setLastChange(2); - ItemInstance newItem = ItemTable.getInstance().createItem(oldItem.getItemId()); + final ItemInstance newItem = ItemTable.getInstance().createItem(oldItem.getItemId()); newItem.setCount(count); refreshWeight(); return newItem; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Party.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Party.java index 181c1326f8..39c7ee517f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Party.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Party.java @@ -87,7 +87,7 @@ public class Party public void addPartyMember(PlayerInstance player) { - PartySmallWindowAll window = new PartySmallWindowAll(); + final PartySmallWindowAll window = new PartySmallWindowAll(); window.setPartyList(_members); player.sendPacket(window); SystemMessage msg = new SystemMessage(SystemMessage.YOU_JOINED_S1_PARTY); @@ -126,7 +126,7 @@ public class Party { for (int i = 0; i < _members.size(); ++i) { - PlayerInstance temp = _members.get(i); + final PlayerInstance temp = _members.get(i); if (!temp.getName().equals(name)) { continue; @@ -153,7 +153,7 @@ public class Party public void oustPartyMember(String name) { - PlayerInstance player = getPlayerByName(name); + final PlayerInstance player = getPlayerByName(name); if (player != null) { if (isLeader(player)) @@ -169,10 +169,10 @@ public class Party private void dissolveParty() { - SystemMessage msg = new SystemMessage(SystemMessage.PARTY_DISPERSED); + final SystemMessage msg = new SystemMessage(SystemMessage.PARTY_DISPERSED); for (int i = 0; i < _members.size(); ++i) { - PlayerInstance temp = _members.get(i); + final PlayerInstance temp = _members.get(i); temp.sendPacket(msg); temp.sendPacket(new PartySmallWindowDeleteAll()); temp.setParty(null); @@ -206,8 +206,8 @@ public class Party smsg.addItemName(item.getItemId()); this.broadcastToPartyMembers(target, smsg); } - ItemInstance item2 = target.getInventory().addItem(item); - InventoryUpdate iu = new InventoryUpdate(); + final ItemInstance item2 = target.getInventory().addItem(item); + final InventoryUpdate iu = new InventoryUpdate(); if (item2.getLastChange() == 1) { iu.addNewItem(item); @@ -217,20 +217,20 @@ public class Party iu.addModifiedItem(item2); } target.sendPacket(iu); - UserInfo ci = new UserInfo(target); + final UserInfo ci = new UserInfo(target); target.sendPacket(ci); } public void distributeAdena(ItemInstance adena) { adena.setCount(adena.getCount() / _members.size()); - SystemMessage smsg = new SystemMessage(SystemMessage.YOU_PICKED_UP_S1_ADENA); + final SystemMessage smsg = new SystemMessage(SystemMessage.YOU_PICKED_UP_S1_ADENA); smsg.addNumber(adena.getCount()); for (int i = 0; i < _members.size(); ++i) { - PlayerInstance member = _members.get(i); - ItemInstance item2 = member.getInventory().addItem(adena); - InventoryUpdate iu = new InventoryUpdate(); + final PlayerInstance member = _members.get(i); + final ItemInstance item2 = member.getInventory().addItem(adena); + final InventoryUpdate iu = new InventoryUpdate(); if (item2.getLastChange() == 1) { iu.addNewItem(adena); @@ -247,14 +247,14 @@ public class Party public void distributeXpAndSp(int partyDmg, int maxHp, int xpReward, int spReward) { double mul = (Math.pow(1.07, _members.size() - 1) * partyDmg) / maxHp; - double xpTotal = mul * xpReward; - double spTotal = mul * spReward; + final double xpTotal = mul * xpReward; + final double spTotal = mul * spReward; for (int i = 0; i < _members.size(); ++i) { - PlayerInstance player = _members.get(i); + final PlayerInstance player = _members.get(i); mul = ((double) player.getLevel() * (double) player.getLevel()) / _partyLvl; - int xp = (int) (mul * xpTotal); - int sp = (int) (mul * spTotal); + final int xp = (int) (mul * xpTotal); + final int sp = (int) (mul * spTotal); player.addExpAndSp(xp, sp); } } @@ -264,7 +264,7 @@ public class Party int newlevel = 0; for (int i = 0; i < _members.size(); ++i) { - int plLevel = _members.get(i).getLevel(); + final int plLevel = _members.get(i).getLevel(); newlevel += plLevel * plLevel; } _partyLvl = newlevel; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Potion.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Potion.java index dcd90a46ba..0b8d32a79f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Potion.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Potion.java @@ -213,7 +213,7 @@ public class Potion extends WorldObject { try { - Object object = _mpLock; + final Object object = _mpLock; synchronized (object) { double nowMp = _instance.getCurrentMp(); @@ -250,7 +250,7 @@ public class Potion extends WorldObject { try { - Object object = _hpLock; + final Object object = _hpLock; synchronized (object) { double nowHp = _instance.getCurrentHp(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Spawn.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Spawn.java index 3ce7ab8bfa..78a2da3959 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Spawn.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Spawn.java @@ -51,7 +51,7 @@ public class Spawn public Spawn(Npc mobTemplate) throws SecurityException, ClassNotFoundException { _template = mobTemplate; - String implementationName = _template.getType(); + final String implementationName = _template.getType(); _constructor = Class.forName("org.l2jmobius.gameserver.model.actor.instance." + implementationName + "Instance").getConstructors()[0]; } @@ -161,7 +161,7 @@ public class Spawn if ((_scheduledCount + _currentCount) < _maximumCount) { ++_scheduledCount; - SpawnTask task = new SpawnTask(npcId); + final SpawnTask task = new SpawnTask(npcId); _spawnTimer.schedule(task, _respawnDelay); } } @@ -179,7 +179,7 @@ public class Spawn NpcInstance mob = null; try { - Object[] parameters = new Object[] + final Object[] parameters = new Object[] { _template }; @@ -195,8 +195,8 @@ public class Spawn } if (getRandomx() > 0) { - int random1 = Rnd.get(getRandomx()); - int newlocx = (getLocx() + Rnd.get(getRandomx())) - random1; + final int random1 = Rnd.get(getRandomx()); + final int newlocx = (getLocx() + Rnd.get(getRandomx())) - random1; mob.setX(newlocx); } else @@ -205,8 +205,8 @@ public class Spawn } if (getRandomy() > 0) { - int random2 = Rnd.get(getRandomy()); - int newlocy = (getLocy() + Rnd.get(getRandomy())) - random2; + final int random2 = Rnd.get(getRandomy()); + final int newlocy = (getLocy() + Rnd.get(getRandomy())) - random2; mob.setY(newlocy); } else diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/TradeList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/TradeList.java index 8bc2d8d41f..157ad4fed0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/TradeList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/TradeList.java @@ -79,7 +79,7 @@ public class TradeList { for (int i = 0; i < _items.size(); ++i) { - ItemInstance item = _items.get(i); + final ItemInstance item = _items.get(i); if (item.getItemId() != itemId) { continue; @@ -93,7 +93,7 @@ public class TradeList { for (int i = 0; i < _items.size(); ++i) { - ItemInstance item = _items.get(i); + final ItemInstance item = _items.get(i); if (item.getObjectId() != ObjectId) { continue; @@ -117,7 +117,7 @@ public class TradeList { for (int y = 0; y < _items.size(); ++y) { - ItemInstance temp = _items.get(y); + final ItemInstance temp = _items.get(y); if (temp.getObjectId() != objId) { continue; @@ -136,7 +136,7 @@ public class TradeList boolean bool = false; for (int y = 0; y < _items.size(); ++y) { - ItemInstance temp = _items.get(y); + final ItemInstance temp = _items.get(y); if (temp.getObjectId() != objId) { continue; @@ -149,25 +149,25 @@ public class TradeList public void tradeItems(PlayerInstance player, PlayerInstance reciever) { - Inventory playersInv = player.getInventory(); - Inventory recieverInv = reciever.getInventory(); + final Inventory playersInv = player.getInventory(); + final Inventory recieverInv = reciever.getInventory(); InventoryUpdate update = new InventoryUpdate(); - ItemTable itemTable = ItemTable.getInstance(); + final ItemTable itemTable = ItemTable.getInstance(); for (int y = 0; y < _items.size(); ++y) { - ItemInstance temp = _items.get(y); + final ItemInstance temp = _items.get(y); ItemInstance playerItem = playersInv.getItem(temp.getObjectId()); - ItemInstance newitem = itemTable.createItem(playerItem.getItemId()); + final ItemInstance newitem = itemTable.createItem(playerItem.getItemId()); newitem.setCount(temp.getCount()); playerItem = playersInv.destroyItem(playerItem.getObjectId(), temp.getCount()); - ItemInstance recieverItem = recieverInv.addItem(newitem); + final ItemInstance recieverItem = recieverInv.addItem(newitem); if (playerItem.getLastChange() == 2) { update.addModifiedItem(playerItem); } else { - World world = World.getInstance(); + final World world = World.getInstance(); world.removeObject(playerItem); update.addRemovedItem(playerItem); } @@ -187,11 +187,11 @@ public class TradeList public void updateBuyList(PlayerInstance player, List list) { - Inventory playersInv = player.getInventory(); + final Inventory playersInv = player.getInventory(); for (int count = 0; count != list.size(); ++count) { - TradeItem temp = list.get(count); - ItemInstance temp2 = playersInv.findItemByItemId(temp.getItemId()); + final TradeItem temp = list.get(count); + final ItemInstance temp2 = playersInv.findItemByItemId(temp.getItemId()); if (temp2 == null) { list.remove(count); @@ -209,11 +209,11 @@ public class TradeList public void updateSellList(PlayerInstance player, List list) { - Inventory playersInv = player.getInventory(); + final Inventory playersInv = player.getInventory(); for (int count = 0; count != list.size(); ++count) { - TradeItem temp = list.get(count); - ItemInstance temp2 = playersInv.getItem(temp.getObjectId()); + final TradeItem temp = list.get(count); + final ItemInstance temp2 = playersInv.getItem(temp.getObjectId()); if (temp2 == null) { list.remove(count); @@ -232,20 +232,20 @@ public class TradeList { int x; int y; - Inventory sellerInv = seller.getInventory(); - Inventory buyerInv = buyer.getInventory(); + final Inventory sellerInv = seller.getInventory(); + final Inventory buyerInv = buyer.getInventory(); TradeItem temp2 = null; WorldObject sellerItem = null; ItemInstance newitem = null; - InventoryUpdate buyerupdate = new InventoryUpdate(); - InventoryUpdate sellerupdate = new InventoryUpdate(); - ItemTable itemTable = ItemTable.getInstance(); + final InventoryUpdate buyerupdate = new InventoryUpdate(); + final InventoryUpdate sellerupdate = new InventoryUpdate(); + final ItemTable itemTable = ItemTable.getInstance(); int cost = 0; - List sysmsgs = new ArrayList<>(); + final List sysmsgs = new ArrayList<>(); for (y = 0; y < buyerlist.size(); ++y) { SystemMessage msg; - TradeItem buyerItem = buyerlist.get(y); + final TradeItem buyerItem = buyerlist.get(y); for (x = 0; x < sellerlist.size(); ++x) { temp2 = sellerlist.get(x); @@ -260,13 +260,13 @@ public class TradeList { continue; } - int amount = buyerItem.getCount() > temp2.getCount() ? temp2.getCount() : buyerItem.getCount(); + final int amount = buyerItem.getCount() > temp2.getCount() ? temp2.getCount() : buyerItem.getCount(); sellerItem = sellerInv.destroyItem(sellerItem.getObjectId(), amount); cost = buyerItem.getCount() * buyerItem.getOwnersPrice(); seller.addAdena(cost); newitem = itemTable.createItem(((ItemInstance) sellerItem).getItemId()); newitem.setCount(amount); - ItemInstance temp = buyerInv.addItem(newitem); + final ItemInstance temp = buyerInv.addItem(newitem); if (amount == 1) { msg = new SystemMessage(SystemMessage.S1_PURCHASED_S2); @@ -311,7 +311,7 @@ public class TradeList } else { - World world = World.getInstance(); + final World world = World.getInstance(); world.removeObject(sellerItem); sellerupdate.addRemovedItem((ItemInstance) sellerItem); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Warehouse.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Warehouse.java index 1505f086b8..dd63788a7b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Warehouse.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/Warehouse.java @@ -60,7 +60,7 @@ public class Warehouse { for (int i = 0; i < _items.size(); ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); if (temp.getItemId() != itemId) { continue; @@ -74,7 +74,7 @@ public class Warehouse { for (int i = 0; i < _items.size(); ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); if (temp.getObjectId() != objectId) { continue; @@ -86,7 +86,7 @@ public class Warehouse public ItemInstance destroyItem(int itemId, int count) { - ItemInstance item = findItemId(itemId); + final ItemInstance item = findItemId(itemId); if (item != null) { if (item.getCount() == count) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/World.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/World.java index 6af1cbe634..8a1e71fcf0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/World.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/World.java @@ -82,15 +82,15 @@ public class World } else if ((_allPlayers.size() != 0) && !(object instanceof PetInstance) && !(object instanceof ItemInstance)) { - int x = object.getX(); - int y = object.getY(); - int sqRadius = 4000000; + final int x = object.getX(); + final int y = object.getY(); + final int sqRadius = 4000000; for (PlayerInstance player : _allPlayers.values()) { long dy; - int x1 = player.getX(); - long dx = x1 - x; - long sqDist = (dx * dx) + ((dy = player.getY() - y) * dy); + final int x1 = player.getX(); + final long dx = x1 - x; + final long sqDist = (dx * dx) + ((dy = player.getY() - y) * dy); if (sqDist >= sqRadius) { continue; @@ -107,7 +107,7 @@ public class World _visibleObjects.remove(object.getObjectId()); for (Object element : object.getKnownObjects()) { - WorldObject temp1 = (WorldObject) element; + final WorldObject temp1 = (WorldObject) element; temp1.removeKnownObject(object); object.removeKnownObject(temp1); } @@ -123,9 +123,9 @@ public class World public Collection getVisibleObjects(WorldObject object, int radius) { - int x = object.getX(); - int y = object.getY(); - List result = new ArrayList<>(); + final int x = object.getX(); + final int y = object.getY(); + final List result = new ArrayList<>(); for (WorldObject worldObject : _visibleObjects.values()) { if ((worldObject == null) || worldObject.equals(object) || (Math.sqrt(Math.pow(x - worldObject.getX(), 2) + Math.pow(y - worldObject.getY(), 2)) > radius)) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Attackable.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Attackable.java index 1c3a580280..0c8fadb7a5 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Attackable.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Attackable.java @@ -88,7 +88,7 @@ public class Attackable extends NpcInstance { if (_active) { - int wait = (10 + Rnd.get(120)) * 1000; + final int wait = (10 + Rnd.get(120)) * 1000; _currentAiTask = new AITask(this); _aiTimer.schedule(_currentAiTask, wait); } @@ -97,7 +97,7 @@ public class Attackable extends NpcInstance protected void startRandomWalking() { _currentAiTask = new AITask(this); - int wait = (10 + Rnd.get(120)) * 1000; + final int wait = (10 + Rnd.get(120)) * 1000; _aiTimer.schedule(_currentAiTask, wait); setCurrentState(CreatureState.RANDOM_WALK); } @@ -161,7 +161,7 @@ public class Attackable extends NpcInstance } else if (isDead()) { - Attackable Attackable = this; + final Attackable Attackable = this; synchronized (Attackable) { if (!_killedAlready) @@ -185,12 +185,12 @@ public class Attackable extends NpcInstance { // TODO: Figure iterator logic and replace with for, if possible. Iterator it = _aggroList.keySet().iterator(); - int npcID = getNpcTemplate().getNpcId(); + final int npcID = getNpcTemplate().getNpcId(); while (it.hasNext()) { PlayerInstance temp; - Creature attacker = (Creature) it.next(); - Integer value = _aggroList.get(attacker); + final Creature attacker = (Creature) it.next(); + final Integer value = _aggroList.get(attacker); Party attackerParty = null; if ((attacker instanceof PlayerInstance) && (temp = (PlayerInstance) attacker).isInParty()) { @@ -240,10 +240,10 @@ public class Attackable extends NpcInstance int partyDmg = 0; if (attackerParty != null) { - List members = attackerParty.getPartyMembers(); + final List members = attackerParty.getPartyMembers(); for (int i = 0; i < members.size(); ++i) { - PlayerInstance tmp = members.get(i); + final PlayerInstance tmp = members.get(i); if (!_aggroList.containsKey(tmp)) { continue; @@ -265,7 +265,7 @@ public class Attackable extends NpcInstance private void calculateAggro(int damage, Creature attacker) { int newAggro = damage; - Integer aggroValue = _aggroList.get(attacker); + final Integer aggroValue = _aggroList.get(attacker); if (aggroValue != null) { newAggro += aggroValue.intValue(); @@ -289,9 +289,9 @@ public class Attackable extends NpcInstance { continue; } - ItemInstance dropit = ItemTable.getInstance().createItem(drop.getItemId()); - int min = drop.getMinDrop(); - int max = drop.getMaxDrop(); + final ItemInstance dropit = ItemTable.getInstance().createItem(drop.getItemId()); + final int min = drop.getMinDrop(); + final int max = drop.getMaxDrop(); int itemCount = 0; itemCount = min < max ? Rnd.get(max - min) + min : 1; if (dropit.getItemId() == 57) @@ -305,7 +305,7 @@ public class Attackable extends NpcInstance dropit.setY(getY()); dropit.setZ(getZ() + 100); dropit.setOnTheGround(true); - DropItem dis = new DropItem(dropit, getObjectId()); + final DropItem dis = new DropItem(dropit, getObjectId()); for (Creature player : broadcastPacket(dis)) { ((PlayerInstance) player).addKnownObjectWithoutCreate(dropit); @@ -357,7 +357,7 @@ public class Attackable extends NpcInstance super.setPhysicalAttack(physicalAttack); _dummyWeapon = new Weapon(); _dummyWeapon.setPDamage(physicalAttack); - int randDmg = getLevel(); + final int randDmg = getLevel(); _dummyWeapon.setRandomDamage(randDmg); } @@ -457,8 +457,8 @@ public class Attackable extends NpcInstance { try { - int x1 = (getX() + Rnd.get(500)) - 250; - int y1 = (getY() + Rnd.get(500)) - 250; + final int x1 = (getX() + Rnd.get(500)) - 250; + final int y1 = (getY() + Rnd.get(500)) - 250; moveTo(x1, y1, getZ(), 0); } catch (Exception e) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Creature.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Creature.java index e87c0cf6b5..c3c4f86287 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Creature.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/Creature.java @@ -201,9 +201,9 @@ public abstract class Creature extends WorldObject { return super.getX(); } - long elapsed = System.currentTimeMillis() - _moveStartTime; - int diff = (int) (elapsed * _xAddition); - int remain = Math.abs(getXdestination() - super.getX()) - Math.abs(diff); + final long elapsed = System.currentTimeMillis() - _moveStartTime; + final int diff = (int) (elapsed * _xAddition); + final int remain = Math.abs(getXdestination() - super.getX()) - Math.abs(diff); if (remain > 0) { return super.getX() + diff; @@ -218,9 +218,9 @@ public abstract class Creature extends WorldObject { return super.getY(); } - long elapsed = System.currentTimeMillis() - _moveStartTime; - int diff = (int) (elapsed * _yAddition); - int remain = Math.abs(getYdestination() - super.getY()) - Math.abs(diff); + final long elapsed = System.currentTimeMillis() - _moveStartTime; + final int diff = (int) (elapsed * _yAddition); + final int remain = Math.abs(getYdestination() - super.getY()) - Math.abs(diff); if (remain > 0) { return super.getY() + diff; @@ -392,22 +392,22 @@ public abstract class Creature extends WorldObject public void broadcastStatusUpdate() { - List list = getStatusListener(); + final List list = getStatusListener(); if (list.isEmpty()) { return; } - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, (int) getCurrentHp()); su.addAttribute(StatusUpdate.CUR_MP, (int) getCurrentMp()); for (int i = 0; i < list.size(); ++i) { - Creature temp = list.get(i); + final Creature temp = list.get(i); if (!(temp instanceof PlayerInstance)) { continue; } - PlayerInstance player = (PlayerInstance) temp; + final PlayerInstance player = (PlayerInstance) temp; try { player.sendPacket(su); @@ -508,11 +508,11 @@ public abstract class Creature extends WorldObject public void increaseLevel() { ++_level; - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.LEVEL, _level); sendPacket(su); sendPacket(new SystemMessage(SystemMessage.YOU_INCREASED_YOUR_LEVEL)); - SocialAction sa = new SocialAction(getObjectId(), 15); + final SocialAction sa = new SocialAction(getObjectId(), 15); broadcastPacket(sa); sendPacket(sa); } @@ -520,7 +520,7 @@ public abstract class Creature extends WorldObject public void decreaseLevel() { --_level; - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.LEVEL, _level); sendPacket(su); } @@ -779,7 +779,7 @@ public abstract class Creature extends WorldObject public void reduceCurrentMp(int i) { - Object object = _mpLock; + final Object object = _mpLock; synchronized (object) { _currentMp -= i; @@ -818,8 +818,8 @@ public abstract class Creature extends WorldObject { _currentMoveTask.cancel(); } - StopMove stop = new StopMove(this); - Die die = new Die(this); + final StopMove stop = new StopMove(this); + final Die die = new Die(this); broadcastPacket(stop); sendPacket(stop); broadcastPacket(die); @@ -836,7 +836,7 @@ public abstract class Creature extends WorldObject public void moveTo(int x, int y, int z, int offset) { _moveOffset = offset; - double distance = getDistance(x, y); + final double distance = getDistance(x, y); if ((distance > 0.0) || (offset > 0)) { if (offset == 0) @@ -847,7 +847,7 @@ public abstract class Creature extends WorldObject setPawnTarget(null); } calculateMovement(x, y, z, distance); - CharMoveToLocation mov = new CharMoveToLocation(this); + final CharMoveToLocation mov = new CharMoveToLocation(this); if (getCurrentState() == CreatureState.CASTING) { setCurrentState(CreatureState.IDLE); @@ -869,7 +869,7 @@ public abstract class Creature extends WorldObject setPawnTarget((Creature) getTarget()); setPawnOffset(offset); calculateMovement(x, y, z, distance); - MoveToPawn mov = new MoveToPawn(this, getTarget(), offset); + final MoveToPawn mov = new MoveToPawn(this, getTarget(), offset); broadcastPacket(mov); sendPacket(mov); return; @@ -893,7 +893,7 @@ public abstract class Creature extends WorldObject } if ((getPawnTarget() != null) && (distance <= getAttackRange()) && (getCurrentState() == CreatureState.FOLLOW)) { - ArriveTask newMoveTask = new ArriveTask(this); + final ArriveTask newMoveTask = new ArriveTask(this); _moveTimer.schedule(newMoveTask, 3000L); _currentMoveTask = newMoveTask; return; @@ -910,13 +910,13 @@ public abstract class Creature extends WorldObject { distance -= _moveOffset - 5; } - double angle = Math.atan2(-dy, -dx); + final double angle = Math.atan2(-dy, -dx); dy = (int) (-(Math.sin(angle) * distance)); dx = (int) (-(Math.cos(angle) * distance)); } if ((distance > 0.0) || (getPawnTarget() != null)) { - float speed = _effectiveSpeed; + final float speed = _effectiveSpeed; if (speed == 0.0f) { _log.warning("speed is 0 for Character oid:" + getObjectId() + " movement canceld"); @@ -927,8 +927,8 @@ public abstract class Creature extends WorldObject _yAddition = ((dy / distance) * speed) / 1000.0; int heading = (int) (Math.atan2(-dy, -dx) * 10430.378350470453); setHeading(heading += 32768); - int destinationX = getX() + (int) (_xAddition * _timeToTarget); - int destinationY = getY() + (int) (_yAddition * _timeToTarget); + final int destinationX = getX() + (int) (_xAddition * _timeToTarget); + final int destinationY = getY() + (int) (_yAddition * _timeToTarget); setXdestination(destinationX); setYdestination(destinationY); setZdestination(z); @@ -937,7 +937,7 @@ public abstract class Creature extends WorldObject { _timeToTarget = 0L; } - ArriveTask newMoveTask = new ArriveTask(this); + final ArriveTask newMoveTask = new ArriveTask(this); if (getPawnTarget() != null) { if (getCurrentState() == CreatureState.INTERACT) @@ -994,15 +994,15 @@ public abstract class Creature extends WorldObject public double getDistance(int x, int y) { - long dx = x - getX(); - long dy = y - getY(); - double distance = Math.sqrt((dx * dx) + (dy * dy)); + final long dx = x - getX(); + final long dy = y - getY(); + final double distance = Math.sqrt((dx * dx) + (dy * dy)); return distance; } public Collection broadcastPacket(ServerBasePacket mov) { - Set nearby = getKnownPlayers(); + final Set nearby = getKnownPlayers(); for (Creature player : nearby) { player.sendPacket(mov); @@ -1018,10 +1018,10 @@ public abstract class Creature extends WorldObject { if (getPawnTarget() != null) { - int x = getPawnTarget().getX(); - int y = getPawnTarget().getY(); - int z = getPawnTarget().getZ(); - double distance = getDistance(x, y); + final int x = getPawnTarget().getX(); + final int y = getPawnTarget().getY(); + final int z = getPawnTarget().getZ(); + final double distance = getDistance(x, y); if (getCurrentState() == CreatureState.FOLLOW) { calculateMovement(x, y, z, distance); @@ -1059,7 +1059,7 @@ public abstract class Creature extends WorldObject setto = new SetToLocation(this); broadcastPacket(setto); } - FinishRotation fr = new FinishRotation(this); + final FinishRotation fr = new FinishRotation(this); broadcastPacket(fr); } @@ -1084,12 +1084,12 @@ public abstract class Creature extends WorldObject private void onAttackTimer() { _currentAttackTask = null; - Creature target = (Creature) _attackTarget; + final Creature target = (Creature) _attackTarget; if (isDead() || (target == null) || target.isDead() || ((getCurrentState() != CreatureState.ATTACKING) && (getCurrentState() != CreatureState.CASTING)) || !target.knownsObject(this) || !knownsObject(target)) { setInCombat(false); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); return; } @@ -1097,12 +1097,12 @@ public abstract class Creature extends WorldObject { setInCombat(false); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); sendPacket(new SystemMessage(SystemMessage.NOT_ENOUGH_ARROWS)); return; } - double distance = getDistance(target.getX(), target.getY()); + final double distance = getDistance(target.getX(), target.getY()); if (distance > getAttackRange()) { moveTo(_attackTarget.getX(), _attackTarget.getY(), _attackTarget.getZ(), getAttackRange()); @@ -1110,24 +1110,24 @@ public abstract class Creature extends WorldObject } if ((getCurrentState() == CreatureState.ATTACKING) && !_currentlyAttacking) { - Weapon weaponItem = getActiveWeapon(); + final Weapon weaponItem = getActiveWeapon(); if (weaponItem == null) { setInCombat(false); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); return; } if (!_currentlyAttacking) { _currentlyAttacking = true; - int baseDamage = weaponItem.getPDamage(); - int randomDamage = weaponItem.getRandomDamage(); + final int baseDamage = weaponItem.getPDamage(); + final int randomDamage = weaponItem.getRandomDamage(); int damage = 0; boolean crit = false; // int hitTarget = Creature.getRnd().nextInt(100); - boolean miss = false; + final boolean miss = false; boolean soulShotUse = false; if (!miss) { @@ -1145,7 +1145,7 @@ public abstract class Creature extends WorldObject } } damage = ((baseDamage + Rnd.get(randomDamage)) * 70) / pDef; - int critHit = Rnd.get(100); + final int critHit = Rnd.get(100); crit = getCriticalHit() > critHit; if (crit) { @@ -1173,13 +1173,13 @@ public abstract class Creature extends WorldObject sendPacket(new SystemMessage(SystemMessage.NOT_ENOUGH_MP)); setInCombat(false); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); return; } reduceCurrentMp(weaponItem.getMpConsume()); sendPacket(new SystemMessage(SystemMessage.GETTING_READY_TO_SHOOT_AN_ARROW)); - SetupGauge sg = new SetupGauge(1, calculateAttackSpeed(weaponItem) * 2); + final SetupGauge sg = new SetupGauge(1, calculateAttackSpeed(weaponItem) * 2); sendPacket(sg); _hitTimer.schedule(new HitTask(this, target, damage, crit, miss, false), calculateHitSpeed(weaponItem, 1)); } @@ -1187,7 +1187,7 @@ public abstract class Creature extends WorldObject { _hitTimer.schedule(new HitTask(this, target, damage, crit, miss, false), calculateHitSpeed(weaponItem, 1)); } - Attack attack = new Attack(getObjectId(), _attackTarget.getObjectId(), damage, miss, crit, soulShotUse, getX(), getY(), getZ()); + final Attack attack = new Attack(getObjectId(), _attackTarget.getObjectId(), damage, miss, crit, soulShotUse, getX(), getY(), getZ()); setActiveSoulshotGrade(0); broadcastPacket(attack); sendPacket(attack); @@ -1213,7 +1213,7 @@ public abstract class Creature extends WorldObject setInCombat(false); setTarget(null); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); return; } @@ -1292,7 +1292,7 @@ public abstract class Creature extends WorldObject { setInCombat(false); setCurrentState(CreatureState.IDLE); - ActionFailed af = new ActionFailed(); + final ActionFailed af = new ActionFailed(); sendPacket(af); return; } @@ -1421,7 +1421,7 @@ public abstract class Creature extends WorldObject { try { - Object object = _mpLock; + final Object object = _mpLock; synchronized (object) { double nowMp = _instance.getCurrentMp(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/ClassMasterInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/ClassMasterInstance.java index 7d0836385e..62c36ef24b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/ClassMasterInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/ClassMasterInstance.java @@ -40,15 +40,15 @@ public class ClassMasterInstance extends NpcInstance { player.setCurrentState(CreatureState.IDLE); player.setTarget(this); - MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); + final MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); player.sendPacket(my); player.sendPacket(new SetToLocation(this)); } else { - int classId = player.getClassId(); + final int classId = player.getClassId(); int jobLevel = 0; - int level = player.getLevel(); + final int level = player.getLevel(); switch (classId) { case 0: @@ -97,7 +97,7 @@ public class ClassMasterInstance extends NpcInstance } else { - NpcHtmlMessage html = new NpcHtmlMessage(1); + final NpcHtmlMessage html = new NpcHtmlMessage(1); switch (jobLevel) { case 1: @@ -132,7 +132,7 @@ public class ClassMasterInstance extends NpcInstance { if (command.startsWith("change_class")) { - int val = Integer.parseInt(command.substring(13)); + final int val = Integer.parseInt(command.substring(13)); changeClass(player, val); } else @@ -144,9 +144,9 @@ public class ClassMasterInstance extends NpcInstance private void changeClass(PlayerInstance player, int val) { player.setClassId(val); - UserInfo ui = new UserInfo(player); + final UserInfo ui = new UserInfo(player); player.sendPacket(ui); - CharInfo info = new CharInfo(player); + final CharInfo info = new CharInfo(player); player.broadcastPacket(info); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/GuardInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/GuardInstance.java index 9a434fb07c..10886f2012 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/GuardInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/GuardInstance.java @@ -105,7 +105,7 @@ public class GuardInstance extends Attackable { player.setCurrentState(CreatureState.IDLE); player.setTarget(this); - MyTargetSelected my = new MyTargetSelected(getObjectId(), 0); + final MyTargetSelected my = new MyTargetSelected(getObjectId(), 0); player.sendPacket(my); player.sendPacket(new SetToLocation(this)); } @@ -115,7 +115,7 @@ public class GuardInstance extends Attackable } else { - double distance = getDistance(player.getX(), player.getY()); + final double distance = getDistance(player.getX(), player.getY()); if (distance > INTERACTION_DISTANCE) { player.setCurrentState(CreatureState.INTERACT); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MerchantInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MerchantInstance.java index 23042c87cc..7ff7fe5ab0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MerchantInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MerchantInstance.java @@ -51,10 +51,10 @@ public class MerchantInstance extends NpcInstance private void showBuyWindow(PlayerInstance player, int val) { - TradeList list = TradeController.getInstance().getBuyList(val); + final TradeList list = TradeController.getInstance().getBuyList(val); if (list != null) { - BuyList bl = new BuyList(list, player.getAdena()); + final BuyList bl = new BuyList(list, player.getAdena()); player.sendPacket(bl); } else @@ -66,7 +66,7 @@ public class MerchantInstance extends NpcInstance private void showSellWindow(PlayerInstance player) { - SellList sl = new SellList(player); + final SellList sl = new SellList(player); player.sendPacket(sl); player.sendPacket(new ActionFailed()); } @@ -77,7 +77,7 @@ public class MerchantInstance extends NpcInstance super.onBypassFeedback(player, command); if (command.startsWith("Buy")) { - int val = Integer.parseInt(command.substring(4)); + final int val = Integer.parseInt(command.substring(4)); showBuyWindow(player, val); } else if (command.equals("Sell")) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MonsterInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MonsterInstance.java index 7a75cb248d..555cb0b1d2 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MonsterInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/MonsterInstance.java @@ -51,7 +51,7 @@ public class MonsterInstance extends Attackable public void removeKnownObject(WorldObject object) { super.removeKnownObject(object); - Creature temp = (Creature) object; + final Creature temp = (Creature) object; if (getTarget() == temp) { setTarget(null); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/NpcInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/NpcInstance.java index 6c259a9655..de57998222 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/NpcInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/NpcInstance.java @@ -71,7 +71,7 @@ public class NpcInstance extends Creature if (!isRunning()) { setRunning(true); - ChangeMoveType move = new ChangeMoveType(this, ChangeMoveType.RUN); + final ChangeMoveType move = new ChangeMoveType(this, ChangeMoveType.RUN); broadcastPacket(move); } super.startAttack(target); @@ -128,11 +128,11 @@ public class NpcInstance extends Creature } player.setCurrentState(CreatureState.IDLE); player.setTarget(this); - MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); + final MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); player.sendPacket(my); if (isAttackable()) { - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, (int) getCurrentHp()); su.addAttribute(StatusUpdate.MAX_HP, getMaxHp()); player.sendPacket(su); @@ -147,7 +147,7 @@ public class NpcInstance extends Creature } if (!isAttackable()) { - double distance = getDistance(player.getX(), player.getY()); + final double distance = getDistance(player.getX(), player.getY()); if (distance > INTERACTION_DISTANCE) { player.setCurrentState(CreatureState.INTERACT); @@ -167,11 +167,11 @@ public class NpcInstance extends Creature @Override public void onActionShift(ClientThread client) { - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); if (client.getAccessLevel() >= 100) { - NpcHtmlMessage html = new NpcHtmlMessage(1); - StringBuffer html1 = new StringBuffer(""); + final NpcHtmlMessage html = new NpcHtmlMessage(1); + final StringBuffer html1 = new StringBuffer("
"); html1.append(""); html1.append(""); html1.append(""); @@ -194,19 +194,19 @@ public class NpcInstance extends Creature public void onBypassFeedback(PlayerInstance player, String command) { - double distance = getDistance(player.getX(), player.getY()); + final double distance = getDistance(player.getX(), player.getY()); if (distance > 150.0) { player.moveTo(getX(), getY(), getZ(), 150); } else if (command.startsWith("Quest")) { - int val = Integer.parseInt(command.substring(6)); + final int val = Integer.parseInt(command.substring(6)); showQuestWindow(player, val); } else if (command.startsWith("Chat")) { - int val = Integer.parseInt(command.substring(5)); + final int val = Integer.parseInt(command.substring(5)); showChatWindow(player, val); } } @@ -220,14 +220,14 @@ public class NpcInstance extends Creature public void insertObjectIdAndShowChatWindow(PlayerInstance player, String content) { content = content.replaceAll("%objectId%", String.valueOf(getObjectId())); - NpcHtmlMessage npcReply = new NpcHtmlMessage(5); + final NpcHtmlMessage npcReply = new NpcHtmlMessage(5); npcReply.setHtml(content); player.sendPacket(npcReply); } protected void showQuestWindow(PlayerInstance player, int val) { - NpcHtmlMessage html = new NpcHtmlMessage(1); + final NpcHtmlMessage html = new NpcHtmlMessage(1); html.setHtml("There is no quests here yet."); player.sendPacket(html); player.sendPacket(new ActionFailed()); @@ -237,8 +237,8 @@ public class NpcInstance extends Creature { String pom = ""; pom = val == 0 ? "" + npcId : npcId + "-" + val; - String temp = "data/html/default/" + pom + ".htm"; - File mainText = new File(temp); + final String temp = "data/html/default/" + pom + ".htm"; + final File mainText = new File(temp); if (mainText.exists()) { return temp; @@ -248,12 +248,12 @@ public class NpcInstance extends Creature public void showChatWindow(PlayerInstance player, int val) { - int npcId = getNpcTemplate().getNpcId(); - String filename = getHtmlPath(npcId, val); - File file = new File(filename); + final int npcId = getNpcTemplate().getNpcId(); + final String filename = getHtmlPath(npcId, val); + final File file = new File(filename); if (!file.exists()) { - NpcHtmlMessage html = new NpcHtmlMessage(1); + final NpcHtmlMessage html = new NpcHtmlMessage(1); html.setHtml("My Text is missing:
" + filename + ""); player.sendPacket(html); player.sendPacket(new ActionFailed()); @@ -264,9 +264,9 @@ public class NpcInstance extends Creature try { fis = new FileInputStream(file); - byte[] raw = new byte[fis.available()]; + final byte[] raw = new byte[fis.available()]; fis.read(raw); - String content = new String(raw, "UTF-8"); + final String content = new String(raw, "UTF-8"); insertObjectIdAndShowChatWindow(player, content); } catch (Exception e) @@ -327,7 +327,7 @@ public class NpcInstance extends Creature super.reduceCurrentHp(i, attacker); if (isDead()) { - NpcInstance NpcInstance = this; + final NpcInstance NpcInstance = this; synchronized (NpcInstance) { if (_decayTask == null) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PetInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PetInstance.java index 0b465719d9..84925be0e9 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PetInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PetInstance.java @@ -91,7 +91,7 @@ public class PetInstance extends Creature } player.setCurrentState(CreatureState.IDLE); player.setTarget(this); - MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); + final MyTargetSelected my = new MyTargetSelected(getObjectId(), player.getLevel() - getLevel()); player.sendPacket(my); } @@ -258,7 +258,7 @@ public class PetInstance extends Creature { _exp += addToExp; _sp += addToSp; - PetStatusUpdate su = new PetStatusUpdate(this); + final PetStatusUpdate su = new PetStatusUpdate(this); _owner.sendPacket(su); while (_exp >= getNextLevel()) { @@ -272,12 +272,12 @@ public class PetInstance extends Creature setLastLevel(getNextLevel()); setLevel(getLevel() + 1); setNextLevel(ExperienceTable.getInstance().getExp(getLevel() + 1)); - PetStatusUpdate ps = new PetStatusUpdate(this); + final PetStatusUpdate ps = new PetStatusUpdate(this); _owner.sendPacket(ps); - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.LEVEL, getLevel()); broadcastPacket(su); - SocialAction sa = new SocialAction(getObjectId(), 15); + final SocialAction sa = new SocialAction(getObjectId(), 15); broadcastPacket(sa); _owner.sendPacket(new SystemMessage(SystemMessage.YOU_INCREASED_YOUR_LEVEL)); } @@ -343,7 +343,7 @@ public class PetInstance extends Creature private void doPickupItem() { - StopMove sm = new StopMove(getObjectId(), getX(), getY(), getZ(), getHeading()); + final StopMove sm = new StopMove(getObjectId(), getX(), getY(), getZ(), getHeading()); broadcastPacket(sm); if (!(getTarget() instanceof ItemInstance)) { @@ -351,9 +351,9 @@ public class PetInstance extends Creature _owner.sendPacket(new ActionFailed()); return; } - ItemInstance target = (ItemInstance) getTarget(); + final ItemInstance target = (ItemInstance) getTarget(); boolean pickupOk = false; - ItemInstance ItemInstance = target; + final ItemInstance ItemInstance = target; synchronized (ItemInstance) { if (target.isOnTheGround()) @@ -368,13 +368,13 @@ public class PetInstance extends Creature setCurrentState(CreatureState.IDLE); return; } - GetItem gi = new GetItem(target, getObjectId()); + final GetItem gi = new GetItem(target, getObjectId()); broadcastPacket(gi); World.getInstance().removeVisibleObject(target); - DeleteObject del = new DeleteObject(target); + final DeleteObject del = new DeleteObject(target); broadcastPacket(del); getInventory().addItem(target); - PetItemList iu = new PetItemList(this); + final PetItemList iu = new PetItemList(this); _owner.sendPacket(iu); setCurrentState(CreatureState.IDLE); if (getFollowStatus()) @@ -400,7 +400,7 @@ public class PetInstance extends Creature } if (isDead()) { - PetInstance PetInstance = this; + final PetInstance PetInstance = this; synchronized (PetInstance) { if (_decayTask == null) @@ -422,7 +422,7 @@ public class PetInstance extends Creature { try { - Inventory petInventory = getInventory(); + final Inventory petInventory = getInventory(); for (ItemInstance giveit : petInventory.getItems()) { if (((giveit.getItem().getWeight() * giveit.getCount()) + _owner.getInventory().getTotalWeight()) < _owner.getMaxLoad()) @@ -445,8 +445,8 @@ public class PetInstance extends Creature { _owner.getInventory().addItem(item); getInventory().dropItem(item, item.getCount()); - PetInventoryUpdate petiu = new PetInventoryUpdate(); - ItemList PlayerUI = new ItemList(_owner, false); + final PetInventoryUpdate petiu = new PetInventoryUpdate(); + final ItemList PlayerUI = new ItemList(_owner, false); petiu.addRemovedItem(item); _owner.sendPacket(petiu); _owner.sendPacket(PlayerUI); @@ -487,18 +487,18 @@ public class PetInstance extends Creature { try { - ItemInstance removedItem = owner.getInventory().destroyItem(getControlItemId(), 1); - InventoryUpdate iu = new InventoryUpdate(); + final ItemInstance removedItem = owner.getInventory().destroyItem(getControlItemId(), 1); + final InventoryUpdate iu = new InventoryUpdate(); iu.addRemovedItem(removedItem); owner.sendPacket(iu); - StatusUpdate su = new StatusUpdate(owner.getObjectId()); + final StatusUpdate su = new StatusUpdate(owner.getObjectId()); su.addAttribute(StatusUpdate.CUR_LOAD, owner.getCurrentLoad()); owner.sendPacket(su); - UserInfo ui = new UserInfo(owner); + final UserInfo ui = new UserInfo(owner); owner.sendPacket(ui); - CharInfo info = new CharInfo(owner); + final CharInfo info = new CharInfo(owner); owner.broadcastPacket(info); - World world = World.getInstance(); + final World world = World.getInstance(); world.removeObject(removedItem); } catch (Exception e) @@ -531,7 +531,7 @@ public class PetInstance extends Creature dropit.setY(getY()); dropit.setZ(getZ() + 100); dropit.setOnTheGround(true); - DropItem dis = new DropItem(dropit, getObjectId()); + final DropItem dis = new DropItem(dropit, getObjectId()); for (Creature player : broadcastPacket(dis)) { ((PlayerInstance) player).addKnownObjectWithoutCreate(dropit); @@ -551,7 +551,7 @@ public class PetInstance extends Creature if (!isRunning()) { setRunning(true); - ChangeMoveType move = new ChangeMoveType(this, ChangeMoveType.RUN); + final ChangeMoveType move = new ChangeMoveType(this, ChangeMoveType.RUN); broadcastPacket(move); } super.startAttack(target); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PlayerInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PlayerInstance.java index 830fe8c4f5..f5443c0597 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PlayerInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/PlayerInstance.java @@ -138,7 +138,7 @@ public class PlayerInstance extends Creature public Skill addSkill(Skill newSkill) { - Skill oldSkill = _skills.put(newSkill.getId(), newSkill); + final Skill oldSkill = _skills.put(newSkill.getId(), newSkill); return oldSkill; } @@ -174,7 +174,7 @@ public class PlayerInstance extends Creature public int getSkillLevel(int skillId) { - Skill skill = _skills.get(skillId); + final Skill skill = _skills.get(skillId); if (skill == null) { return -1; @@ -287,47 +287,47 @@ public class PlayerInstance extends Creature Weapon weaponItem = null; if ((classId >= 0) && (classId <= 9)) { - Item temp = ItemTable.getInstance().getTemplate(246); + final Item temp = ItemTable.getInstance().getTemplate(246); weaponItem = (Weapon) temp; } else if ((classId >= 10) && (classId <= 17)) { - Item temp = ItemTable.getInstance().getTemplate(251); + final Item temp = ItemTable.getInstance().getTemplate(251); weaponItem = (Weapon) temp; } else if ((classId >= 18) && (classId <= 24)) { - Item temp = ItemTable.getInstance().getTemplate(244); + final Item temp = ItemTable.getInstance().getTemplate(244); weaponItem = (Weapon) temp; } else if ((classId >= 25) && (classId <= 30)) { - Item temp = ItemTable.getInstance().getTemplate(249); + final Item temp = ItemTable.getInstance().getTemplate(249); weaponItem = (Weapon) temp; } else if ((classId >= 31) && (classId <= 37)) { - Item temp = ItemTable.getInstance().getTemplate(245); + final Item temp = ItemTable.getInstance().getTemplate(245); weaponItem = (Weapon) temp; } else if ((classId >= 38) && (classId <= 43)) { - Item temp = ItemTable.getInstance().getTemplate(250); + final Item temp = ItemTable.getInstance().getTemplate(250); weaponItem = (Weapon) temp; } else if ((classId >= 44) && (classId <= 48)) { - Item temp = ItemTable.getInstance().getTemplate(248); + final Item temp = ItemTable.getInstance().getTemplate(248); weaponItem = (Weapon) temp; } else if ((classId >= 49) && (classId <= 52)) { - Item temp = ItemTable.getInstance().getTemplate(252); + final Item temp = ItemTable.getInstance().getTemplate(252); weaponItem = (Weapon) temp; } else if ((classId >= 53) && (classId <= 57)) { - Item temp = ItemTable.getInstance().getTemplate(247); + final Item temp = ItemTable.getInstance().getTemplate(247); weaponItem = (Weapon) temp; } return weaponItem; @@ -338,11 +338,11 @@ public class PlayerInstance extends Creature { _exp += addToExp; _sp += addToSp; - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.EXP, _exp); su.addAttribute(StatusUpdate.SP, _sp); sendPacket(su); - SystemMessage sm = new SystemMessage(SystemMessage.YOU_EARNED_S1_EXP_AND_S2_SP); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_EARNED_S1_EXP_AND_S2_SP); sm.addNumber(addToExp); sm.addNumber(addToSp); sendPacket(sm); @@ -361,25 +361,25 @@ public class PlayerInstance extends Creature private void rewardSkills() { // int charclass = this.getClassId(); - int lvl = getLevel(); + final int lvl = getLevel(); if (lvl == 5) { - Skill skill = SkillTable.getInstance().getInfo(194, 1); + final Skill skill = SkillTable.getInstance().getInfo(194, 1); removeSkill(skill); } else if (lvl == 20) { - Skill skill = SkillTable.getInstance().getInfo(239, 1); + final Skill skill = SkillTable.getInstance().getInfo(239, 1); addSkill(skill); } else if (lvl == 40) { - Skill skill = SkillTable.getInstance().getInfo(239, 2); + final Skill skill = SkillTable.getInstance().getInfo(239, 2); addSkill(skill); } else if (lvl == 52) { - Skill skill = SkillTable.getInstance().getInfo(239, 3); + final Skill skill = SkillTable.getInstance().getInfo(239, 3); addSkill(skill); } } @@ -588,7 +588,7 @@ public class PlayerInstance extends Creature if (player.getTarget() != this) { player.setTarget(this); - MyTargetSelected my = new MyTargetSelected(getObjectId(), 0); + final MyTargetSelected my = new MyTargetSelected(getObjectId(), 0); player.sendPacket(my); } else @@ -605,7 +605,7 @@ public class PlayerInstance extends Creature @Override public void broadcastStatusUpdate() { - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.CUR_HP, (int) getCurrentHp()); su.addAttribute(StatusUpdate.CUR_MP, (int) getCurrentMp()); super.broadcastStatusUpdate(); @@ -615,7 +615,7 @@ public class PlayerInstance extends Creature } if (isInParty()) { - PartySmallWindowUpdate update = new PartySmallWindowUpdate(this); + final PartySmallWindowUpdate update = new PartySmallWindowUpdate(this); getParty().broadcastToPartyMembers(this, update); } } @@ -661,7 +661,7 @@ public class PlayerInstance extends Creature } else { - SystemMessage sm = new SystemMessage(SystemMessage.YOU_DID_S1_DMG); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_DID_S1_DMG); sm.addNumber(damage); sendPacket(sm); } @@ -682,7 +682,7 @@ public class PlayerInstance extends Creature public void sendMessage(String message) { - SystemMessage sm = new SystemMessage(SystemMessage.S1_S2); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_S2); sm.addString(message); sendPacket(sm); } @@ -690,7 +690,7 @@ public class PlayerInstance extends Creature @Override protected void startCombat() { - Creature target = (Creature) getTarget(); + final Creature target = (Creature) getTarget(); if (target == null) { _log.warning("Failed to start combat without target."); @@ -732,7 +732,7 @@ public class PlayerInstance extends Creature { if (getTarget() instanceof PlayerInstance) { - PlayerInstance temp = (PlayerInstance) getTarget(); + final PlayerInstance temp = (PlayerInstance) getTarget(); sendPacket(new ActionFailed()); if (temp.getPrivateStoreType() == 1) { @@ -767,12 +767,12 @@ public class PlayerInstance extends Creature _log.warning("trying to pickup wrong target." + getTarget()); return; } - ItemInstance target = (ItemInstance) getTarget(); + final ItemInstance target = (ItemInstance) getTarget(); sendPacket(new ActionFailed()); - StopMove sm = new StopMove(getObjectId(), getX(), getY(), getZ(), getHeading()); + final StopMove sm = new StopMove(getObjectId(), getX(), getY(), getZ(), getHeading()); sendPacket(sm); boolean pickupOk = false; - ItemInstance ItemInstance = target; + final ItemInstance ItemInstance = target; synchronized (ItemInstance) { if (target.isOnTheGround()) @@ -786,10 +786,10 @@ public class PlayerInstance extends Creature return; } World.getInstance().removeVisibleObject(target); - GetItem gi = new GetItem(target, getObjectId()); + final GetItem gi = new GetItem(target, getObjectId()); sendPacket(gi); broadcastPacket(gi); - DeleteObject del = new DeleteObject(target); + final DeleteObject del = new DeleteObject(target); sendPacket(del); broadcastPacket(del); if (!isInParty()) @@ -808,8 +808,8 @@ public class PlayerInstance extends Creature smsg.addItemName(target.getItemId()); sendPacket(smsg); } - ItemInstance target2 = getInventory().addItem(target); - InventoryUpdate iu = new InventoryUpdate(); + final ItemInstance target2 = getInventory().addItem(target); + final InventoryUpdate iu = new InventoryUpdate(); if (target2.getLastChange() == 1) { iu.addNewItem(target); @@ -819,7 +819,7 @@ public class PlayerInstance extends Creature iu.addModifiedItem(target2); } sendPacket(iu); - UserInfo ci = new UserInfo(this); + final UserInfo ci = new UserInfo(this); sendPacket(ci); } else if (target.getItemId() == 57) @@ -861,7 +861,7 @@ public class PlayerInstance extends Creature @Override public Weapon getActiveWeapon() { - ItemInstance weapon = getInventory().getPaperdollItem(7); + final ItemInstance weapon = getInventory().getPaperdollItem(7); if (weapon == null) { return getFistsWeaponItem(); @@ -889,10 +889,10 @@ public class PlayerInstance extends Creature } // Damage message. - SystemMessage smsg = new SystemMessage(SystemMessage.S1_GAVE_YOU_S2_DMG); + final SystemMessage smsg = new SystemMessage(SystemMessage.S1_GAVE_YOU_S2_DMG); if ((attacker instanceof MonsterInstance) || (attacker instanceof NpcInstance)) { - int mobId = ((NpcInstance) attacker).getNpcTemplate().getNpcId(); + final int mobId = ((NpcInstance) attacker).getNpcTemplate().getNpcId(); smsg.addNpcName(mobId); } else @@ -965,7 +965,7 @@ public class PlayerInstance extends Creature public void increasePkKillsAndKarma(int level) { int newKarma = Config.KARMA_MIN_KARMA; - int pkLevel = getLevel(); + final int pkLevel = getLevel(); final int pkPKCount = getPkKills(); int pkCountMulti = 0; @@ -1088,7 +1088,7 @@ public class PlayerInstance extends Creature super.addKnownObject(object); if (object instanceof ItemInstance) { - SpawnItem si = new SpawnItem((ItemInstance) object); + final SpawnItem si = new SpawnItem((ItemInstance) object); sendPacket(si); } else if (object instanceof NpcInstance) @@ -1103,7 +1103,7 @@ public class PlayerInstance extends Creature } else if (object instanceof PlayerInstance) { - PlayerInstance otherPlayer = (PlayerInstance) object; + final PlayerInstance otherPlayer = (PlayerInstance) object; sendPacket(new CharInfo(otherPlayer)); if ((otherPlayer.getPrivateStoreType() == 1) || (otherPlayer.getPrivateStoreType() == 3)) { @@ -1114,15 +1114,15 @@ public class PlayerInstance extends Creature } if (object instanceof Creature) { - Creature obj = (Creature) object; + final Creature obj = (Creature) object; if (obj.isMoving()) { - CharMoveToLocation mov = new CharMoveToLocation(obj); + final CharMoveToLocation mov = new CharMoveToLocation(obj); sendPacket(mov); } else if (obj.isMovingToPawn()) { - MoveToPawn mov = new MoveToPawn(obj, obj.getPawnTarget(), obj.getPawnOffset()); + final MoveToPawn mov = new MoveToPawn(obj, obj.getPawnTarget(), obj.getPawnOffset()); sendPacket(mov); } } @@ -1139,18 +1139,18 @@ public class PlayerInstance extends Creature public void increaseLevel() { super.increaseLevel(); - LvlupData lvlData = LevelUpData.getInstance().getTemplate(getClassId()); + final LvlupData lvlData = LevelUpData.getInstance().getTemplate(getClassId()); if (lvlData != null) { - double hp1 = (getLevel() - 1) * lvlData.getDefaulthpadd(); - double hp2 = (getLevel() - 2) * lvlData.getDefaulthpbonus(); - double mp1 = (getLevel() - 1) * lvlData.getDefaultmpadd(); - double mp2 = (getLevel() - 2) * lvlData.getDefaultmpbonus(); - int newhp = (int) Math.rint(lvlData.getDefaulthp() + hp1 + hp2); - int newmp = (int) Math.rint(lvlData.getDefaultmp() + mp1 + mp2); + final double hp1 = (getLevel() - 1) * lvlData.getDefaulthpadd(); + final double hp2 = (getLevel() - 2) * lvlData.getDefaulthpbonus(); + final double mp1 = (getLevel() - 1) * lvlData.getDefaultmpadd(); + final double mp2 = (getLevel() - 2) * lvlData.getDefaultmpbonus(); + final int newhp = (int) Math.rint(lvlData.getDefaulthp() + hp1 + hp2); + final int newmp = (int) Math.rint(lvlData.getDefaultmp() + mp1 + mp2); setMaxHp(newhp); setCurrentHp(newhp); - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.MAX_HP, newhp); su.addAttribute(StatusUpdate.CUR_HP, newhp); setMaxMp(newmp); @@ -1172,7 +1172,7 @@ public class PlayerInstance extends Creature @Override public int getAttackRange() { - Weapon weapon = getActiveWeapon(); + final Weapon weapon = getActiveWeapon(); if ((weapon != null) && (weapon.getWeaponType() == 5)) { return 500; @@ -1203,7 +1203,7 @@ public class PlayerInstance extends Creature { stopAllTimers(); setTarget(null); - World world = World.getInstance(); + final World world = World.getInstance(); world.removeVisibleObject(this); if (isInParty()) { @@ -1232,8 +1232,8 @@ public class PlayerInstance extends Creature public void updatePAtk() { - double lvlmod = (89.0 + getLevel()) / 100.0; - StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); + final double lvlmod = (89.0 + getLevel()) / 100.0; + final StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); double strmod = 1.0; if (modifier != null) { @@ -1243,7 +1243,7 @@ public class PlayerInstance extends Creature { _log.warning("Missing STR modifier for classId: " + getClassId()); } - CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); + final CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); double weapondmg = 1.0; if (template != null) { @@ -1253,20 +1253,20 @@ public class PlayerInstance extends Creature { _log.warning("Missing template for classId: " + getClassId()); } - Weapon weapon = getActiveWeapon(); + final Weapon weapon = getActiveWeapon(); if (weapon != null) { weapondmg += weapon.getPDamage(); } - double pAtk = weapondmg * lvlmod * strmod; + final double pAtk = weapondmg * lvlmod * strmod; setPhysicalAttack((int) Math.rint(pAtk)); } public void updatePDef() { Armor armorPiece; - double lvlmod = (89.0 + getLevel()) / 100.0; - CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); + final double lvlmod = (89.0 + getLevel()) / 100.0; + final CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); double totalItemDef = 40.0; if (template != null) { @@ -1312,15 +1312,15 @@ public class PlayerInstance extends Creature armorPiece = (Armor) dummy.getItem(); totalItemDef += armorPiece.getPDef(); } - double pDef = totalItemDef * lvlmod; + final double pDef = totalItemDef * lvlmod; setPhysicalDefense((int) Math.round(pDef)); } public void updateMAtk() { - double lmod = (89.0 + getLevel()) / 100.0; - double lvlmod = Math.sqrt(lmod); - StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); + final double lmod = (89.0 + getLevel()) / 100.0; + final double lvlmod = Math.sqrt(lmod); + final StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); double imod = 1.0; if (modifier != null) { @@ -1330,8 +1330,8 @@ public class PlayerInstance extends Creature { _log.warning("Missing INT modifier for classId: " + getClassId()); } - double intmod = Math.sqrt(imod); - CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); + final double intmod = Math.sqrt(imod); + final CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); double weapondmg = 1.0; if (template != null) { @@ -1341,20 +1341,20 @@ public class PlayerInstance extends Creature { _log.warning("Missing template for classId: " + getClassId()); } - Weapon weapon = getActiveWeapon(); + final Weapon weapon = getActiveWeapon(); if (weapon != null) { weapondmg += weapon.getMDamage(); } - double mAtk = weapondmg * lvlmod * intmod; + final double mAtk = weapondmg * lvlmod * intmod; setMagicalAttack((int) Math.rint(mAtk)); } public void updateMDef() { Armor armorPiece; - double lvlBonus = (89.0 + getLevel()) / 100.0; - StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); + final double lvlBonus = (89.0 + getLevel()) / 100.0; + final StatModifiers modifier = CharStatsTable.getInstance().getTemplate(getClassId()); double MENbonus = 1.0; if (modifier != null) { @@ -1364,7 +1364,7 @@ public class PlayerInstance extends Creature { _log.warning("Missing MEN modifier for classId: " + getClassId()); } - CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); + final CharTemplate template = CharTemplateTable.getInstance().getTemplate(getClassId()); double totalItemDef = 40.0; if (template != null) { @@ -1400,7 +1400,7 @@ public class PlayerInstance extends Creature armorPiece = (Armor) dummy.getItem(); totalItemDef += armorPiece.getMDef(); } - double mDef = totalItemDef * lvlBonus * MENbonus; + final double mDef = totalItemDef * lvlBonus * MENbonus; setMagicalDefense((int) Math.round(mDef)); } @@ -1482,8 +1482,8 @@ public class PlayerInstance extends Creature return; } - int weaponType = getActiveWeapon().getWeaponType(); - int skillId = skill.getId(); + final int weaponType = getActiveWeapon().getWeaponType(); + final int skillId = skill.getId(); if ((skillId == 56) && (weaponType != 5)) { return; @@ -1518,21 +1518,21 @@ public class PlayerInstance extends Creature } setCurrentState(CreatureState.CASTING); setSkill(skill); - double distance = getDistance(target.getX(), target.getY()); + final double distance = getDistance(target.getX(), target.getY()); if ((skill.getCastRange() > 0) && (distance > skill.getCastRange())) { moveTo(target.getX(), target.getY(), target.getZ(), skill.getCastRange()); return; } - int magicId = skill.getId(); - int level = getSkillLevel(magicId); - ActionFailed af = new ActionFailed(); + final int magicId = skill.getId(); + final int level = getSkillLevel(magicId); + final ActionFailed af = new ActionFailed(); sendPacket(af); - MagicSkillUser msu = new MagicSkillUser(this, target, magicId, level, skill.getHitTime(), skill.getReuseDelay()); + final MagicSkillUser msu = new MagicSkillUser(this, target, magicId, level, skill.getHitTime(), skill.getReuseDelay()); sendPacket(msu); broadcastPacket(msu); sendPacket(new SetupGauge(0, skill.getHitTime())); - SystemMessage sm = new SystemMessage(SystemMessage.USE_S1); + final SystemMessage sm = new SystemMessage(SystemMessage.USE_S1); sm.addSkillName(magicId); sendPacket(sm); if (skill.getSkillTime() > 300) @@ -1548,7 +1548,7 @@ public class PlayerInstance extends Creature @Override protected void reduceArrowCount() { - ItemInstance arrows = getInventory().destroyItem(getInventory().getPaperdollObjectId(8), 1); + final ItemInstance arrows = getInventory().destroyItem(getInventory().getPaperdollObjectId(8), 1); // _log.info("arrow count:" + arrows.getCount()); if (arrows.getCount() == 0) { @@ -1559,7 +1559,7 @@ public class PlayerInstance extends Creature } else { - InventoryUpdate iu = new InventoryUpdate(); + final InventoryUpdate iu = new InventoryUpdate(); iu.addModifiedItem(arrows); sendPacket(iu); } @@ -1574,7 +1574,7 @@ public class PlayerInstance extends Creature if (_arrowItem != null) { getInventory().setPaperdollItem(8, _arrowItem); - ItemList il = new ItemList(this, false); + final ItemList il = new ItemList(this, false); sendPacket(il); } } @@ -1588,7 +1588,7 @@ public class PlayerInstance extends Creature @Override protected boolean isUsingDualWeapon() { - Weapon weaponItem = getActiveWeapon(); + final Weapon weaponItem = getActiveWeapon(); if (weaponItem.getWeaponType() == 9) { return true; @@ -1618,28 +1618,28 @@ public class PlayerInstance extends Creature { if ((getCurrentState() == CreatureState.CASTING) && (getSkill() == skill)) { - int magicId = skill.getId(); - int level = getSkillLevel(magicId); + final int magicId = skill.getId(); + final int level = getSkillLevel(magicId); if ((skill.getTargetType() == Skill.TARGET_PARTY) && isInParty()) { for (PlayerInstance player : getParty().getPartyMembers()) { - MagicSkillLaunched msl = new MagicSkillLaunched(this, magicId, level, player); + final MagicSkillLaunched msl = new MagicSkillLaunched(this, magicId, level, player); sendPacket(msl); broadcastPacket(msl); } } else { - MagicSkillLaunched msl = new MagicSkillLaunched(this, magicId, level, target); + final MagicSkillLaunched msl = new MagicSkillLaunched(this, magicId, level, target); sendPacket(msl); broadcastPacket(msl); } reduceCurrentMp(skill.getMpConsume()); - StatusUpdate su = new StatusUpdate(getObjectId()); + final StatusUpdate su = new StatusUpdate(getObjectId()); su.addAttribute(StatusUpdate.CUR_MP, (int) getCurrentMp()); sendPacket(su); - ISkillHandler handler = SkillHandler.getInstance().getSkillHandler(skill.getId()); + final ISkillHandler handler = SkillHandler.getInstance().getSkillHandler(skill.getId()); if (handler == null) { _log.warning("No skillhandler registered for skillId: " + skill.getId()); @@ -1739,7 +1739,7 @@ public class PlayerInstance extends Creature { setCurrentState(CreatureState.IDLE); enableAllSkills(); - MagicSkillCanceld msc = new MagicSkillCanceld(getObjectId()); + final MagicSkillCanceld msc = new MagicSkillCanceld(getObjectId()); sendPacket(msc); broadcastPacket(msc); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TeleporterInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TeleporterInstance.java index df2c42faa1..6dc3efb485 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TeleporterInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TeleporterInstance.java @@ -41,7 +41,7 @@ public class TeleporterInstance extends NpcInstance super.onBypassFeedback(player, command); if (command.startsWith("goto")) { - int val = Integer.parseInt(command.substring(5)); + final int val = Integer.parseInt(command.substring(5)); doTeleport(player, val); } } @@ -62,18 +62,18 @@ public class TeleporterInstance extends NpcInstance private void doTeleport(PlayerInstance player, int val) { - TeleportLocation list = TeleportLocationTable.getInstance().getTemplate(val); + final TeleportLocation list = TeleportLocationTable.getInstance().getTemplate(val); if (list != null) { if (player.getAdena() >= list.getPrice()) { player.reduceAdena(list.getPrice()); - TeleportToLocation Tloc = new TeleportToLocation(player, list.getLocX(), list.getLocY(), list.getLocZ()); + final TeleportToLocation Tloc = new TeleportToLocation(player, list.getLocX(), list.getLocY(), list.getLocZ()); player.sendPacket(Tloc); } else { - SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); player.sendPacket(sm); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TrainerInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TrainerInstance.java index 97503f4c40..41fbf5b9bf 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TrainerInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/TrainerInstance.java @@ -46,7 +46,7 @@ public class TrainerInstance extends NpcInstance public void showSkillList(PlayerInstance player) { - AquireSkillList asl = new AquireSkillList(); + final AquireSkillList asl = new AquireSkillList(); for (SkillLearn skill : SkillTreeTable.getInstance().getAvailableSkills(player)) { asl.addSkill(skill.getId(), skill.getLevel(), skill.getLevel(), skill.getSpCost(), 0); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/VillageMasterInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/VillageMasterInstance.java index c28128d3e6..29c791f18c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/VillageMasterInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/VillageMasterInstance.java @@ -37,7 +37,7 @@ public class VillageMasterInstance extends NpcInstance super.onBypassFeedback(player, command); if (command.startsWith("create_clan")) { - String val = command.substring(12); + final String val = command.substring(12); createClan(player, val); } } @@ -60,37 +60,37 @@ public class VillageMasterInstance extends NpcInstance { if (player.getLevel() < 10) { - SystemMessage sm = new SystemMessage(SystemMessage.FAILED_TO_CREATE_CLAN); + final SystemMessage sm = new SystemMessage(SystemMessage.FAILED_TO_CREATE_CLAN); player.sendPacket(sm); return; } if (player.getClanId() != 0) { - SystemMessage sm = new SystemMessage(SystemMessage.FAILED_TO_CREATE_CLAN); + final SystemMessage sm = new SystemMessage(SystemMessage.FAILED_TO_CREATE_CLAN); player.sendPacket(sm); return; } if (clanName.length() > 16) { - SystemMessage sm = new SystemMessage(SystemMessage.CLAN_NAME_TOO_LONG); + final SystemMessage sm = new SystemMessage(SystemMessage.CLAN_NAME_TOO_LONG); player.sendPacket(sm); return; } - Clan clan = ClanTable.getInstance().createClan(player, clanName); + final Clan clan = ClanTable.getInstance().createClan(player, clanName); if (clan == null) { - SystemMessage sm = new SystemMessage(SystemMessage.CLAN_NAME_INCORRECT); + final SystemMessage sm = new SystemMessage(SystemMessage.CLAN_NAME_INCORRECT); player.sendPacket(sm); return; } player.setClan(clan); player.setClanId(clan.getClanId()); player.setIsClanLeader(true); - PledgeShowInfoUpdate pu = new PledgeShowInfoUpdate(clan, player); + final PledgeShowInfoUpdate pu = new PledgeShowInfoUpdate(clan, player); player.sendPacket(pu); - UserInfo ui = new UserInfo(player); + final UserInfo ui = new UserInfo(player); player.sendPacket(ui); - SystemMessage sm = new SystemMessage(SystemMessage.CLAN_CREATED); + final SystemMessage sm = new SystemMessage(SystemMessage.CLAN_CREATED); player.sendPacket(sm); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/WarehouseInstance.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/WarehouseInstance.java index d432a356bf..a657b00794 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/WarehouseInstance.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/model/actor/instance/WarehouseInstance.java @@ -51,10 +51,10 @@ public class WarehouseInstance extends NpcInstance private void showRetrieveWindow(PlayerInstance player) { - Warehouse list = player.getWarehouse(); + final Warehouse list = player.getWarehouse(); if (list != null) { - WareHouseWithdrawalList wl = new WareHouseWithdrawalList(player); + final WareHouseWithdrawalList wl = new WareHouseWithdrawalList(player); player.sendPacket(wl); } else @@ -66,14 +66,14 @@ public class WarehouseInstance extends NpcInstance private void showDepositWindow(PlayerInstance player) { - WareHouseDepositList dl = new WareHouseDepositList(player); + final WareHouseDepositList dl = new WareHouseDepositList(player); player.sendPacket(dl); player.sendPacket(new ActionFailed()); } private void showDepositWindowClan(PlayerInstance player) { - NpcHtmlMessage html = new NpcHtmlMessage(1); + final NpcHtmlMessage html = new NpcHtmlMessage(1); html.setHtml("Clans are not supported yet."); player.sendPacket(html); player.sendPacket(new ActionFailed()); @@ -81,7 +81,7 @@ public class WarehouseInstance extends NpcInstance private void showWithdrawWindowClan(PlayerInstance player) { - NpcHtmlMessage html = new NpcHtmlMessage(1); + final NpcHtmlMessage html = new NpcHtmlMessage(1); html.setHtml("Clans are not supported yet."); player.sendPacket(html); player.sendPacket(new ActionFailed()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/ClientThread.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/ClientThread.java index 4bbd8abaac..e4f4dab9b8 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/ClientThread.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/ClientThread.java @@ -93,7 +93,7 @@ public class ClientThread extends Thread saveCharToDisk(_activeChar); starttime = System.currentTimeMillis(); } - byte[] decrypt = _connection.getPacket(); + final byte[] decrypt = _connection.getPacket(); _handler.handlePacket(decrypt); } while (true); @@ -272,7 +272,7 @@ public class ClientThread extends Thread public PlayerInstance loadCharFromDisk(int charslot) { PlayerInstance character = new PlayerInstance(); - File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); + final File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); character = restoreChar(chars[charslot]); if (character != null) { @@ -282,7 +282,7 @@ public class ClientThread extends Thread restoreWarehouse(new File(_charFolder, character.getName() + "_warehouse.csv"), character); if (character.getClanId() != 0) { - Clan clan = ClanTable.getInstance().getClan(character.getClanId()); + final Clan clan = ClanTable.getInstance().getClan(character.getClanId()); if (!clan.isMember(character.getName())) { character.setClanId(0); @@ -312,13 +312,13 @@ public class ClientThread extends Thread String line = null; while ((line = ((LineNumberReader) lnr).readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, ";"); - int slot = Integer.parseInt(st.nextToken()); - int type = Integer.parseInt(st.nextToken()); - int id = Integer.parseInt(st.nextToken()); - int level = Integer.parseInt(st.nextToken()); - int unk = Integer.parseInt(st.nextToken()); - ShortCut sc = new ShortCut(slot, type, id, level, unk); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int slot = Integer.parseInt(st.nextToken()); + final int type = Integer.parseInt(st.nextToken()); + final int id = Integer.parseInt(st.nextToken()); + final int level = Integer.parseInt(st.nextToken()); + final int unk = Integer.parseInt(st.nextToken()); + final ShortCut sc = new ShortCut(slot, type, id, level, unk); restored.registerShortCut(sc); } } @@ -501,11 +501,11 @@ public class ClientThread extends Thread String line = null; while ((line = ((LineNumberReader) lnr).readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, ";"); - ItemInstance item = new ItemInstance(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final ItemInstance item = new ItemInstance(); item.setObjectId(Integer.parseInt(st.nextToken())); - int itemId = Integer.parseInt(st.nextToken()); - Item itemTemp = ItemTable.getInstance().getTemplate(itemId); + final int itemId = Integer.parseInt(st.nextToken()); + final Item itemTemp = ItemTable.getInstance().getTemplate(itemId); item.setItem(itemTemp); st.nextToken(); item.setCount(Integer.parseInt(st.nextToken())); @@ -537,12 +537,12 @@ public class ClientThread extends Thread OutputStreamWriter out = null; try { - List items = cha.getWarehouse().getItems(); + final List items = cha.getWarehouse().getItems(); out = new FileWriter(saveFile); out.write("#objectId;itemId;name;count;\n"); for (int i = 0; i < items.size(); ++i) { - ItemInstance item = items.get(i); + final ItemInstance item = items.get(i); out.write(item.getObjectId() + ";"); out.write(item.getItemId() + ";"); out.write(item.getItem().getName() + ";"); @@ -578,11 +578,11 @@ public class ClientThread extends Thread String line = null; while ((line = ((LineNumberReader) lnr).readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, ";"); - ItemInstance item = new ItemInstance(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final ItemInstance item = new ItemInstance(); item.setObjectId(Integer.parseInt(st.nextToken())); - int itemId = Integer.parseInt(st.nextToken()); - Item itemTemp = ItemTable.getInstance().getTemplate(itemId); + final int itemId = Integer.parseInt(st.nextToken()); + final Item itemTemp = ItemTable.getInstance().getTemplate(itemId); item.setItem(itemTemp); st.nextToken(); item.setCount(Integer.parseInt(st.nextToken())); @@ -625,11 +625,11 @@ public class ClientThread extends Thread String line = null; while ((line = ((LineNumberReader) lnr).readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, ";"); - int id = Integer.parseInt(st.nextToken()); - int level = Integer.parseInt(st.nextToken()); + final StringTokenizer st = new StringTokenizer(line, ";"); + final int id = Integer.parseInt(st.nextToken()); + final int level = Integer.parseInt(st.nextToken()); st.nextToken(); - Skill skill = SkillTable.getInstance().getInfo(id, level); + final Skill skill = SkillTable.getInstance().getInfo(id, level); cha.addSkill(skill); } } @@ -654,14 +654,14 @@ public class ClientThread extends Thread private PlayerInstance restoreChar(File charFile) { - PlayerInstance oldChar = new PlayerInstance(); + final PlayerInstance oldChar = new PlayerInstance(); BufferedReader lnr = null; try { lnr = new LineNumberReader(new BufferedReader(new FileReader(charFile))); ((LineNumberReader) lnr).readLine(); - String line = ((LineNumberReader) lnr).readLine(); - StringTokenizer st = new StringTokenizer(line, ";"); + final String line = ((LineNumberReader) lnr).readLine(); + final StringTokenizer st = new StringTokenizer(line, ";"); oldChar.setObjectId(Integer.parseInt(st.nextToken())); oldChar.setName(st.nextToken()); oldChar.setLevel(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Connection.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Connection.java index ac34179af0..14a1b05677 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Connection.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Connection.java @@ -60,7 +60,7 @@ public class Connection // _log.warning("client terminated connection"); throw new IOException("EOF"); } - byte[] incoming = new byte[length]; + final byte[] incoming = new byte[length]; incoming[0] = (byte) lengthLo; incoming[1] = (byte) lengthHi; int newBytes = 0; @@ -73,7 +73,7 @@ public class Connection _log.warning("Incomplete Packet is sent to the server, closing connection."); throw new IOException(); } - byte[] decrypt = new byte[incoming.length - 2]; + final byte[] decrypt = new byte[incoming.length - 2]; System.arraycopy(incoming, 2, decrypt, 0, decrypt.length); _inCrypt.decrypt(decrypt); // int packetType = decrypt[0] & 0xFF; @@ -82,12 +82,12 @@ public class Connection public void sendPacket(byte[] data) throws IOException { - Connection connection = this; + final Connection connection = this; synchronized (connection) { // _log.config("\n" + printData(data, data.length)); _outCrypt.encrypt(data); - int length = data.length + 2; + final int length = data.length + 2; _out.write(length & 0xFF); _out.write((length >> 8) & 0xFF); _out.flush(); @@ -98,7 +98,7 @@ public class Connection public void sendPacket(ServerBasePacket bp) throws IOException { - byte[] data = bp.getContent(); + final byte[] data = bp.getContent(); this.sendPacket(data); } @@ -124,7 +124,7 @@ public class Connection int a; int charpoint; byte t1; - StringBuffer result = new StringBuffer(); + final StringBuffer result = new StringBuffer(); int counter = 0; for (int i = 0; i < len; ++i) { @@ -151,7 +151,7 @@ public class Connection result.append("\n"); counter = 0; } - int rest = data.length % 16; + final int rest = data.length % 16; if (rest > 0) { for (int i = 0; i < (17 - rest); ++i) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Crypt.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Crypt.java index 0a72ad86ac..7d885b0283 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Crypt.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/Crypt.java @@ -37,7 +37,7 @@ public class Crypt int j = 0; for (int i = 0; i < raw.length; ++i) { - int temp2 = raw[i] & 0xFF; + final int temp2 = raw[i] & 0xFF; raw[i] = (byte) (temp2 ^ (_key[j++] & 0xFF) ^ temp); temp = temp2; if (j <= 7) @@ -67,7 +67,7 @@ public class Crypt int j = 0; for (int i = 0; i < raw.length; ++i) { - int temp2 = raw[i] & 0xFF; + final int temp2 = raw[i] & 0xFF; raw[i] = (byte) (temp2 ^ (_key[j++] & 0xFF) ^ temp); temp = raw[i]; if (j <= 7) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/PacketHandler.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/PacketHandler.java index 0426b4ea8b..29e0d7df48 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/PacketHandler.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/PacketHandler.java @@ -115,7 +115,7 @@ public class PacketHandler public void handlePacket(byte[] data) throws IOException { - int id = data[0] & 0xFF; + final int id = data[0] & 0xFF; switch (id) { case 0: @@ -544,7 +544,7 @@ public class PacketHandler int a; int charpoint; byte t1; - StringBuffer result = new StringBuffer(); + final StringBuffer result = new StringBuffer(); int counter = 0; for (int i = 0; i < len; ++i) { @@ -571,7 +571,7 @@ public class PacketHandler result.append("\n"); counter = 0; } - int rest = data.length % 16; + final int rest = data.length % 16; if (rest > 0) { for (int i = 0; i < (17 - rest); ++i) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Action.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Action.java index 9535998952..ccca7d9b0f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Action.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Action.java @@ -30,16 +30,16 @@ public class Action extends ClientBasePacket public Action(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); + final int objectId = readD(); @SuppressWarnings("unused") - int originX = readD(); + final int originX = readD(); @SuppressWarnings("unused") - int originY = readD(); + final int originY = readD(); @SuppressWarnings("unused") - int originZ = readD(); - int actionId = readC(); - PlayerInstance activeChar = client.getActiveChar(); - WorldObject obj = World.getInstance().findObject(objectId); + final int originZ = readD(); + final int actionId = readC(); + final PlayerInstance activeChar = client.getActiveChar(); + final WorldObject obj = World.getInstance().findObject(objectId); if ((obj != null) && !activeChar.isDead() && (activeChar.getPrivateStoreType() == 0) && (activeChar.getTransactionRequester() == null)) { switch (actionId) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AddTradeItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AddTradeItem.java index c57bd4a2f2..993527fd5b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AddTradeItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AddTradeItem.java @@ -34,21 +34,21 @@ public class AddTradeItem extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int tradeId = readD(); - int objectId = readD(); - int amount = readD(); - PlayerInstance player = client.getActiveChar(); - PlayerInstance requestor = player.getTransactionRequester(); + final int tradeId = readD(); + final int objectId = readD(); + final int amount = readD(); + final PlayerInstance player = client.getActiveChar(); + final PlayerInstance requestor = player.getTransactionRequester(); if (requestor.getTransactionRequester() != null) { - TradeList playerItemList = player.getTradeList(); + final TradeList playerItemList = player.getTradeList(); player.getTradeList().setConfirmedTrade(false); requestor.getTradeList().setConfirmedTrade(false); if (playerItemList.getItems().size() > 0) { if (!playerItemList.contains(objectId)) { - ItemInstance temp = new ItemInstance(); + final ItemInstance temp = new ItemInstance(); temp.setObjectId(player.getInventory().getItem(objectId).getObjectId()); temp.setCount(amount); playerItemList.addItem(temp); @@ -58,7 +58,7 @@ public class AddTradeItem extends ClientBasePacket else { ItemInstance tempTradeItem; - int InvItemCount = player.getInventory().getItem(objectId).getCount(); + final int InvItemCount = player.getInventory().getItem(objectId).getCount(); if (InvItemCount != (tempTradeItem = playerItemList.getItem(objectId)).getCount()) { if ((amount + tempTradeItem.getCount()) >= InvItemCount) @@ -78,7 +78,7 @@ public class AddTradeItem extends ClientBasePacket } else { - ItemInstance temp = new ItemInstance(); + final ItemInstance temp = new ItemInstance(); temp.setObjectId(objectId); temp.setCount(amount); playerItemList.addItem(temp); @@ -89,7 +89,7 @@ public class AddTradeItem extends ClientBasePacket else { player.sendPacket(new SendTradeDone(0)); - SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); + final SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); player.sendPacket(msg); player.setTransactionRequester(null); requestor.getTradeList().getItems().clear(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AnswerTradeRequest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AnswerTradeRequest.java index b4fa9f04fb..b796edf62b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AnswerTradeRequest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AnswerTradeRequest.java @@ -31,9 +31,9 @@ public class AnswerTradeRequest extends ClientBasePacket public AnswerTradeRequest(byte[] decrypt, ClientThread client) { super(decrypt); - int response = readD(); - PlayerInstance player = client.getActiveChar(); - PlayerInstance requestor = player.getTransactionRequester(); + final int response = readD(); + final PlayerInstance player = client.getActiveChar(); + final PlayerInstance requestor = player.getTransactionRequester(); if (requestor.getTransactionRequester() != null) { if (response == 1) @@ -57,7 +57,7 @@ public class AnswerTradeRequest extends ClientBasePacket } else { - SystemMessage msg = new SystemMessage(SystemMessage.S1_DENIED_TRADE_REQUEST); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_DENIED_TRADE_REQUEST); msg.addString(player.getName()); requestor.sendPacket(msg); requestor.setTransactionRequester(null); @@ -67,7 +67,7 @@ public class AnswerTradeRequest extends ClientBasePacket else if (response != 0) { player.sendPacket(new SendTradeDone(0)); - SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); + final SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); player.sendPacket(msg); player.setTransactionRequester(null); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Appearing.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Appearing.java index 6b971edff0..32097ab056 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Appearing.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Appearing.java @@ -40,10 +40,10 @@ public class Appearing extends ClientBasePacket public Appearing(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); activeChar.removeAllKnownObjects(); - Connection con = client.getConnection(); - UserInfo ui = new UserInfo(activeChar); + final Connection con = client.getConnection(); + final UserInfo ui = new UserInfo(activeChar); con.sendPacket(ui); for (WorldObject worldObject : World.getInstance().getVisibleObjects(activeChar, 2000)) { @@ -52,7 +52,7 @@ public class Appearing extends ClientBasePacket activeChar.addKnownObject(worldObject); if (worldObject instanceof ItemInstance) { - SpawnItem si = new SpawnItem((ItemInstance) worldObject); + final SpawnItem si = new SpawnItem((ItemInstance) worldObject); con.sendPacket(si); continue; } @@ -76,7 +76,7 @@ public class Appearing extends ClientBasePacket { continue; } - PlayerInstance player = (PlayerInstance) worldObject; + final PlayerInstance player = (PlayerInstance) worldObject; con.sendPacket(new CharInfo(player)); player.addKnownObject(activeChar); player.getNetConnection().sendPacket(new CharInfo(activeChar)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AttackRequest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AttackRequest.java index f7e5bef687..bb54d4c9da 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AttackRequest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AttackRequest.java @@ -30,17 +30,17 @@ public class AttackRequest extends ClientBasePacket public AttackRequest(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); + final int objectId = readD(); @SuppressWarnings("unused") - int originX = readD(); + final int originX = readD(); @SuppressWarnings("unused") - int originY = readD(); + final int originY = readD(); @SuppressWarnings("unused") - int originZ = readD(); + final int originZ = readD(); @SuppressWarnings("unused") - int attackId = readC(); - PlayerInstance activeChar = client.getActiveChar(); - WorldObject target = World.getInstance().findObject(objectId); + final int attackId = readC(); + final PlayerInstance activeChar = client.getActiveChar(); + final WorldObject target = World.getInstance().findObject(objectId); if ((target != null) && (activeChar.getTarget() != target)) { target.onAction(activeChar); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AuthLogin.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AuthLogin.java index 4456dae0c7..f2abccae47 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AuthLogin.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/AuthLogin.java @@ -31,12 +31,12 @@ public class AuthLogin extends ClientBasePacket public AuthLogin(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - String loginName = readS().toLowerCase(); + final String loginName = readS().toLowerCase(); @SuppressWarnings("unused") - long key1 = readD(); - long key2 = readD(); + final long key1 = readD(); + final long key2 = readD(); - int access = LoginController.getInstance().getGmAccessLevel(loginName); + final int access = LoginController.getInstance().getGmAccessLevel(loginName); if (!LoginController.getInstance().loginPossible(access)) { _log.warning("Server is full. client is blocked: " + loginName); @@ -45,7 +45,7 @@ public class AuthLogin extends ClientBasePacket } client.setLoginName(loginName); client.setLoginFolder(loginName); - int sessionKey = LoginController.getInstance().getKeyForAccount(loginName); + final int sessionKey = LoginController.getInstance().getKeyForAccount(loginName); if (sessionKey != key2) { _log.warning("session key is not correct. closing connection"); @@ -54,7 +54,7 @@ public class AuthLogin extends ClientBasePacket else { LoginController.getInstance().addGameServerLogin(loginName, client.getConnection()); - CharSelectInfo cl = new CharSelectInfo(loginName, client.getSessionId()); + final CharSelectInfo cl = new CharSelectInfo(loginName, client.getSessionId()); client.getConnection().sendPacket(cl); } client.setAccessLevel(access); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeMoveType2.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeMoveType2.java index afdd63a276..4014d48a40 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeMoveType2.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeMoveType2.java @@ -27,8 +27,8 @@ public class ChangeMoveType2 extends ClientBasePacket public ChangeMoveType2(byte[] decrypt, ClientThread client) { super(decrypt); - int type = readD(); - ChangeMoveType cmt = new ChangeMoveType(client.getActiveChar(), type); + final int type = readD(); + final ChangeMoveType cmt = new ChangeMoveType(client.getActiveChar(), type); client.getActiveChar().setMoveType(type); client.getActiveChar().sendPacket(cmt); client.getActiveChar().broadcastPacket(cmt); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeWaitType2.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeWaitType2.java index 9b92cbbe83..18d4944058 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeWaitType2.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ChangeWaitType2.java @@ -27,8 +27,8 @@ public class ChangeWaitType2 extends ClientBasePacket public ChangeWaitType2(byte[] decrypt, ClientThread client) { super(decrypt); - int type = readD(); - ChangeWaitType cwt = new ChangeWaitType(client.getActiveChar(), type); + final int type = readD(); + final ChangeWaitType cwt = new ChangeWaitType(client.getActiveChar(), type); client.getActiveChar().setWaitType(type); client.getActiveChar().sendPacket(cwt); client.getActiveChar().broadcastPacket(cwt); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterCreate.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterCreate.java index 04f7b2573a..5d2acd7a5e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterCreate.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterCreate.java @@ -43,7 +43,7 @@ public class CharacterCreate extends ClientBasePacket public CharacterCreate(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - PlayerInstance newChar = new PlayerInstance(); + final PlayerInstance newChar = new PlayerInstance(); newChar.setName(readS()); newChar.setRace(readD()); newChar.setSex(readD()); @@ -59,19 +59,19 @@ public class CharacterCreate extends ClientBasePacket newChar.setFace(readD()); if (CharNameTable.getInstance().doesCharNameExist(newChar.getName())) { - CharCreateFail ccf = new CharCreateFail(CharCreateFail.REASON_NAME_ALREADY_EXISTS); + final CharCreateFail ccf = new CharCreateFail(CharCreateFail.REASON_NAME_ALREADY_EXISTS); client.getConnection().sendPacket(ccf); } else if ((newChar.getName().length() <= 16) && isAlphaNumeric(newChar.getName())) { - CharCreateOk cco = new CharCreateOk(); + final CharCreateOk cco = new CharCreateOk(); client.getConnection().sendPacket(cco); initNewChar(client, newChar); CharNameTable.getInstance().addCharName(newChar.getName()); } else { - CharCreateFail ccf = new CharCreateFail(CharCreateFail.REASON_16_ENG_CHARS); + final CharCreateFail ccf = new CharCreateFail(CharCreateFail.REASON_16_ENG_CHARS); client.getConnection().sendPacket(ccf); } } @@ -79,7 +79,7 @@ public class CharacterCreate extends ClientBasePacket private boolean isAlphaNumeric(String text) { boolean result = true; - char[] chars = text.toCharArray(); + final char[] chars = text.toCharArray(); for (char c : chars) { if (Character.isLetterOrDigit(c)) @@ -96,7 +96,7 @@ public class CharacterCreate extends ClientBasePacket { newChar.setObjectId(IdFactory.getInstance().getNextId()); World.getInstance().storeObject(newChar); - CharTemplate template = CharTemplateTable.getInstance().getTemplate(newChar.getClassId()); + final CharTemplate template = CharTemplateTable.getInstance().getTemplate(newChar.getClassId()); newChar.setAccuracy(template.getAcc()); newChar.setCon(template.getCon()); newChar.setCriticalHit(template.getCrit()); @@ -144,10 +144,10 @@ public class CharacterCreate extends ClientBasePacket newChar.setCollisionRadius(template.getFColR()); newChar.setCollisionHeight(template.getFColH()); } - ItemTable itemTable = ItemTable.getInstance(); + final ItemTable itemTable = ItemTable.getInstance(); for (Integer item2 : template.getItems()) { - ItemInstance item = itemTable.createItem(item2); + final ItemInstance item = itemTable.createItem(item2); newChar.getInventory().addItem(item); } newChar.setTitle(""); @@ -157,7 +157,7 @@ public class CharacterCreate extends ClientBasePacket newChar.addSkill(SkillTable.getInstance().getInfo(startSkill.getId(), startSkill.getLevel())); } client.saveCharToDisk(newChar); - CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); + final CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); client.getConnection().sendPacket(cl); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterDelete.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterDelete.java index e21bfbc0e2..6118503054 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterDelete.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterDelete.java @@ -31,12 +31,12 @@ public class CharacterDelete extends ClientBasePacket public CharacterDelete(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int charSlot = readD(); - Connection con = client.getConnection(); + final int charSlot = readD(); + final Connection con = client.getConnection(); client.deleteCharFromDisk(charSlot); - CharDeleteOk ccf = new CharDeleteOk(); + final CharDeleteOk ccf = new CharDeleteOk(); con.sendPacket(ccf); - CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); + final CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); con.sendPacket(cl); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterRestore.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterRestore.java index 9303001bbb..42d99af3e6 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterRestore.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterRestore.java @@ -30,8 +30,8 @@ public class CharacterRestore extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int charSlot = readD(); - CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); + final int charSlot = readD(); + final CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); client.getConnection().sendPacket(cl); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterSelected.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterSelected.java index 42dabd1011..3fc7b6b1f4 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterSelected.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/CharacterSelected.java @@ -30,11 +30,11 @@ public class CharacterSelected extends ClientBasePacket public CharacterSelected(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int charSlot = readD(); - PlayerInstance cha = client.loadCharFromDisk(charSlot); + final int charSlot = readD(); + final PlayerInstance cha = client.loadCharFromDisk(charSlot); cha.setMoveType(1); cha.setWaitType(1); - CharSelected cs = new CharSelected(cha, client.getSessionId()); + final CharSelected cs = new CharSelected(cha, client.getSessionId()); client.getConnection().sendPacket(cs); client.setActiveChar(cha); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ClientBasePacket.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ClientBasePacket.java index 5891bd4c91..4732e8f15e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ClientBasePacket.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ClientBasePacket.java @@ -43,7 +43,7 @@ public abstract class ClientBasePacket public int readC() { - int result = _decrypt[_off++] & 0xFF; + final int result = _decrypt[_off++] & 0xFF; return result; } @@ -83,7 +83,7 @@ public abstract class ClientBasePacket public byte[] readB(int length) { - byte[] result = new byte[length]; + final byte[] result = new byte[length]; System.arraycopy(_decrypt, _off, result, 0, length); _off += length; return result; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/EnterWorld.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/EnterWorld.java index cde614858d..199830db73 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/EnterWorld.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/EnterWorld.java @@ -40,22 +40,22 @@ public class EnterWorld extends ClientBasePacket public EnterWorld(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - PlayerInstance activeChar = client.getActiveChar(); - Connection con = client.getConnection(); + final PlayerInstance activeChar = client.getActiveChar(); + final Connection con = client.getConnection(); if (client.getAccessLevel() >= 100) { activeChar.setIsGM(true); GmListManager.getInstance().addGm(activeChar); } - SystemMessage sm = new SystemMessage(SystemMessage.WELCOME_TO_LINEAGE); + final SystemMessage sm = new SystemMessage(SystemMessage.WELCOME_TO_LINEAGE); con.sendPacket(sm); Announcements.getInstance().showAnnouncements(activeChar); - ItemList il = new ItemList(activeChar, false); + final ItemList il = new ItemList(activeChar, false); activeChar.sendPacket(il); - ShortCutInit sci = new ShortCutInit(); + final ShortCutInit sci = new ShortCutInit(); for (ShortCut shortcut : activeChar.getAllShortCuts()) { switch (shortcut.getType()) @@ -83,7 +83,7 @@ public class EnterWorld extends ClientBasePacket } con.sendPacket(sci); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); con.sendPacket(ui); if (activeChar.isDead()) { @@ -95,11 +95,11 @@ public class EnterWorld extends ClientBasePacket private void notifyClanMembers(PlayerInstance activeChar) { - Clan clan = activeChar.getClan(); + final Clan clan = activeChar.getClan(); if (clan != null) { clan.getClanMember(activeChar.getName()).setPlayerInstance(activeChar); - SystemMessage msg = new SystemMessage(SystemMessage.CLAN_MEMBER_S1_LOGGED_IN); + final SystemMessage msg = new SystemMessage(SystemMessage.CLAN_MEMBER_S1_LOGGED_IN); msg.addString(activeChar.getName()); for (PlayerInstance clanMember : clan.getOnlineMembers(activeChar.getName())) { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/FinishRotating.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/FinishRotating.java index 5822ee2575..5b7d9ee391 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/FinishRotating.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/FinishRotating.java @@ -27,10 +27,10 @@ public class FinishRotating extends ClientBasePacket public FinishRotating(byte[] decrypt, ClientThread client) { super(decrypt); - int degree = readD(); + final int degree = readD(); @SuppressWarnings("unused") - int unknown = readD(); - StopRotation sr = new StopRotation(client.getActiveChar(), degree); + final int unknown = readD(); + final StopRotation sr = new StopRotation(client.getActiveChar(), degree); client.getActiveChar().sendPacket(sr); client.getActiveChar().broadcastPacket(sr); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Logout.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Logout.java index 97040c0ee0..38e6c86a72 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Logout.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Logout.java @@ -32,7 +32,7 @@ public class Logout extends ClientBasePacket { super(decrypt); - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); if (player != null) { if ((player.getPvpFlag() > 0) || player.isInCombat()) @@ -41,7 +41,7 @@ public class Logout extends ClientBasePacket player.sendPacket(new ActionFailed()); return; } - LeaveWorld ql = new LeaveWorld(); + final LeaveWorld ql = new LeaveWorld(); client.getConnection().sendPacket(ql); player.deleteMe(); client.saveCharToDisk(player); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/MoveBackwardToLocation.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/MoveBackwardToLocation.java index f702420cc1..88f772c529 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/MoveBackwardToLocation.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/MoveBackwardToLocation.java @@ -30,13 +30,13 @@ public class MoveBackwardToLocation extends ClientBasePacket public MoveBackwardToLocation(byte[] decrypt, ClientThread client) { super(decrypt); - int targetX = readD(); - int targetY = readD(); - int targetZ = readD(); - int originX = readD(); - int originY = readD(); - int originZ = readD(); - PlayerInstance activeChar = client.getActiveChar(); + final int targetX = readD(); + final int targetY = readD(); + final int targetZ = readD(); + final int originX = readD(); + final int originY = readD(); + final int originZ = readD(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.getCurrentState() == CreatureState.CASTING) { activeChar.sendPacket(new ActionFailed()); @@ -45,7 +45,7 @@ public class MoveBackwardToLocation extends ClientBasePacket { if (activeChar.getCurrentState() == CreatureState.ATTACKING) { - AttackCanceld ac = new AttackCanceld(activeChar.getObjectId()); + final AttackCanceld ac = new AttackCanceld(activeChar.getObjectId()); activeChar.sendPacket(ac); activeChar.broadcastPacket(ac); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/NewCharacter.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/NewCharacter.java index 5d757528e4..896bba173a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/NewCharacter.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/NewCharacter.java @@ -31,7 +31,7 @@ public class NewCharacter extends ClientBasePacket public NewCharacter(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - CharTemplates ct = new CharTemplates(); + final CharTemplates ct = new CharTemplates(); CharTemplate template = CharTemplateTable.getInstance().getTemplate(0); ct.addChar(template); template = CharTemplateTable.getInstance().getTemplate(0); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ProtocolVersion.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ProtocolVersion.java index 35125d580f..55504140e0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ProtocolVersion.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ProtocolVersion.java @@ -31,7 +31,7 @@ public class ProtocolVersion extends ClientBasePacket public ProtocolVersion(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - int version = readD(); + final int version = readD(); // this packet is never encrypted if (version == -2) @@ -44,8 +44,8 @@ public class ProtocolVersion extends ClientBasePacket } else { - Connection con = client.getConnection(); - KeyPacket pk = new KeyPacket(); + final Connection con = client.getConnection(); + final KeyPacket pk = new KeyPacket(); pk.setKey(con.getCryptKey()); con.sendPacket(pk); con.activateCryptKey(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestActionUse.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestActionUse.java index 3879fc3256..ca7de3828e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestActionUse.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestActionUse.java @@ -33,13 +33,13 @@ public class RequestActionUse extends ClientBasePacket public RequestActionUse(byte[] rawPacket, ClientThread client) { super(rawPacket); - int actionId = readD(); + final int actionId = readD(); @SuppressWarnings("unused") - int data2 = readD(); + final int data2 = readD(); @SuppressWarnings("unused") - int data3 = readC(); + final int data3 = readC(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.isDead()) { activeChar.sendPacket(new ActionFailed()); @@ -49,8 +49,8 @@ public class RequestActionUse extends ClientBasePacket { case 0: { - int waitType = activeChar.getWaitType() ^ 1; - ChangeWaitType cmt = new ChangeWaitType(activeChar, waitType); + final int waitType = activeChar.getWaitType() ^ 1; + final ChangeWaitType cmt = new ChangeWaitType(activeChar, waitType); activeChar.setWaitType(waitType); activeChar.sendPacket(cmt); activeChar.broadcastPacket(cmt); @@ -58,8 +58,8 @@ public class RequestActionUse extends ClientBasePacket } case 1: { - int moveType = activeChar.getMoveType() ^ 1; - ChangeMoveType cmt = new ChangeMoveType(activeChar, moveType); + final int moveType = activeChar.getMoveType() ^ 1; + final ChangeMoveType cmt = new ChangeMoveType(activeChar, moveType); activeChar.setMoveType(moveType); activeChar.sendPacket(cmt); activeChar.broadcastPacket(cmt); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAllyCrest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAllyCrest.java index c6d11c19a5..f4b940c25d 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAllyCrest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAllyCrest.java @@ -30,11 +30,11 @@ public class RequestAllyCrest extends ClientBasePacket public RequestAllyCrest(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - int crestId = readD(); - File crestFile = new File("data/allycrest_" + crestId + ".bmp"); + final int crestId = readD(); + final File crestFile = new File("data/allycrest_" + crestId + ".bmp"); if (crestFile.exists()) { - AllyCrest ac = new AllyCrest(crestId, crestFile); + final AllyCrest ac = new AllyCrest(crestId, crestFile); client.getConnection().sendPacket(ac); } else diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinParty.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinParty.java index 5c4acd67b5..94ea0635b0 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinParty.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinParty.java @@ -29,10 +29,10 @@ public class RequestAnswerJoinParty extends ClientBasePacket public RequestAnswerJoinParty(byte[] decrypt, ClientThread client) { super(decrypt); - int response = readD(); - PlayerInstance player = client.getActiveChar(); - PlayerInstance requestor = player.getTransactionRequester(); - JoinParty join = new JoinParty(response); + final int response = readD(); + final PlayerInstance player = client.getActiveChar(); + final PlayerInstance requestor = player.getTransactionRequester(); + final JoinParty join = new JoinParty(response); requestor.sendPacket(join); if (response == 1) { @@ -40,7 +40,7 @@ public class RequestAnswerJoinParty extends ClientBasePacket } else { - SystemMessage msg = new SystemMessage(SystemMessage.PLAYER_DECLINED); + final SystemMessage msg = new SystemMessage(SystemMessage.PLAYER_DECLINED); requestor.sendPacket(msg); if (requestor.getParty().getMemberCount() == 1) { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinPledge.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinPledge.java index 334309f5be..1f8600d7fd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinPledge.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAnswerJoinPledge.java @@ -35,27 +35,27 @@ public class RequestAnswerJoinPledge extends ClientBasePacket public RequestAnswerJoinPledge(byte[] rawPacket, ClientThread client) { super(rawPacket); - int answer = readD(); + final int answer = readD(); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); - PlayerInstance requestor = activeChar.getTransactionRequester(); + final PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance requestor = activeChar.getTransactionRequester(); if (answer == 1) { - JoinPledge jp = new JoinPledge(requestor.getClanId()); + final JoinPledge jp = new JoinPledge(requestor.getClanId()); activeChar.sendPacket(jp); - Clan clan = requestor.getClan(); + final Clan clan = requestor.getClan(); clan.addClanMember(activeChar); clan.store(); activeChar.setClanId(clan.getClanId()); activeChar.setClan(clan); - PledgeShowInfoUpdate pu = new PledgeShowInfoUpdate(clan, activeChar); + final PledgeShowInfoUpdate pu = new PledgeShowInfoUpdate(clan, activeChar); activeChar.sendPacket(pu); activeChar.sendPacket(new UserInfo(activeChar)); activeChar.broadcastPacket(new CharInfo(activeChar)); SystemMessage sm = new SystemMessage(SystemMessage.ENTERED_THE_CLAN); activeChar.sendPacket(sm); // ClanMember[] members = clan.getMembers(); - PledgeShowMemberListAdd la = new PledgeShowMemberListAdd(activeChar); + final PledgeShowMemberListAdd la = new PledgeShowMemberListAdd(activeChar); sm = new SystemMessage(SystemMessage.S1_HAS_JOINED_CLAN); sm.addString(activeChar.getName()); clan.broadcastToOnlineMembers(la); @@ -64,7 +64,7 @@ public class RequestAnswerJoinPledge extends ClientBasePacket } else { - SystemMessage sm = new SystemMessage(SystemMessage.S1_REFUSED_TO_JOIN_CLAN); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_REFUSED_TO_JOIN_CLAN); sm.addString(activeChar.getName()); requestor.sendPacket(sm); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkill.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkill.java index ddb1d96ead..f95671a887 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkill.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkill.java @@ -39,10 +39,10 @@ public class RequestAquireSkill extends ClientBasePacket public RequestAquireSkill(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - PlayerInstance player = client.getActiveChar(); - int id = readD(); - int level = readD(); - Skill skill = SkillTable.getInstance().getInfo(id, level); + final PlayerInstance player = client.getActiveChar(); + final int id = readD(); + final int level = readD(); + final Skill skill = SkillTable.getInstance().getInfo(id, level); Collection skills = SkillTreeTable.getInstance().getAvailableSkills(player); int _requiredSp = 0; for (SkillLearn skill2 : skills) @@ -58,10 +58,10 @@ public class RequestAquireSkill extends ClientBasePacket { player.addSkill(skill); player.setSp(player.getSp() - _requiredSp); - StatusUpdate su = new StatusUpdate(player.getObjectId()); + final StatusUpdate su = new StatusUpdate(player.getObjectId()); su.addAttribute(StatusUpdate.SP, player.getSp()); player.sendPacket(su); - SystemMessage sm = new SystemMessage(SystemMessage.LEARNED_SKILL_S1); + final SystemMessage sm = new SystemMessage(SystemMessage.LEARNED_SKILL_S1); sm.addSkillName(id); player.sendPacket(sm); if (level > 1) @@ -79,11 +79,11 @@ public class RequestAquireSkill extends ClientBasePacket } else { - SystemMessage sm = new SystemMessage(SystemMessage.NOT_ENOUGH_SP_TO_LEARN_SKILL); + final SystemMessage sm = new SystemMessage(SystemMessage.NOT_ENOUGH_SP_TO_LEARN_SKILL); player.sendPacket(sm); } skills = SkillTreeTable.getInstance().getAvailableSkills(player); - AquireSkillList asl = new AquireSkillList(); + final AquireSkillList asl = new AquireSkillList(); for (SkillLearn skill2 : skills) { asl.addSkill(skill2.getId(), skill2.getLevel(), skill2.getLevel(), skill2.getSpCost(), 0); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkillInfo.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkillInfo.java index ec1c091946..24803c9b50 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkillInfo.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestAquireSkillInfo.java @@ -35,11 +35,11 @@ public class RequestAquireSkillInfo extends ClientBasePacket public RequestAquireSkillInfo(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - PlayerInstance activeChar = client.getActiveChar(); - Connection con = client.getConnection(); - int id = readD(); - int level = readD(); - Skill skill = SkillTable.getInstance().getInfo(id, level); + final PlayerInstance activeChar = client.getActiveChar(); + final Connection con = client.getConnection(); + final int id = readD(); + final int level = readD(); + final Skill skill = SkillTable.getInstance().getInfo(id, level); int requiredSp = 0; for (SkillLearn skill2 : SkillTreeTable.getInstance().getAvailableSkills(activeChar)) { @@ -50,7 +50,7 @@ public class RequestAquireSkillInfo extends ClientBasePacket requiredSp = skill2.getSpCost(); break; } - AquireSkillInfo asi = new AquireSkillInfo(skill.getId(), skill.getLevel(), requiredSp); + final AquireSkillInfo asi = new AquireSkillInfo(skill.getId(), skill.getLevel(), requiredSp); con.sendPacket(asi); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBuyItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBuyItem.java index 83293fc12b..9a28f8a746 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBuyItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBuyItem.java @@ -38,26 +38,26 @@ public class RequestBuyItem extends ClientBasePacket { super(decrypt); int i; - int listId = readD(); - int count = readD(); - ItemInstance[] items = new ItemInstance[count]; + final int listId = readD(); + final int count = readD(); + final ItemInstance[] items = new ItemInstance[count]; for (int i2 = 0; i2 < count; ++i2) { - int itemId = readD(); - int cnt = readD(); - ItemInstance inst = ItemTable.getInstance().createItem(itemId); + final int itemId = readD(); + final int cnt = readD(); + final ItemInstance inst = ItemTable.getInstance().createItem(itemId); inst.setCount(cnt); items[i2] = inst; } - PlayerInstance activeChar = client.getActiveChar(); - Connection con = client.getConnection(); + final PlayerInstance activeChar = client.getActiveChar(); + final Connection con = client.getConnection(); double neededMoney = 0.0; - long currentMoney = activeChar.getAdena(); - TradeList list = TradeController.getInstance().getBuyList(listId); + final long currentMoney = activeChar.getAdena(); + final TradeList list = TradeController.getInstance().getBuyList(listId); for (i = 0; i < items.length; ++i) { - double count2 = items[i].getCount(); - int id = items[i].getItemId(); + final double count2 = items[i].getCount(); + final int id = items[i].getItemId(); int price = list.getPriceForItemId(id); if (price == -1) { @@ -68,7 +68,7 @@ public class RequestBuyItem extends ClientBasePacket } if ((neededMoney > currentMoney) || (neededMoney < 0.0) || (currentMoney <= 0L)) { - SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); con.sendPacket(sm); return; } @@ -77,9 +77,9 @@ public class RequestBuyItem extends ClientBasePacket { activeChar.getInventory().addItem(items[i]); } - ItemList il = new ItemList(activeChar, false); + final ItemList il = new ItemList(activeChar, false); con.sendPacket(il); - StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); + final StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); su.addAttribute(StatusUpdate.CUR_LOAD, activeChar.getCurrentLoad()); activeChar.sendPacket(su); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBypassToServer.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBypassToServer.java index 1792f5169a..2d7715553e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBypassToServer.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestBypassToServer.java @@ -32,7 +32,7 @@ public class RequestBypassToServer extends ClientBasePacket public RequestBypassToServer(byte[] decrypt, ClientThread client) { super(decrypt); - String command = readS(); + final String command = readS(); try { if (command.startsWith("admin_") && (client.getAccessLevel() >= 100)) @@ -45,9 +45,9 @@ public class RequestBypassToServer extends ClientBasePacket } else if (command.startsWith("npc_")) { - int endOfId = command.indexOf(95, 5); - String id = command.substring(4, endOfId); - WorldObject object = World.getInstance().findObject(Integer.parseInt(id)); + final int endOfId = command.indexOf(95, 5); + final String id = command.substring(4, endOfId); + final WorldObject object = World.getInstance().findObject(Integer.parseInt(id)); if (object instanceof NpcInstance) { ((NpcInstance) object).onBypassFeedback(client.getActiveChar(), command.substring(endOfId + 1)); @@ -66,11 +66,11 @@ public class RequestBypassToServer extends ClientBasePacket private void comeHere(ClientThread client) { - WorldObject obj = client.getActiveChar().getTarget(); + final WorldObject obj = client.getActiveChar().getTarget(); if (obj instanceof NpcInstance) { - NpcInstance temp = (NpcInstance) obj; - PlayerInstance player = client.getActiveChar(); + final NpcInstance temp = (NpcInstance) obj; + final PlayerInstance player = client.getActiveChar(); temp.setTarget(player); temp.moveTo(player.getX(), player.getY(), player.getZ(), 0); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDestroyItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDestroyItem.java index 0541ffb7c4..ac4d0b88d5 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDestroyItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDestroyItem.java @@ -35,9 +35,9 @@ public class RequestDestroyItem extends ClientBasePacket super(decrypt); InventoryUpdate iu; ItemInstance itemToRemove; - int objectId = readD(); + final int objectId = readD(); int count = readD(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (count == 0) { return; @@ -59,7 +59,7 @@ public class RequestDestroyItem extends ClientBasePacket activeChar.updateMDef(); activeChar.updateMAtk(); } - ItemInstance removedItem = activeChar.getInventory().destroyItem(objectId, count); + final ItemInstance removedItem = activeChar.getInventory().destroyItem(objectId, count); iu = new InventoryUpdate(); if (removedItem.getCount() == 0) { @@ -70,14 +70,14 @@ public class RequestDestroyItem extends ClientBasePacket iu.addModifiedItem(removedItem); } activeChar.sendPacket(iu); - StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); + final StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); su.addAttribute(StatusUpdate.CUR_LOAD, activeChar.getCurrentLoad()); activeChar.sendPacket(su); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); activeChar.sendPacket(ui); - CharInfo info = new CharInfo(activeChar); + final CharInfo info = new CharInfo(activeChar); activeChar.broadcastPacket(info); - World world = World.getInstance(); + final World world = World.getInstance(); world.removeObject(removedItem); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDropItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDropItem.java index 1eda002cd5..223f9d4e4e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDropItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestDropItem.java @@ -37,26 +37,26 @@ public class RequestDropItem extends ClientBasePacket public RequestDropItem(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int objectId = readD(); - int count = readD(); - int x = readD(); - int y = readD(); - int z = readD(); + final int objectId = readD(); + final int count = readD(); + final int x = readD(); + final int y = readD(); + final int z = readD(); if (count == 0) { return; } if ((client.getActiveChar().getPrivateStoreType() == 0) && (client.getActiveChar().getTransactionRequester() == null)) { - Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); - ItemInstance oldItem = activeChar.getInventory().getItem(objectId); + final Connection con = client.getConnection(); + final PlayerInstance activeChar = client.getActiveChar(); + final ItemInstance oldItem = activeChar.getInventory().getItem(objectId); if (oldItem == null) { _log.warning("tried to drop an item that is not in the inventory ?!?:" + objectId); return; } - int oldCount = oldItem.getCount(); + final int oldCount = oldItem.getCount(); ItemInstance dropedItem = null; if (oldCount < count) { @@ -64,17 +64,17 @@ public class RequestDropItem extends ClientBasePacket } if ((activeChar.getDistance(x, y) > 150.0) || (Math.abs(z - activeChar.getZ()) > 50)) { - SystemMessage sm = new SystemMessage(SystemMessage.CANNOT_DISCARD_DISTANCE_TOO_FAR); + final SystemMessage sm = new SystemMessage(SystemMessage.CANNOT_DISCARD_DISTANCE_TOO_FAR); activeChar.sendPacket(sm); return; } if (oldItem.isEquipped()) { dropedItem = activeChar.getInventory().dropItem(objectId, count); - InventoryUpdate iu = new InventoryUpdate(); + final InventoryUpdate iu = new InventoryUpdate(); iu.addModifiedItem(oldItem); con.sendPacket(iu); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); con.sendPacket(ui); } else @@ -85,14 +85,14 @@ public class RequestDropItem extends ClientBasePacket dropedItem.setY(y); dropedItem.setZ(z); dropedItem.setOnTheGround(true); - DropItem di = new DropItem(dropedItem, activeChar.getObjectId()); + final DropItem di = new DropItem(dropedItem, activeChar.getObjectId()); activeChar.sendPacket(di); activeChar.addKnownObjectWithoutCreate(dropedItem); for (Creature player : activeChar.broadcastPacket(di)) { ((PlayerInstance) player).addKnownObjectWithoutCreate(dropedItem); } - InventoryUpdate iu = new InventoryUpdate(); + final InventoryUpdate iu = new InventoryUpdate(); if (oldCount == dropedItem.getCount()) { iu.addRemovedItem(oldItem); @@ -102,7 +102,7 @@ public class RequestDropItem extends ClientBasePacket iu.addModifiedItem(oldItem); } con.sendPacket(iu); - SystemMessage sm = new SystemMessage(SystemMessage.YOU_DROPPED_S1); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_DROPPED_S1); sm.addItemName(dropedItem.getItemId()); con.sendPacket(sm); con.sendPacket(new UserInfo(activeChar)); @@ -110,7 +110,7 @@ public class RequestDropItem extends ClientBasePacket } else { - SystemMessage msg = new SystemMessage(SystemMessage.NOTHING_HAPPENED); + final SystemMessage msg = new SystemMessage(SystemMessage.NOTHING_HAPPENED); client.getActiveChar().sendPacket(msg); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGMCommand.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGMCommand.java index b7d7782753..df621044d6 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGMCommand.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGMCommand.java @@ -31,11 +31,11 @@ public class RequestGMCommand extends ClientBasePacket public RequestGMCommand(byte[] rawPacket, ClientThread client) { super(rawPacket); - String targetName = readS(); - int command = readD(); + final String targetName = readS(); + final int command = readD(); @SuppressWarnings("unused") - int unknown = readD(); - PlayerInstance player = World.getInstance().getPlayer(targetName); + final int unknown = readD(); + final PlayerInstance player = World.getInstance().getPlayer(targetName); if (player == null) { return; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGetItemFromPet.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGetItemFromPet.java index 9e75ebc73c..bb734f3900 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGetItemFromPet.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGetItemFromPet.java @@ -30,13 +30,13 @@ public class RequestGetItemFromPet extends ClientBasePacket public RequestGetItemFromPet(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); - int amount = readD(); + final int objectId = readD(); + final int amount = readD(); @SuppressWarnings("unused") - int noidea = readD(); - Inventory petInventory = client.getActiveChar().getPet().getInventory(); - Inventory playerInventory = client.getActiveChar().getInventory(); - ItemInstance petItem = petInventory.getItem(objectId); + final int noidea = readD(); + final Inventory petInventory = client.getActiveChar().getPet().getInventory(); + final Inventory playerInventory = client.getActiveChar().getInventory(); + final ItemInstance petItem = petInventory.getItem(objectId); if (petItem == null) { _log.warning("item requested from pet, but its not there."); @@ -46,20 +46,20 @@ public class RequestGetItemFromPet extends ClientBasePacket { playerInventory.addItem(petItem); petInventory.destroyItem(objectId, petItem.getCount()); - PetInventoryUpdate petiu = new PetInventoryUpdate(); + final PetInventoryUpdate petiu = new PetInventoryUpdate(); petiu.addRemovedItem(petItem); client.getActiveChar().sendPacket(petiu); - ItemList playerUI = new ItemList(client.getActiveChar(), false); + final ItemList playerUI = new ItemList(client.getActiveChar(), false); client.getActiveChar().sendPacket(playerUI); } else { - int total = petItem.getCount(); - ItemInstance newPlayerItem = petInventory.dropItem(objectId, total); - PetInventoryUpdate petiu = new PetInventoryUpdate(); + final int total = petItem.getCount(); + final ItemInstance newPlayerItem = petInventory.dropItem(objectId, total); + final PetInventoryUpdate petiu = new PetInventoryUpdate(); petiu.addModifiedItem(petItem); playerInventory.addItem(newPlayerItem); - ItemList playerUI = new ItemList(client.getActiveChar(), false); + final ItemList playerUI = new ItemList(client.getActiveChar(), false); client.getActiveChar().sendPacket(petiu); client.getActiveChar().sendPacket(playerUI); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveItemToPet.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveItemToPet.java index f16e52c84a..4e9029c397 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveItemToPet.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveItemToPet.java @@ -30,27 +30,27 @@ public class RequestGiveItemToPet extends ClientBasePacket public RequestGiveItemToPet(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); - int amount = readD(); - Inventory petInventory = client.getActiveChar().getPet().getInventory(); - Inventory playerInventory = client.getActiveChar().getInventory(); - ItemInstance playerItem = playerInventory.getItem(objectId); + final int objectId = readD(); + final int amount = readD(); + final Inventory petInventory = client.getActiveChar().getPet().getInventory(); + final Inventory playerInventory = client.getActiveChar().getInventory(); + final ItemInstance playerItem = playerInventory.getItem(objectId); if (amount >= playerItem.getCount()) { playerInventory.dropItem(objectId, playerItem.getCount()); petInventory.addItem(playerItem); - InventoryUpdate playerUI = new InventoryUpdate(); + final InventoryUpdate playerUI = new InventoryUpdate(); playerUI.addRemovedItem(playerItem); client.getActiveChar().sendPacket(playerUI); - PetItemList petiu = new PetItemList(client.getActiveChar().getPet()); + final PetItemList petiu = new PetItemList(client.getActiveChar().getPet()); client.getActiveChar().sendPacket(petiu); } else { - ItemInstance newPetItem = playerInventory.dropItem(objectId, amount); + final ItemInstance newPetItem = playerInventory.dropItem(objectId, amount); petInventory.addItem(newPetItem); - PetItemList petiu = new PetItemList(client.getActiveChar().getPet()); - InventoryUpdate playerUI = new InventoryUpdate(); + final PetItemList petiu = new PetItemList(client.getActiveChar().getPet()); + final InventoryUpdate playerUI = new InventoryUpdate(); playerUI.addModifiedItem(playerItem); client.getActiveChar().sendPacket(petiu); client.getActiveChar().sendPacket(playerUI); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveNickName.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveNickName.java index 63375fdadb..d10f6d54d3 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveNickName.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestGiveNickName.java @@ -31,16 +31,16 @@ public class RequestGiveNickName extends ClientBasePacket public RequestGiveNickName(byte[] rawPacket, ClientThread client) { super(rawPacket); - String target = readS(); - String title = readS(); + final String target = readS(); + final String title = readS(); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.isClanLeader()) { PlayerInstance member; if (activeChar.getClan().getLevel() < 3) { - SystemMessage sm = new SystemMessage(SystemMessage.CLAN_LVL_3_NEEDED_TO_ENDOVE_TITLE); + final SystemMessage sm = new SystemMessage(SystemMessage.CLAN_LVL_3_NEEDED_TO_ENDOVE_TITLE); activeChar.sendPacket(sm); activeChar.sendMessage("But you can do it freely for now ;)"); activeChar.sendPacket(sm); @@ -48,9 +48,9 @@ public class RequestGiveNickName extends ClientBasePacket if ((member = World.getInstance().getPlayer(target)).getClanId() == activeChar.getClanId()) { member.setTitle(title); - UserInfo ui = new UserInfo(member); + final UserInfo ui = new UserInfo(member); member.sendPacket(ui); - CharInfo ci = new CharInfo(member); + final CharInfo ci = new CharInfo(member); member.broadcastPacket(ci); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestItemList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestItemList.java index 095a9ca68e..3b93a553eb 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestItemList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestItemList.java @@ -29,7 +29,7 @@ public class RequestItemList extends ClientBasePacket public RequestItemList(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - ItemList il = new ItemList(client.getActiveChar(), true); + final ItemList il = new ItemList(client.getActiveChar(), true); client.getConnection().sendPacket(il); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinParty.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinParty.java index 4c45b63066..bd52c97427 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinParty.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinParty.java @@ -31,19 +31,19 @@ public class RequestJoinParty extends ClientBasePacket public RequestJoinParty(byte[] decrypt, ClientThread client) { super(decrypt); - int id = readD(); - int itemDistribution = readD(); - PlayerInstance target = (PlayerInstance) World.getInstance().findObject(id); - PlayerInstance requestor = client.getActiveChar(); + final int id = readD(); + final int itemDistribution = readD(); + final PlayerInstance target = (PlayerInstance) World.getInstance().findObject(id); + final PlayerInstance requestor = client.getActiveChar(); if (requestor.isTransactionInProgress()) { - SystemMessage msg = new SystemMessage(SystemMessage.WAITING_FOR_REPLY); + final SystemMessage msg = new SystemMessage(SystemMessage.WAITING_FOR_REPLY); requestor.sendPacket(msg); return; } if (target.isInParty()) { - SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_ALREADY_IN_PARTY); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_ALREADY_IN_PARTY); msg.addString(target.getName()); requestor.sendPacket(msg); return; @@ -76,15 +76,15 @@ public class RequestJoinParty extends ClientBasePacket { target.setTransactionRequester(requestor); requestor.setTransactionRequester(target); - AskJoinParty ask = new AskJoinParty(requestor.getObjectId(), itemDistribution); + final AskJoinParty ask = new AskJoinParty(requestor.getObjectId(), itemDistribution); target.sendPacket(ask); - SystemMessage msg = new SystemMessage(SystemMessage.YOU_INVITED_S1_TO_PARTY); + final SystemMessage msg = new SystemMessage(SystemMessage.YOU_INVITED_S1_TO_PARTY); msg.addString(target.getName()); requestor.sendPacket(msg); } else { - SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); requestor.sendPacket(msg); _log.warning(requestor.getName() + " already received a party invitation"); } @@ -104,15 +104,15 @@ public class RequestJoinParty extends ClientBasePacket requestor.setParty(new Party(requestor, itemDistribution == 1)); target.setTransactionRequester(requestor); requestor.setTransactionRequester(target); - AskJoinParty ask = new AskJoinParty(requestor.getObjectId(), itemDistribution); + final AskJoinParty ask = new AskJoinParty(requestor.getObjectId(), itemDistribution); target.sendPacket(ask); - SystemMessage msg = new SystemMessage(SystemMessage.YOU_INVITED_S1_TO_PARTY); + final SystemMessage msg = new SystemMessage(SystemMessage.YOU_INVITED_S1_TO_PARTY); msg.addString(target.getName()); requestor.sendPacket(msg); } else { - SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); msg.addString(target.getName()); requestor.sendPacket(msg); _log.warning(requestor.getName() + " already received a party invitation"); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinPledge.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinPledge.java index 5ae3c1f19e..117e45c1f7 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinPledge.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestJoinPledge.java @@ -32,9 +32,9 @@ public class RequestJoinPledge extends ClientBasePacket { super(rawPacket); WorldObject object; - int target = readD(); + final int target = readD(); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.isTransactionInProgress()) { activeChar.sendPacket(new SystemMessage(SystemMessage.WAITING_FOR_REPLY)); @@ -42,30 +42,30 @@ public class RequestJoinPledge extends ClientBasePacket } if (target == activeChar.getObjectId()) { - SystemMessage sm = new SystemMessage(SystemMessage.CANNOT_INVITE_YOURSELF); + final SystemMessage sm = new SystemMessage(SystemMessage.CANNOT_INVITE_YOURSELF); activeChar.sendPacket(sm); return; } if (activeChar.isClanLeader() && ((object = World.getInstance().findObject(target)) instanceof PlayerInstance)) { - PlayerInstance member = (PlayerInstance) object; + final PlayerInstance member = (PlayerInstance) object; if (member.getClanId() != 0) { - SystemMessage sm = new SystemMessage(SystemMessage.S1_WORKING_WITH_ANOTHER_CLAN); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_WORKING_WITH_ANOTHER_CLAN); sm.addString(member.getName()); activeChar.sendPacket(sm); return; } if (member.isTransactionInProgress()) { - SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); sm.addString(member.getName()); activeChar.sendPacket(sm); return; } member.setTransactionRequester(activeChar); activeChar.setTransactionRequester(member); - AskJoinPledge ap = new AskJoinPledge(activeChar.getObjectId(), activeChar.getClan().getName()); + final AskJoinPledge ap = new AskJoinPledge(activeChar.getObjectId(), activeChar.getClan().getName()); member.sendPacket(ap); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestMagicSkillUse.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestMagicSkillUse.java index 025102bfe1..49d34c49ff 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestMagicSkillUse.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestMagicSkillUse.java @@ -29,15 +29,15 @@ public class RequestMagicSkillUse extends ClientBasePacket public RequestMagicSkillUse(byte[] rawPacket, ClientThread client) { super(rawPacket); - int magicId = readD(); + final int magicId = readD(); @SuppressWarnings("unused") - int data2 = readD(); + final int data2 = readD(); @SuppressWarnings("unused") - int data3 = readC(); + final int data3 = readC(); - PlayerInstance activeChar = client.getActiveChar(); - int level = activeChar.getSkillLevel(magicId); - Skill skill = SkillTable.getInstance().getInfo(magicId, level); + final PlayerInstance activeChar = client.getActiveChar(); + final int level = activeChar.getSkillLevel(magicId); + final Skill skill = SkillTable.getInstance().getInfo(magicId, level); if (skill != null) { activeChar.stopMove(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPartyMember.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPartyMember.java index 11bb580c0e..7c385c9f66 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPartyMember.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPartyMember.java @@ -27,8 +27,8 @@ public class RequestOustPartyMember extends ClientBasePacket public RequestOustPartyMember(byte[] decrypt, ClientThread client) { super(decrypt); - String name = readS(); - PlayerInstance activeChar = client.getActiveChar(); + final String name = readS(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.isInParty() && activeChar.getParty().isLeader(activeChar)) { activeChar.getParty().oustPartyMember(name); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPledgeMember.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPledgeMember.java index 78a79f4878..4e306e9a62 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPledgeMember.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestOustPledgeMember.java @@ -34,15 +34,15 @@ public class RequestOustPledgeMember extends ClientBasePacket public RequestOustPledgeMember(byte[] rawPacket, ClientThread client) { super(rawPacket); - String target = readS(); + final String target = readS(); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (!activeChar.isClanLeader()) { return; } - Clan clan = activeChar.getClan(); - ClanMember member = clan.getClanMember(target); + final Clan clan = activeChar.getClan(); + final ClanMember member = clan.getClanMember(target); if (member == null) { _log.warning("target is not member of the clan"); @@ -50,13 +50,13 @@ public class RequestOustPledgeMember extends ClientBasePacket } clan.removeClanMember(target); clan.store(); - SystemMessage msg = new SystemMessage(SystemMessage.CLAN_MEMBER_S1_EXPELLED); + final SystemMessage msg = new SystemMessage(SystemMessage.CLAN_MEMBER_S1_EXPELLED); msg.addString(member.getName()); clan.broadcastToOnlineMembers(msg); clan.broadcastToOnlineMembers(new PledgeShowMemberListDelete(target)); if (member.isOnline()) { - PlayerInstance player = member.getPlayerInstance(); + final PlayerInstance player = member.getPlayerInstance(); player.setClan(null); player.setClanId(0); player.setTitle(""); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchConfig.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchConfig.java index 6058348d65..454278dab3 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchConfig.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchConfig.java @@ -26,10 +26,10 @@ public class RequestPartyMatchConfig extends ClientBasePacket public RequestPartyMatchConfig(byte[] decrypt, ClientThread client) { super(decrypt); - int automaticRegistration = readD(); - int showLevel = readD(); - int showClass = readD(); - String memo = readS(); + final int automaticRegistration = readD(); + final int showLevel = readD(); + final int showClass = readD(); + final String memo = readS(); client.getActiveChar().setPartyMatchingAutomaticRegistration(automaticRegistration == 1); client.getActiveChar().setPartyMatchingShowLevel(showLevel == 1); client.getActiveChar().setPartyMatchingShowClass(showClass == 1); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchDetail.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchDetail.java index ff7f8ee12e..3eb52e3d2a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchDetail.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchDetail.java @@ -31,9 +31,9 @@ public class RequestPartyMatchDetail extends ClientBasePacket public RequestPartyMatchDetail(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int objectId = readD(); - PlayerInstance player = (PlayerInstance) World.getInstance().findObject(objectId); - PartyMatchDetail details = new PartyMatchDetail(player); + final int objectId = readD(); + final PlayerInstance player = (PlayerInstance) World.getInstance().findObject(objectId); + final PartyMatchDetail details = new PartyMatchDetail(player); client.getConnection().sendPacket(details); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchList.java index c51788571e..7bf18ea48f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPartyMatchList.java @@ -30,10 +30,10 @@ public class RequestPartyMatchList extends ClientBasePacket public RequestPartyMatchList(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int status = readD(); + final int status = readD(); if (status == 1) { - PartyMatchList matchList = new PartyMatchList(World.getInstance().getAllPlayers()); + final PartyMatchList matchList = new PartyMatchList(World.getInstance().getAllPlayers()); client.getConnection().sendPacket(matchList); } // else if (status == 3) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPetGetItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPetGetItem.java index 2f2e74baa1..d982d74193 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPetGetItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPetGetItem.java @@ -29,9 +29,9 @@ public class RequestPetGetItem extends ClientBasePacket public RequestPetGetItem(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); - World world = World.getInstance(); - ItemInstance item = (ItemInstance) world.findObject(objectId); + final int objectId = readD(); + final World world = World.getInstance(); + final ItemInstance item = (ItemInstance) world.findObject(objectId); client.getActiveChar().getPet().setTarget(item); client.getActiveChar().getPet().setCurrentState(CreatureState.PICKUP_ITEM); client.getActiveChar().getPet().moveTo(item.getX(), item.getY(), item.getZ(), 0); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeCrest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeCrest.java index 207edbf045..45c4077819 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeCrest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeCrest.java @@ -30,11 +30,11 @@ public class RequestPledgeCrest extends ClientBasePacket public RequestPledgeCrest(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - int crestId = readD(); - File crestFile = new File("data/crests/Pledge_" + crestId + ".bmp"); + final int crestId = readD(); + final File crestFile = new File("data/crests/Pledge_" + crestId + ".bmp"); if (crestFile.exists()) { - PledgeCrest pc = new PledgeCrest(crestId, crestFile); + final PledgeCrest pc = new PledgeCrest(crestId, crestFile); client.getConnection().sendPacket(pc); } else diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeInfo.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeInfo.java index 59a123699a..2f9b8ef29c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeInfo.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeInfo.java @@ -31,19 +31,19 @@ public class RequestPledgeInfo extends ClientBasePacket public RequestPledgeInfo(byte[] rawPacket, ClientThread client) { super(rawPacket); - int clanId = readD(); - PlayerInstance activeChar = client.getActiveChar(); - Clan clan = ClanTable.getInstance().getClan(clanId); + final int clanId = readD(); + final PlayerInstance activeChar = client.getActiveChar(); + final Clan clan = ClanTable.getInstance().getClan(clanId); if (clan == null) { _log.warning("Clan data for clanId " + clanId + " is missing"); return; } - PledgeInfo pc = new PledgeInfo(clan); + final PledgeInfo pc = new PledgeInfo(clan); activeChar.sendPacket(pc); if (clan.getClanId() == activeChar.getClanId()) { - PledgeShowMemberListAll pm = new PledgeShowMemberListAll(clan, activeChar); + final PledgeShowMemberListAll pm = new PledgeShowMemberListAll(clan, activeChar); activeChar.sendPacket(pm); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeMemberList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeMemberList.java index 54ddba4cf3..4f7322f84f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeMemberList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPledgeMemberList.java @@ -29,11 +29,11 @@ public class RequestPledgeMemberList extends ClientBasePacket public RequestPledgeMemberList(byte[] rawPacket, ClientThread client) { super(rawPacket); - PlayerInstance activeChar = client.getActiveChar(); - Clan clan = activeChar.getClan(); + final PlayerInstance activeChar = client.getActiveChar(); + final Clan clan = activeChar.getClan(); if (clan != null) { - PledgeShowMemberListAll pm = new PledgeShowMemberListAll(clan, activeChar); + final PledgeShowMemberListAll pm = new PledgeShowMemberListAll(clan, activeChar); activeChar.sendPacket(pm); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreBuyManage.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreBuyManage.java index 227577a6ed..b15d666580 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreBuyManage.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreBuyManage.java @@ -32,8 +32,8 @@ public class RequestPrivateStoreBuyManage extends ClientBasePacket public RequestPrivateStoreBuyManage(byte[] decrypt, ClientThread client) { super(decrypt); - PlayerInstance player = client.getActiveChar(); - int privatetype = player.getPrivateStoreType(); + final PlayerInstance player = client.getActiveChar(); + final int privatetype = player.getPrivateStoreType(); if (privatetype == 0) { if (player.getWaitType() != 1) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreManage.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreManage.java index c48f12f173..4f1a1605d5 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreManage.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreManage.java @@ -33,8 +33,8 @@ public class RequestPrivateStoreManage extends ClientBasePacket public RequestPrivateStoreManage(byte[] decrypt, ClientThread client) { super(decrypt); - PlayerInstance player = client.getActiveChar(); - int privatetype = player.getPrivateStoreType(); + final PlayerInstance player = client.getActiveChar(); + final int privatetype = player.getPrivateStoreType(); if (privatetype == 0) { if (player.getWaitType() != 1) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitBuy.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitBuy.java index 66dadcc6a2..902d3ddcfc 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitBuy.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitBuy.java @@ -28,7 +28,7 @@ public class RequestPrivateStoreQuitBuy extends ClientBasePacket public RequestPrivateStoreQuitBuy(byte[] decrypt, ClientThread client) { super(decrypt); - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); player.setPrivateStoreType(0); player.sendPacket(new UserInfo(player)); player.broadcastPacket(new UserInfo(player)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitSell.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitSell.java index a102e04e6a..2040f8760e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitSell.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestPrivateStoreQuitSell.java @@ -28,7 +28,7 @@ public class RequestPrivateStoreQuitSell extends ClientBasePacket public RequestPrivateStoreQuitSell(byte[] decrypt, ClientThread client) { super(decrypt); - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); player.setPrivateStoreType(0); player.sendPacket(new UserInfo(player)); player.broadcastPacket(new UserInfo(player)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestQuestList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestQuestList.java index a59961a511..2f183e9e54 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestQuestList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestQuestList.java @@ -29,7 +29,7 @@ public class RequestQuestList extends ClientBasePacket public RequestQuestList(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - QuestList ql = new QuestList(); + final QuestList ql = new QuestList(); client.getConnection().sendPacket(ql); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestart.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestart.java index c010d034d4..323b1a235e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestart.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestart.java @@ -33,7 +33,7 @@ public class RequestRestart extends ClientBasePacket { super(decrypt); - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); if (player != null) { if ((player.getPvpFlag() > 0) || player.isInCombat()) @@ -43,11 +43,11 @@ public class RequestRestart extends ClientBasePacket return; } player.deleteMe(); - RestartResponse response = new RestartResponse(); + final RestartResponse response = new RestartResponse(); client.getConnection().sendPacket(response); client.saveCharToDisk(client.getActiveChar()); client.setActiveChar(null); - CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); + final CharSelectInfo cl = new CharSelectInfo(client.getLoginName(), client.getSessionId()); client.getConnection().sendPacket(cl); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestartPoint.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestartPoint.java index 92f29d69b0..4a0cc5d267 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestartPoint.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestRestartPoint.java @@ -37,15 +37,15 @@ public class RequestRestartPoint extends ClientBasePacket public RequestRestartPoint(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); - int[] townCords = MapRegionTable.getInstance().getClosestTownCords(activeChar); - StopMove stopMove = new StopMove(activeChar); + final Connection con = client.getConnection(); + final PlayerInstance activeChar = client.getActiveChar(); + final int[] townCords = MapRegionTable.getInstance().getClosestTownCords(activeChar); + final StopMove stopMove = new StopMove(activeChar); con.sendPacket(stopMove); - ActionFailed actionFailed = new ActionFailed(); + final ActionFailed actionFailed = new ActionFailed(); con.sendPacket(actionFailed); activeChar.broadcastPacket(stopMove); - TeleportToLocation teleport = new TeleportToLocation(activeChar, townCords[0], townCords[1], townCords[2]); + final TeleportToLocation teleport = new TeleportToLocation(activeChar, townCords[0], townCords[1], townCords[2]); activeChar.sendPacket(teleport); World.getInstance().removeVisibleObject(activeChar); activeChar.removeAllKnownObjects(); @@ -54,7 +54,7 @@ public class RequestRestartPoint extends ClientBasePacket activeChar.setZ(townCords[2]); activeChar.setCurrentHp(0.6 * activeChar.getMaxHp()); activeChar.setCurrentMp(0.6 * activeChar.getMaxMp()); - Revive revive = new Revive(activeChar); + final Revive revive = new Revive(activeChar); try { Thread.sleep(2000L); @@ -64,7 +64,7 @@ public class RequestRestartPoint extends ClientBasePacket // empty catch block } World.getInstance().addVisibleObject(activeChar); - SocialAction sa = new SocialAction(activeChar.getObjectId(), 15); + final SocialAction sa = new SocialAction(activeChar.getObjectId(), 15); activeChar.broadcastPacket(sa); activeChar.sendPacket(sa); activeChar.sendPacket(revive); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSellItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSellItem.java index 64efdc2e0b..9e87ed4525 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSellItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSellItem.java @@ -30,24 +30,24 @@ public class RequestSellItem extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int listId = readD(); - int count = readD(); - PlayerInstance activeChar = client.getActiveChar(); + final int listId = readD(); + final int count = readD(); + final PlayerInstance activeChar = client.getActiveChar(); // ItemInstance[] items = new ItemInstance[count]; for (int i = 0; i < count; ++i) { - int objectId = readD(); - int itemId = readD(); - int cnt = readD(); + final int objectId = readD(); + final int itemId = readD(); + final int cnt = readD(); if ((activeChar.getInventory().getItem(objectId).getItemId() != itemId) || (activeChar.getInventory().getItem(objectId).getCount() < cnt)) { continue; } - ItemInstance item = activeChar.getInventory().getItem(objectId); + final ItemInstance item = activeChar.getInventory().getItem(objectId); activeChar.addAdena((item.getItem().getReferencePrice() / 2) * cnt); activeChar.getInventory().destroyItem(objectId, cnt); } - StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); + final StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); su.addAttribute(StatusUpdate.CUR_LOAD, activeChar.getCurrentLoad()); activeChar.sendPacket(su); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSetPledgeCrest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSetPledgeCrest.java index eb16c61901..7d213bd509 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSetPledgeCrest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSetPledgeCrest.java @@ -34,22 +34,22 @@ public class RequestSetPledgeCrest extends ClientBasePacket public RequestSetPledgeCrest(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - int length = readD(); - byte[] data = readB(length); + final int length = readD(); + final byte[] data = readB(length); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (!activeChar.isClanLeader()) { return; } - Clan clan = activeChar.getClan(); - File crestFile = new File("data/crests/Pledge_" + clan.getClanId() + ".bmp"); - FileOutputStream out = new FileOutputStream(crestFile); + final Clan clan = activeChar.getClan(); + final File crestFile = new File("data/crests/Pledge_" + clan.getClanId() + ".bmp"); + final FileOutputStream out = new FileOutputStream(crestFile); out.write(data); out.close(); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); activeChar.sendPacket(ui); - CharInfo ci = new CharInfo(activeChar); + final CharInfo ci = new CharInfo(activeChar); activeChar.broadcastPacket(ci); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutDel.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutDel.java index 2555a5e6fd..1a79a8e9d5 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutDel.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutDel.java @@ -27,9 +27,9 @@ public class RequestShortCutDel extends ClientBasePacket public RequestShortCutDel(byte[] rawPacket, ClientThread client) { super(rawPacket); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); // Connection con = client.getConnection(); - int slot = readD(); + final int slot = readD(); activeChar.deleteShortCut(slot); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutReg.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutReg.java index 40babef98f..1f761f95bf 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutReg.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShortCutReg.java @@ -32,12 +32,12 @@ public class RequestShortCutReg extends ClientBasePacket public RequestShortCutReg(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - PlayerInstance activeChar = client.getActiveChar(); - Connection con = client.getConnection(); - int type = readD(); - int slot = readD(); - int id = readD(); - int unk = readD(); + final PlayerInstance activeChar = client.getActiveChar(); + final Connection con = client.getConnection(); + final int type = readD(); + final int slot = readD(); + final int id = readD(); + final int unk = readD(); switch (type) { case 1: @@ -49,7 +49,7 @@ public class RequestShortCutReg extends ClientBasePacket } case 2: { - int level = activeChar.getSkillLevel(id); + final int level = activeChar.getSkillLevel(id); if (level <= 0) { break; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShowBoard.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShowBoard.java index aabf1f88ac..ffbab9b4d9 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShowBoard.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestShowBoard.java @@ -28,7 +28,7 @@ public class RequestShowBoard extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int unknown = readD(); + final int unknown = readD(); CommunityBoardManager.getInstance().handleCommands(client, "bbs_default"); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSkillList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSkillList.java index 904845060a..1d418d3322 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSkillList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSkillList.java @@ -30,7 +30,7 @@ public class RequestSkillList extends ClientBasePacket public RequestSkillList(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - SkillList response = new SkillList(); + final SkillList response = new SkillList(); for (Skill skill : client.getActiveChar().getAllSkills()) { response.addSkill(skill.getId(), skill.getLevel(), skill.isPassive()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSocialAction.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSocialAction.java index 7c2af29347..74606557e8 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSocialAction.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestSocialAction.java @@ -29,11 +29,11 @@ public class RequestSocialAction extends ClientBasePacket public RequestSocialAction(byte[] decrypt, ClientThread client) { super(decrypt); - int actionId = readD(); - PlayerInstance activeChar = client.getActiveChar(); + final int actionId = readD(); + final PlayerInstance activeChar = client.getActiveChar(); if ((activeChar.getPrivateStoreType() == 0) && (activeChar.getTransactionRequester() == null) && (activeChar.getCurrentState() == CreatureState.IDLE)) { - SocialAction atk = new SocialAction(client.getActiveChar().getObjectId(), actionId); + final SocialAction atk = new SocialAction(client.getActiveChar().getObjectId(), actionId); activeChar.sendPacket(atk); activeChar.broadcastPacket(atk); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestTargetCanceld.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestTargetCanceld.java index 276af8e100..34ff8a26ff 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestTargetCanceld.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestTargetCanceld.java @@ -31,10 +31,10 @@ public class RequestTargetCanceld extends ClientBasePacket public RequestTargetCanceld(byte[] rawPacket, ClientThread client) throws IOException { super(rawPacket); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.getTarget() != null) { - TargetUnselected atk = new TargetUnselected(activeChar); + final TargetUnselected atk = new TargetUnselected(activeChar); client.getConnection().sendPacket(atk); ((Creature) activeChar).setTarget(null); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestUnEquipItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestUnEquipItem.java index 1870cd096d..8ee9c2264e 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestUnEquipItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestUnEquipItem.java @@ -34,10 +34,10 @@ public class RequestUnEquipItem extends ClientBasePacket public RequestUnEquipItem(byte[] decrypt, ClientThread client) { super(decrypt); - int slot = readD(); - PlayerInstance activeChar = client.getActiveChar(); - Collection unequiped = activeChar.getInventory().unEquipItemInBodySlot(slot); - InventoryUpdate iu = new InventoryUpdate(); + final int slot = readD(); + final PlayerInstance activeChar = client.getActiveChar(); + final Collection unequiped = activeChar.getInventory().unEquipItemInBodySlot(slot); + final InventoryUpdate iu = new InventoryUpdate(); for (ItemInstance element : unequiped) { iu.addModifiedItem(element); @@ -47,14 +47,14 @@ public class RequestUnEquipItem extends ClientBasePacket activeChar.updatePAtk(); activeChar.updateMDef(); activeChar.updateMAtk(); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); activeChar.sendPacket(ui); activeChar.setAttackStatus(false); - CharInfo info = new CharInfo(activeChar); + final CharInfo info = new CharInfo(activeChar); activeChar.broadcastPacket(info); if (unequiped.size() > 0) { - SystemMessage sm = new SystemMessage(SystemMessage.S1_DISARMED); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_DISARMED); sm.addItemName(unequiped.stream().findFirst().get().getItemId()); activeChar.sendPacket(sm); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestWithdrawalPledge.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestWithdrawalPledge.java index cbbc247313..219a2272a1 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestWithdrawalPledge.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/RequestWithdrawalPledge.java @@ -34,17 +34,17 @@ public class RequestWithdrawalPledge extends ClientBasePacket { super(rawPacket); // Connection con = client.getConnection(); - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar.getClanId() == 0) { return; } - Clan clan = activeChar.getClan(); - ClanMember member = clan.getClanMember(activeChar.getName()); + final Clan clan = activeChar.getClan(); + final ClanMember member = clan.getClanMember(activeChar.getName()); clan.removeClanMember(activeChar.getName()); clan.store(); activeChar.sendPacket(new SystemMessage(SystemMessage.CLAN_MEMBERSHIP_TERMINATED)); - PlayerInstance player = member.getPlayerInstance(); + final PlayerInstance player = member.getPlayerInstance(); player.setClan(null); player.setClanId(0); player.setTitle(""); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Say2.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Say2.java index f5620615ba..517a2fbb9f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Say2.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/Say2.java @@ -41,19 +41,19 @@ public class Say2 extends ClientBasePacket public Say2(byte[] decrypt, ClientThread client) { super(decrypt); - String text = readS(); - int type = readD(); + final String text = readS(); + final int type = readD(); String target = null; if (type == 2) { target = readS(); } - PlayerInstance activeChar = client.getActiveChar(); + final PlayerInstance activeChar = client.getActiveChar(); // Connection con = client.getConnection(); - CreatureSay cs = new CreatureSay(activeChar.getObjectId(), type, activeChar.getName(), text); + final CreatureSay cs = new CreatureSay(activeChar.getObjectId(), type, activeChar.getName(), text); if (type == 2) { - PlayerInstance receiver = World.getInstance().getPlayer(target); + final PlayerInstance receiver = World.getInstance().getPlayer(target); if (receiver != null) { receiver.sendPacket(cs); @@ -61,7 +61,7 @@ public class Say2 extends ClientBasePacket } else { - SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_NOT_ONLINE); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_NOT_ONLINE); sm.addString(target); activeChar.sendPacket(sm); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendBypassBuildCmd.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendBypassBuildCmd.java index 74e9051d59..e093a7de8c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendBypassBuildCmd.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendBypassBuildCmd.java @@ -33,8 +33,8 @@ public class SendBypassBuildCmd extends ClientBasePacket public SendBypassBuildCmd(byte[] decrypt, ClientThread client) { super(decrypt); - PlayerInstance activeChar = client.getActiveChar(); - String command = readS(); + final PlayerInstance activeChar = client.getActiveChar(); + final String command = readS(); if (client.getAccessLevel() >= 100) { if (command.equals("admin")) @@ -45,8 +45,8 @@ public class SendBypassBuildCmd extends ClientBasePacket { try { - String text = command.substring(9); - CreatureSay cs = new CreatureSay(0, 10, activeChar.getName(), text); + final String text = command.substring(9); + final CreatureSay cs = new CreatureSay(0, 10, activeChar.getName(), text); for (PlayerInstance player : World.getInstance().getAllPlayers()) { player.sendPacket(cs); @@ -60,8 +60,8 @@ public class SendBypassBuildCmd extends ClientBasePacket { try { - String text = command.substring(7); - CreatureSay cs = new CreatureSay(0, 9, activeChar.getName(), text); + final String text = command.substring(7); + final CreatureSay cs = new CreatureSay(0, 9, activeChar.getName(), text); GmListManager.getInstance().broadcastToGMs(cs); } catch (StringIndexOutOfBoundsException e) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyBuyList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyBuyList.java index 597b0d1bed..6469b30fcb 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyBuyList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyBuyList.java @@ -34,17 +34,17 @@ public class SendPrivateStoreBuyBuyList extends ClientBasePacket public SendPrivateStoreBuyBuyList(byte[] decrypt, ClientThread client) { super(decrypt); - int buyerID = readD(); - int count = readD(); - World world = World.getInstance(); - PlayerInstance seller = client.getActiveChar(); - PlayerInstance buyer = (PlayerInstance) world.findObject(buyerID); - List buyerlist = buyer.getBuyList(); - List sellerlist = new ArrayList<>(); + final int buyerID = readD(); + final int count = readD(); + final World world = World.getInstance(); + final PlayerInstance seller = client.getActiveChar(); + final PlayerInstance buyer = (PlayerInstance) world.findObject(buyerID); + final List buyerlist = buyer.getBuyList(); + final List sellerlist = new ArrayList<>(); int cost = 0; for (int i = 0; i < count; ++i) { - TradeItem temp = new TradeItem(); + final TradeItem temp = new TradeItem(); temp.setObjectId(readD()); temp.setItemId(readD()); readH(); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyList.java index 9ed0ebc8eb..5cb6d20567 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendPrivateStoreBuyList.java @@ -35,17 +35,17 @@ public class SendPrivateStoreBuyList extends ClientBasePacket public SendPrivateStoreBuyList(byte[] decrypt, ClientThread client) { super(decrypt); - int sellerID = readD(); - int count = readD(); - World world = World.getInstance(); - PlayerInstance seller = (PlayerInstance) world.findObject(sellerID); - PlayerInstance buyer = client.getActiveChar(); - List buyerlist = new ArrayList<>(); - List sellerlist = seller.getSellList(); + final int sellerID = readD(); + final int count = readD(); + final World world = World.getInstance(); + final PlayerInstance seller = (PlayerInstance) world.findObject(sellerID); + final PlayerInstance buyer = client.getActiveChar(); + final List buyerlist = new ArrayList<>(); + final List sellerlist = seller.getSellList(); int cost = 0; for (int i = 0; i < count; ++i) { - TradeItem temp = new TradeItem(); + final TradeItem temp = new TradeItem(); temp.setObjectId(readD()); temp.setCount(readD()); temp.setOwnersPrice(readD()); @@ -67,7 +67,7 @@ public class SendPrivateStoreBuyList extends ClientBasePacket } else { - SystemMessage msg = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); + final SystemMessage msg = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); buyer.sendPacket(msg); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseDepositList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseDepositList.java index e9c1e34d67..23c9166243 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseDepositList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseDepositList.java @@ -35,24 +35,24 @@ public class SendWareHouseDepositList extends ClientBasePacket { super(decrypt); int i; - PlayerInstance activeChar = client.getActiveChar(); - Connection con = client.getConnection(); - int count = readD(); - int price = 30; + final PlayerInstance activeChar = client.getActiveChar(); + final Connection con = client.getConnection(); + final int count = readD(); + final int price = 30; int neededMoney = count * price; - int currentMoney = activeChar.getAdena(); + final int currentMoney = activeChar.getAdena(); if (neededMoney > currentMoney) { - SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); + final SystemMessage sm = new SystemMessage(SystemMessage.YOU_NOT_ENOUGH_ADENA); con.sendPacket(sm); return; } - ItemInstance[] items = new ItemInstance[count]; + final ItemInstance[] items = new ItemInstance[count]; for (i = 0; i < count; ++i) { - int itemId = readD(); - int cnt = readD(); - ItemInstance inst = ItemTable.getInstance().createItem(itemId); + final int itemId = readD(); + final int cnt = readD(); + final ItemInstance inst = ItemTable.getInstance().createItem(itemId); inst.setCount(cnt); items[i] = inst; } @@ -68,7 +68,7 @@ public class SendWareHouseDepositList extends ClientBasePacket neededMoney += price; } activeChar.reduceAdena(neededMoney); - ItemList il = new ItemList(activeChar, false); + final ItemList il = new ItemList(activeChar, false); con.sendPacket(il); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseWithDrawList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseWithDrawList.java index 22ac7dc0f1..520f1789eb 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseWithDrawList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SendWareHouseWithDrawList.java @@ -34,15 +34,15 @@ public class SendWareHouseWithDrawList extends ClientBasePacket { super(decrypt); int i; - PlayerInstance activeChar = client.getActiveChar(); - int itemCount = readD(); + final PlayerInstance activeChar = client.getActiveChar(); + final int itemCount = readD(); int weight = 0; - ItemInstance[] items = new ItemInstance[itemCount]; + final ItemInstance[] items = new ItemInstance[itemCount]; for (i = 0; i < itemCount; ++i) { - int itemId = readD(); - int count = readD(); - ItemInstance inst = ItemTable.getInstance().createItem(itemId); + final int itemId = readD(); + final int count = readD(); + final ItemInstance inst = ItemTable.getInstance().createItem(itemId); inst.setCount(count); items[i] = inst; weight += items[i].getItem().getWeight() * count; @@ -54,10 +54,10 @@ public class SendWareHouseWithDrawList extends ClientBasePacket activeChar.getInventory().addItem(items[i]); activeChar.getWarehouse().destroyItem(items[i].getItemId(), items[i].getCount()); } - StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); + final StatusUpdate su = new StatusUpdate(activeChar.getObjectId()); su.addAttribute(StatusUpdate.CUR_LOAD, activeChar.getCurrentLoad()); activeChar.sendPacket(su); - ItemList il = new ItemList(activeChar, false); + final ItemList il = new ItemList(activeChar, false); activeChar.sendPacket(il); } else @@ -66,7 +66,7 @@ public class SendWareHouseWithDrawList extends ClientBasePacket { World.getInstance().removeVisibleObject(items[i]); } - SystemMessage sm = new SystemMessage(SystemMessage.WEIGHT_LIMIT_EXCEEDED); + final SystemMessage sm = new SystemMessage(SystemMessage.WEIGHT_LIMIT_EXCEEDED); activeChar.sendPacket(sm); } } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListBuy.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListBuy.java index 61c23b9b11..0bf034bee3 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListBuy.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListBuy.java @@ -38,14 +38,14 @@ public class SetPrivateStoreListBuy extends ClientBasePacket int count = readD(); if (count <= 10) { - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); // TradeList tradelist = player.getTradeList(); player.setBuyList(new ArrayList<>()); List listbuy = player.getBuyList(); int cost = 0; for (int x = 0; x < count; ++x) { - TradeItem temp = new TradeItem(); + final TradeItem temp = new TradeItem(); temp.setItemId(readD()); readH(); temp.setCount(readD()); @@ -60,7 +60,7 @@ public class SetPrivateStoreListBuy extends ClientBasePacket if (cost > player.getAdena()) { count = 0; - SystemMessage msg = new SystemMessage(SystemMessage.THE_PURCHASE_PRICE_IS_HIGHER_THAN_MONEY); + final SystemMessage msg = new SystemMessage(SystemMessage.THE_PURCHASE_PRICE_IS_HIGHER_THAN_MONEY); player.sendPacket(msg); } if (count != 0) @@ -82,7 +82,7 @@ public class SetPrivateStoreListBuy extends ClientBasePacket } else { - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); player.setPrivateStoreType(0); player.sendPacket(new UserInfo(player)); player.broadcastPacket(new UserInfo(player)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListSell.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListSell.java index aacfd438c9..18f3921736 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListSell.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreListSell.java @@ -34,14 +34,14 @@ public class SetPrivateStoreListSell extends ClientBasePacket public SetPrivateStoreListSell(byte[] decrypt, ClientThread client) { super(decrypt); - int count = readD(); - PlayerInstance player = client.getActiveChar(); + final int count = readD(); + final PlayerInstance player = client.getActiveChar(); // TradeList tradelist = player.getTradeList(); player.setSellList(new ArrayList<>()); List listsell = player.getSellList(); for (int x = 0; x < count; ++x) { - TradeItem temp = new TradeItem(); + final TradeItem temp = new TradeItem(); temp.setObjectId(readD()); temp.setCount(readD()); temp.setOwnersPrice(readD()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgBuy.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgBuy.java index dd7456fec4..cdb95b338a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgBuy.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgBuy.java @@ -27,8 +27,8 @@ public class SetPrivateStoreMsgBuy extends ClientBasePacket public SetPrivateStoreMsgBuy(byte[] decrypt, ClientThread client) { super(decrypt); - String storename = readS(); - PlayerInstance player = client.getActiveChar(); + final String storename = readS(); + final PlayerInstance player = client.getActiveChar(); player.getTradeList().setBuyStoreName(storename); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgSell.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgSell.java index 4ccc45c129..23f0b5e58a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgSell.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/SetPrivateStoreMsgSell.java @@ -27,8 +27,8 @@ public class SetPrivateStoreMsgSell extends ClientBasePacket public SetPrivateStoreMsgSell(byte[] decrypt, ClientThread client) { super(decrypt); - String storename = readS(); - PlayerInstance player = client.getActiveChar(); + final String storename = readS(); + final PlayerInstance player = client.getActiveChar(); player.getTradeList().setSellStoreName(storename); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StartRotating.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StartRotating.java index 54fed182a8..b17eaeeea7 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StartRotating.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StartRotating.java @@ -27,9 +27,9 @@ public class StartRotating extends ClientBasePacket public StartRotating(byte[] decrypt, ClientThread client) { super(decrypt); - int degree = readD(); - int side = readD(); - BeginRotation br = new BeginRotation(client.getActiveChar(), degree, side); + final int degree = readD(); + final int side = readD(); + final BeginRotation br = new BeginRotation(client.getActiveChar(), degree, side); client.getActiveChar().sendPacket(br); client.getActiveChar().broadcastPacket(br); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StopMove.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StopMove.java index 663ed5ce62..dc869bd70a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StopMove.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/StopMove.java @@ -30,19 +30,19 @@ public class StopMove extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int x = readD(); + final int x = readD(); @SuppressWarnings("unused") - int y = readD(); + final int y = readD(); @SuppressWarnings("unused") - int z = readD(); - int heading = readD(); + final int z = readD(); + final int heading = readD(); - PlayerInstance player = client.getActiveChar(); + final PlayerInstance player = client.getActiveChar(); player.stopMove(); - StopMoveWithLocation smwl = new StopMoveWithLocation(player); + final StopMoveWithLocation smwl = new StopMoveWithLocation(player); client.getActiveChar().sendPacket(smwl); client.getActiveChar().broadcastPacket(smwl); - StopRotation sr = new StopRotation(client.getActiveChar(), heading); + final StopRotation sr = new StopRotation(client.getActiveChar(), heading); client.getActiveChar().sendPacket(sr); client.getActiveChar().broadcastPacket(sr); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeDone.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeDone.java index 41b0f15bca..f4765cf1dd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeDone.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeDone.java @@ -29,9 +29,9 @@ public class TradeDone extends ClientBasePacket public TradeDone(byte[] decrypt, ClientThread client) { super(decrypt); - int response = readD(); - PlayerInstance player = client.getActiveChar(); - PlayerInstance requestor = player.getTransactionRequester(); + final int response = readD(); + final PlayerInstance player = client.getActiveChar(); + final PlayerInstance requestor = player.getTransactionRequester(); if (requestor.getTransactionRequester() != null) { if (response == 1) @@ -45,7 +45,7 @@ public class TradeDone extends ClientBasePacket player.sendPacket(new SendTradeDone(1)); requestor.getTradeList().getItems().clear(); player.getTradeList().getItems().clear(); - SystemMessage msg = new SystemMessage(SystemMessage.TRADE_SUCCESSFUL); + final SystemMessage msg = new SystemMessage(SystemMessage.TRADE_SUCCESSFUL); requestor.sendPacket(msg); player.sendPacket(msg); requestor.setTransactionRequester(null); @@ -53,7 +53,7 @@ public class TradeDone extends ClientBasePacket } else { - SystemMessage msg = new SystemMessage(SystemMessage.S1_CONFIRMED_TRADE); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_CONFIRMED_TRADE); msg.addString(player.getName()); requestor.sendPacket(msg); } @@ -64,7 +64,7 @@ public class TradeDone extends ClientBasePacket requestor.sendPacket(new SendTradeDone(0)); player.setTradeList(null); requestor.setTradeList(null); - SystemMessage msg = new SystemMessage(SystemMessage.S1_CANCELED_TRADE); + final SystemMessage msg = new SystemMessage(SystemMessage.S1_CANCELED_TRADE); msg.addString(player.getName()); requestor.sendPacket(msg); requestor.setTransactionRequester(null); @@ -74,7 +74,7 @@ public class TradeDone extends ClientBasePacket else { player.sendPacket(new SendTradeDone(0)); - SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); + final SystemMessage msg = new SystemMessage(SystemMessage.TARGET_IS_NOT_FOUND_IN_THE_GAME); player.sendPacket(msg); player.setTransactionRequester(null); requestor.setTradeList(null); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeRequest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeRequest.java index b9cfe0a33a..39fef08918 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeRequest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/TradeRequest.java @@ -31,10 +31,10 @@ public class TradeRequest extends ClientBasePacket public TradeRequest(byte[] decrypt, ClientThread client) { super(decrypt); - int objectId = readD(); - PlayerInstance player = client.getActiveChar(); - World world = World.getInstance(); - WorldObject target = world.findObject(objectId); + final int objectId = readD(); + final PlayerInstance player = client.getActiveChar(); + final World world = World.getInstance(); + final WorldObject target = world.findObject(objectId); if ((target == null) || !(target instanceof PlayerInstance) || (target.getObjectId() != objectId)) { player.sendPacket(new SystemMessage(SystemMessage.TARGET_IS_INCORRECT)); @@ -45,19 +45,19 @@ public class TradeRequest extends ClientBasePacket player.sendPacket(new SystemMessage(SystemMessage.ALREADY_TRADING)); return; } - PlayerInstance pcTarget = (PlayerInstance) target; + final PlayerInstance pcTarget = (PlayerInstance) target; if (player.knownsObject(target) && !pcTarget.isTransactionInProgress()) { pcTarget.setTransactionRequester(player); player.setTransactionRequester(pcTarget); pcTarget.sendPacket(new SendTradeRequest(player.getObjectId())); - SystemMessage sm = new SystemMessage(SystemMessage.REQUEST_S1_FOR_TRADE); + final SystemMessage sm = new SystemMessage(SystemMessage.REQUEST_S1_FOR_TRADE); sm.addString(pcTarget.getName()); player.sendPacket(sm); } else { - SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_IS_BUSY_TRY_LATER); sm.addString(pcTarget.getName()); player.sendPacket(sm); _log.info("transaction already in progress."); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/UseItem.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/UseItem.java index 32448e5efb..3c50220a23 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/UseItem.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/UseItem.java @@ -37,12 +37,12 @@ public class UseItem extends ClientBasePacket public UseItem(byte[] decrypt, ClientThread client) throws IOException { super(decrypt); - int objectId = readD(); - PlayerInstance activeChar = client.getActiveChar(); - ItemInstance item = activeChar.getInventory().getItem(objectId); + final int objectId = readD(); + final PlayerInstance activeChar = client.getActiveChar(); + final ItemInstance item = activeChar.getInventory().getItem(objectId); if ((item != null) && item.isEquipable() && !activeChar.isInCombat()) { - List items = activeChar.getInventory().equipItem(item); + final List items = activeChar.getInventory().equipItem(item); if (item.getItem().getType2() == 0) { activeChar.updatePAtk(); @@ -56,27 +56,27 @@ public class UseItem extends ClientBasePacket { activeChar.updateMDef(); } - SystemMessage sm = new SystemMessage(SystemMessage.S1_EQUIPPED); + final SystemMessage sm = new SystemMessage(SystemMessage.S1_EQUIPPED); sm.addItemName(item.getItemId()); activeChar.sendPacket(sm); - InventoryUpdate iu = new InventoryUpdate(items); + final InventoryUpdate iu = new InventoryUpdate(items); activeChar.sendPacket(iu); - UserInfo ui = new UserInfo(activeChar); + final UserInfo ui = new UserInfo(activeChar); activeChar.sendPacket(ui); activeChar.setAttackStatus(false); - CharInfo info = new CharInfo(activeChar); + final CharInfo info = new CharInfo(activeChar); activeChar.broadcastPacket(info); } else if (item != null) { - IItemHandler handler = ItemHandler.getInstance().getItemHandler(item.getItemId()); + final IItemHandler handler = ItemHandler.getInstance().getItemHandler(item.getItemId()); if (handler == null) { _log.warning("no itemhandler registered for itemId:" + item.getItemId()); } else { - int count = handler.useItem(activeChar, item); + final int count = handler.useItem(activeChar, item); if (count > 0) { removeItemFromInventory(activeChar, item, count); @@ -87,8 +87,8 @@ public class UseItem extends ClientBasePacket private void removeItemFromInventory(PlayerInstance activeChar, ItemInstance item, int count) { - ItemInstance item2 = activeChar.getInventory().destroyItem(item.getObjectId(), count); - InventoryUpdate iu = new InventoryUpdate(); + final ItemInstance item2 = activeChar.getInventory().destroyItem(item.getObjectId(), count); + final InventoryUpdate iu = new InventoryUpdate(); if (item2.getCount() == 0) { iu.addRemovedItem(item2); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ValidatePosition.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ValidatePosition.java index 00a9fdacd5..17e45526b2 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ValidatePosition.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/clientpackets/ValidatePosition.java @@ -35,15 +35,15 @@ public class ValidatePosition extends ClientBasePacket { super(decrypt); @SuppressWarnings("unused") - int x = readD(); + final int x = readD(); @SuppressWarnings("unused") - int y = readD(); - int z = readD(); + final int y = readD(); + final int z = readD(); @SuppressWarnings("unused") - int heading = readD(); + final int heading = readD(); @SuppressWarnings("unused") - int data = readD(); - PlayerInstance activeChar = client.getActiveChar(); + final int data = readD(); + final PlayerInstance activeChar = client.getActiveChar(); if (activeChar != null) { // Connection con = client.getConnection(); @@ -57,8 +57,8 @@ public class ValidatePosition extends ClientBasePacket { int i; int delete = 0; - Set known = activeChar.getKnownObjects(); - List toBeDeleted = new ArrayList<>(); + final Set known = activeChar.getKnownObjects(); + final List toBeDeleted = new ArrayList<>(); for (WorldObject obj : known) { if (distance(activeChar, obj) <= 16000000L) @@ -97,8 +97,8 @@ public class ValidatePosition extends ClientBasePacket private long distance(WorldObject a, WorldObject b) { - long dX = a.getX() - b.getX(); - long dY = a.getY() - b.getY(); + final long dX = a.getX() - b.getX(); + final long dY = a.getY() - b.getY(); return (dX * dX) + (dY * dY); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AllyCrest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AllyCrest.java index 334b25007f..79f55ceb0d 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AllyCrest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AllyCrest.java @@ -39,9 +39,9 @@ public class AllyCrest extends ServerBasePacket writeD(_crestId); try { - FileInputStream fis = new FileInputStream(_crestFile); + final FileInputStream fis = new FileInputStream(_crestFile); // BufferedInputStream bfis = new BufferedInputStream(fis); - int crestSize = fis.available(); + final int crestSize = fis.available(); writeD(crestSize); int temp = -1; while ((temp = fis.read()) != -1) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillInfo.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillInfo.java index 89cb70b6ff..26d0319c07 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillInfo.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillInfo.java @@ -49,7 +49,7 @@ public class AquireSkillInfo extends ServerBasePacket writeD(_reqs.size()); for (int i = 0; i < _reqs.size(); ++i) { - Req temp = _reqs.get(i); + final Req temp = _reqs.get(i); writeD(temp.type); writeD(temp.id); writeD(temp.count); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillList.java index 24e4b6727f..801243a6f1 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/AquireSkillList.java @@ -36,7 +36,7 @@ public class AquireSkillList extends ServerBasePacket writeD(_skills.size()); for (int i = 0; i < _skills.size(); ++i) { - Skill temp = _skills.get(i); + final Skill temp = _skills.get(i); writeD(temp.id); writeD(temp.nextLevel); writeD(temp.maxLevel); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/BuyList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/BuyList.java index a894ab81e9..5847308086 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/BuyList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/BuyList.java @@ -40,13 +40,13 @@ public class BuyList extends ServerBasePacket writeC(29); writeD(_money); writeD(_list.getListId()); - int count = _list.getItems().size(); + final int count = _list.getItems().size(); writeH(count); - List items = _list.getItems(); + final List items = _list.getItems(); for (int i = 0; i < count; ++i) { - ItemInstance temp = items.get(i); - int type = temp.getItem().getType1(); + final ItemInstance temp = items.get(i); + final int type = temp.getItem().getType1(); writeH(type); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharSelectInfo.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharSelectInfo.java index dd263bde98..d89068a1b7 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharSelectInfo.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharSelectInfo.java @@ -123,11 +123,11 @@ public class CharSelectInfo extends ServerBasePacket public CharSelectInfoPackage[] loadCharacterSelectInfoFromDisk() { - File _charFolder = new File("data/accounts", _loginName); + final File _charFolder = new File("data/accounts", _loginName); _charFolder.mkdirs(); - File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); + final File[] chars = _charFolder.listFiles((FilenameFilter) (dir, name) -> name.endsWith("_char.csv")); _charNameList = new String[chars.length]; - CharSelectInfoPackage[] characters = new CharSelectInfoPackage[chars.length]; + final CharSelectInfoPackage[] characters = new CharSelectInfoPackage[chars.length]; for (int i = 0; i < chars.length; ++i) { _charInfopackage = new CharSelectInfoPackage(); @@ -154,11 +154,11 @@ public class CharSelectInfo extends ServerBasePacket String line = null; while ((line = ((LineNumberReader) lnr).readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, ";"); - ItemInstance item = new ItemInstance(); + final StringTokenizer st = new StringTokenizer(line, ";"); + final ItemInstance item = new ItemInstance(); item.setObjectId(Integer.parseInt(st.nextToken())); - int itemId = Integer.parseInt(st.nextToken()); - Item itemTemp = ItemTable.getInstance().getTemplate(itemId); + final int itemId = Integer.parseInt(st.nextToken()); + final Item itemTemp = ItemTable.getInstance().getTemplate(itemId); item.setItem(itemTemp); st.nextToken(); item.setCount(Integer.parseInt(st.nextToken())); @@ -198,8 +198,8 @@ public class CharSelectInfo extends ServerBasePacket { lnr = new LineNumberReader(new BufferedReader(new FileReader(charFile))); ((LineNumberReader) lnr).readLine(); - String line = ((LineNumberReader) lnr).readLine(); - StringTokenizer st = new StringTokenizer(line, ";"); + final String line = ((LineNumberReader) lnr).readLine(); + final StringTokenizer st = new StringTokenizer(line, ";"); st.nextToken(); _charInfopackage.setName(st.nextToken()); _charInfopackage.setLevel(Integer.parseInt(st.nextToken())); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharTemplates.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharTemplates.java index 5809c0dd86..0c5d965655 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharTemplates.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/CharTemplates.java @@ -38,7 +38,7 @@ public class CharTemplates extends ServerBasePacket writeD(_chars.size()); for (int i = 0; i < _chars.size(); ++i) { - CharTemplate temp = _chars.get(i); + final CharTemplate temp = _chars.get(i); writeD(temp.getRaceId()); writeD(temp.getClassId()); writeD(70); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/InventoryUpdate.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/InventoryUpdate.java index b6cb79f632..4923e021ba 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/InventoryUpdate.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/InventoryUpdate.java @@ -60,11 +60,11 @@ public class InventoryUpdate extends ServerBasePacket public byte[] getContent() { writeC(55); - int count = _items.size(); + final int count = _items.size(); writeH(count); for (int i = 0; i < count; ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); writeH(temp.getLastChange()); writeH(temp.getItem().getType1()); writeD(temp.getObjectId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/MagicEffectIcons.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/MagicEffectIcons.java index 7e3cd309f7..7a9ef18079 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/MagicEffectIcons.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/MagicEffectIcons.java @@ -36,7 +36,7 @@ public class MagicEffectIcons extends ServerBasePacket writeH(_effects.size()); for (int i = 0; i < _effects.size(); ++i) { - Effect temp = _effects.get(i); + final Effect temp = _effects.get(i); writeD(temp.skillId); writeH(temp.dat); writeD(temp.duration / 1000); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PartySmallWindowAll.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PartySmallWindowAll.java index 08dd888783..ae9803559a 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PartySmallWindowAll.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PartySmallWindowAll.java @@ -39,7 +39,7 @@ public class PartySmallWindowAll extends ServerBasePacket writeD(_partyMembers.size()); for (int i = 0; i < _partyMembers.size(); ++i) { - PlayerInstance member = _partyMembers.get(i); + final PlayerInstance member = _partyMembers.get(i); writeD(member.getObjectId()); writeS(member.getName()); writeD((int) member.getCurrentHp()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PetInventoryUpdate.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PetInventoryUpdate.java index aa2412da52..57c5cc736c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PetInventoryUpdate.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PetInventoryUpdate.java @@ -60,11 +60,11 @@ public class PetInventoryUpdate extends ServerBasePacket public byte[] getContent() { writeC(204); - int count = _items.size(); + final int count = _items.size(); writeH(count); for (int i = 0; i < count; ++i) { - ItemInstance temp = _items.get(i); + final ItemInstance temp = _items.get(i); writeH(temp.getLastChange()); writeH(temp.getItem().getType1()); writeD(temp.getObjectId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PledgeCrest.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PledgeCrest.java index ec2b6eeaa1..7418bc8d9d 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PledgeCrest.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PledgeCrest.java @@ -39,9 +39,9 @@ public class PledgeCrest extends ServerBasePacket writeD(_crestId); try { - FileInputStream fis = new FileInputStream(_crestFile); + final FileInputStream fis = new FileInputStream(_crestFile); // BufferedInputStream bfis = new BufferedInputStream(fis); - int crestSize = fis.available(); + final int crestSize = fis.available(); writeD(crestSize); int temp = -1; while ((temp = fis.read()) != -1) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListBuy.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListBuy.java index df4a53045b..7b69df98aa 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListBuy.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListBuy.java @@ -45,9 +45,9 @@ public class PrivateBuyListBuy extends ServerBasePacket writeC(209); writeD(_buyer.getObjectId()); writeD(_seller.getAdena()); - List buyerslist = _buyer.getBuyList(); - Collection sellerItems = _seller.getInventory().getItems(); - ArrayList sellerslist = new ArrayList<>(); + final List buyerslist = _buyer.getBuyList(); + final Collection sellerItems = _seller.getInventory().getItems(); + final ArrayList sellerslist = new ArrayList<>(); int count = buyerslist.size(); for (int i = 0; i < count; ++i) { @@ -90,8 +90,8 @@ public class PrivateBuyListBuy extends ServerBasePacket { temp2 = buyerslist.get(i); temp3 = sellerslist.get(i); - int buyCount = temp2.getCount(); - int sellCount = temp3.getCount(); + final int buyCount = temp2.getCount(); + final int sellCount = temp3.getCount(); writeD(temp3.getObjectId()); writeD(temp3.getItemId()); writeH(1); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListSell.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListSell.java index 3081f24fd4..e1b604e525 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListSell.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateBuyListSell.java @@ -38,11 +38,11 @@ public class PrivateBuyListSell extends ServerBasePacket writeC(180); writeD(_seller.getObjectId()); writeD(_buyer.getAdena()); - int count = _seller.getSellList().size(); + final int count = _seller.getSellList().size(); writeD(count); for (int i = 0; i < count; ++i) { - TradeItem temp2 = _seller.getSellList().get(i); + final TradeItem temp2 = _seller.getSellList().get(i); writeD(0); writeD(temp2.getObjectId()); writeD(temp2.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListBuy.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListBuy.java index 0969c9ba4c..e378fa225c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListBuy.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListBuy.java @@ -41,8 +41,8 @@ public class PrivateSellListBuy extends ServerBasePacket writeC(208); writeD(_buyer.getObjectId()); writeD(_buyer.getAdena()); - TradeList list = new TradeList(0); - List buyList = _buyer.getBuyList(); + final TradeList list = new TradeList(0); + final List buyList = _buyer.getBuyList(); int count = _buyer.getInventory().getSize(); for (ItemInstance item : _buyer.getInventory().getItems()) { @@ -56,7 +56,7 @@ public class PrivateSellListBuy extends ServerBasePacket writeD(count); for (i = 0; i < count; ++i) { - ItemInstance temp = list.getItems().get(i); + final ItemInstance temp = list.getItems().get(i); writeD(temp.getItemId()); writeH(0); writeD(temp.getCount()); @@ -71,7 +71,7 @@ public class PrivateSellListBuy extends ServerBasePacket { for (i = 0; i < count; ++i) { - TradeItem temp2 = buyList.get(i); + final TradeItem temp2 = buyList.get(i); writeD(temp2.getItemId()); writeH(0); writeD(temp2.getCount()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListSell.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListSell.java index 1a8beccfb0..0c85d1e66d 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListSell.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/PrivateSellListSell.java @@ -43,8 +43,8 @@ public class PrivateSellListSell extends ServerBasePacket writeC(179); writeD(_seller.getObjectId()); writeD(_seller.getAdena()); - TradeList list = new TradeList(0); - List sellList = _seller.getSellList(); + final TradeList list = new TradeList(0); + final List sellList = _seller.getSellList(); int count = _seller.getInventory().getSize(); for (ItemInstance item : _seller.getInventory().getItems()) { @@ -66,7 +66,7 @@ public class PrivateSellListSell extends ServerBasePacket writeD(count); for (i2 = 0; i2 < count; ++i2) { - ItemInstance temp = list.getItems().get(i2); + final ItemInstance temp = list.getItems().get(i2); writeD(0); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ServerBasePacket.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ServerBasePacket.java index f4fb911304..dc9493975b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ServerBasePacket.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ServerBasePacket.java @@ -52,7 +52,7 @@ public abstract class ServerBasePacket protected void writeF(double org) { - long value = Double.doubleToRawLongBits(org); + final long value = Double.doubleToRawLongBits(org); _bao.write((int) (value & 0xFFL)); _bao.write((int) ((value >> 8) & 0xFFL)); _bao.write((int) ((value >> 16) & 0xFFL)); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ShortCutInit.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ShortCutInit.java index 534bb6f830..1707fb0237 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ShortCutInit.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/ShortCutInit.java @@ -46,7 +46,7 @@ public class ShortCutInit extends ServerBasePacket writeD(_shortCuts.size()); for (int i = 0; i < _shortCuts.size(); ++i) { - ShortCut temp = _shortCuts.get(i); + final ShortCut temp = _shortCuts.get(i); writeD(temp.type); writeD(temp.slot); writeD(temp.typeId); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SkillList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SkillList.java index 047119f7df..14f95d6664 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SkillList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SkillList.java @@ -36,7 +36,7 @@ public class SkillList extends ServerBasePacket writeD(_skills.size()); for (int i = 0; i < _skills.size(); ++i) { - Skill temp = _skills.get(i); + final Skill temp = _skills.get(i); if (temp.passive) { writeD(1); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/StatusUpdate.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/StatusUpdate.java index f4b5fc4943..1e3955d922 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/StatusUpdate.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/StatusUpdate.java @@ -69,7 +69,7 @@ public class StatusUpdate extends ServerBasePacket writeD(_attributes.size()); for (int i = 0; i < _attributes.size(); ++i) { - Attribute temp = _attributes.get(i); + final Attribute temp = _attributes.get(i); writeD(temp.id); writeD(temp.value); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SystemMessage.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SystemMessage.java index ff4f4d1e59..1ed426c9a2 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SystemMessage.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/SystemMessage.java @@ -166,7 +166,7 @@ public class SystemMessage extends ServerBasePacket writeD(_types.size()); block5: for (int i = 0; i < _types.size(); ++i) { - int t = _types.get(i); + final int t = _types.get(i); writeD(t); switch (t) { @@ -179,13 +179,13 @@ public class SystemMessage extends ServerBasePacket case 2: case 3: { - int t1 = (Integer) _values.get(i); + final int t1 = (Integer) _values.get(i); writeD(t1); continue block5; } case 4: { - int t1 = (Integer) _values.get(i); + final int t1 = (Integer) _values.get(i); writeD(t1); writeD(1); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOtherAdd.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOtherAdd.java index e33a7c7e34..e96e880f49 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOtherAdd.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOtherAdd.java @@ -36,7 +36,7 @@ public class TradeOtherAdd extends ServerBasePacket { writeC(49); writeH(1); - int type = temp.getItem().getType1(); + final int type = temp.getItem().getType1(); writeH(type); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOwnAdd.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOwnAdd.java index 48668c313c..40dceb992b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOwnAdd.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeOwnAdd.java @@ -36,7 +36,7 @@ public class TradeOwnAdd extends ServerBasePacket { writeC(48); writeH(1); - int type = temp.getItem().getType1(); + final int type = temp.getItem().getType1(); writeH(type); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeStart.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeStart.java index 4caa2d49bb..d97a14e897 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeStart.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/TradeStart.java @@ -52,8 +52,8 @@ public class TradeStart extends ServerBasePacket writeH(count); for (int i = 0; i < count; ++i) { - ItemInstance temp = _tradelist.get(i); - int type = temp.getItem().getType1(); + final ItemInstance temp = _tradelist.get(i); + final int type = temp.getItem().getType1(); writeH(type); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseDepositList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseDepositList.java index 6b352693f1..99936e2931 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseDepositList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseDepositList.java @@ -41,7 +41,7 @@ public class WareHouseDepositList extends ServerBasePacket int i; writeC(83); writeD(_money); - List itemlist = new ArrayList<>(); + final List itemlist = new ArrayList<>(); int count = _cha.getInventory().getSize(); for (ItemInstance item : _cha.getInventory().getItems()) { @@ -55,7 +55,7 @@ public class WareHouseDepositList extends ServerBasePacket writeH(count); for (i = 0; i < count; ++i) { - ItemInstance temp = itemlist.get(i); + final ItemInstance temp = itemlist.get(i); writeH(temp.getItem().getType1()); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseWithdrawalList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseWithdrawalList.java index 2086a82de3..cedc991f3c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseWithdrawalList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/network/serverpackets/WareHouseWithdrawalList.java @@ -39,12 +39,12 @@ public class WareHouseWithdrawalList extends ServerBasePacket { writeC(84); writeD(_money); - int count = _cha.getWarehouse().getSize(); + final int count = _cha.getWarehouse().getSize(); writeH(count); - List items = _cha.getWarehouse().getItems(); + final List items = _cha.getWarehouse().getItems(); for (int i = 0; i < count; ++i) { - ItemInstance temp = items.get(i); + final ItemInstance temp = items.get(i); writeH(temp.getItem().getType1()); writeD(temp.getObjectId()); writeD(temp.getItemId()); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/Gui.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/Gui.java index 759643e0cd..08e595edd1 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/Gui.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/Gui.java @@ -90,14 +90,14 @@ public class Gui txtrConsole.getDocument().addDocumentListener(new LimitLinesDocumentListener(500)); // Initialize menu items. - JMenuBar menuBar = new JMenuBar(); + final JMenuBar menuBar = new JMenuBar(); menuBar.setFont(new Font("Segoe UI", Font.PLAIN, 14)); - JMenu mnActions = new JMenu("Actions"); + final JMenu mnActions = new JMenu("Actions"); mnActions.setFont(new Font("Segoe UI", Font.PLAIN, 13)); menuBar.add(mnActions); - JMenuItem mntmShutdown = new JMenuItem("Shutdown"); + final JMenuItem mntmShutdown = new JMenuItem("Shutdown"); mntmShutdown.setFont(new Font("Segoe UI", Font.PLAIN, 13)); mntmShutdown.addActionListener(arg0 -> { @@ -120,11 +120,11 @@ public class Gui }); mnActions.add(mntmShutdown); - JMenu mnReload = new JMenu("Reload"); + final JMenu mnReload = new JMenu("Reload"); mnReload.setFont(new Font("Segoe UI", Font.PLAIN, 13)); menuBar.add(mnReload); - JMenuItem mntmConfigs = new JMenuItem("Configs"); + final JMenuItem mntmConfigs = new JMenuItem("Configs"); mntmConfigs.setFont(new Font("Segoe UI", Font.PLAIN, 13)); mntmConfigs.addActionListener(arg0 -> { @@ -135,11 +135,11 @@ public class Gui }); mnReload.add(mntmConfigs); - JMenu mnAnnounce = new JMenu("Announce"); + final JMenu mnAnnounce = new JMenu("Announce"); mnAnnounce.setFont(new Font("Segoe UI", Font.PLAIN, 13)); menuBar.add(mnAnnounce); - JMenuItem mntmNormal = new JMenuItem("Normal"); + final JMenuItem mntmNormal = new JMenuItem("Normal"); mntmNormal.setFont(new Font("Segoe UI", Font.PLAIN, 13)); mntmNormal.addActionListener(arg0 -> { @@ -155,11 +155,11 @@ public class Gui }); mnAnnounce.add(mntmNormal); - JMenu mnFont = new JMenu("Font"); + final JMenu mnFont = new JMenu("Font"); mnFont.setFont(new Font("Segoe UI", Font.PLAIN, 13)); menuBar.add(mnFont); - String[] fonts = + final String[] fonts = { "16", "21", @@ -168,7 +168,7 @@ public class Gui }; for (String font : fonts) { - JMenuItem mntmFont = new JMenuItem(font); + final JMenuItem mntmFont = new JMenuItem(font); mntmFont.setFont(new Font("Segoe UI", Font.PLAIN, 13)); mntmFont.addActionListener(arg0 -> { @@ -177,11 +177,11 @@ public class Gui mnFont.add(mntmFont); } - JMenu mnHelp = new JMenu("Help"); + final JMenu mnHelp = new JMenu("Help"); mnHelp.setFont(new Font("Segoe UI", Font.PLAIN, 13)); menuBar.add(mnHelp); - JMenuItem mntmAbout = new JMenuItem("About"); + final JMenuItem mntmAbout = new JMenuItem("About"); mntmAbout.setFont(new Font("Segoe UI", Font.PLAIN, 13)); mntmAbout.addActionListener(arg0 -> { @@ -190,22 +190,22 @@ public class Gui mnHelp.add(mntmAbout); // Set icons. - List icons = new ArrayList<>(); + final List icons = new ArrayList<>(); icons.add(new ImageIcon(".\\images\\l2jmobius_16x16.png").getImage()); icons.add(new ImageIcon(".\\images\\l2jmobius_32x32.png").getImage()); icons.add(new ImageIcon(".\\images\\l2jmobius_64x64.png").getImage()); icons.add(new ImageIcon(".\\images\\l2jmobius_128x128.png").getImage()); // Set Panels. - JPanel systemPanel = new SystemPanel(); - JScrollPane scrollPanel = new JScrollPane(txtrConsole); + final JPanel systemPanel = new SystemPanel(); + final JScrollPane scrollPanel = new JScrollPane(txtrConsole); scrollPanel.setBounds(0, 0, 800, 550); - JLayeredPane layeredPanel = new JLayeredPane(); + final JLayeredPane layeredPanel = new JLayeredPane(); layeredPanel.add(scrollPanel, 0, 0); layeredPanel.add(systemPanel, 1, 0); // Set frame. - JFrame frame = new JFrame("Mobius - GameServer"); + final JFrame frame = new JFrame("Mobius - GameServer"); frame.setDefaultCloseOperation(WindowConstants.DO_NOTHING_ON_CLOSE); frame.addWindowListener(new WindowAdapter() { @@ -254,7 +254,7 @@ public class Gui // Method that manages the redirect. private void redirectSystemStreams() { - OutputStream out = new OutputStream() + final OutputStream out = new OutputStream() { @Override public void write(int b) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/SystemPanel.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/SystemPanel.java index 20ad382571..ba3e593cff 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/SystemPanel.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/SystemPanel.java @@ -51,32 +51,32 @@ public class SystemPanel extends JPanel setOpaque(true); setLayout(null); - JLabel lblProtocol = new JLabel("Protocol"); + final JLabel lblProtocol = new JLabel("Protocol"); lblProtocol.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblProtocol.setBounds(10, 5, 264, 17); add(lblProtocol); - JLabel lblConnected = new JLabel("Connected"); + final JLabel lblConnected = new JLabel("Connected"); lblConnected.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblConnected.setBounds(10, 23, 264, 17); add(lblConnected); - JLabel lblMaxConnected = new JLabel("Max connected"); + final JLabel lblMaxConnected = new JLabel("Max connected"); lblMaxConnected.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblMaxConnected.setBounds(10, 41, 264, 17); add(lblMaxConnected); - JLabel lblElapsedTime = new JLabel("Elapsed time"); + final JLabel lblElapsedTime = new JLabel("Elapsed time"); lblElapsedTime.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblElapsedTime.setBounds(10, 59, 264, 17); add(lblElapsedTime); - JLabel lblJavaVersion = new JLabel("Build JDK"); + final JLabel lblJavaVersion = new JLabel("Build JDK"); lblJavaVersion.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblJavaVersion.setBounds(10, 77, 264, 17); add(lblJavaVersion); - JLabel lblBuildDate = new JLabel("Build date"); + final JLabel lblBuildDate = new JLabel("Build date"); lblBuildDate.setFont(new Font("Monospaced", Font.PLAIN, 16)); lblBuildDate.setBounds(10, 95, 264, 17); add(lblBuildDate); @@ -90,9 +90,9 @@ public class SystemPanel extends JPanel lblBuildDate.setText("Build date: Unavailable"); try { - File jarName = Locator.getClassSource(GameServer.class); - JarFile jarFile = new JarFile(jarName); - Attributes attrs = jarFile.getManifest().getMainAttributes(); + final File jarName = Locator.getClassSource(GameServer.class); + final JarFile jarFile = new JarFile(jarName); + final Attributes attrs = jarFile.getManifest().getMainAttributes(); lblBuildDate.setText("Build date: " + attrs.getValue("Build-Date").split(" ")[0]); jarFile.close(); } @@ -125,13 +125,13 @@ public class SystemPanel extends JPanel static String getDurationBreakdown(long millis) { - long days = TimeUnit.MILLISECONDS.toDays(millis); + final long days = TimeUnit.MILLISECONDS.toDays(millis); millis -= TimeUnit.DAYS.toMillis(days); - long hours = TimeUnit.MILLISECONDS.toHours(millis); + final long hours = TimeUnit.MILLISECONDS.toHours(millis); millis -= TimeUnit.HOURS.toMillis(hours); - long minutes = TimeUnit.MILLISECONDS.toMinutes(millis); + final long minutes = TimeUnit.MILLISECONDS.toMinutes(millis); millis -= TimeUnit.MINUTES.toMillis(minutes); - long seconds = TimeUnit.MILLISECONDS.toSeconds(millis); + final long seconds = TimeUnit.MILLISECONDS.toSeconds(millis); return (days + "d " + hours + "h " + minutes + "m " + seconds + "s"); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/frmAbout.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/frmAbout.java index ea9a9f8842..0c766fa5f7 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/frmAbout.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/gameserver/ui/frmAbout.java @@ -60,30 +60,30 @@ public class frmAbout frmAbout.setType(Type.UTILITY); frmAbout.getContentPane().setLayout(null); - JLabel lblLjmobius = new JLabel("L2jMobius"); + final JLabel lblLjmobius = new JLabel("L2jMobius"); lblLjmobius.setFont(new Font("Tahoma", Font.PLAIN, 32)); lblLjmobius.setHorizontalAlignment(SwingConstants.CENTER); lblLjmobius.setBounds(10, 11, 271, 39); frmAbout.getContentPane().add(lblLjmobius); - JLabel lblData = new JLabel("2013-" + Calendar.getInstance().get(Calendar.YEAR)); + final JLabel lblData = new JLabel("2013-" + Calendar.getInstance().get(Calendar.YEAR)); lblData.setHorizontalAlignment(SwingConstants.CENTER); lblData.setBounds(10, 44, 271, 14); frmAbout.getContentPane().add(lblData); - JLabel lblSupports = new JLabel("Server Protocol"); + final JLabel lblSupports = new JLabel("Server Protocol"); lblSupports.setHorizontalAlignment(SwingConstants.CENTER); lblSupports.setFont(new Font("Tahoma", Font.PLAIN, 14)); lblSupports.setBounds(10, 78, 271, 23); frmAbout.getContentPane().add(lblSupports); - JLabel lblProtocols = new JLabel("Protocol Number"); + final JLabel lblProtocols = new JLabel("Protocol Number"); lblProtocols.setHorizontalAlignment(SwingConstants.CENTER); lblProtocols.setFont(new Font("Tahoma", Font.PLAIN, 14)); lblProtocols.setBounds(10, 92, 271, 23); frmAbout.getContentPane().add(lblProtocols); - JLabel site = new JLabel(URL); + final JLabel site = new JLabel(URL); site.setText("" + URL + ""); site.setHorizontalAlignment(SwingConstants.CENTER); site.setBounds(76, 128, 140, 14); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginController.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginController.java index 4f21fc1a86..e90a28e4bd 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginController.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginController.java @@ -92,7 +92,7 @@ public class LoginController public int getKeyForAccount(String account) { int key = 0; - Integer result = _logins.get(account); + final Integer result = _logins.get(account); if (result != null) { key = result; diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginServer.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginServer.java index a0808945c6..87505495a3 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginServer.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/LoginServer.java @@ -41,7 +41,7 @@ public class LoginServer extends Thread public static void main(String[] args) throws IOException { - LoginServer server = new LoginServer(); + final LoginServer server = new LoginServer(); _log.config("LoginServer Listening on port 2106"); server.start(); } @@ -56,9 +56,9 @@ public class LoginServer extends Thread do { // _log.fine("Waiting for client connection..."); - Socket connection = _serverSocket.accept(); + final Socket connection = _serverSocket.accept(); // _log.fine("Connection from " + connection.getInetAddress()); - String connectedIp = connection.getInetAddress().getHostAddress(); + final String connectedIp = connection.getInetAddress().getHostAddress(); if (connectedIp.startsWith("192.168.") || connectedIp.startsWith("10.")) { // _log.fine("Using internal ip as server ip " + Config.INTERNAL_HOST_NAME); @@ -84,7 +84,7 @@ public class LoginServer extends Thread if (!Config.LOGIN_HOST_NAME.equals("*")) { - InetAddress adr = InetAddress.getByName(Config.LOGIN_HOST_NAME); + final InetAddress adr = InetAddress.getByName(Config.LOGIN_HOST_NAME); _ip = adr.getHostAddress(); _log.config("LoginServer listening on IP:" + _ip + " Port 2106"); _serverSocket = new ServerSocket(2106, 50, adr); @@ -101,11 +101,11 @@ public class LoginServer extends Thread try { - File bannedFile = new File("banned_ip.cfg"); + final File bannedFile = new File("banned_ip.cfg"); if (bannedFile.isFile() && bannedFile.exists()) { int count = 0; - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(bannedFile))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(bannedFile))); String line = null; while ((line = lnr.readLine()) != null) { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/data/AccountData.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/data/AccountData.java index f956745abd..a4ef7b5de4 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/data/AccountData.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/data/AccountData.java @@ -46,7 +46,7 @@ public class AccountData public AccountData(boolean autoCreate) { _log.config("Automatically creating new accounts: " + Config.AUTO_CREATE_ACCOUNTS); - File loginFile = new File("data/accounts.txt"); + final File loginFile = new File("data/accounts.txt"); if (loginFile.exists()) { try @@ -68,7 +68,7 @@ public class AccountData public boolean loginValid(String user, String password, InetAddress address) throws HackingException { boolean ok = false; - Integer failedConnects = _hackProtection.get(address.getHostAddress()); + final Integer failedConnects = _hackProtection.get(address.getHostAddress()); if ((failedConnects != null) && (failedConnects > 2)) { _log.warning("Hacking detected from ip:" + address.getHostAddress() + " .. adding IP to banlist."); @@ -77,10 +77,10 @@ public class AccountData try { - MessageDigest md = MessageDigest.getInstance(SHA); - byte[] raw = password.getBytes(UTF_8); - byte[] hash = md.digest(raw); - byte[] expected = _logPass.get(user); + final MessageDigest md = MessageDigest.getInstance(SHA); + final byte[] raw = password.getBytes(UTF_8); + final byte[] hash = md.digest(raw); + final byte[] expected = _logPass.get(user); if (expected == null) { if (Config.AUTO_CREATE_ACCOUNTS) @@ -133,21 +133,21 @@ public class AccountData _logPass.clear(); int i = 0; String line = null; - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(loginFile))); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(new FileInputStream(loginFile))); while ((line = lnr.readLine()) != null) { - StringTokenizer st = new StringTokenizer(line, "\t\n\r"); + final StringTokenizer st = new StringTokenizer(line, "\t\n\r"); if (!st.hasMoreTokens()) { continue; } - String name = st.nextToken().toLowerCase(); - String password = st.nextToken(); + final String name = st.nextToken().toLowerCase(); + final String password = st.nextToken(); _logPass.put(name, Base64.getDecoder().decode(password)); if (st.hasMoreTokens()) { - String access = st.nextToken(); - Integer level = Integer.parseInt(access); + final String access = st.nextToken(); + final Integer level = Integer.parseInt(access); _accessLevels.put(name, level); } else @@ -164,7 +164,7 @@ public class AccountData { try { - FileWriter writer = new FileWriter(new File("data/accounts.txt")); + final FileWriter writer = new FileWriter(new File("data/accounts.txt")); for (String name : _logPass.keySet()) { writer.write(name); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/BlowfishEngine.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/BlowfishEngine.java index 5ea5243a8b..771215652c 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/BlowfishEngine.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/BlowfishEngine.java @@ -93,7 +93,7 @@ public class BlowfishEngine private void processTable(int xl, int xr, int[] table) { - int size = table.length; + final int size = table.length; for (int s = 0; s < size; s += 2) { xl ^= P[0]; @@ -115,7 +115,7 @@ public class BlowfishEngine System.arraycopy(KS2, 0, S2, 0, 256); System.arraycopy(KS3, 0, S3, 0, 256); System.arraycopy(KP, 0, P, 0, 18); - int keyLength = key.length; + final int keyLength = key.length; int keyIndex = 0; int i = 0; while (i < 18) @@ -130,7 +130,7 @@ public class BlowfishEngine } keyIndex = 0; } - int n = i++; + final int n = i++; P[n] = P[n] ^ data; } processTable(0, 0, P); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/ClientThread.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/ClientThread.java index 3628806d4e..381d03cd98 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/ClientThread.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/ClientThread.java @@ -53,7 +53,7 @@ public class ClientThread extends Thread public ClientThread(Socket client, AccountData logins, String host, int port) throws IOException { _csocket = client; - String ip = client.getInetAddress().getHostAddress(); + final String ip = client.getInetAddress().getHostAddress(); if (_bannedIPs.contains(ip)) { throw new IOException("banned IP"); @@ -80,9 +80,9 @@ public class ClientThread extends Thread String gameServerIp = null; try { - InetAddress adr = InetAddress.getByName(_gameServerHost); + final InetAddress adr = InetAddress.getByName(_gameServerHost); gameServerIp = adr.getHostAddress(); - Init startPacket = new Init(); + final Init startPacket = new Init(); _out.write(startPacket.getLength() & 255); _out.write((startPacket.getLength() >> 8) & 255); _out.write(startPacket.getContent()); @@ -96,7 +96,7 @@ public class ClientThread extends Thread { break; } - byte[] incoming = new byte[length]; + final byte[] incoming = new byte[length]; incoming[0] = (byte) lengthLo; incoming[1] = (byte) lengthHi; int newBytes = 0; @@ -114,27 +114,27 @@ public class ClientThread extends Thread System.arraycopy(incoming, 2, decrypt, 0, decrypt.length); decrypt = _crypt.decrypt(decrypt); checksumOk = _crypt.checksum(decrypt); - int packetType = decrypt[0] & 255; + final int packetType = decrypt[0] & 255; switch (packetType) { case 0: { - RequestAuthLogin ral = new RequestAuthLogin(decrypt); + final RequestAuthLogin ral = new RequestAuthLogin(decrypt); account = ral.getUser().toLowerCase(); - LoginController lc = LoginController.getInstance(); + final LoginController lc = LoginController.getInstance(); if (_logins.loginValid(account, ral.getPassword(), _csocket.getInetAddress())) { if (!lc.isAccountInGameServer(account) && !lc.isAccountInLoginServer(account)) { - int accessLevel = _logins.getAccessLevel(account); + final int accessLevel = _logins.getAccessLevel(account); if (accessLevel < 0) { - LoginFail lok = new LoginFail(LoginFail.REASON_ACCOUNT_BANNED); + final LoginFail lok = new LoginFail(LoginFail.REASON_ACCOUNT_BANNED); sendPacket(lok); break; } sessionKey = lc.assignSessionKeyToLogin(account, accessLevel, _csocket); - LoginOk lok = new LoginOk(); + final LoginOk lok = new LoginOk(); sendPacket(lok); break; } @@ -150,27 +150,27 @@ public class ClientThread extends Thread lc.getClientConnection(account).close(); lc.removeGameServerLogin(account); } - LoginFail lok = new LoginFail(LoginFail.REASON_ACCOUNT_IN_USE); + final LoginFail lok = new LoginFail(LoginFail.REASON_ACCOUNT_IN_USE); sendPacket(lok); break; } - LoginFail lok = new LoginFail(LoginFail.REASON_USER_OR_PASS_WRONG); + final LoginFail lok = new LoginFail(LoginFail.REASON_USER_OR_PASS_WRONG); sendPacket(lok); break; } case 2: { // RequestServerLogin rsl = new RequestServerLogin(decrypt); - PlayOk po = new PlayOk(sessionKey); + final PlayOk po = new PlayOk(sessionKey); sendPacket(po); break; } case 5: { // RequestServerList rsl = new RequestServerList(decrypt); - ServerList sl = new ServerList(); - int current = LoginController.getInstance().getOnlinePlayerCount(); - int max = LoginController.getInstance().getMaxAllowedOnlinePlayers(); + final ServerList sl = new ServerList(); + final int current = LoginController.getInstance().getOnlinePlayerCount(); + final int max = LoginController.getInstance().getMaxAllowedOnlinePlayers(); sl.addServer(gameServerIp, _gameServerPort, true, false, current, max); sendPacket(sl); break; @@ -228,7 +228,7 @@ public class ClientThread extends Thread byte[] data = sl.getContent(); _crypt.checksum(data); data = _crypt.crypt(data); - int len = data.length + 2; + final int len = data.length + 2; _out.write(len & 0xFF); _out.write((len >> 8) & 0xFF); _out.write(data); @@ -240,7 +240,7 @@ public class ClientThread extends Thread int a; int charpoint; byte t1; - StringBuffer result = new StringBuffer(); + final StringBuffer result = new StringBuffer(); int counter = 0; for (int i = 0; i < len; ++i) { @@ -267,7 +267,7 @@ public class ClientThread extends Thread result.append("\n"); counter = 0; } - int rest = data.length % 16; + final int rest = data.length % 16; if (rest > 0) { for (int i = 0; i < (17 - rest); ++i) @@ -302,7 +302,7 @@ public class ClientThread extends Thread @SuppressWarnings("unused") private String getTerminatedString(byte[] data, int offset) { - StringBuffer result = new StringBuffer(); + final StringBuffer result = new StringBuffer(); for (int i = offset; (i < data.length) && (data[i] != 0); ++i) { result.append((char) data[i]); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/NewCrypt.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/NewCrypt.java index 1097928f50..3b29063009 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/NewCrypt.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/NewCrypt.java @@ -26,7 +26,7 @@ public class NewCrypt public NewCrypt(String key) { - byte[] keybytes = key.getBytes(); + final byte[] keybytes = key.getBytes(); _crypt = new BlowfishEngine(); _crypt.init(true, keybytes); _decrypt = new BlowfishEngine(); @@ -37,7 +37,7 @@ public class NewCrypt { long ecx; long chksum = 0L; - int count = raw.length - 8; + final int count = raw.length - 8; int i = 0; for (i = 0; i < count; i += 4) { @@ -58,8 +58,8 @@ public class NewCrypt public byte[] decrypt(byte[] raw) throws IOException { - byte[] result = new byte[raw.length]; - int count = raw.length / 8; + final byte[] result = new byte[raw.length]; + final int count = raw.length / 8; for (int i = 0; i < count; ++i) { _decrypt.processBlock(raw, i * 8, result, i * 8); @@ -69,8 +69,8 @@ public class NewCrypt public byte[] crypt(byte[] raw) throws IOException { - int count = raw.length / 8; - byte[] result = new byte[raw.length]; + final int count = raw.length / 8; + final byte[] result = new byte[raw.length]; for (int i = 0; i < count; ++i) { _crypt.processBlock(raw, i * 8, result, i * 8); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/clientpackets/ClientBasePacket.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/clientpackets/ClientBasePacket.java index e68a59a470..323cedf55f 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/clientpackets/ClientBasePacket.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/clientpackets/ClientBasePacket.java @@ -38,7 +38,7 @@ public abstract class ClientBasePacket public int readC() { - int result = _decrypt[_off++] & 0xFF; + final int result = _decrypt[_off++] & 0xFF; return result; } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerBasePacket.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerBasePacket.java index a41594df84..5d038ac4bf 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerBasePacket.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerBasePacket.java @@ -49,7 +49,7 @@ public abstract class ServerBasePacket protected void writeF(double org) { - long value = Double.doubleToRawLongBits(org); + final long value = Double.doubleToRawLongBits(org); _bao.write((int) (value & 0xFFL)); _bao.write((int) ((value >> 8) & 0xFFL)); _bao.write((int) ((value >> 16) & 0xFFL)); @@ -85,7 +85,7 @@ public abstract class ServerBasePacket public byte[] getBytes() { writeD(0); - int padding = _bao.size() % 8; + final int padding = _bao.size() % 8; if (padding != 0) { for (int i = padding; i < 8; ++i) diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerList.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerList.java index cc92f9c797..9e6c50a621 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerList.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/loginserver/network/serverpackets/ServerList.java @@ -39,12 +39,12 @@ public class ServerList extends ServerBasePacket writeC(0); for (int i = 0; i < _servers.size(); ++i) { - ServerData server = _servers.get(i); + final ServerData server = _servers.get(i); writeC(i + 1); try { - InetAddress i4 = InetAddress.getByName(server.ip); - byte[] raw = i4.getAddress(); + final InetAddress i4 = InetAddress.getByName(server.ip); + final byte[] raw = i4.getAddress(); writeC(raw[0] & 0xFF); writeC(raw[1] & 0xFF); writeC(raw[2] & 0xFF); diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/tools/accountmanager/AccountManager.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/tools/accountmanager/AccountManager.java index c18f3752e5..eb924b215b 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/tools/accountmanager/AccountManager.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/tools/accountmanager/AccountManager.java @@ -44,7 +44,7 @@ public class AccountManager System.out.println("3 - Delete existing account (this option _keeps_ character files)"); System.out.println("4 - List accounts & access levels"); System.out.println("5 - exit"); - LineNumberReader _in = new LineNumberReader(new InputStreamReader(System.in)); + final LineNumberReader _in = new LineNumberReader(new InputStreamReader(System.in)); while (!(_mode.equals("1") || _mode.equals("2") || _mode.equals("3") || _mode.equals("4") || _mode.equals("5"))) { System.out.print("Your choice: "); @@ -80,7 +80,7 @@ public class AccountManager if (_mode.equals("3")) { System.out.print("Do you really want to delete this account ? Y/N : "); - String yesno = _in.readLine(); + final String yesno = _in.readLine(); if (!yesno.equals("Y")) { _mode = "5"; @@ -99,14 +99,14 @@ public class AccountManager private static void printAccInfo(String fin) throws FileNotFoundException, IOException { - File _test = new File(fin); + final File _test = new File(fin); if (!_test.exists()) { _test.createNewFile(); } - FileInputStream in = new FileInputStream(fin); + final FileInputStream in = new FileInputStream(fin); @SuppressWarnings("resource") - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(in)); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(in)); String line = null; int count = 0; System.out.println("--------------"); @@ -121,20 +121,20 @@ public class AccountManager private static void updateAccounts(String fin, String fout) throws FileNotFoundException, IOException, NoSuchAlgorithmException { - File _test = new File(fin); + final File _test = new File(fin); if (!_test.exists()) { _test.createNewFile(); } - FileInputStream in = new FileInputStream(fin); - FileWriter out = new FileWriter(fout); - MessageDigest md = MessageDigest.getInstance("SHA"); + final FileInputStream in = new FileInputStream(fin); + final FileWriter out = new FileWriter(fout); + final MessageDigest md = MessageDigest.getInstance("SHA"); byte[] newpass = _pass.getBytes("UTF-8"); newpass = md.digest(newpass); try { @SuppressWarnings("resource") - LineNumberReader lnr = new LineNumberReader(new InputStreamReader(in)); + final LineNumberReader lnr = new LineNumberReader(new InputStreamReader(in)); String line = null; boolean added = false; while ((line = lnr.readLine()) != null) @@ -177,8 +177,8 @@ public class AccountManager { out.close(); in.close(); - File _fin = new File(fin); - File _fout = new File(fout); + final File _fin = new File(fin); + final File _fout = new File(fout); _fin.delete(); _fout.renameTo(_fin); } @@ -191,8 +191,8 @@ public class AccountManager { out.close(); in.close(); - File _fin = new File(fin); - File _fout = new File(fout); + final File _fin = new File(fin); + final File _fout = new File(fout); _fin.delete(); _fout.renameTo(_fin); } diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/LimitLinesDocumentListener.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/LimitLinesDocumentListener.java index 30bb652678..550f161d39 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/LimitLinesDocumentListener.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/LimitLinesDocumentListener.java @@ -72,7 +72,7 @@ public class LimitLinesDocumentListener implements DocumentListener { if (maximumLines < 1) { - String message = "Maximum lines must be greater than 0"; + final String message = "Maximum lines must be greater than 0"; throw new IllegalArgumentException(message); } @@ -105,8 +105,8 @@ public class LimitLinesDocumentListener implements DocumentListener private void removeLines(DocumentEvent e) { // The root Element of the Document will tell us the total number of line in the Document. - Document document = e.getDocument(); - Element root = document.getDefaultRootElement(); + final Document document = e.getDocument(); + final Element root = document.getDefaultRootElement(); while (root.getElementCount() > _maximumLines) { @@ -126,8 +126,8 @@ public class LimitLinesDocumentListener implements DocumentListener */ private void removeFromStart(Document document, Element root) { - Element line = root.getElement(0); - int end = line.getEndOffset(); + final Element line = root.getElement(0); + final int end = line.getEndOffset(); try { @@ -146,9 +146,9 @@ public class LimitLinesDocumentListener implements DocumentListener { // We use start minus 1 to make sure we remove the newline character of the previous line. - Element line = root.getElement(root.getElementCount() - 1); - int start = line.getStartOffset(); - int end = line.getEndOffset(); + final Element line = root.getElement(root.getElementCount() - 1); + final int start = line.getStartOffset(); + final int end = line.getEndOffset(); try { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/Locator.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/Locator.java index dd61677ab7..7fbb5e04d8 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/Locator.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/Locator.java @@ -46,7 +46,7 @@ public class Locator */ public static File getClassSource(Class c) { - String classResource = c.getName().replace('.', '/') + ".class"; + final String classResource = c.getName().replace('.', '/') + ".class"; return getResourceSource(c.getClassLoader(), classResource); } @@ -74,17 +74,17 @@ public class Locator } if (url != null) { - String u = url.toString(); + final String u = url.toString(); if (u.startsWith("jar:file:")) { - int pling = u.indexOf("!"); - String jarName = u.substring(4, pling); + final int pling = u.indexOf("!"); + final String jarName = u.substring(4, pling); return new File(fromURI(jarName)); } else if (u.startsWith("file:")) { - int tail = u.indexOf(resource); - String dirName = u.substring(0, tail); + final int tail = u.indexOf(resource); + final String dirName = u.substring(0, tail); return new File(fromURI(dirName)); } } @@ -118,13 +118,13 @@ public class Locator { throw new IllegalArgumentException("Can only handle valid file: URIs"); } - StringBuffer buf = new StringBuffer(url.getHost()); + final StringBuffer buf = new StringBuffer(url.getHost()); if (buf.length() > 0) { buf.insert(0, File.separatorChar).insert(0, File.separatorChar); } - String file = url.getFile(); - int queryPos = file.indexOf('?'); + final String file = url.getFile(); + final int queryPos = file.indexOf('?'); buf.append((queryPos < 0) ? file : file.substring(0, queryPos)); uri = buf.toString().replace('/', File.separatorChar); @@ -133,7 +133,7 @@ public class Locator { uri = uri.substring(1); } - String path = decodeUri(uri); + final String path = decodeUri(uri); return path; } @@ -148,20 +148,20 @@ public class Locator { return uri; } - StringBuffer sb = new StringBuffer(); - CharacterIterator iter = new StringCharacterIterator(uri); + final StringBuffer sb = new StringBuffer(); + final CharacterIterator iter = new StringCharacterIterator(uri); for (char c = iter.first(); c != CharacterIterator.DONE; c = iter.next()) { if (c == '%') { - char c1 = iter.next(); + final char c1 = iter.next(); if (c1 != CharacterIterator.DONE) { - int i1 = Character.digit(c1, 16); - char c2 = iter.next(); + final int i1 = Character.digit(c1, 16); + final char c2 = iter.next(); if (c2 != CharacterIterator.DONE) { - int i2 = Character.digit(c2, 16); + final int i2 = Character.digit(c2, 16); sb.append((char) ((i1 << 4) + i2)); } } @@ -171,7 +171,7 @@ public class Locator sb.append(c); } } - String path = sb.toString(); + final String path = sb.toString(); return path; } @@ -212,7 +212,7 @@ public class Locator { javaHome = javaHome.substring(0, javaHome.length() - 4); } - File toolsJar = new File(javaHome + "/lib/tools.jar"); + final File toolsJar = new File(javaHome + "/lib/tools.jar"); if (!toolsJar.exists()) { System.out.println("Unable to locate tools.jar. " + "Expected to find it in " + toolsJar.getPath()); @@ -254,7 +254,7 @@ public class Locator if (!location.isDirectory()) { urls = new URL[1]; - String path = location.getPath(); + final String path = location.getPath(); for (String extension : extensions) { if (path.toLowerCase().endsWith(extension)) @@ -265,7 +265,7 @@ public class Locator } return urls; } - File[] matches = location.listFiles((FilenameFilter) (dir, name) -> + final File[] matches = location.listFiles((FilenameFilter) (dir, name) -> { for (String extension : extensions) { diff --git a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/SplashScreen.java b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/SplashScreen.java index 0e4e1a5b5e..e24bd7fef3 100644 --- a/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/SplashScreen.java +++ b/L2J_Mobius_C1_HarbingersOfWar/java/org/l2jmobius/util/SplashScreen.java @@ -45,7 +45,7 @@ public class SplashScreen extends JWindow { setBackground(new Color(0, 255, 0, 0)); // Transparency. image = Toolkit.getDefaultToolkit().getImage(path); - ImageIcon imageIcon = new ImageIcon(image); + final ImageIcon imageIcon = new ImageIcon(image); setSize(imageIcon.getIconWidth(), imageIcon.getIconHeight()); setLocationRelativeTo(null); setAlwaysOnTop(true);
Current Target:

Object ID: " + getObjectId() + "