Proper naming for various methods and variables.
This commit is contained in:
@@ -94,13 +94,12 @@ public class DrChaos extends AbstractNpcAI
|
||||
final GrandBoss golem = (GrandBoss) addSpawn(CHAOS_GOLEM, loc_x, loc_y, loc_z, heading, false, 0, false);
|
||||
GrandBossManager.getInstance().addBoss(golem);
|
||||
|
||||
final Npc _golem = golem;
|
||||
_golem.setCurrentHpMp(hp, mp);
|
||||
_golem.setRunning();
|
||||
golem.setCurrentHpMp(hp, mp);
|
||||
golem.setRunning();
|
||||
|
||||
// start monitoring Dr. Chaos's inactivity
|
||||
_lastAttackVsGolem = Chronos.currentTimeMillis();
|
||||
startQuestTimer("golem_despawn", 60000, _golem, null, true);
|
||||
startQuestTimer("golem_despawn", 60000, golem, null, true);
|
||||
}
|
||||
// Spawn the regular NPC.
|
||||
else
|
||||
|
@@ -662,7 +662,7 @@ public class LastImperialTomb extends AbstractInstance
|
||||
}
|
||||
else // Teleport Cube
|
||||
{
|
||||
final Instance world = getPlayer(player);
|
||||
final Instance world = getPlayerInstance(player);
|
||||
if (world != null)
|
||||
{
|
||||
teleportPlayerOut(player, world);
|
||||
|
@@ -67,8 +67,8 @@ public class RudolphsBlessing extends LongTimeEvent
|
||||
if (takeItems(player, ITEM_REQUIREMENT.getId(), ITEM_REQUIREMENT.getCount()))
|
||||
{
|
||||
SkillCaster.triggerCast(player, player, RUDOLPH_TRYUCK.getSkill());
|
||||
final Skill RudolphsBlessing = SkillData.getInstance().getSkill(23297, 1);
|
||||
RudolphsBlessing.applyEffects(player, player);
|
||||
final Skill rudolphsBlessing = SkillData.getInstance().getSkill(23297, 1);
|
||||
rudolphsBlessing.applyEffects(player, player);
|
||||
}
|
||||
startQuestTimer("rudolph_eat", 10 * 60 * 1000, null, player);
|
||||
}
|
||||
|
@@ -1230,7 +1230,7 @@ public class AdminEditChar implements IAdminCommandHandler
|
||||
*/
|
||||
private void findCharacter(Player activeChar, String characterToFind)
|
||||
{
|
||||
int CharactersFound = 0;
|
||||
int charactersFound = 0;
|
||||
String name;
|
||||
final NpcHtmlMessage adminReply = new NpcHtmlMessage(0, 1);
|
||||
adminReply.setFile(activeChar, "data/html/admin/charfind.htm");
|
||||
@@ -1243,7 +1243,7 @@ public class AdminEditChar implements IAdminCommandHandler
|
||||
name = player.getName();
|
||||
if (name.toLowerCase().contains(characterToFind.toLowerCase()))
|
||||
{
|
||||
CharactersFound += 1;
|
||||
charactersFound += 1;
|
||||
replyMSG.append("<tr><td width=80><a action=\"bypass -h admin_character_info ");
|
||||
replyMSG.append(name);
|
||||
replyMSG.append("\">");
|
||||
@@ -1254,7 +1254,7 @@ public class AdminEditChar implements IAdminCommandHandler
|
||||
replyMSG.append(player.getLevel());
|
||||
replyMSG.append("</td></tr>");
|
||||
}
|
||||
if (CharactersFound > 20)
|
||||
if (charactersFound > 20)
|
||||
{
|
||||
break;
|
||||
}
|
||||
@@ -1262,16 +1262,16 @@ public class AdminEditChar implements IAdminCommandHandler
|
||||
adminReply.replace("%results%", replyMSG.toString());
|
||||
|
||||
final String replyMSG2;
|
||||
if (CharactersFound == 0)
|
||||
if (charactersFound == 0)
|
||||
{
|
||||
replyMSG2 = "s. Please try again.";
|
||||
}
|
||||
else if (CharactersFound > 20)
|
||||
else if (charactersFound > 20)
|
||||
{
|
||||
adminReply.replace("%number%", " more than 20");
|
||||
replyMSG2 = "s.<br>Please refine your search to see all of the results.";
|
||||
}
|
||||
else if (CharactersFound == 1)
|
||||
else if (charactersFound == 1)
|
||||
{
|
||||
replyMSG2 = ".";
|
||||
}
|
||||
@@ -1280,7 +1280,7 @@ public class AdminEditChar implements IAdminCommandHandler
|
||||
replyMSG2 = "s.";
|
||||
}
|
||||
|
||||
adminReply.replace("%number%", String.valueOf(CharactersFound));
|
||||
adminReply.replace("%number%", String.valueOf(charactersFound));
|
||||
adminReply.replace("%end%", replyMSG2);
|
||||
activeChar.sendPacket(adminReply);
|
||||
}
|
||||
|
@@ -66,9 +66,9 @@ public abstract class AbstractInstance extends AbstractNpcAI
|
||||
* @param player player who wants get instance world
|
||||
* @return instance world if found, otherwise null
|
||||
*/
|
||||
public Instance getPlayer(Player player)
|
||||
public Instance getPlayerInstance(Player player)
|
||||
{
|
||||
return InstanceManager.getInstance().getPlayer(player, false);
|
||||
return InstanceManager.getInstance().getPlayerInstance(player, false);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -107,7 +107,7 @@ public abstract class AbstractInstance extends AbstractNpcAI
|
||||
*/
|
||||
protected final void enterInstance(Player player, Npc npc, int templateId)
|
||||
{
|
||||
Instance instance = getPlayer(player);
|
||||
Instance instance = getPlayerInstance(player);
|
||||
if (instance != null) // Player has already any instance active
|
||||
{
|
||||
if (instance.getTemplateId() != templateId)
|
||||
@@ -153,7 +153,7 @@ public abstract class AbstractInstance extends AbstractNpcAI
|
||||
// Check if any player from enter group has active instance
|
||||
for (Player member : enterGroup)
|
||||
{
|
||||
if (getPlayer(member) != null)
|
||||
if (getPlayerInstance(member) != null)
|
||||
{
|
||||
enterGroup.forEach(p -> p.sendPacket(SystemMessageId.YOU_HAVE_ENTERED_ANOTHER_INSTANT_ZONE_THEREFORE_YOU_CANNOT_ENTER_CORRESPONDING_DUNGEON));
|
||||
return;
|
||||
|
@@ -250,16 +250,16 @@ public class Q00350_EnhanceYourWeapon extends Quest
|
||||
|
||||
private static void exchangeCrystal(Player player, Attackable mob, int takeid, int giveid, boolean broke)
|
||||
{
|
||||
Item Item = player.getInventory().destroyItemByItemId("SoulCrystal", takeid, 1, player, mob);
|
||||
if (Item != null)
|
||||
Item item = player.getInventory().destroyItemByItemId("SoulCrystal", takeid, 1, player, mob);
|
||||
if (item != null)
|
||||
{
|
||||
// Prepare inventory update packet
|
||||
final InventoryUpdate playerIU = new InventoryUpdate();
|
||||
playerIU.addRemovedItem(Item);
|
||||
playerIU.addRemovedItem(item);
|
||||
|
||||
// Add new crystal to the killer's inventory
|
||||
Item = player.getInventory().addItem("SoulCrystal", giveid, 1, player, mob);
|
||||
playerIU.addItem(Item);
|
||||
item = player.getInventory().addItem("SoulCrystal", giveid, 1, player, mob);
|
||||
playerIU.addItem(item);
|
||||
|
||||
// Send a sound event and text message to the player
|
||||
if (broke)
|
||||
|
Reference in New Issue
Block a user