lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prohibit parameter assignments.

Browse Source
This commit is contained in:
MobiusDevelopment
2020-05-10 03:29:34 +00:00
parent 2d73110d15
commit 33bbf97afb
1756 changed files with 12542 additions and 10025 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/ai/others/ClanHallManager/ClanHallManager.java vendored
View File

@@ -462,8 +462,9 @@ public class ClanHallManager extends AbstractNpcAI
World.getInstance().forEachVisibleObject(npc, PlayerInstance.class, player -> player.sendPacket(new AgitDecoInfo(clanHall)));
}
private String getFunctionInfo(ResidenceFunction func, String htmltext, String name)
private String getFunctionInfo(ResidenceFunction func, String htmltextValue, String name)
{
String htmltext = htmltextValue;
if (func != null)
{
htmltext = htmltext.replaceAll("%" + name + "recovery%", String.valueOf((int) func.getTemplate().getValue()) + "%");

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/ai/others/ClassMaster/ClassMaster.java vendored
View File

@@ -235,7 +235,7 @@ public class ClassMaster extends AbstractNpcAI implements IXmlReader
}
@Override
public String onAdvEvent(String event, Npc npc, PlayerInstance player)
public String onAdvEvent(String eventValue, Npc npc, PlayerInstance player)
{
if (!_isEnabled)
{
@@ -243,6 +243,7 @@ public class ClassMaster extends AbstractNpcAI implements IXmlReader
}
String htmltext = null;
String event = eventValue;
final StringTokenizer st = new StringTokenizer(event);
event = st.nextToken();
switch (event)

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminBuffs.java vendored
View File

@@ -61,8 +61,9 @@ public class AdminBuffs implements IAdminCommandHandler
private static final String FONT_RED2 = "</font>";
@Override
public boolean useAdminCommand(String command, PlayerInstance activeChar)
public boolean useAdminCommand(String commandValue, PlayerInstance activeChar)
{
String command = commandValue;
if (command.startsWith("admin_buff"))
{
if ((activeChar.getTarget() == null) || !activeChar.getTarget().isCreature())

6
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminEditChar.java vendored
View File

@@ -1075,8 +1075,9 @@ public class AdminEditChar implements IAdminCommandHandler
activeChar.sendPacket(html);
}
private void showCharacterInfo(PlayerInstance activeChar, PlayerInstance player)
private void showCharacterInfo(PlayerInstance activeChar, PlayerInstance targetPlayer)
{
PlayerInstance player = targetPlayer;
if (player == null)
{
final WorldObject target = activeChar.getTarget();
@@ -1177,7 +1178,7 @@ public class AdminEditChar implements IAdminCommandHandler
activeChar.sendPacket(adminReply);
}
private void setTargetReputation(PlayerInstance activeChar, int newReputation)
private void setTargetReputation(PlayerInstance activeChar, int value)
{
final WorldObject target = activeChar.getTarget();
PlayerInstance player = null;
@@ -1190,6 +1191,7 @@ public class AdminEditChar implements IAdminCommandHandler
return;
}
int newReputation = value;
if (newReputation > Config.MAX_REPUTATION)
{
newReputation = Config.MAX_REPUTATION;

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminEffects.java vendored
View File

@@ -109,8 +109,9 @@ public class AdminEffects implements IAdminCommandHandler
};
@Override
public boolean useAdminCommand(String command, PlayerInstance activeChar)
public boolean useAdminCommand(String commandValue, PlayerInstance activeChar)
{
String command = commandValue;
final StringTokenizer st = new StringTokenizer(command);
st.nextToken();

12
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminFightCalculator.java vendored
View File

@@ -160,10 +160,10 @@ public class AdminFightCalculator implements IAdminCommandHandler
private void handleShow(String params, PlayerInstance activeChar)
{
params = params.trim();
String trimmedParams = params.trim();
Creature npc1 = null;
Creature npc2 = null;
if (params.isEmpty())
if (trimmedParams.isEmpty())
{
npc1 = activeChar;
npc2 = (Creature) activeChar.getTarget();
@@ -177,7 +177,7 @@ public class AdminFightCalculator implements IAdminCommandHandler
{
int mid1 = 0;
int mid2 = 0;
final StringTokenizer st = new StringTokenizer(params);
final StringTokenizer st = new StringTokenizer(trimmedParams);
mid1 = Integer.parseInt(st.nextToken());
mid2 = Integer.parseInt(st.nextToken());
npc1 = new MonsterInstance(NpcData.getInstance().getTemplate(mid1));
@@ -291,7 +291,7 @@ public class AdminFightCalculator implements IAdminCommandHandler
final NpcHtmlMessage adminReply = new NpcHtmlMessage(0, 1);
final StringBuilder replyMSG = new StringBuilder(1000);
replyMSG.append("<html><title>Selected mobs to fight</title><body><table>");
if (params.isEmpty())
if (trimmedParams.isEmpty())
{
replyMSG.append("<tr><td width=140>Parameter</td><td width=70>me</td><td width=70>target</td></tr>");
}
@@ -321,7 +321,7 @@ public class AdminFightCalculator implements IAdminCommandHandler
replyMSG.append("</tr></table><center><br>");
if (params.isEmpty())
if (trimmedParams.isEmpty())
{
replyMSG.append("<button value=\"Retry\" action=\"bypass -h admin_fight_calculator_show\" width=100 height=15 back=\"L2UI_ct1.button_df\" fore=\"L2UI_ct1.button_df\">");
}
@@ -334,7 +334,7 @@ public class AdminFightCalculator implements IAdminCommandHandler
adminReply.setHtml(replyMSG.toString());
activeChar.sendPacket(adminReply);
if (params.length() != 0)
if (trimmedParams.length() != 0)
{
npc1.deleteMe();
npc2.deleteMe();

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminFortSiege.java vendored
View File

@@ -49,8 +49,9 @@ public class AdminFortSiege implements IAdminCommandHandler
};
@Override
public boolean useAdminCommand(String command, PlayerInstance activeChar)
public boolean useAdminCommand(String commandValue, PlayerInstance activeChar)
{
String command = commandValue;
final StringTokenizer st = new StringTokenizer(command, " ");
command = st.nextToken(); // Get actual command

8
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminSkill.java vendored
View File

@@ -86,8 +86,9 @@ public class AdminSkill implements IAdminCommandHandler
private static Skill[] adminSkills;
@Override
public boolean useAdminCommand(String command, PlayerInstance activeChar)
public boolean useAdminCommand(String commandValue, PlayerInstance activeChar)
{
String command = commandValue;
if (command.equals("admin_show_skills"))
{
showMainPage(activeChar);
@@ -343,9 +344,9 @@ public class AdminSkill implements IAdminCommandHandler
/**
* TODO: Externalize HTML
* @param activeChar the active Game Master.
* @param page
* @param pageValue
*/
private void removeSkillsPage(PlayerInstance activeChar, int page)
private void removeSkillsPage(PlayerInstance activeChar, int pageValue)
{
final WorldObject target = activeChar.getTarget();
if ((target == null) || !target.isPlayer())
@@ -363,6 +364,7 @@ public class AdminSkill implements IAdminCommandHandler
maxPages++;
}
int page = pageValue;
if (page > maxPages)
{
page = maxPages;

5
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/admincommandhandlers/AdminSpawn.java vendored
View File

@@ -501,7 +501,7 @@ public class AdminSpawn implements IAdminCommandHandler
}
}
private void spawnMonster(PlayerInstance activeChar, String monsterId, int respawnTime, int mobCount, boolean permanent)
private void spawnMonster(PlayerInstance activeChar, String monsterIdValue, int respawnTime, int mobCount, boolean permanentValue)
{
WorldObject target = activeChar.getTarget();
if (target == null)
@@ -510,6 +510,7 @@ public class AdminSpawn implements IAdminCommandHandler
}
final NpcTemplate template1;
String monsterId = monsterIdValue;
if (monsterId.matches("[0-9]*"))
{
// First parameter was an ID number
@@ -536,6 +537,8 @@ public class AdminSpawn implements IAdminCommandHandler
spawn.setAmount(mobCount);
spawn.setHeading(activeChar.getHeading());
spawn.setRespawnDelay(respawnTime);
boolean permanent = permanentValue;
if (activeChar.isInInstance())
{
spawn.setInstanceId(activeChar.getInstanceId());

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/bypasshandlers/NpcViewMod.java vendored
View File

@@ -343,7 +343,7 @@ public class NpcViewMod implements IBypassHandler
return sb.toString();
}
private void sendNpcDropList(PlayerInstance player, Npc npc, DropType dropType, int page)
private void sendNpcDropList(PlayerInstance player, Npc npc, DropType dropType, int pageValue)
{
final List<DropHolder> dropList = npc.getTemplate().getDropList(dropType);
if (dropList == null)
@@ -368,6 +368,7 @@ public class NpcViewMod implements IBypassHandler
pagesSb.append("</tr></table>");
}
int page = pageValue;
if (page >= pages)
{
page = pages - 1;

7
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/bypasshandlers/QuestLink.java vendored
View File

@@ -101,17 +101,18 @@ public class QuestLink implements IBypassHandler
.collect(Collectors.toSet());
//@formatter:on
Collection<Quest> questList = quests;
if (Config.ORDER_QUEST_LIST_BY_QUESTID)
{
final Map<Integer, Quest> orderedQuests = new TreeMap<>(); // Use TreeMap to order quests
for (Quest q : quests)
for (Quest q : questList)
{
orderedQuests.put(q.getId(), q);
}
quests = orderedQuests.values();
questList = orderedQuests.values();
}
for (Quest quest : quests)
for (Quest quest : questList)
{
final QuestState qs = player.getQuestState(quest.getScriptName());
if ((qs == null) || qs.isCreated() || (qs.isCompleted() && qs.isNowAvailable()))

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/chathandlers/ChatGeneral.java vendored
View File

@@ -43,7 +43,7 @@ public class ChatGeneral implements IChatHandler
};
@Override
public void handleChat(ChatType type, PlayerInstance activeChar, String params, String text)
public void handleChat(ChatType type, PlayerInstance activeChar, String paramsValue, String text)
{
boolean vcdUsed = false;
if (text.startsWith("."))
@@ -51,6 +51,7 @@ public class ChatGeneral implements IChatHandler
final StringTokenizer st = new StringTokenizer(text);
final IVoicedCommandHandler vch;
String command = "";
String params = paramsValue;
if (st.countTokens() > 1)
{
command = st.nextToken().substring(1);

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/communityboard/ClanBoard.java vendored
View File

@@ -176,8 +176,9 @@ public class ClanBoard implements IWriteBoardHandler
}
}
private void clanList(PlayerInstance player, int index)
private void clanList(PlayerInstance player, int indexValue)
{
int index = indexValue;
if (index < 1)
{
index = 1;

3
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/handlers/effecthandlers/AddHate.java vendored
View File

@@ -45,8 +45,9 @@ public class AddHate extends AbstractEffect
}
@Override
public void instant(Creature effector, Creature effected, Skill skill, ItemInstance item)
public void instant(Creature creature, Creature effected, Skill skill, ItemInstance item)
{
Creature effector = creature;
if (_affectSummoner && (effector.getSummoner() != null))
{
effector = effector.getSummoner();

6
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/quests/Q00500_BrothersBoundInChains/Q00500_BrothersBoundInChains.java vendored
View File

@@ -101,7 +101,7 @@ public class Q00500_BrothersBoundInChains extends Quest
}
else
{
event = "30981-05.html";
return "30981-05.html";
}
break;
}
@@ -124,13 +124,13 @@ public class Q00500_BrothersBoundInChains extends Quest
{
// If player delete QuestItems: Need check how it work on retail.
qs.setCond(1);
event = "30981-07.html";
return "30981-07.html";
}
break;
}
default:
{
event = getNoQuestMsg(player);
return getNoQuestMsg(player);
}
}

2
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/village_master/DarkElfChange1/DarkElfChange1.java vendored
View File

@@ -92,7 +92,7 @@ public class DarkElfChange1 extends AbstractNpcAI
player.broadcastUserInfo();
}
}
event = npc.getId() + "-" + suffix + ".html";
return npc.getId() + "-" + suffix + ".html";
}
}
return event;

2
L2J_Mobius_Classic_2.1_Zaken/dist/game/data/scripts/village_master/DarkElfChange2/DarkElfChange2.java vendored
View File

@@ -107,7 +107,7 @@ public class DarkElfChange2 extends AbstractNpcAI
player.broadcastUserInfo();
}
}
event = "30474-" + suffix + ".html";
return "30474-" + suffix + ".html";
}
}
return event;