Make use of StringBuilder for commonly used toString methods.

This commit is contained in:
MobiusDevelopment
2022-09-27 23:38:13 +00:00
parent 463c15f650
commit 237155859e
188 changed files with 2290 additions and 1079 deletions

View File

@@ -922,6 +922,13 @@ public abstract class WorldObject extends ListenersContainer implements IIdentif
@Override
public String toString()
{
return getClass().getSimpleName() + ":" + _name + "[" + _objectId + "]";
final StringBuilder sb = new StringBuilder();
sb.append(getClass().getSimpleName());
sb.append(":");
sb.append(_name);
sb.append("[");
sb.append(_objectId);
sb.append("]");
return sb.toString();
}
}

View File

@@ -1227,12 +1227,6 @@ public class Npc extends Creature
return _spawn;
}
@Override
public String toString()
{
return getClass().getSimpleName() + ":" + getName() + "(" + getId() + ")[" + getObjectId() + "]";
}
public boolean isDecayed()
{
return _isDecayed;
@@ -1951,4 +1945,19 @@ public class Npc extends Creature
_timerHolders.clear();
}
}
@Override
public String toString()
{
final StringBuilder sb = new StringBuilder();
sb.append(getClass().getSimpleName());
sb.append(":");
sb.append(getName());
sb.append("(");
sb.append(getId());
sb.append(")[");
sb.append(getObjectId());
sb.append("]");
return sb.toString();
}
}

View File

@@ -930,12 +930,6 @@ public abstract class Summon extends Playable
sendPacket(new TeleportToLocation(this, getX(), getY(), getZ(), getHeading()));
}
@Override
public String toString()
{
return super.toString() + "(" + getId() + ") Owner: " + _owner;
}
@Override
public boolean isUndead()
{
@@ -1174,4 +1168,16 @@ public abstract class Summon extends Playable
{
return (_owner != null) && _owner.isOnEvent();
}
@Override
public String toString()
{
final StringBuilder sb = new StringBuilder();
sb.append(super.toString());
sb.append("(");
sb.append(getId());
sb.append(") Owner: ");
sb.append(_owner);
return sb.toString();
}
}

View File

@@ -486,12 +486,6 @@ public class Door extends Creature
}
}
@Override
public String toString()
{
return getClass().getSimpleName() + "[" + getTemplate().getId() + "](" + getObjectId() + ")";
}
@Override
public String getName()
{
@@ -688,4 +682,17 @@ public class Door extends Creature
{
return true;
}
@Override
public String toString()
{
final StringBuilder sb = new StringBuilder();
sb.append(getClass().getSimpleName());
sb.append("[");
sb.append(getTemplate().getId());
sb.append("](");
sb.append(getObjectId());
sb.append(")");
return sb.toString();
}
}

View File

@@ -211,6 +211,12 @@ public class Doppelganger extends Npc
@Override
public String toString()
{
return super.toString() + "(" + getId() + ") Summoner: " + getSummoner();
final StringBuilder sb = new StringBuilder();
sb.append(super.toString());
sb.append("(");
sb.append(getId());
sb.append(") Summoner: ");
sb.append(getSummoner());
return sb.toString();
}
}

View File

@@ -974,16 +974,6 @@ public abstract class ItemTemplate extends ListenersContainer implements IIdenti
return _artifactSlot;
}
/**
* Returns the name of the item followed by the item ID.
* @return the name and the ID of the item
*/
@Override
public String toString()
{
return _name + "(" + _itemId + ")";
}
/**
* Verifies if the item has effects immediately.<br>
* <i>Used for herbs mostly.</i>
@@ -1078,4 +1068,19 @@ public abstract class ItemTemplate extends ListenersContainer implements IIdenti
}
return defaultValue;
}
/**
* Returns the name of the item followed by the item ID.
* @return the name and the ID of the item
*/
@Override
public String toString()
{
final StringBuilder sb = new StringBuilder();
sb.append(_name);
sb.append("(");
sb.append(_itemId);
sb.append(")");
return sb.toString();
}
}

View File

@@ -1813,16 +1813,6 @@ public class Item extends WorldObject
}
}
/**
* Returns the item in String format
* @return String
*/
@Override
public String toString()
{
return _itemTemplate + "[" + getObjectId() + "]";
}
public void resetOwnerTimer()
{
if (_itemLootShedule != null)
@@ -2627,4 +2617,19 @@ public class Item extends WorldObject
}
}
}
/**
* Returns the item in String format
* @return String
*/
@Override
public String toString()
{
final StringBuilder sb = new StringBuilder();
sb.append(_itemTemplate);
sb.append("[");
sb.append(getObjectId());
sb.append("]");
return sb.toString();
}
}