Store Npc isWalker in a simple boolean instead of checking WalkingManager.

This commit is contained in:
MobiusDevelopment 2020-02-13 20:16:40 +00:00
parent e56dad5f81
commit 1a3c34b3c5
34 changed files with 153 additions and 85 deletions

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -134,6 +134,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1589,13 +1590,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -134,6 +134,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1589,13 +1590,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -127,6 +127,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1371,13 +1372,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -127,6 +127,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1371,13 +1372,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -127,6 +127,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1371,13 +1372,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override

View File

@ -247,7 +247,7 @@ public class WalkingManager implements IXmlReader
* @param npc NPC to check
* @return {@code true} if given NPC controlled by Walking Manager.
*/
public boolean isRegistered(Npc npc)
private boolean isRegistered(Npc npc)
{
return _activeRoutes.containsKey(npc.getObjectId());
}
@ -309,6 +309,7 @@ public class WalkingManager implements IXmlReader
walk.setWalkCheckTask(newTask); // start walk check task, for resuming walk after fight
}
npc.setWalker();
_activeRoutes.put(npc.getObjectId(), walk); // register route
}
else

View File

@ -126,6 +126,7 @@ public class Npc extends Creature
/** Support for random animation switching */
private boolean _isRandomAnimationEnabled = true;
private boolean _isRandomWalkingEnabled = true;
private boolean _isWalker = false;
private boolean _isTalkable = getTemplate().isTalkable();
private final boolean _isQuestMonster = getTemplate().isQuestMonster();
private final boolean _isFakePlayer = getTemplate().isFakePlayer();
@ -1359,13 +1360,15 @@ public class Npc extends Creature
broadcastInfo();
}
/**
* @return {@code true} if this Npc is registered in WalkingManager
*/
@Override
public boolean isWalker()
{
return WalkingManager.getInstance().isRegistered(this);
return _isWalker;
}
public void setWalker()
{
_isWalker = true;
}
@Override