Fixed probable trap task NPE.

This commit is contained in:
MobiusDevelopment
2020-12-18 22:46:08 +00:00
parent 31e7c50c12
commit 0ca0d081e7
34 changed files with 119 additions and 17 deletions

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }

View File

@@ -213,6 +213,10 @@ public class TrapInstance extends Npc
public Skill getSkill() public Skill getSkill()
{ {
if (_skill == null)
{
return null;
}
return _skill.getSkill(); return _skill.getSkill();
} }

View File

@@ -19,6 +19,7 @@ package org.l2jmobius.gameserver.model.actor.tasks.npc.trap;
import java.util.logging.Logger; import java.util.logging.Logger;
import org.l2jmobius.gameserver.model.actor.instance.TrapInstance; import org.l2jmobius.gameserver.model.actor.instance.TrapInstance;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction; import org.l2jmobius.gameserver.network.serverpackets.SocialAction;
/** /**
@@ -57,7 +58,8 @@ public class TrapTask implements Runnable
} }
} }
if (!_trap.getSkill().getTargetsAffected(_trap, _trap).isEmpty()) final Skill skill = _trap.getSkill();
if ((skill != null) && !skill.getTargetsAffected(_trap, _trap).isEmpty())
{ {
_trap.triggerTrap(_trap); _trap.triggerTrap(_trap);
} }