lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removal of unnecessary IdFactory releaseId calls.

Browse Source 
Contributed by Sahar.
This commit is contained in:
MobiusDevelopment
2019-10-10 18:52:20 +00:00
parent 412b805b0e
commit 04b93ce79b
31 changed files with 4 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
L2J_Mobius_CT_2.6_HighFive/java/org/l2jmobius/gameserver/model/actor/instance/PlayerInstance.java
View File

@@ -5976,7 +5976,6 @@ public class PlayerInstance extends Playable
if (Config.OFFLINE_DISCONNECT_FINISHED && (privateStoreType == PrivateStoreType.NONE) && ((_client == null) || _client.isDetached()))
{
IdFactory.getInstance().releaseId(getObjectId());
Disconnection.of(this).storeMe().deleteMe();
}
}
@@ -7780,7 +7779,6 @@ public class PlayerInstance extends Playable
try (Connection con = DatabaseFactory.getConnection();
PreparedStatement ps = con.prepareStatement(ADD_NEW_SKILLS))
{
con.setAutoCommit(false);
for (Skill addSkill : newSkills)
{
ps.setInt(1, getObjectId());
@@ -7790,7 +7788,6 @@ public class PlayerInstance extends Playable
ps.addBatch();
}
ps.executeBatch();
con.commit();
}
catch (SQLException e)
{

10
L2J_Mobius_CT_2.6_HighFive/java/org/l2jmobius/gameserver/model/itemcontainer/Mail.java
View File

@@ -23,7 +23,6 @@ import java.util.logging.Level;
import org.l2jmobius.commons.database.DatabaseFactory;
import org.l2jmobius.gameserver.enums.ItemLocation;
import org.l2jmobius.gameserver.idfactory.IdFactory;
import org.l2jmobius.gameserver.model.World;
import org.l2jmobius.gameserver.model.actor.instance.PlayerInstance;
import org.l2jmobius.gameserver.model.items.instance.ItemInstance;
@@ -162,12 +161,11 @@ public class Mail extends ItemContainer
@Override
public void deleteMe()
{
_items.forEach(i ->
_items.forEach(item ->
{
i.updateDatabase(true);
i.deleteMe();
World.getInstance().removeObject(i);
IdFactory.getInstance().releaseId(i.getObjectId());
item.updateDatabase(true);
item.deleteMe();
World.getInstance().removeObject(item);
});
_items.clear();
}

2
L2J_Mobius_CT_2.6_HighFive/java/org/l2jmobius/gameserver/network/serverpackets/CharSelectionInfo.java
View File

@@ -29,7 +29,6 @@ import org.l2jmobius.commons.database.DatabaseFactory;
import org.l2jmobius.commons.network.PacketWriter;
import org.l2jmobius.gameserver.data.sql.impl.ClanTable;
import org.l2jmobius.gameserver.data.xml.impl.ExperienceData;
import org.l2jmobius.gameserver.idfactory.IdFactory;
import org.l2jmobius.gameserver.model.CharSelectInfoPackage;
import org.l2jmobius.gameserver.model.World;
import org.l2jmobius.gameserver.model.actor.instance.PlayerInstance;
@@ -193,7 +192,6 @@ public class CharSelectionInfo implements IClientOutgoingPacket
final PlayerInstance player = World.getInstance().getPlayer(charInfopackage.getObjectId());
if (player != null)
{
IdFactory.getInstance().releaseId(player.getObjectId());
Disconnection.of(player).storeMe().deleteMe();
}
}