Replaced instanceof L2Character with isCharacter method.

This commit is contained in:
MobiusDev
2018-06-30 16:42:41 +00:00
parent d806ff66e5
commit 049a9b02aa
179 changed files with 270 additions and 282 deletions

View File

@@ -572,7 +572,7 @@ abstract class AbstractAI implements Ctrl
}
// Send a Server->Client packet MoveToPawn/CharMoveToLocation to the actor and all L2PcInstance in its _knownPlayers
if (pawn instanceof L2Character)
if (pawn.isCharacter())
{
if (_actor.isOnGeodataPath())
{

View File

@@ -427,7 +427,7 @@ public class L2AttackableAI extends L2CharacterAI
// Go through visible objects
for (L2Object obj : npc.getKnownList().getKnownObjects().values())
{
if ((obj == null) || !(obj instanceof L2Character))
if ((obj == null) || !obj.isCharacter())
{
continue;
}

View File

@@ -1029,7 +1029,7 @@ public class L2CharacterAI extends AbstractAI
offset += _actor.getTemplate().collisionRadius;
if (target instanceof L2Character)
if (target.isCharacter())
{
offset += ((L2Character) target).getTemplate().collisionRadius;
}
@@ -1086,7 +1086,7 @@ public class L2CharacterAI extends AbstractAI
stopFollow();
if ((target instanceof L2Character) && !(target instanceof L2DoorInstance))
if (target.isCharacter() && !(target instanceof L2DoorInstance))
{
if (((L2Character) target).isMoving())
{

View File

@@ -440,7 +440,7 @@ public class L2ControllableMobAI extends L2AttackableAI
for (L2Object obj : npc.getKnownList().getKnownObjects().values())
{
if (!(obj instanceof L2Character))
if (!obj.isCharacter())
{
continue;
}

View File

@@ -239,7 +239,7 @@ public class AdminEffects implements IAdminCommandHandler
{
final L2Object target = activeChar.getTarget();
L2Character player = null;
if (target instanceof L2Character)
if (target.isCharacter())
{
player = (L2Character) target;
if (type.equals("1"))
@@ -267,7 +267,7 @@ public class AdminEffects implements IAdminCommandHandler
{
final L2Object target = activeChar.getTarget();
L2Character player = null;
if (target instanceof L2Character)
if (target.isCharacter())
{
player = (L2Character) target;
player.stopAbnormalEffect((short) 0x0400);
@@ -322,7 +322,7 @@ public class AdminEffects implements IAdminCommandHandler
L2Object target = activeChar.getTarget();
L2Character player = null;
if (target instanceof L2Character)
if (target.isCharacter())
{
player = (L2Character) target;
player.startAbnormalEffect(0x2000);
@@ -340,7 +340,7 @@ public class AdminEffects implements IAdminCommandHandler
L2Object target = activeChar.getTarget();
L2Character player = null;
if (target instanceof L2Character)
if (target.isCharacter())
{
player = (L2Character) target;
player.stopAbnormalEffect((short) 0x2000);
@@ -545,7 +545,7 @@ public class AdminEffects implements IAdminCommandHandler
L2Object target = activeChar.getTarget();
L2Character player = null;
if (target instanceof L2Character)
if (target.isCharacter())
{
player = (L2Character) target;
player.stopAllEffects();
@@ -662,7 +662,7 @@ public class AdminEffects implements IAdminCommandHandler
obj = activeChar;
}
if (!(obj instanceof L2Character))
if (!obj.isCharacter())
{
activeChar.sendPacket(SystemMessageId.INCORRECT_TARGET);
}
@@ -696,7 +696,7 @@ public class AdminEffects implements IAdminCommandHandler
*/
private boolean performAbnormal(int action, L2Object target)
{
if (target instanceof L2Character)
if (target.isCharacter())
{
L2Character character = (L2Character) target;
@@ -718,7 +718,7 @@ public class AdminEffects implements IAdminCommandHandler
{
try
{
if (target instanceof L2Character)
if (target.isCharacter())
{
if ((target instanceof L2Summon) || (target instanceof L2ChestInstance))
{

View File

@@ -95,7 +95,7 @@ public class AdminHeal implements IAdminCommandHandler
final int radius = Integer.parseInt(player);
for (L2Object object : activeChar.getKnownList().getKnownObjects().values())
{
if (object instanceof L2Character)
if (object.isCharacter())
{
L2Character character = (L2Character) object;
character.setCurrentHpMp(character.getMaxHp(), character.getMaxMp());
@@ -121,7 +121,7 @@ public class AdminHeal implements IAdminCommandHandler
obj = activeChar;
}
if (obj instanceof L2Character)
if (obj.isCharacter())
{
final L2Character target = (L2Character) obj;
target.setCurrentHpMp(target.getMaxHp(), target.getMaxMp());

View File

@@ -123,7 +123,7 @@ public class AdminKill implements IAdminCommandHandler
{
L2Object obj = activeChar.getTarget();
if ((obj == null) || (obj instanceof L2ControllableMobInstance) || !(obj instanceof L2Character))
if ((obj == null) || (obj instanceof L2ControllableMobInstance) || !obj.isCharacter())
{
activeChar.sendPacket(SystemMessageId.INCORRECT_TARGET);
}

View File

@@ -105,7 +105,7 @@ public class AdminMobGroup implements IAdminCommandHandler
}
else if (command.startsWith("admin_mobgroup_attack"))
{
if (activeChar.getTarget() instanceof L2Character)
if (activeChar.getTarget().isCharacter())
{
L2Character target = (L2Character) activeChar.getTarget();
attack(command, activeChar, target);

View File

@@ -107,7 +107,7 @@ public class AdminPolymorph implements IAdminCommandHandler
obj.getPoly().setPolyInfo(type, id);
// animation
if (obj instanceof L2Character)
if (obj.isCharacter())
{
L2Character Char = (L2Character) obj;
MagicSkillUse msk = new MagicSkillUse(Char, 1008, 1, 4000, 0);

View File

@@ -196,7 +196,7 @@ public class AdminTest implements IAdminCommandHandler
L2Character player;
L2Object target = activeChar.getTarget();
if ((target == null) || !(target instanceof L2Character))
if ((target == null) || !target.isCharacter())
{
player = activeChar;
}

View File

@@ -53,7 +53,7 @@ public class CombatPointHeal implements ISkillHandler
for (L2Object object : targets)
{
if (!(object instanceof L2Character))
if (!object.isCharacter())
{
continue;
}

View File

@@ -95,7 +95,7 @@ public class Disablers implements ISkillHandler
for (L2Object target2 : targets)
{
// Get a target
if (!(target2 instanceof L2Character))
if (!target2.isCharacter())
{
continue;
}

View File

@@ -77,7 +77,7 @@ public class Recall implements ISkillHandler
for (L2Object target1 : targets)
{
if (!(target1 instanceof L2Character))
if (!target1.isCharacter())
{
continue;
}

View File

@@ -112,7 +112,7 @@ public class SummonFriend implements ISkillHandler
{
for (L2Object target1 : targets)
{
if (!(target1 instanceof L2Character))
if (!target1.isCharacter())
{
continue;
}

View File

@@ -38,7 +38,7 @@ public class ZakenPlayer implements ISkillHandler
{
for (L2Object target1 : targets)
{
if (!(target1 instanceof L2Character))
if (!target1.isCharacter())
{
continue;
}

View File

@@ -38,7 +38,7 @@ public class ZakenSelf implements ISkillHandler
{
for (L2Object target1 : targets)
{
if (!(target1 instanceof L2Character))
if (!target1.isCharacter())
{
continue;
}

View File

@@ -1402,7 +1402,7 @@ public abstract class L2Skill
Env env = new Env();
env.player = activeChar;
if (target instanceof L2Character)
if (target.isCharacter())
{
env.target = (L2Character) target;
}
@@ -1432,7 +1432,7 @@ public abstract class L2Skill
// Get the L2Objcet targeted by the user of the skill at this moment
final L2Object objTarget = activeChar.getTarget();
// If the L2Object targeted is a L2Character, it becomes the L2Character target
if (objTarget instanceof L2Character)
if (objTarget.isCharacter())
{
target = (L2Character) objTarget;
}

View File

@@ -1581,7 +1581,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
L2Character target;
for (L2Object obj : getKnownList().getKnownObjects().values())
{
if (obj instanceof L2Character)
if (obj.isCharacter())
{
if ((obj instanceof L2PetInstance) && (this instanceof L2PcInstance) && (((L2PetInstance) obj).getOwner() == (L2PcInstance) this))
{
@@ -3195,7 +3195,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
* <BR>
* <B><U> Assert </U> :</B><BR>
* <BR>
* <li>this instanceof L2Character</li><BR>
* <li>this.isCharacter().</li><BR>
* <BR
* @param template the new template
*/
@@ -7457,7 +7457,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
@Override
public void onForcedAttack(L2PcInstance player)
{
if ((player.getTarget() == null) || !(player.getTarget() instanceof L2Character))
if ((player.getTarget() == null) || !player.getTarget().isCharacter())
{
// If target is not attackable, send a Server->Client packet ActionFailed
player.sendPacket(ActionFailed.STATIC_PACKET);
@@ -7668,7 +7668,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
}
}
if ((attacker instanceof L2Character) && ((L2Character) attacker).isInsideZone(ZoneId.PEACE)
if (attacker.isCharacter() && ((L2Character) attacker).isInsideZone(ZoneId.PEACE)
// the townzone has to be already peace zone
// || TownManager.getInstance().getTown(attacker.getX(), attacker.getY(), attacker.getZ())!= null
)
@@ -7676,7 +7676,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
return true;
}
if ((target instanceof L2Character) && ((L2Character) target).isInsideZone(ZoneId.PEACE)
if (target.isCharacter() && ((L2Character) target).isInsideZone(ZoneId.PEACE)
// the townzone has to be already peace zone
// || TownManager.getInstance().getTown(target.getX(), target.getY(), target.getZ())!= null
)
@@ -8387,7 +8387,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
for (int i = 0; (targets != null) && (i < targets.length); i++)
{
if (targets[i] instanceof L2Character)
if (targets[i].isCharacter())
{
if (!Util.checkIfInRange(escapeRange, this, targets[i], true))
{
@@ -8712,12 +8712,12 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
// Like L2OFF if the skill is BLOW the player doesn't auto attack
// If on XML skill nextActionAttack = true the char auto attack
// If CTRL is pressed the autoattack is aborted (like L2OFF)
if ((skilldat != null) && !skilldat.isCtrlPressed() && skill.nextActionIsAttack() && (_target != null) && (_target instanceof L2Character))
if ((skilldat != null) && !skilldat.isCtrlPressed() && skill.nextActionIsAttack() && (_target != null) && _target.isCharacter())
{
getAI().setIntention(AI_INTENTION_ATTACK, _target);
}
}
else if (skill.nextActionIsAttack() && (_target != null) && (_target instanceof L2Character))
else if (skill.nextActionIsAttack() && (_target != null) && _target.isCharacter())
{
getAI().setIntention(AI_INTENTION_ATTACK, _target);
}
@@ -8790,7 +8790,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
{
for (L2Object target : targets)
{
if ((target != null) && (target instanceof L2Character) && !((L2Character) target).isDead())
if ((target != null) && target.isCharacter() && !((L2Character) target).isDead())
{
final L2Character player = (L2Character) target;
@@ -9048,7 +9048,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
// Do initial checkings for skills and set pvp flag/draw aggro when needed
for (L2Object target : targets)
{
if (target instanceof L2Character)
if (target.isCharacter())
{
// Set some values inside target's instance for later use
L2Character player = (L2Character) target;
@@ -9066,7 +9066,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
* instanceof L2PcInstance) { sendPacket(SystemMessage.sendString("Target affected by weapon special ability!")); } }
*/
if (target instanceof L2Character)
if (target.isCharacter())
{
final L2Character targ = (L2Character) target;
@@ -9476,7 +9476,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
return false;
}
if (target instanceof L2Character)
if (target.isCharacter())
{
((L2Character) target).sendPacket(new ValidateLocation(this));
sendPacket(new ValidateLocation(((L2Character) target)));
@@ -9567,7 +9567,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
return false;
}
if (target instanceof L2Character)
if (target.isCharacter())
{
((L2Character) target).sendPacket(new ValidateLocation(this));
sendPacket(new ValidateLocation(((L2Character) target)));
@@ -9628,7 +9628,7 @@ public abstract class L2Character extends L2Object implements ISkillsHolder
return false;
}
if (target instanceof L2Character)
if (target.isCharacter())
{
if (isBehind(_target) || isFront(_target))
{

View File

@@ -534,7 +534,7 @@ public class L2CubicInstance
}
// test owners target if it is valid then use it
if ((ownerTarget instanceof L2Character) && (ownerTarget != _owner.getPet()) && (ownerTarget != _owner))
if (ownerTarget.isCharacter() && (ownerTarget != _owner.getPet()) && (ownerTarget != _owner))
{
// target mob which has aggro on you or your summon
if (ownerTarget instanceof L2Attackable)

View File

@@ -607,7 +607,7 @@ public class L2NpcInstance extends L2Character
return 10000;
}
if ((object instanceof L2FolkInstance) || !(object instanceof L2Character))
if ((object instanceof L2FolkInstance) || !object.isCharacter())
{
return 0;
}

View File

@@ -1297,7 +1297,7 @@ public final class L2PcInstance extends L2Playable
default:
{
L2Object mainTarget = skill.getFirstOfTargetList(L2PcInstance.this);
if ((mainTarget == null) || !(mainTarget instanceof L2Character))
if ((mainTarget == null) || !mainTarget.isCharacter())
{
return;
}
@@ -6893,7 +6893,7 @@ public final class L2PcInstance extends L2Playable
}
// Remove the L2PcInstance from the _statusListener of the old target if it was a L2Character
if (oldTarget instanceof L2Character)
if (oldTarget.isCharacter())
{
((L2Character) oldTarget).removeStatusListener(this);
}
@@ -6901,7 +6901,7 @@ public final class L2PcInstance extends L2Playable
oldTarget = null;
// Add the L2PcInstance to the _statusListener of the new target if it's a L2Character
if ((newTarget != null) && (newTarget instanceof L2Character))
if ((newTarget != null) && newTarget.isCharacter())
{
((L2Character) newTarget).addStatusListener(this);
TargetSelected my = new TargetSelected(getObjectId(), newTarget.getObjectId(), getX(), getY(), getZ());

View File

@@ -22,7 +22,6 @@ import com.l2jmobius.gameserver.ai.CtrlIntention;
import com.l2jmobius.gameserver.ai.L2CharacterAI;
import com.l2jmobius.gameserver.model.L2Object;
import com.l2jmobius.gameserver.model.actor.L2Attackable;
import com.l2jmobius.gameserver.model.actor.L2Character;
import com.l2jmobius.gameserver.model.actor.L2Playable;
import com.l2jmobius.gameserver.model.actor.instance.L2FolkInstance;
import com.l2jmobius.gameserver.model.actor.instance.L2PcInstance;
@@ -50,7 +49,7 @@ public class AttackableKnownList extends NpcKnownList
}
// Remove the L2Object from the _aggrolist of the L2Attackable
if ((object != null) && (object instanceof L2Character))
if ((object != null) && object.isCharacter())
{
getActiveChar().getAggroList().remove(object);
}
@@ -95,7 +94,7 @@ public class AttackableKnownList extends NpcKnownList
@Override
public int getDistanceToWatchObject(L2Object object)
{
if ((object instanceof L2FolkInstance) || !(object instanceof L2Character))
if ((object instanceof L2FolkInstance) || !object.isCharacter())
{
return 0;
}

View File

@@ -147,7 +147,7 @@ public class CharKnownList extends ObjectKnownList
for (L2Object obj : getKnownObjects().values())
{
if ((obj != null) && (obj instanceof L2Character))
if ((obj != null) && obj.isCharacter())
{
result.add((L2Character) obj);
}

View File

@@ -67,7 +67,7 @@ public class FriendlyMobKnownList extends AttackableKnownList
return false;
}
if (!(object instanceof L2Character))
if (!object.isCharacter())
{
return true;
}

View File

@@ -68,7 +68,7 @@ public class MonsterKnownList extends AttackableKnownList
return false;
}
if (!(object instanceof L2Character))
if (!object.isCharacter())
{
return true;
}

View File

@@ -46,7 +46,7 @@ public class NpcKnownList extends CharKnownList
return false;
}
if (getActiveObject().isNpc() && (object instanceof L2Character))
if (getActiveObject().isNpc() && object.isCharacter())
{
// Broadcast correct walking NPC position.
if (object.isPlayer() && getActiveChar().isMoving() && !getActiveChar().isInCombat())
@@ -77,7 +77,7 @@ public class NpcKnownList extends CharKnownList
return 10000;
}
if ((object instanceof L2FolkInstance) || !(object instanceof L2Character))
if ((object instanceof L2FolkInstance) || !object.isCharacter())
{
return 0;
}

View File

@@ -114,7 +114,7 @@ public class ObjectKnownList
public final synchronized void updateKnownObjects()
{
// Only bother updating knownobjects for L2Character; don't for L2Object
if (_activeObject instanceof L2Character)
if (_activeObject.isCharacter())
{
findCloseObjects();
forgetObjects();
@@ -150,7 +150,7 @@ public class ObjectKnownList
// Try to add active object to object's known objects
// Only if object is a L2Character and active object is a L2PlayableInstance
if (object instanceof L2Character)
if (object.isCharacter())
{
object.getKnownList().addKnownObject(_activeObject);
}

View File

@@ -229,7 +229,7 @@ public class PcKnownList extends PlayableKnownList
}
}
if (object instanceof L2Character)
if (object.isCharacter())
{
// Update the state of the L2Character object client side by sending Server->Client packet MoveToPawn/CharMoveToLocation and AutoAttackStart to the L2PcInstance
L2Character obj = (L2Character) object;

View File

@@ -23,7 +23,6 @@ import com.l2jmobius.commons.util.Point3D;
import com.l2jmobius.gameserver.model.L2Object;
import com.l2jmobius.gameserver.model.L2World;
import com.l2jmobius.gameserver.model.L2WorldRegion;
import com.l2jmobius.gameserver.model.actor.L2Character;
import com.l2jmobius.gameserver.model.actor.instance.L2PcInstance;
/**
@@ -107,7 +106,7 @@ public class ObjectPosition
((L2PcInstance) _activeObject).sendMessage("Error with your coords, Please ask a GM for help!");
}
else if (_activeObject instanceof L2Character)
else if (_activeObject.isCharacter())
{
_activeObject.decayMe();
}

View File

@@ -120,7 +120,7 @@ public final class Action extends L2GameClientPacket
}
case 1:
{
if ((obj instanceof L2Character) && ((L2Character) obj).isAlikeDead())
if (obj.isCharacter() && ((L2Character) obj).isAlikeDead())
{
obj.onAction(activeChar);
}

View File

@@ -747,7 +747,7 @@ public final class RequestActionUse extends L2GameClientPacket
boolean force = _ctrlPressed;
if (target instanceof L2Character)
if (target.isCharacter())
{
if (activeSummon.isInsideZone(ZoneId.PVP) && ((L2Character) target).isInsideZone(ZoneId.PVP))
{

View File

@@ -160,7 +160,7 @@ public class RequestRecordInfo extends L2GameClientPacket
}
}
if (object instanceof L2Character)
if (object.isCharacter())
{
// Update the state of the L2Character object client side by sending Server->Client packet MoveToPawn/CharMoveToLocation and AutoAttackStart to the L2PcInstance
final L2Character obj = (L2Character) object;

View File

@@ -225,7 +225,7 @@ public final class Say2 extends L2GameClientPacket
final CreatureSay cs = new CreatureSay(actor, _type, name, _text);
for (L2Object obj : list)
{
if ((obj == null) || !(obj instanceof L2Character))
if ((obj == null) || !obj.isCharacter())
{
continue;
}

View File

@@ -90,7 +90,7 @@ public class NpcInfoPoly extends L2GameServerPacket
_isSummoned = false;
_collisionRadius = _template.collisionRadius;
_collisionHeight = _template.collisionHeight;
if (_obj instanceof L2Character)
if (_obj.isCharacter())
{
_activeChar = (L2Character) obj;
_isAttackable = obj.isAutoAttackable(attacker);

View File

@@ -71,7 +71,7 @@ final class EffectConfusion extends L2Effect
continue;
}
if ((obj instanceof L2Character) && (obj != getEffected()))
if (obj.isCharacter() && (obj != getEffected()))
{
targetList.add((L2Character) obj);
}

View File

@@ -22,7 +22,6 @@ import com.l2jmobius.commons.concurrent.ThreadPool;
import com.l2jmobius.gameserver.model.L2Object;
import com.l2jmobius.gameserver.model.L2World;
import com.l2jmobius.gameserver.model.L2WorldRegion;
import com.l2jmobius.gameserver.model.actor.L2Character;
import com.l2jmobius.gameserver.model.actor.L2Playable;
public class KnownListUpdateTaskManager
@@ -118,7 +117,7 @@ public class KnownListUpdateTaskManager
}
}
}
else if (object instanceof L2Character)
else if (object.isCharacter())
{
for (L2WorldRegion regi : region.getSurroundingRegions()) // offer members of this and surrounding regions
{

View File

@@ -177,11 +177,11 @@ public final class Util
}
int rad = 0;
if (obj1 instanceof L2Character)
if (obj1.isCharacter())
{
rad += ((L2Character) obj1).getTemplate().collisionRadius;
}
if (obj2 instanceof L2Character)
if (obj2.isCharacter())
{
rad += ((L2Character) obj2).getTemplate().collisionRadius;
}

View File

@@ -1097,7 +1097,7 @@ public class GameStatusThread extends Thread
{
continue;
}
if (obj instanceof L2Character)
if (obj.isCharacter())
{
if (((L2Character) obj).hasAI())
{
@@ -1144,7 +1144,7 @@ public class GameStatusThread extends Thread
{
doorCount++;
}
else if (obj instanceof L2Character)
else if (obj.isCharacter())
{
charCount++;
}