lineage2/l2j_mobius
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Should not use primitive types for synchronization.

Browse Source
This commit is contained in:
MobiusDevelopment 2021-05-08 21:02:27 +00:00
parent 559ba288e6
commit 00a2dcd7a9
2 changed files with 8 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
L2J_Mobius_C4_ScionsOfDestiny/java/org/l2jmobius/gameserver/model/ObjectPosition.java
View File

@ -29,7 +29,6 @@ public class ObjectPosition
private int _heading = 0; private int _heading = 0;
private Location _worldPosition; private Location _worldPosition;
private WorldRegion _worldRegion; // Object localization : Used for items/chars that are seen in the world private WorldRegion _worldRegion; // Object localization : Used for items/chars that are seen in the world
private Boolean _changingRegion = false;
/** /**
* Instantiates a new object position. * Instantiates a new object position.
@ -235,25 +234,17 @@ public class ObjectPosition
* Gets the world region. * Gets the world region.
* @return the world region * @return the world region
*/ */
public WorldRegion getWorldRegion() public synchronized WorldRegion getWorldRegion()
{ {
synchronized (_changingRegion) return _worldRegion;
{
_changingRegion = false;
return _worldRegion;
}
} }
/** /**
* Sets the world region. * Sets the world region.
* @param value the new world region * @param value the new world region
*/ */
public void setWorldRegion(WorldRegion value) public synchronized void setWorldRegion(WorldRegion value)
{ {
synchronized (_changingRegion) _worldRegion = value;
{
_changingRegion = true;
_worldRegion = value;
}
} }
} }

17
L2J_Mobius_C6_Interlude/java/org/l2jmobius/gameserver/model/ObjectPosition.java
View File

@ -29,7 +29,6 @@ public class ObjectPosition
private int _heading = 0; private int _heading = 0;
private Location _worldPosition; private Location _worldPosition;
private WorldRegion _worldRegion; // Object localization : Used for items/chars that are seen in the world private WorldRegion _worldRegion; // Object localization : Used for items/chars that are seen in the world
private Boolean _changingRegion = false;
/** /**
* Instantiates a new object position. * Instantiates a new object position.
@ -235,25 +234,17 @@ public class ObjectPosition
* Gets the world region. * Gets the world region.
* @return the world region * @return the world region
*/ */
public WorldRegion getWorldRegion() public synchronized WorldRegion getWorldRegion()
{ {
synchronized (_changingRegion) return _worldRegion;
{
_changingRegion = false;
return _worldRegion;
}
} }
/** /**
* Sets the world region. * Sets the world region.
* @param value the new world region * @param value the new world region
*/ */
public void setWorldRegion(WorldRegion value) public synchronized void setWorldRegion(WorldRegion value)
{ {
synchronized (_changingRegion) _worldRegion = value;
{
_changingRegion = true;
_worldRegion = value;
}
} }
} }